From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 848493321B1 for ; Thu, 11 Jun 2026 03:53:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781150010; cv=none; b=tbgNFybk+PFrGJzLmrfOYi5IkqVkfUwwqkSz+bgxu5Yp7oOdhNy4W0ouKa63eQV5tPD2erSxTM+dQ3y/DiFcHTpPf0/nFn6N+zAZCAcuv68iMeClnmUojb2XSs/duG5WDyFIpTCV5G+UwwX67AMSFE2czwNFVYqQ/eyFFYwePYE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781150010; c=relaxed/simple; bh=d1dwl51R0SVH7jP5sjbK9oDfm/F9UhJ8pLa3jSft4To=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=FHoXN2vTfaQMJSyA+JCjt0bL5Ztai4Jpqz37aLmu+FvkulkYgxKoMqMDVUP+zpBuuNr21MYhAnfOmApTKH8T9gRvZoxGm/zfn3zdR5tmm4xdAL1EVN4FZEpte71VPFnz0Yz+HJZrIGxCNj1+gF0PNruJ43wSBbWDOVBcOkCwg5E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=gCDwH8R1; arc=none smtp.client-ip=209.85.216.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gCDwH8R1" Received: by mail-pj1-f42.google.com with SMTP id 98e67ed59e1d1-36d5b11201aso4816701a91.2 for ; Wed, 10 Jun 2026 20:53:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781150003; x=1781754803; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=sSyqeaLlyNKBtKqq9I2lY6bL8Oe5QRX1qiD3SyWg9M8=; b=gCDwH8R1/iZMm6e6oSJ0xy6xUW/yG8H2jcF9oLpBzBWppl9bqa9S0UrYMKzbEz5D7/ ONxb5a3tYfjeJb5bytVmHjuvow7iEjUFDgGAHvfDTXkV2/qJx7PIvoESM5cQ53Oj3ZjR f0TB/+hblyqoIclS222l19ZgazY3bCCXGFVQRf7CMmP/hVEz8idfFD5YARUcNSOQgaTg dj4VX52FfhCRS4H48Rwgj97uVylvNHHBbALMcJJYYxQqy3H71NelGQzNi47LRQph2wCV 08Dg6ZAMgwcaZV/TIhb3LsmnnysUzH8uyOYpQuLC7wkvB+AS1U/hAmVukyOGfwKmAfCS 1Gvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781150003; x=1781754803; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=sSyqeaLlyNKBtKqq9I2lY6bL8Oe5QRX1qiD3SyWg9M8=; b=bSnFn84M8YBxlAEtB+nT8b8hLR0h1eLkZR8a8sVUuT05P/KtGs4Ru23a+AjGDQXQ4Y /xqCPqvEApMm/O7hP5U1si0oARzPBZMOD/saHgy1mqKhc3Vdr6zdP92CdSGupr+/ZuG8 6A+H/LaLqxbqLyZDMFaS9RsZoqzYFXj4MGwfYUIa2kXfoczc5DAxPOLAeofKR+XdN47O +pWx8b6oWAxdz29FQ0DzddWie9NGE+3hAWXm7Q5fZizm62AKpzkSNLCf9BH2I7/AI38Y E2GGN9bhI2gGuRWheaU1iYJ7OYwrneEXTsjz91jVwgRLTDsLxvKsi64MyJLL3wOcM7xC qCDA== X-Forwarded-Encrypted: i=1; AFNElJ9O0trugE7XPwfNBasn2vHiLxsLMcqjf9hwtGBUIMR7pVNhrdN8TahZ2Haq3Wsz/2/t2pmEX5YCiCp2g1o=@vger.kernel.org X-Gm-Message-State: AOJu0YzCN6LKNkgRlpeeEZ+IrWzV7+27aaVGUM2/an6mpb3H02uV7OXp +Sr0AqO71jM+E9CktrHKi+Ps/1UvGlPUwZaR32/itfb2bv00uTINmmnm X-Gm-Gg: Acq92OGhD/3jIC/JJ+adB/1OdJjniprQ0ZuxBf10pUbs0liVImr4S5RHircasWKJVs1 kw9nQEzRLCWn9T6yyiWie+yVOCo6yZfmCuZs/eAjFbchgrSMUge50jWpITKTEpHLeHvEzKzo/Mr ++sJTWj5c4Kg7PLcsCCjfAg/hOCTGit6fhlJm6suXExGc81Euu3bu6EdGIGa/DS2MeDG52oqWnP m9LoX8LvsML52t3RoPp/tMWbuoi3sOqN0fl8nuvSBOBzaPDHtvyKXOHwmUhEHSCntzspVo20Ewr 1rWnIzJYYx3S0WDO/qMsYZkpjEWsHS6IqIR5CP5OqwR2RLz3SADmk5Axz+CGiJPR70sAP1l/aki mObdJFTAaC2Re8dU0dgplT+vuH21j2OSg+F9KR6tK8vUdstcKQIqwwhztl7DMg7UJ1iMkMjWDKH Y2OSQir3RQo3Y2KWxkP81Gz9qGWyj9l9fgeNWZyIfmPSYGdzx6ONw+nexW9kA+ag3PObY2Z/oaG ct9xpomEoyDy7afiz2422TqiPIpdsesdZe/plitWXQLkw== X-Received: by 2002:a17:90b:4acb:b0:368:7c0f:ebf7 with SMTP id 98e67ed59e1d1-377a73e2750mr1300085a91.16.1781150002966; Wed, 10 Jun 2026 20:53:22 -0700 (PDT) Received: from ryzen ([2601:644:8000:5b5d:7285:c2ff:fe45:8a32]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-377522a188asm910131a91.3.2026.06.10.20.53.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Jun 2026 20:53:22 -0700 (PDT) From: Rosen Penev To: dmaengine@vger.kernel.org Cc: Vinod Koul , Frank Li , Zhang Wei , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , linux-kernel@vger.kernel.org (open list), linuxppc-dev@lists.ozlabs.org (open list:FREESCALE DMA DRIVER), llvm@lists.linux.dev (open list:CLANG/LLVM BUILD SUPPORT:Keyword:\b(?i:clang|llvm)\b) Subject: [PATCHv4 13/15] dmaengine: fsldma: replace irq_of_parse_and_map with of_irq_get Date: Wed, 10 Jun 2026 20:52:43 -0700 Message-ID: <20260611035245.13439-14-rosenp@gmail.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260611035245.13439-1-rosenp@gmail.com> References: <20260611035245.13439-1-rosenp@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Use of_irq_get() which returns a negative error code on failure instead of silently returning 0. Split the IRQ validation check in fsldma_request_irqs to handle three cases: - chan->irq < 0: propagate the error (e.g. -EPROBE_DEFER) - chan->irq == 0: IRQ not found, return -ENODEV - chan->irq > 0: valid IRQ, proceed The fsldma_free_irqs() function's !chan->irq check is unchanged since both 0 and negative values mean no IRQ to free. Assisted-by: opencode:big-pickle Signed-off-by: Rosen Penev --- drivers/dma/fsldma.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/dma/fsldma.c b/drivers/dma/fsldma.c index dc70a6bf5723..0ee3d719ae95 100644 --- a/drivers/dma/fsldma.c +++ b/drivers/dma/fsldma.c @@ -1070,6 +1070,12 @@ static int fsldma_request_irqs(struct fsldma_device *fdev) if (!chan) continue; + if (chan->irq < 0) { + if (chan->irq != -EPROBE_DEFER) + chan_err(chan, "interrupts property missing in device tree\n"); + ret = chan->irq; + goto out_unwind; + } if (!chan->irq) { chan_err(chan, "interrupts property missing in device tree\n"); ret = -ENODEV; @@ -1093,7 +1099,7 @@ static int fsldma_request_irqs(struct fsldma_device *fdev) if (!chan) continue; - if (!chan->irq) + if (chan->irq <= 0) continue; free_irq(chan->irq, chan); @@ -1178,7 +1184,7 @@ static int fsl_dma_chan_probe(struct fsldma_device *fdev, dma_cookie_init(&chan->common); /* find the IRQ line, if it exists in the device tree */ - chan->irq = irq_of_parse_and_map(node, 0); + chan->irq = of_irq_get(node, 0); /* Add the channel to DMA device channel list */ list_add_tail(&chan->common.device_node, &fdev->common.channels); -- 2.54.0