From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f49.google.com (mail-pj1-f49.google.com [209.85.216.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F0EB63358B0 for ; Thu, 11 Jun 2026 03:53:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781150009; cv=none; b=le6J17A25LIiolah09pGx5KaJ0oclrBQr8GZiIPagv8I5i/PkccPhDbi5a33ZPMtcJF2o+WECvsHLo944qre+ubyqOhSzkg9kB7nKSzpldC22NXKCFMhlFPbY3e9qKVBgojO2iD7o13Fpm2zloiBBPqgTNgqajJDo4CWz655cLc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781150009; c=relaxed/simple; bh=SOI5HmXjnx5R6WLI2V3ZreO6yRicXxjdlFUUoqrXGOA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=nUap6HUDOm5hqQIodIdjNwhMP41oslt/YsIQHy/Y8Sl2/S+b2f5Kc1REGpRogMKpMBp8094XDAmwxQbaI7WmgqSOi9zxA5zDDPDXsZo9UxkiFl1mMdsE+DapGdJqMDKp3My1NkU0IrWhqYFabacJMnglIz/0q6p0NJZzcjsDu0Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Ikk4hzPU; arc=none smtp.client-ip=209.85.216.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Ikk4hzPU" Received: by mail-pj1-f49.google.com with SMTP id 98e67ed59e1d1-36baec934b6so269234a91.0 for ; Wed, 10 Jun 2026 20:53:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781150004; x=1781754804; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=bwl7yp6z2DJ8E/UGfDrMntTB6a7fFKpl/92m0Qbl/AQ=; b=Ikk4hzPUboMVvjTi2T2EGu++PVLfjDm0DJSLG8TJv1zNjxn/X/M37M469w2M+ZBCGF ppYAGRGfTRR9TAjL0pfKFEAbpbZTs6jZ/SKRc4bN81K3p4Ryy04Nch8IO0+SPaVxaXV+ y+H2/G7+YVh/SMBDP/GhEw5o8q8VGIvH7d5o2oYBtbC0WS6RUp0el2KVdX/7vW00D3/y uDpx4LULTwrJpISWSjNi+l/m0BZsqeBvUjvD0Vv0kFbTD+MsZRUVYOLObrZGZ6w9ehx5 aD34a/VGQx8bdEkc+HE7+F1WPJBmfhXhXU0ySwlCyATMQNK5BGpIQWMCi3RO7gP5ubTa QK4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781150004; x=1781754804; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=bwl7yp6z2DJ8E/UGfDrMntTB6a7fFKpl/92m0Qbl/AQ=; b=Q26mZs1dQdZTzsyhQF2HwwaXvHwJLW3rMhgZt1suUNifyCb64/3jqYHF15cvb53kei uYFGd4Av9xoMux9AwU3qpQ0wN2LccTyr/mTcQObzCfP4akD5LpZyac2c27aVaqgKENmn i0sbhPUslLV1pLpKlmNv4ZexTFsdE3i8hIBN6enRhPvpB/tYnfBRayF0wN8wzUyPvXgp zZU42wO47x/+PQpBrGojXAyUK1QgY/Apdz8+KayIxgdjFb7AJvKZcync/v5FaFyEggmO 5T90KIw4meeJ+upLZ4QYN0dDkbea9kYmIJk7yzBuTDXjKwroF+rBN8LrOMl2qPV6fJxl 6rhg== X-Forwarded-Encrypted: i=1; AFNElJ+X8nU2wzZ+gOWS4dpY5RrmePCQPqSjFLLnR/+SZKTP4c159vxDGq+7VshFt0rIzsAyfgZ7+GPY06P7BHg=@vger.kernel.org X-Gm-Message-State: AOJu0Ywxvw00m/Gkyn/RliYTEbswyGTUAeHt4qke/lcu6Ln19OUA67wV rwncFzqbJxqQMXzqwv6CZr7imGFlDhV0RUD2gjIOdyziZGX0cBza+L6e X-Gm-Gg: Acq92OHcLta4xhm2x2MrgEq/qvENFyB2xbAO5ILKPTzlk7L6eCuLYt45E2FaiUcwJyQ lrqX5pGBxEM0Hm+3kxHQJJpn9UVoOt+mMj4Q17a7bSZg0pZmRmjY/U6aJBUbOASqMU6zZJl+XwU 72zSIVy0oS40IfykT01vTt6aRsyOFe2t1iEJyrXVSrxdc45zyOF+RsFjeD2RUvyszBL8S+LZQTG 3pdofOvtOesZSBQ4ahtcRqEcXfyz0YbmgbiKfZuEalbyVpL19fe381hD9oRBb9Z7Nx0sdqN1kIR 8cCtnzIFlKLBp33CMmHHEkbGo7JnJKx3DL/Yens0G1yIeHACkbJ2O4lT4dm4ifNwwac74MZky20 MVN1YmH9AP9NLAA2c2I+58naZ6bb7D9ewR7BzHjT9C7xpZnFVtGMe0YC8m6/PZNpr2BXWNVuRr1 pPkob+5n0dBphb16C/V9CbsYT5zdr/Wexf83ZiA5ve05VLgJDCE7mN7VdQ8VM9W8EKSf3R4PcyP ZnOkjpEZ69dkhOkQEkVMoKCcvfSIwvt6fSY/qysnHy1ww== X-Received: by 2002:a17:90b:580d:b0:36d:630a:c4e4 with SMTP id 98e67ed59e1d1-37800fee6f0mr745354a91.3.1781150004392; Wed, 10 Jun 2026 20:53:24 -0700 (PDT) Received: from ryzen ([2601:644:8000:5b5d:7285:c2ff:fe45:8a32]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-377522a188asm910131a91.3.2026.06.10.20.53.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Jun 2026 20:53:23 -0700 (PDT) From: Rosen Penev To: dmaengine@vger.kernel.org Cc: Vinod Koul , Frank Li , Zhang Wei , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , linux-kernel@vger.kernel.org (open list), linuxppc-dev@lists.ozlabs.org (open list:FREESCALE DMA DRIVER), llvm@lists.linux.dev (open list:CLANG/LLVM BUILD SUPPORT:Keyword:\b(?i:clang|llvm)\b) Subject: [PATCHv4 14/15] dmaengine: fsldma: replace ppc-specific accessors with portable generic ones Date: Wed, 10 Jun 2026 20:52:44 -0700 Message-ID: <20260611035245.13439-15-rosenp@gmail.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260611035245.13439-1-rosenp@gmail.com> References: <20260611035245.13439-1-rosenp@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit - Convert remaining in_be32/in_le32 calls to FSL_DMA_IN macro - Replace __ilog2 with generic ilog2 (pull in linux/log2.h) - Add linux/io.h include - Expand non-PPC accessor support from ARM-only to all architectures - Guard 64-bit generic accessors with CONFIG_64BIT; provide emulation using 32-bit accessors on 32-bit platforms Add COMPILE_TEST support as a result for extra compile coverage. Assisted-by: opencode:big-pickle Signed-off-by: Rosen Penev --- drivers/dma/Kconfig | 2 +- drivers/dma/fsldma.c | 11 ++++++----- drivers/dma/fsldma.h | 35 ++++++++++++++++++++++++++++++++--- 3 files changed, 39 insertions(+), 9 deletions(-) diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig index 302021540d76..9b13e7aa31c7 100644 --- a/drivers/dma/Kconfig +++ b/drivers/dma/Kconfig @@ -206,7 +206,7 @@ config EP93XX_DMA config FSL_DMA tristate "Freescale Elo series DMA support" - depends on FSL_SOC + depends on FSL_SOC || COMPILE_TEST select DMA_ENGINE select ASYNC_TX_ENABLE_CHANNEL_SWITCH help diff --git a/drivers/dma/fsldma.c b/drivers/dma/fsldma.c index 0ee3d719ae95..157db416eaaf 100644 --- a/drivers/dma/fsldma.c +++ b/drivers/dma/fsldma.c @@ -32,6 +32,8 @@ #include #include #include +#include +#include #include #include "dmaengine.h" #include "fsldma.h" @@ -266,7 +268,7 @@ static void fsl_chan_set_src_loop_size(struct fsldma_chan *chan, int size) case 4: case 8: mode &= ~FSL_DMA_MR_SAHTS_MASK; - mode |= FSL_DMA_MR_SAHE | (__ilog2(size) << 14); + mode |= FSL_DMA_MR_SAHE | (ilog2(size) << 14); break; } @@ -299,7 +301,7 @@ static void fsl_chan_set_dst_loop_size(struct fsldma_chan *chan, int size) case 4: case 8: mode &= ~FSL_DMA_MR_DAHTS_MASK; - mode |= FSL_DMA_MR_DAHE | (__ilog2(size) << 16); + mode |= FSL_DMA_MR_DAHE | (ilog2(size) << 16); break; } @@ -326,7 +328,7 @@ static void fsl_chan_set_request_count(struct fsldma_chan *chan, int size) mode = get_mr(chan); mode &= ~FSL_DMA_MR_BWC_MASK; - mode |= (__ilog2(size) << 24) & FSL_DMA_MR_BWC_MASK; + mode |= (ilog2(size) << 24) & FSL_DMA_MR_BWC_MASK; set_mr(chan, mode); } @@ -1007,8 +1009,7 @@ static irqreturn_t fsldma_ctrl_irq(int irq, void *data) u32 gsr, mask; int i; - gsr = (fdev->feature & FSL_DMA_BIG_ENDIAN) ? in_be32(fdev->regs) - : in_le32(fdev->regs); + gsr = FSL_DMA_IN(fdev, fdev->regs, 32); mask = 0xff000000; dev_dbg(fdev->dev, "IRQ: gsr 0x%.8x\n", gsr); diff --git a/drivers/dma/fsldma.h b/drivers/dma/fsldma.h index d7b7a3138b85..01f93123b233 100644 --- a/drivers/dma/fsldma.h +++ b/drivers/dma/fsldma.h @@ -232,17 +232,46 @@ static void fsl_iowrite64be(u64 val, u64 __iomem *addr) out_be32((u32 __iomem *)addr + 1, (u32)val); } #endif -#endif - -#if defined(CONFIG_ARM64) || defined(CONFIG_ARM) +#else #define fsl_ioread32(p) ioread32(p) #define fsl_ioread32be(p) ioread32be(p) #define fsl_iowrite32(v, p) iowrite32(v, p) #define fsl_iowrite32be(v, p) iowrite32be(v, p) + +#ifdef CONFIG_64BIT #define fsl_ioread64(p) ioread64(p) #define fsl_ioread64be(p) ioread64be(p) #define fsl_iowrite64(v, p) iowrite64(v, p) #define fsl_iowrite64be(v, p) iowrite64be(v, p) +#else +static inline u64 fsl_ioread64(const u64 __iomem *addr) +{ + u32 val_lo = ioread32((u32 __iomem *)addr); + u32 val_hi = ioread32((u32 __iomem *)addr + 1); + + return ((u64)val_hi << 32) + val_lo; +} + +static inline void fsl_iowrite64(u64 val, u64 __iomem *addr) +{ + iowrite32(val >> 32, (u32 __iomem *)addr + 1); + iowrite32((u32)val, (u32 __iomem *)addr); +} + +static inline u64 fsl_ioread64be(const u64 __iomem *addr) +{ + u32 val_hi = ioread32be((u32 __iomem *)addr); + u32 val_lo = ioread32be((u32 __iomem *)addr + 1); + + return ((u64)val_hi << 32) + val_lo; +} + +static inline void fsl_iowrite64be(u64 val, u64 __iomem *addr) +{ + iowrite32be(val >> 32, (u32 __iomem *)addr); + iowrite32be((u32)val, (u32 __iomem *)addr + 1); +} +#endif #endif #define FSL_DMA_IN(fsl_dma, addr, width) \ -- 2.54.0