From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f45.google.com (mail-pj1-f45.google.com [209.85.216.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CD27133B6CC for ; Thu, 11 Jun 2026 03:53:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781149993; cv=none; b=DS+RHpx3Y+AolOYLPqDs6GQKCJ8CzN6h+GHwU4X9iDKEDjedR4zMhYhkrJSH5dd9F4Pn5UvRX+WKBpfDvAq/PPJ2RiKGL0+6wC8cz06dojPD/DrzYot0Pap2FfycbFOLoHgeBH5nwmJhiO8AWu/jkNgsB9UeB34593E8TzdxCYQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781149993; c=relaxed/simple; bh=lyTXMgabiZFV1r5MchNd6Qy8eKJqo3LxCHLLSTQ8EzE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=DliYsUNDQr/TfCgQ22RNgKEVhEdwtnXNsy5OQEIzGipyvcojlnK/AiuKgEMcK+ZZQRjgeoCeIQQiy82XyMDXEHjnsUPwWFJZr4s2qBKaurcwHXWHQgZ2L5GYz1xRVlzknaCXpmbzL58t72dyukm8xBUIjZvxBvs/5tbNdD4UpXg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=jVvaEUrT; arc=none smtp.client-ip=209.85.216.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jVvaEUrT" Received: by mail-pj1-f45.google.com with SMTP id 98e67ed59e1d1-36b900f350fso6465626a91.0 for ; Wed, 10 Jun 2026 20:53:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781149991; x=1781754791; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Axf2i08FEMNQcDQLuzX7KUZnp7l0NF95o4nFAH7q5yc=; b=jVvaEUrTKFzbDua+hHIl5BIeZqwDCBr47Xu0QKig5P35vB3jwKG9D1HKUTaqCFRg57 t9xP+DBlfFFJ7yo3PXwPyXGygtYZ5idjxOPaiDGWPIQ1WGLrb82gCl//mlFW1nsYguLm 8I3K/7N0Uytim3xotB3DH75knqrf/ORzdJv0tn9yn2DsNF9A8Gt6Lm9suQQkipYrkw49 +V+YWYY6hQuscxPOpR6yKDIWOJNKcF4z8XWUnKHCJi7e8X2+Az63/qXuuuebVvzggaoW /B9TP52fSG6n6bSJXTRiMyuHeLBg+1mcCZBmxjWx7wDNgQRvQIURaRJC0jX/R/uofB7D 2E9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781149991; x=1781754791; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Axf2i08FEMNQcDQLuzX7KUZnp7l0NF95o4nFAH7q5yc=; b=e6D9An9ZZmcSZFEhaHr3zsJyh34ioezxpP6tK1MbkH2uKtWAH2Mew/F4Togalaiy/T XNJ0/pN+zdnZby/jtfQRPhtQoms8E+ElLIQO6cPQjux4aHI2wlVCmAho1b2WQYWOd6Z+ 0dPQFzE+sXZxjL0Ye105vr0QHyHjSq3MtHkOyEmWRZS2YsewbX+YAEfnNCerGSAApPxW G92nWZN+6nrIBzzGp/sPswLIqtSBd/ll+Ds3ix2pTBPAGDpQTPWSweMVOpo/cdJxTpSO bkAlJwAvZJ8vyvmR8xBYlNcmdhtF32UMTkM5CQnd7cKT4GAHGRS9jhBrbxDufbZe8zY9 jMcA== X-Forwarded-Encrypted: i=1; AFNElJ8Z5j8VLPiCP+RAl9REKHHgogJaeVOy2d3hyAPV6OJ30qsh2qb6PszLZwLMGlgrFh4+mSF0zlvwyGqh4y8=@vger.kernel.org X-Gm-Message-State: AOJu0YxsU4ZHVFcbLEve5SHdvHEHYPiMtShwr1grlhB/8trrTcEHwr6w HHZns50C7VIQxAdXMfsy4aFUmqehMt4hEOU694JNDd4i0oQOpEAYqtFC X-Gm-Gg: Acq92OGrcKcjhWl8IuvEQ448FBuiCQsVdWXuOTGBmjaTe4einlvQSuZv8hvU1e+QZgu T9VLUDOujPRXBzqA8cuBz0HUnnsPKFyN8L55HIKpxVbG10AtCGAtW6iu9ttguNQBuWojuQvqv7/ WUbUcS5+0goxywso4uUbpJ+LpsqTVjJYqN3mhRbntjlCMpAe7llfLHT/Vw1lVZWyeqJ7+n3yj6K MVzOsd5kx0SQ8ZmVRwrPz1X1PeGjwRWNdC/XXIW841fB/hbGCPf2fd6+5hWVukMYsT0mp26hCiT S1JOk8LLl0gvYDZaYyhDxeIybP5p5NPZBFPOx1ZXjHEoxusCX7v+jEWRMc6vHqPJgBH5saWys8O 1T546nh5epFszExjB8uQi4QgM4UUt+UWz6sLEZGAZgJL26BC5ZOSHbuFpPNCzkOjQJdOIUXCi8r N42PJcXfINlMRFfILhKlOKaILdn8AKRCiHBuKAUk9l80qLlY5gnGD7/YAr5T51o6D66D6UyGq5z V7MUVRHjvWVT5ysMvxNryEXhTa1X4z6UCS8VOfHrZSgfw== X-Received: by 2002:a17:90b:2dc8:b0:366:10f1:3d86 with SMTP id 98e67ed59e1d1-377aa799f69mr1529495a91.22.1781149991227; Wed, 10 Jun 2026 20:53:11 -0700 (PDT) Received: from ryzen ([2601:644:8000:5b5d:7285:c2ff:fe45:8a32]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-377522a188asm910131a91.3.2026.06.10.20.53.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Jun 2026 20:53:10 -0700 (PDT) From: Rosen Penev To: dmaengine@vger.kernel.org Cc: Vinod Koul , Frank Li , Zhang Wei , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , linux-kernel@vger.kernel.org (open list), linuxppc-dev@lists.ozlabs.org (open list:FREESCALE DMA DRIVER), llvm@lists.linux.dev (open list:CLANG/LLVM BUILD SUPPORT:Keyword:\b(?i:clang|llvm)\b) Subject: [PATCHv4 05/15] dmaengine: fsldma: check dma_async_device_register() return value Date: Wed, 10 Jun 2026 20:52:35 -0700 Message-ID: <20260611035245.13439-6-rosenp@gmail.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260611035245.13439-1-rosenp@gmail.com> References: <20260611035245.13439-1-rosenp@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Check the return value of dma_async_device_register() in the probe path and propagate errors instead of silently returning success. Previously, a registration failure would cause a NULL pointer dereference in list_del_rcu() during remove when dma_async_device_unregister() tried to remove the device's global_node from a list it was never added to. Assisted-by: opencode:big-pickle Signed-off-by: Rosen Penev --- drivers/dma/fsldma.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/dma/fsldma.c b/drivers/dma/fsldma.c index 43d817f6ded1..3009e1531292 100644 --- a/drivers/dma/fsldma.c +++ b/drivers/dma/fsldma.c @@ -1303,7 +1303,11 @@ static int fsldma_of_probe(struct platform_device *op) goto out_free_fdev; } - dma_async_device_register(&fdev->common); + err = dma_async_device_register(&fdev->common); + if (err) { + dev_err(fdev->dev, "unable to register DMA device\n"); + goto out_free_fdev; + } return 0; out_free_fdev: -- 2.54.0