From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1E50833B6E3 for ; Thu, 11 Jun 2026 03:53:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781149994; cv=none; b=CAC+lL8OOvaVI7p0tnjpph4o3F/Zgwyxxx+IDrTdNsM6TMKbZoFiddH/fiSO35nHEnxWUatrzg5kX76XRTM8rzTaC7Q7ozq4j3nF77bCV9EGZokvIncpUs+f+QoOduvIqvN6+6AH1AIpYft7asF5EV7MZcLuZaOFTuBnlNM6w1E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781149994; c=relaxed/simple; bh=Q/PgZrUxr7JJJLlNJf1HKxpgmT9Z+J8tRDHEovzB8l0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=m8GqVo6oRQGpTr9dcp0edxTBdMdgBtgVYc1PA6uFKGl5WfQdITnLdO1Wk/5ThwYNNKYvcZXU1BcDod3+mcc3XYdrm18Zx8snsd1eN6poVEeYIzFY1Mugv1AINig/MbyeDhm5xNVztAo9lPVdgJmjTXJTMxIbNBS8B6urRDUgxmQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=PvqF9Uzl; arc=none smtp.client-ip=209.85.216.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="PvqF9Uzl" Received: by mail-pj1-f42.google.com with SMTP id 98e67ed59e1d1-36bcbd7821fso3346902a91.2 for ; Wed, 10 Jun 2026 20:53:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781149992; x=1781754792; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=EHDaxjKNRdlH2zlMKhtRadxGEkWWwDYddu/hmn7v0eI=; b=PvqF9Uzlmvto+4zxhnkGgZFQjOv5NzMt34rpoRvliekGRxFJVNvH5ZxTB1H85jiOtE rK4hc+PrgbTyzjauG7u86Sz54FGi1H9l1PT3rfsPhyxlwdDtSMMKntEwmuqRJpXSrPNj mnziR+UlO0IMQPLjkWG/7M3Tw3P9PVjjBiE2cvr9SEcCE6DhInhdlqO/bfZ33PnjAjgs zIqHLg/TXHtiLdrebjfg7XqnGQvNyZzY7aKToFJxmjkSco4EKbWGEjUH4F3NjygOqrzS lUepUzDUVvraC2ykgR7HT6ttwvC4jEvuogmF609XKYmBTfOJLLoDBr3T8SLvFGfbfIrY DXMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781149992; x=1781754792; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=EHDaxjKNRdlH2zlMKhtRadxGEkWWwDYddu/hmn7v0eI=; b=tG1q5DVTRaJNkB3vqHTU7DCKC/tbV5OigZj7akYiX8H2vbRB6ADNDUyNvw0BXhJxJd E/5zB7G56YG5/fK2w8R0LTE9bLb6HhrlSsCARCqYC2A7I0KZE//yl/8mTQ9QdvdPCwNK ei7JS49SBKm9H+UVGmxhBr6jlFMoTb4TZ9PvNjYEHWVhoPFeDHOKXWAInhYIypCRIcB/ HeGGZ1NjD/IbY7azwMlvtBRE2WPVwhcy7aqHwHabt8TD2PPY/R3ZyMdEEf2M4Kyvizkn 9uqvSSbAHliEwUtu4RQRTvfudcGqHDKiYbj3Fvn5bTfNEXMU5A62M6Oxp950nW3VeJ9h xGzA== X-Forwarded-Encrypted: i=1; AFNElJ/9C0fll9TlOoOS6eD4GgJ0j1uBd0T+mEPj2ngrJnOyWqjaWAYdW1P52OCC4uIMee1A01YnLuT4WD7IgM8=@vger.kernel.org X-Gm-Message-State: AOJu0YyFVCzC0zBQ27eJ9wzBmrq9Lkfo8oBKTBFY20A0wlQUruM8XuWw DdHdePjlFEWL1rYeLFLmiEaHgS5mvgz/V8uvBVAN6I/DPVuL0tFnelM4 X-Gm-Gg: Acq92OFMIb40AykgCKuymUPx/4hAPgbM71lzU+004kB1x0431vWygMzRWUdg2NhADut /qmb1HGJXYbM39ehk/gXLmaRAp7VMygVdxoxchVfmrsv9TMMgaqgkKPpxvVUL1f+E9e5ANZ41PH iHuIOyK7Tw/efVDm0i8owm2BOBUHvLzuH6WlpLYsssAFz34lB2Y85Ycn5nhN0QLQwpbybsi+Qj7 edMSf4qES0qf95Ee8KEdx9bNHHYO2rMMRXPJkMDYhfcFDobcqGXg2c+TTH86XY2XRNHHb9YkTOI zpQMm+Jbi0LckUhceiPinwpXmPb9bLZ+2Sl4k8XqBym06H+a/8tijZ1GP48IaktNyMtryJgx1rv N13QFhAZdPSMKQgjgk8FSuNFxJThTuWvMSJrr8QZQmL1Rq5EsQwQBn2ZrtOuY2gxnIx5Gm3WqjY fNOcAlXw/OgQKJCtr+DYyUYXOzRhn4s8nj4bsrx2Y6CUe9rSyzGtvFRYffMhPHlih5purBuQ8qX mS/MlXcdvsn6HrUHLowxXpwqi6qrfE/dVd4huTlCPDAwA== X-Received: by 2002:a17:90a:d004:b0:36d:5dbe:2a0d with SMTP id 98e67ed59e1d1-3779e231462mr1177515a91.7.1781149992546; Wed, 10 Jun 2026 20:53:12 -0700 (PDT) Received: from ryzen ([2601:644:8000:5b5d:7285:c2ff:fe45:8a32]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-377522a188asm910131a91.3.2026.06.10.20.53.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Jun 2026 20:53:12 -0700 (PDT) From: Rosen Penev To: dmaengine@vger.kernel.org Cc: Vinod Koul , Frank Li , Zhang Wei , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , linux-kernel@vger.kernel.org (open list), linuxppc-dev@lists.ozlabs.org (open list:FREESCALE DMA DRIVER), llvm@lists.linux.dev (open list:CLANG/LLVM BUILD SUPPORT:Keyword:\b(?i:clang|llvm)\b) Subject: [PATCHv4 06/15] dmaengine: fsldma: fix probe error path not freeing IRQs Date: Wed, 10 Jun 2026 20:52:36 -0700 Message-ID: <20260611035245.13439-7-rosenp@gmail.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260611035245.13439-1-rosenp@gmail.com> References: <20260611035245.13439-1-rosenp@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit If dma_async_device_register() fails after fsldma_request_irqs() succeeded, the error path jumped to out_free_fdev which only removed channels but never freed the already-registered IRQs. A subsequent interrupt would access freed memory. Fix by adding an out_free_irqs label that calls fsldma_free_irqs() before falling through to the existing channel cleanup. Assisted-by: opencode:big-pickle Signed-off-by: Rosen Penev --- drivers/dma/fsldma.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/dma/fsldma.c b/drivers/dma/fsldma.c index 3009e1531292..4475d50a94f5 100644 --- a/drivers/dma/fsldma.c +++ b/drivers/dma/fsldma.c @@ -1306,10 +1306,12 @@ static int fsldma_of_probe(struct platform_device *op) err = dma_async_device_register(&fdev->common); if (err) { dev_err(fdev->dev, "unable to register DMA device\n"); - goto out_free_fdev; + goto out_free_irqs; } return 0; +out_free_irqs: + fsldma_free_irqs(fdev); out_free_fdev: for (i = 0; i < FSL_DMA_MAX_CHANS_PER_DEVICE; i++) { if (fdev->chan[i]) -- 2.54.0