From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f48.google.com (mail-pj1-f48.google.com [209.85.216.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 86239331A63 for ; Thu, 11 Jun 2026 03:53:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781149995; cv=none; b=lgAZfsVegGbrk1/LwSaw/cSAloJenlsOiiUhJdnKQcEL7bup2mNhZaN5RUhGzF+Op+32YdoxYFbi+Gs/5ep/E4pYglNwrkPDktqNnqmxrpEkNp2cMrEXmxaSPtVle0fexI1lW01f6sgQbHEuuoAY/JMeR9AMbBUFJn0XRjcrBbQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781149995; c=relaxed/simple; bh=QNstBAc1L91v28F1oF1V1UBDhakUFuGDQ4mwwDQaYVc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=V3gdVoyzHODhLGNxkFoekMf9BzuVziOUo7j0dkDNxAsrFUkwsQvkIK4PRTH2FyOqv34SfJizJyCdayYvuDmnO73DYraSjxq5KCzpvHz3T0bxqmV8jGQRQtvC4OjQLQj7gWn64ZCk7bYcWZFP6X2NH/m1xfdtrK6EkVl1kHn9SBs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ijHgXKiq; arc=none smtp.client-ip=209.85.216.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ijHgXKiq" Received: by mail-pj1-f48.google.com with SMTP id 98e67ed59e1d1-36ba3ea5c46so4522953a91.1 for ; Wed, 10 Jun 2026 20:53:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781149994; x=1781754794; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=1tT9xKJ0Z4ILZqTxJ8ZpiwY1jbcqBK/pYbLAZ3NF4IQ=; b=ijHgXKiqDiLNIyCOE+hAkkmR2Khr2We0ZjgaEaFDpcQF19g2iNaZTBDnqxwL4+BV11 V35S4J4IMTzCwvva5RhBUUjSqZ8tYuYqjvW9EU4LC3PAl4VzHjXmyfnNWRToogD9Tojt bLnH490Bp8Wb9/vZIX1rWAwXqNcfBi+bVFMwLV7bo1w2zsSZ3Y3fWzhHJJH5Agx9sCtc LCM861CoL51020BIS2SSmLhDeLyyjhL37OYg/63y2bR0PkuTN2HL0pI1+c6pWgnr6X21 jXzSnfYpb6l/w9StxON7iFZSBxT0MUBO6Jmi+FeavBHQV4MDUvIoEdiOJYUsAGq+OTT0 1fEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781149994; x=1781754794; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=1tT9xKJ0Z4ILZqTxJ8ZpiwY1jbcqBK/pYbLAZ3NF4IQ=; b=l5zcjDVt6SjApoCMrBL/2YhrfbGGT7B0zu+PPGTFy2tsL0zrNavd1+VCieZk5x/seI LN7DkK8TQq3u2K4tW7NUqcSvWOCoBzCf6HZYUBJxBd+pkjUfRK/yuRbXGYez4JxIX0cS fI3aj5LlBMspFtk+YehRF/BDajGthPLW3ZhPl7vbAx65eBICjcqOfBgvuwruVjYjCLQz Y4kasa7m5C7UPXuD8W2JHBIE9isiV0pfi/S0Y8s1fmWv1A7lGOkBQ3z1Ihan73arX3zZ m4OPHhAbh3DNAcpBPjipSLBJcjEKVFkdDKvGSOSLx0EO5WJzV5f/PB/IKHxVpjB0ZRTK Zo/A== X-Forwarded-Encrypted: i=1; AFNElJ9aq0WQgvLNGX7wQQYTogOfZBFPjS8EnwqwHwIdH+q2je7uObesXqK3qO5P+pxOE/esmIJcCk7C0JJ0PwI=@vger.kernel.org X-Gm-Message-State: AOJu0YxnoM00V9Z4fhOtAUvRAeSz1b3TM/NLCwO5Yb4f+DGs/mrjonSC Brk4orJV3OjIE7FgNtF/+4hYwaDQCUp4xofsMHKtcphlvmH0HAbtxWTA X-Gm-Gg: Acq92OHKhpuqpkAFOKQF3q1fO8sfiCmvh8qtzmL6sl8pHvO8D7a8Cd1xQ/h5GSY7b6v nIpTQY3a1UCLsIxNDvigy+nBb/pg7uzX9LMKyMkwHN5IF2GzhEKHeOMLhn+1ISObGF0HrzBiJL8 o27SX4EPer4IQrXe2tmkOu1syBM6rKvOrsj6D+cbn/WXLB2TofCUWgnkDTEjJFyD9onz4hmAW8J hxTA2kP9MUstiEmSJOFj+kE9uGnr4Zl8Rh8J3VIcxBUnaMjL/AYKsbdYP8gzWOuSX/Z89kENGGT LKjvfubvo87O5GQBIySawa3JqxXNrOISzwZS5yjJ6b0PrR/3vBF/qEc+pZQh74lZ/r2enR7Tmnw 7TT/o9X93Qoe0EHGbTeENXsSQNOuDM5ZT2Ir+Wgt/ZqtwSn3T3ee2DTvhMvGoB5ettoNhEpfTfB VcpKQfBK/cHEPmJVZgkD07enKmiOnQHxkWuGGH94mQnGnhWDW0RMG/jcbFdfJlxWH/OB1tIiNvz f8TZc+nlp5HoN7CdnTRU3sajUHN//6SJfUpEIgPiXsFCA== X-Received: by 2002:a17:90b:4d84:b0:367:b819:2214 with SMTP id 98e67ed59e1d1-377a4ab6f54mr1274422a91.13.1781149993882; Wed, 10 Jun 2026 20:53:13 -0700 (PDT) Received: from ryzen ([2601:644:8000:5b5d:7285:c2ff:fe45:8a32]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-377522a188asm910131a91.3.2026.06.10.20.53.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Jun 2026 20:53:13 -0700 (PDT) From: Rosen Penev To: dmaengine@vger.kernel.org Cc: Vinod Koul , Frank Li , Zhang Wei , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , linux-kernel@vger.kernel.org (open list), linuxppc-dev@lists.ozlabs.org (open list:FREESCALE DMA DRIVER), llvm@lists.linux.dev (open list:CLANG/LLVM BUILD SUPPORT:Keyword:\b(?i:clang|llvm)\b) Subject: [PATCHv4 07/15] dmaengine: fsldma: fix request_irqs unwind freeing unregistered IRQ Date: Wed, 10 Jun 2026 20:52:37 -0700 Message-ID: <20260611035245.13439-8-rosenp@gmail.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260611035245.13439-1-rosenp@gmail.com> References: <20260611035245.13439-1-rosenp@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit When fsldma_request_irqs() fails on a per-channel IRQ, the unwind loop starts at the current index i, which calls free_irq() on the IRQ that request_irq() just failed to register. Decrement i before the loop to skip the failed channel. Bug introduced by commit 586f54672b33 ("dmaengine: fsldma: convert to platform_get_irq_optional()"). Assisted-by: opencode:big-pickle Signed-off-by: Rosen Penev --- drivers/dma/fsldma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/dma/fsldma.c b/drivers/dma/fsldma.c index 4475d50a94f5..c04a7fbd2ed0 100644 --- a/drivers/dma/fsldma.c +++ b/drivers/dma/fsldma.c @@ -1088,7 +1088,7 @@ static int fsldma_request_irqs(struct fsldma_device *fdev) return 0; out_unwind: - for (/* none */; i >= 0; i--) { + for (i--; i >= 0; i--) { chan = fdev->chan[i]; if (!chan) continue; -- 2.54.0