From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f54.google.com (mail-pj1-f54.google.com [209.85.216.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D4EA033DED1 for ; Thu, 11 Jun 2026 03:53:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781150000; cv=none; b=kvdio/tTTFQhkbe75kk3EZniMHCqh2tiewkpSTcGYvbAReLptjIyq0bTLz36DzWuRJEjFmnYJTt0wIuBaqtWlKdyP6434ybrfi7AOFzkQLeZ3zTeRa/itLb7YRfY4MrOPsNTEgIC+r/lcI8Om1fijfD3keHDrjMJYzojixFVa0Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781150000; c=relaxed/simple; bh=PGNeHFjQkdZFVCBNSlBrOzGYn37IRrmrGpkyMACc34M=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=dSQ3Qy4jaeZpOj7/T4vC5QQ/BOKlDgfBQ+l/7A6vQt+gT0RMHlE4Rrr3r0qg80aqb1ivXadnH94VUu+6TsKHa/kRwBKrcevO7ohdFn3WEytfzPAQXwyv2VLZaCaR43PbKl/H6UsiGsdyGxbqMTAfvuawle9xyEBwGYGq+iGz2Jw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Ni6Umfxf; arc=none smtp.client-ip=209.85.216.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Ni6Umfxf" Received: by mail-pj1-f54.google.com with SMTP id 98e67ed59e1d1-36ba285e98bso7406255a91.2 for ; Wed, 10 Jun 2026 20:53:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781149995; x=1781754795; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=R8RAk798iHkOqMUF+266tq7iD91rBE+7QMl47XALgu8=; b=Ni6UmfxfCZDZCuHMkoeBATQPSvmDxCBrUF0DcJ2gQ1LtiO6j2EcHEgBRe3763xefoZ RTAknq7HLgrG/vNBj0hPPbCrspViKCus5AzXPS2jYti1O3StPJJ3k5ZPgnBTKw3OW/6Z Qm01jtLtdUeenQa20UPDxR6/MbA/t7htmr9t8R7qi2bD15fJIzj1MrmPcPOD3zpF4Nhx uPiqyr1rwxE+8wKL47vnk2d7RxN00RMCWW28E3YDzLcJUd52bTHCRSCf7+YHQtAlfW3+ 41TzGO6+8dInXGZIz8VbytYQrqGZLt6zbmTi0sZnKol9TrmwkwQgLJRCw0y3nIM0sSWn 1CuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781149995; x=1781754795; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=R8RAk798iHkOqMUF+266tq7iD91rBE+7QMl47XALgu8=; b=aRRVwdSO0ZFhBJ9bQhzT21f+Gnl4mpf7/SpDcDSaSEvI2oHmzH5+iPNWJenUFNwpft 6Wu/r4a9v85a7jDZMD7h2jbcjnpswsnFQFMmI8BBiBWfBzHAOvptFX/dvNN7DEpo3xS2 smhAdJXQ2sqo7ttd/M/NnF2oQYFkxULTlWQtnrpGg7W3ftqWCBQ027NVCzGLG7UO2Vry NHmwgDfL0vjoGU6t/yo9Lqq5QYOoC61vgZ+3a7N5DBGYmAHYVVStZTiQvI2c6HeNJEod MctEVL6PYe+RYAA9j+xwayjxbKJKFqLtnbfjTLInsynJIuTNtfq6sE+W1yuFG9yrn0ba lqeQ== X-Forwarded-Encrypted: i=1; AFNElJ/bXVCWu+gyActc6CeLyt0zLfZViTtA4ULciL7/UYZEKrCkem02k3GflBj2h6fNoZHR3dkS7BBZN3BG5nI=@vger.kernel.org X-Gm-Message-State: AOJu0YwWF5VZXZc7xwzqf5Q/v28LFcT/1Y5AE/+ntkZqStp/PiOI5/m1 I1v/2rlCtyTP+dNNyS0VbuwXDKXfurtaBbvlMDit23+fnx4SZwRQZO61 X-Gm-Gg: Acq92OHZSlqOSPwm4B2Azcw2DcfIZOCwEe/umYZgqAZxmOSPkIqYDVSp/B+HqOcKZHn SERukY157GAtwq6q8HI1VY48nhoubz5NC5+mCeavIyn9olNKUqTOS6mI/jXgfFr3Y14/WwzrEeZ hP8dSHueX8c0aGR18FUIVpMou+w2nmikBa5AN1K5gKLZJ/qLJFTg4UDCnOz6ERZi2qE3YywVhMZ tstyOZIi5HBnbkQcEHVhrlvo/T3dS9Feti57HeDMXdBzBws34dsRTuaXXcDurqA7MufFWwsgFEz ZJ+3RGcWdWyTifqS940+ccRRnYQVr+tu5FIWEGoyRgJUmUiIUGqiW+0AbuRLbK18KdcB8BhmbbU 38SRZ+J/mEjypF+0RNdIo9FiV44E7nIil0rmQPDzrYBTiG7NgzYASGNqgks4/ZI/D5jA8fHCLFG RBxdQiNa+qNYQEK/WEXmqxYqfSxh7PtVl0GWwZB2knNeSL2e1Sp/QTHbpQ4Io8sqNWZFBN+AKqy DnjgoFmt2wpxkZt42nib9kPxPt2ImfPb3q+5ZMDeraQOQ== X-Received: by 2002:a17:90b:1642:b0:369:7421:75c3 with SMTP id 98e67ed59e1d1-377a5915432mr1202815a91.16.1781149995246; Wed, 10 Jun 2026 20:53:15 -0700 (PDT) Received: from ryzen ([2601:644:8000:5b5d:7285:c2ff:fe45:8a32]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-377522a188asm910131a91.3.2026.06.10.20.53.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Jun 2026 20:53:14 -0700 (PDT) From: Rosen Penev To: dmaengine@vger.kernel.org Cc: Vinod Koul , Frank Li , Zhang Wei , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , linux-kernel@vger.kernel.org (open list), linuxppc-dev@lists.ozlabs.org (open list:FREESCALE DMA DRIVER), llvm@lists.linux.dev (open list:CLANG/LLVM BUILD SUPPORT:Keyword:\b(?i:clang|llvm)\b) Subject: [PATCHv4 08/15] dmaengine: fsldma: convert to platform_get_irq_optional() Date: Wed, 10 Jun 2026 20:52:38 -0700 Message-ID: <20260611035245.13439-9-rosenp@gmail.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260611035245.13439-1-rosenp@gmail.com> References: <20260611035245.13439-1-rosenp@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Replace the per-controller irq_of_parse_and_map() call with platform_get_irq_optional(). The controller IRQ is optional when absent (-ENXIO) and the driver falls back to per-channel IRQs. Any other error is treated as fatal. The corresponding irq_dispose_mapping() calls in the probe error path and remove function are removed. The per-channel IRQ mapping in fsl_dma_chan_probe() uses a child device_node rather than the platform device's of_node, so it is not converted here. Assisted-by: opencode:big-pickle Signed-off-by: Rosen Penev Reviewed-by: Frank Li --- drivers/dma/fsldma.c | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/drivers/dma/fsldma.c b/drivers/dma/fsldma.c index c04a7fbd2ed0..eba194d64105 100644 --- a/drivers/dma/fsldma.c +++ b/drivers/dma/fsldma.c @@ -1213,7 +1213,6 @@ static void fsl_dma_chan_remove(struct fsldma_chan *chan) spin_unlock_bh(&chan->desc_lock); tasklet_kill(&chan->tasklet); - irq_dispose_mapping(chan->irq); list_del(&chan->common.device_node); iounmap(chan->regs); kfree(chan); @@ -1248,7 +1247,14 @@ static int fsldma_of_probe(struct platform_device *op) } /* map the channel IRQ if it exists, but don't hookup the handler yet */ - fdev->irq = irq_of_parse_and_map(op->dev.of_node, 0); + fdev->irq = platform_get_irq_optional(op, 0); + if (fdev->irq < 0) { + if (fdev->irq != -ENXIO) { + err = fdev->irq; + goto out_iounmap; + } + fdev->irq = 0; + } dma_cap_set(DMA_MEMCPY, fdev->common.cap_mask); dma_cap_set(DMA_SLAVE, fdev->common.cap_mask); @@ -1317,7 +1323,7 @@ static int fsldma_of_probe(struct platform_device *op) if (fdev->chan[i]) fsl_dma_chan_remove(fdev->chan[i]); } - irq_dispose_mapping(fdev->irq); +out_iounmap: iounmap(fdev->regs); out_free: kfree(fdev); @@ -1353,7 +1359,6 @@ static void fsldma_of_remove(struct platform_device *op) if (chans[i]) fsl_dma_chan_remove(chans[i]); } - irq_dispose_mapping(fdev->irq); iounmap(fdev->regs); kfree(fdev); -- 2.54.0