From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B0DEF362138 for ; Thu, 11 Jun 2026 06:28:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781159311; cv=none; b=RwJ/7zBOPalwzSlHBjObTAXz1r8+dx6P0Be8PTn7o6zFtkQDLJVGlSmnSowifjssbMfRFIG+dJT2vVSgfQxEKyz47g/YyQyo5g9kmMxXtc8WjGLD9OnE//G4X8OjBRaK6CXalBG3LNI9Nh4TWzPkdk0aqCd3SmsCCa0Rw8VBW4w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781159311; c=relaxed/simple; bh=+zokLVbOzGFitsw36alWayaKMRG+sHuntk6NcwDsdUI=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=m0m6ouVPmb9hbjJMcWduZnTsSXBnJPGnVM3AE2Dwn9IfuqceSOE2uPqNrb950ga5ygjqpCDb6Umo3m4UbojOVpliTWpvZ+UYs7bvywlDrsDbqTMbRELfmHAK1F+gE7RL4My5iVvVw2ppSA5DOrl9v+PDKj2iwiyQYrOW3lF8iTI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=tK2ojUVp; arc=none smtp.client-ip=209.85.214.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="tK2ojUVp" Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-2c0c379e8ffso52412735ad.3 for ; Wed, 10 Jun 2026 23:28:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781159310; x=1781764110; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=/KFSPxWAI+mIMkFyj/SFPC1tnivbSRId0vdj8dR7c/U=; b=tK2ojUVpDu4IRDIpbOYqs89e0tM1s3W4Hj1RyrBfP/LBVG5FVnsKRZYHL8A09qw04Z gLzfEnfrHc97Df2Vymfhgi5blvNNrp9X08fwl5u8zGyXzLEc4x2O7W1C+hYTc15p5EOa s2pVS7VzHNyvDuDyYhvNyBx2EiiFj8aAe2gaedMeKHtkLuYT7++eYfTU9iW+v666Qiae MmNd6Tq7mulTi4Ne8lmgp4VU0JNk8PT24UyHrxYcGEtsEDHDM8e69Ppxku9iM6PT1XTJ 8QXuQ6Edeu3JxmiquALs/gbXNhFCpi3WP7FNOiQ6xRKCIYC1mWoavUBh3FGpMFTnF3mv hApg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781159310; x=1781764110; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=/KFSPxWAI+mIMkFyj/SFPC1tnivbSRId0vdj8dR7c/U=; b=PWCZ/Oa35SRLXFJ+sNAZLBH2fTktXHJlaCkwdpZQ//G/mrN0RH2EiW/xOPWmt/ITWh NGp2JgeS6ohpmSE3talLmqCUtEK49wbaP3VBW9lU3wCZDrkMD7IEBlDkyo3qLSKvtADa 0L6MeUk7d4dpWMdI2QRrO5Pmb8cYyCpBFjbCWkfNcc/mz0aBJNpQOmzM80Y21LYjuwFo kf++4tUjIXkxNnkUY3ZYJCx6SLlQA7LpLFAoIOJPcpEYe4IxaLztVXtEXyhfRRVfybpq gFk3lE7jzJHh3lDaP9X0OU7J2QLCxHUJqmhSyIVQGhFoLVTg+5hLkWuetU40ukXFGjYf 6Y0A== X-Forwarded-Encrypted: i=1; AFNElJ8RGlnLSllfjOIRNQsL326WRCZHFrJDtrzEsBJmaT9/EEY2YhXCIai3HDPtPNE9CBbpcSPQSHWlYu3yAes=@vger.kernel.org X-Gm-Message-State: AOJu0YzLql8R9Up2QKlwJEIanVORx+J2JpeTkppiQGrAU9TRpo1JXzCu FsOVCeilatufWlgxuZclt+vPd2aOcPYtetDVJW+Wv0j48aFuKOwvobGL X-Gm-Gg: Acq92OFTRDNh5AH8REMSA0cIFeyqDWniyOlyDtieIz8mkMYDDXLB3CL5v9vV0/pgygt IhHlySyRvxGWsJ1l/+q6yRk0P6r3SjRAXpuwjSe1to7iT8banD1ltg0y/eOQxES3S0v+6+yOX4Z 0Ay3g6wymJ84HyVOTTSR/nuC+XmapjUcyCtmVSVhJpiGkKZ+CEafW0Ngn0XJ8P9l1tgMKSmZYOr PyfEGG/KjFRycmVJ6XkkwZjZ9naXJ5+Ei/wS7P4B4RL+fpzBEqEXypJlOe+rMYtFSJFZwxj9Wzg O1qvXLG76YrJ/rxm3xuR2mauJQiWqDhvDrgqJG0BQK4mm9/Oviwj9UgvMRmLy5q1X921PWlcjoE umcrtYABVjY29WK7FcQh8WzkVeKyJ+MmRlN9Nh+Ub8kcJigGZQCCYmg7oMGC8T3UDVjel1iwhyA iD8bQznW0mQ8y4kKXMEKyJFeJ9aMzEZiBhAwWq7raGgPiU7CAIQhP9o4GBEmg= X-Received: by 2002:a17:903:2342:b0:2c2:bd0d:3cf0 with SMTP id d9443c01a7336-2c2f3c0376emr15193595ad.25.1781159309968; Wed, 10 Jun 2026 23:28:29 -0700 (PDT) Received: from csl-conti-dell7858.ntu.edu.sg ([155.69.195.57]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2c164f6d2bbsm282891565ad.1.2026.06.10.23.28.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Jun 2026 23:28:29 -0700 (PDT) From: Maoyi Xie To: "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: David Ahern , Kuniyuki Iwashima , Xiao Liang , Steffen Klassert , Herbert Xu , Simon Horman , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: [PATCH net v5 3/7] net: ip_vti: require CAP_NET_ADMIN in the device netns for changelink Date: Thu, 11 Jun 2026 14:28:10 +0800 Message-Id: <20260611062814.2528793-4-maoyixie.tju@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260611062814.2528793-1-maoyixie.tju@gmail.com> References: <20260611062814.2528793-1-maoyixie.tju@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit vti_changelink() operates on at most two netns, dev_net(dev) and the tunnel link netns t->net. They differ once the device is created in or moved to a netns other than the one the request runs in. The rtnl changelink path checks CAP_NET_ADMIN only against dev_net(dev), so a caller privileged there but not in t->net can rewrite a tunnel that lives in t->net. Gate vti_changelink() on rtnl_dev_link_net_capable() at its top, before any attribute is parsed. Reported-by: Xiao Liang Closes: https://lore.kernel.org/netdev/CABAhCOSzP1vaThGV35_VnsRCb=87_CPjPVsTHbq905k8A+BuUg@mail.gmail.com/ Fixes: d0f418516022 ("net, ip_tunnel: fix namespaces move") Cc: stable@vger.kernel.org Signed-off-by: Maoyi Xie --- net/ipv4/ip_vti.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/net/ipv4/ip_vti.c b/net/ipv4/ip_vti.c index 95b6bb78fcd2..3b80929994a0 100644 --- a/net/ipv4/ip_vti.c +++ b/net/ipv4/ip_vti.c @@ -596,6 +596,9 @@ static int vti_changelink(struct net_device *dev, struct nlattr *tb[], struct ip_tunnel_parm_kern p; __u32 fwmark = t->fwmark; + if (!rtnl_dev_link_net_capable(dev, t->net)) + return -EPERM; + vti_netlink_parms(data, &p, &fwmark); return ip_tunnel_changelink(dev, tb, &p, fwmark); } -- 2.34.1