From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f43.google.com (mail-pj1-f43.google.com [209.85.216.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9D369361675 for ; Thu, 11 Jun 2026 06:28:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781159318; cv=none; b=LvEVN2qfUtzVwWgH/aiPRrzgL2BFRsp2mXtF8n8ZK+8CpjCV4nLK90kbOCO0HnMvHm31V6vDHTHR7X8zMl+u+cqG6kXuC9pdDdgJcEbA0mLkb/RORXQD6pmSxImkxu7Rs1r7BXj44eTDCmLRTywTTtj3QhxUDyI/pidqiI5qNHk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781159318; c=relaxed/simple; bh=P3DEwMDSz7QrnY6Nl3zghY4LlUKgR9E6EOx71pAzN7s=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=qAXSDm/+zAB9o37JDRmvxPJYUPVh63REmOCkX1OMAdwBtuffmBfilmuZJyr1Qh/PN+LtqZU7CcVyjQMLH0XEvYZ4K8GYUm0icw3gCd59rihNNTAjqePhCp/rncSvVyb+JSMk8uEJk3cDym8up/BvEHK7skU7hfUr2I2EeB87uyQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=cxAjv7Nr; arc=none smtp.client-ip=209.85.216.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="cxAjv7Nr" Received: by mail-pj1-f43.google.com with SMTP id 98e67ed59e1d1-36b8e1760ccso4814509a91.0 for ; Wed, 10 Jun 2026 23:28:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781159317; x=1781764117; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ql1o+3bWl8+fth8gszVm+RpfzjR1vuCSvpffdbii/uk=; b=cxAjv7Nr/E6arf+wm1ermgrqZx26ssFX5tZvwulkODhW/OPkNeQIem+Amq/I7X2Dmx +wqHHT0R288aAKRoUIEBqF9Nc0l3VczCuIMvc5vZMlXinwj4msp+YeHrrwfRDZ/lJgn5 dutNiotCD05zCM4V4CWp645k893TFKTosoTQayMThTO8cN9WJDT9TPXxFv4k1KUqpvom 2qyFRyUk8ih5iIiUEDoIHn8yS7pWAlqzpOT1RguHDObZf1iApV4yjvxPKpknPEaL6LDL nVOrXUiauaKTztJmoRTmbKuYIeZ1tf1MTQn7Puw2/N4j4cVTrd/aA7GHpg3W0OPPNbIo XUOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781159317; x=1781764117; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=ql1o+3bWl8+fth8gszVm+RpfzjR1vuCSvpffdbii/uk=; b=oJ1mZz7EodgIZFOV9ZlFzeeif3SiSl/zGXPJpS7wVDWBRF/yX9XvDrYZqp0OIT7cpM TtJkX6+L2UPno1GzqJ2u+m1oKg5FXNZ/KrxFaNBN/rrZ7SQG8TEH0YAl/1hizEP6oAF2 0db0JM8zX8+/m87lTYyKs7GQ7BSnFmFi/j9ZxWz2DvHVu287RqN371NG9oCXCvcjxx02 NJNX70wzek6NCti1PCSs+ve0b5mSFJp8v1SS8oP3zSuDd8GANqCM5m1u/Zsqfh9k5et3 bpd7CJ8q6uqS2ju8il7uPN8IT1VTDE6++5p57D2OR0Pkw6dBRCeJzzQ1rxhJ5mMN0ApF O81g== X-Forwarded-Encrypted: i=1; AFNElJ8WrO876Ds2e8f/4a5Ze8g4mNZPxwrqcUmnyikqmcvgWBnmpnM/1jXMFKe6HJ/QNvYRE2kWzHRAEu1nu4g=@vger.kernel.org X-Gm-Message-State: AOJu0YwTFtJiLLX4oW1bsJ+HXQrbX8j9SoA9vXnvRyYE7hV103Z8rRCo 6SoVk9TMA0sFIopfRFfsefNiQCZfRU8goZ41DXQ4+ziDMRO8TNFv6qbp X-Gm-Gg: Acq92OEWkXxDnxT0sNGaGGM+Li4/VZ7tSH6mvL/IF8yNzX3BWidV3Q0hjGJ/k222k33 wTKTNV0aN02puPw7dGJF+NcfTMTQqJ9ZDZADlUIrOmlLheJSRlcUmB6guidzoYDybsCsvWk8VYL w1WbBQfQa+6wSJhFErqAppv6hkTUR+f7eGRIAaNq1MjmqTHFACS/1CpZC3h7572Bxt4vd5+vrD1 AABVj2OgVYWDRS74Q08cJXL1Av5aPXcf6Udoz4SJ6aKbju6x89o/2tbwraRE/DD2r/ofHylXHzQ w+bHWsC1b0HsOkE3bDnp9cnrREDXpqC+ACcTqpy7INVlN2fMc9hdRmPH0sFPZA2Fkh6+HbTpz1F 0+2px6jzLC4QpKkfchyvLE9rWtmbs/6gdGgLX/Cr8os9BtjDdCXQEcEQ982n+C9EkfUW/0UmkHj vmQRqnWUNDSdpRHXKLWdLM3D0UQEezWE5w9QVQ7ieDIYpAscsJYeiT6PR0fRc= X-Received: by 2002:a17:903:2385:b0:2c1:d49c:8398 with SMTP id d9443c01a7336-2c2f005eb1bmr18921125ad.8.1781159316899; Wed, 10 Jun 2026 23:28:36 -0700 (PDT) Received: from csl-conti-dell7858.ntu.edu.sg ([155.69.195.57]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2c164f6d2bbsm282891565ad.1.2026.06.10.23.28.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Jun 2026 23:28:36 -0700 (PDT) From: Maoyi Xie To: "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: David Ahern , Kuniyuki Iwashima , Xiao Liang , Steffen Klassert , Herbert Xu , Simon Horman , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: [PATCH net v5 5/7] net: ip6_gre: require CAP_NET_ADMIN in the device netns for changelink Date: Thu, 11 Jun 2026 14:28:12 +0800 Message-Id: <20260611062814.2528793-6-maoyixie.tju@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260611062814.2528793-1-maoyixie.tju@gmail.com> References: <20260611062814.2528793-1-maoyixie.tju@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ip6gre_changelink() and ip6erspan_changelink() operate on at most two netns, dev_net(dev) and the tunnel link netns t->net. They differ once the device is created in or moved to a netns other than the one the request runs in. The rtnl changelink path checks CAP_NET_ADMIN only against dev_net(dev), so a caller privileged there but not in t->net can rewrite a tunnel that lives in t->net. Gate both ops on rtnl_dev_link_net_capable() at their top, before any attribute is parsed. Reported-by: Xiao Liang Closes: https://lore.kernel.org/netdev/CABAhCOSzP1vaThGV35_VnsRCb=87_CPjPVsTHbq905k8A+BuUg@mail.gmail.com/ Fixes: 690afc165bb3 ("net: ip6_gre: fix moving ip6gre between namespaces") Cc: stable@vger.kernel.org Signed-off-by: Maoyi Xie --- net/ipv6/ip6_gre.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/net/ipv6/ip6_gre.c b/net/ipv6/ip6_gre.c index 365b4059eb20..8ebc99a299c9 100644 --- a/net/ipv6/ip6_gre.c +++ b/net/ipv6/ip6_gre.c @@ -2047,6 +2047,9 @@ static int ip6gre_changelink(struct net_device *dev, struct nlattr *tb[], struct ip6gre_net *ign = net_generic(t->net, ip6gre_net_id); struct __ip6_tnl_parm p; + if (!rtnl_dev_link_net_capable(dev, t->net)) + return -EPERM; + t = ip6gre_changelink_common(dev, tb, data, &p, extack); if (IS_ERR(t)) return PTR_ERR(t); @@ -2266,6 +2269,9 @@ static int ip6erspan_changelink(struct net_device *dev, struct nlattr *tb[], struct __ip6_tnl_parm p; struct ip6gre_net *ign; + if (!rtnl_dev_link_net_capable(dev, t->net)) + return -EPERM; + ign = net_generic(t->net, ip6gre_net_id); t = ip6gre_changelink_common(dev, tb, data, &p, extack); if (IS_ERR(t)) -- 2.34.1