From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DB92135E1B6 for ; Thu, 11 Jun 2026 06:28:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781159321; cv=none; b=QHnhogKpwo3RhE8Y01NMg+S2QrhQd0aZeARyB7v9vu9eOCl8MNGQymMhFdx0syTP8+oGHbBVcXWgoiSs3RKXbcp5swDKUYUihDTh0DjrVsGgeljXWYPlL9d/my7xx3qMh9wWQTL+62CJ32vkvNnM11hZV2xq0EvKBgKdncYyw3s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781159321; c=relaxed/simple; bh=4Nvj/htZQGso53Mmm0lreiAmj6V5PmDqdYSnHL4fZ+Y=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=oan6LWGlgwXTLyXx6jmouW2Ed2Harl9N33VtYsx2mgQ4ewYWOrIb8CKq3QI9/Xb5JuPfQPvLsa3v3PPadmwqJQdTGfIkoC/eWpFEERhfSKK2cxjPMnI++o9NritZ84D1KNVbM+hLDurtEN9Ty1Oq3O32mXER51Wm0khxQOU99jg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=BO89fSLQ; arc=none smtp.client-ip=209.85.214.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="BO89fSLQ" Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-2c0c20f0c0aso58808145ad.0 for ; Wed, 10 Jun 2026 23:28:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781159320; x=1781764120; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=bDIz/z+wpE+gNeERCet5gmogC5x6oFr8X90Oro0lyGw=; b=BO89fSLQWumSP51LRMfKqi0fXZ4A56qNlQJ8NDbbketYaBNUiI030qjZSjlVRoABx8 DjqPqIUueH+L9S9XhM0B09TECMlDOoDaKfry/uZtSjz3irYvILuVMa2qRtcUqqR5/mix XHhnqab7fGSVJTU34ajJMnAEpWTFJC4ybiKCP9CH7TlTBlwvzMCkXQvqzV5qG6Cstajy zR9lsO5ewO6Fnqr1VftpayuI35DewcN+nPPuXP2T4C25vM3YayuziYviNEQ4Wc2bnC9B ymO/HCVO8EDCdPcfkqJW4YE/q0IO3+UcpAsV+DhuY7AfWMqndLAw0JXGN5sT2n7ZKIiM okng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781159320; x=1781764120; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=bDIz/z+wpE+gNeERCet5gmogC5x6oFr8X90Oro0lyGw=; b=o//8blwg8pmFTK5N+QuXshY7DHJzQDn3sMMsQhyYDGr8t8DDMKBIhsffKkrczVh4nv 8WrydUea741Jxyqzv8pVhe8ivSBzLH9Pp1JBRRMg7pDw4ggo12TKsSHmnISKnWy4SMYp aKjuzWnsIw7ebj4AtZTanYPV6Nd6VBR60WdTXbwOkUtwulsI8qJzawX2fovZKURx4xTK Qr6OzFMggaVVq/0QeOiorT+lhdV2kiT3aCy0YGBpqxXGkdlCPItm7z2Udk3UAloDAGms w7BwsGOvBzxPyHEXZZUCwuFeCGSNF/QQmyoaHRwPNiv3hNwxJzrkHh53d+rIvwK6APD3 HLjg== X-Forwarded-Encrypted: i=1; AFNElJ9QW+gBt2rKwYKxaH8QgbNKWGx4aUs5evRSSCi4HFsT3INtM0atcFNQtLSpTKZHSbZMFKdcbn8CEPSgSmg=@vger.kernel.org X-Gm-Message-State: AOJu0YygwZmBIDj52g0FRt0lgAVMrjlBIfRNvlB35TV6Hg/9zDZiyJni VAmHXiXwFQj1/sRN3cyG6yYHZRcPFma489kVKs+c282p2lKKF74MvNFX X-Gm-Gg: Acq92OEIVDfLxY/a6Ol4HvMRI1FednKQSTx8uoT42f/md5B9ugs28Py86KWaQDgHB6h SBluFv7xMVKPa8dsTk8oCjRAvuovyDLmUW3hEKs3Awe73+h/CRjY2zcjkWOtgM/oRSDcz65+BHm AkvrOL4miD3Jfzq7aHHwed3njziYSFR/i3RFQKtMGL9rFcmS9kTg1XkpXotg8od2IZDIT/Jq+FA 7PN4MQwd9QhZaugW/0+ASWKJDKgVHkYFhtRhSdROGsHdtdBrxnjrxtuRmN3UOJaeGrASCI5kLBh ZLniRwWyTpd9IUF2wbQ68grMY18s9E6KnVZdD7xp5+Ghv3MarzOqJeaddNYcm8zWMXxKdG1byGu Fsoxbev1vpeG8TxzhphMELmZuPJrXB1t4hGx7C/aDPLQt9vrrttBkVqrdBwUDJJsZ/Oh055pdlf nTY2fGt5bj07JJvuA9VNfAzkhp3C8yFwDiMBSIRStiPJDLFak4FSMfhJBxP04= X-Received: by 2002:a17:903:2f04:b0:2bf:23ad:8595 with SMTP id d9443c01a7336-2c2f18e2911mr17791965ad.4.1781159320304; Wed, 10 Jun 2026 23:28:40 -0700 (PDT) Received: from csl-conti-dell7858.ntu.edu.sg ([155.69.195.57]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2c164f6d2bbsm282891565ad.1.2026.06.10.23.28.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Jun 2026 23:28:39 -0700 (PDT) From: Maoyi Xie To: "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: David Ahern , Kuniyuki Iwashima , Xiao Liang , Steffen Klassert , Herbert Xu , Simon Horman , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: [PATCH net v5 6/7] net: ip6_vti: require CAP_NET_ADMIN in the device netns for changelink Date: Thu, 11 Jun 2026 14:28:13 +0800 Message-Id: <20260611062814.2528793-7-maoyixie.tju@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260611062814.2528793-1-maoyixie.tju@gmail.com> References: <20260611062814.2528793-1-maoyixie.tju@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit vti6_changelink() operates on at most two netns, dev_net(dev) and the tunnel link netns t->net. They differ once the device is created in or moved to a netns other than the one the request runs in. The rtnl changelink path checks CAP_NET_ADMIN only against dev_net(dev), so a caller privileged there but not in t->net can rewrite a tunnel that lives in t->net. Gate vti6_changelink() on rtnl_dev_link_net_capable() at its top, before any attribute is parsed. Reported-by: Xiao Liang Closes: https://lore.kernel.org/netdev/CABAhCOSzP1vaThGV35_VnsRCb=87_CPjPVsTHbq905k8A+BuUg@mail.gmail.com/ Fixes: 11b326fb0a37 ("ip6: vti: Use ip6_tnl.net in vti6_changelink().") Cc: stable@vger.kernel.org Signed-off-by: Maoyi Xie --- net/ipv6/ip6_vti.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/net/ipv6/ip6_vti.c b/net/ipv6/ip6_vti.c index d871cab6938d..ab94b3a4ba9c 100644 --- a/net/ipv6/ip6_vti.c +++ b/net/ipv6/ip6_vti.c @@ -1046,6 +1046,9 @@ static int vti6_changelink(struct net_device *dev, struct nlattr *tb[], struct __ip6_tnl_parm p; struct vti6_net *ip6n; + if (!rtnl_dev_link_net_capable(dev, net)) + return -EPERM; + ip6n = net_generic(net, vti6_net_id); if (dev == ip6n->fb_tnl_dev) return -EINVAL; -- 2.34.1