From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7F0CA361DD5 for ; Thu, 11 Jun 2026 06:28:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781159325; cv=none; b=lhnN9cvsbykZ/ebA/kYmbOpROvADtu15GiE/K8ltjeZoDFWuTDQvPGdZnZQYg+I6UcPpazbeX3zPD4zdravsVoOMueEd+i/0i+VJ2dHrHSyT0vOCWONDyB4a7o5T3+9Qj+KiGC2d8khZsOIMI8a2Qg99NFHpXEfLusvqW0tZC7w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781159325; c=relaxed/simple; bh=OoelfBjirpw9i5/nYFRVXtU1s8vRlWtNC7c2OJ/Xcy4=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=qt5yQqDZoslLyDkBy1kJtLBlZKiyYjCycwKaKxuquhbfNG/mT1ht13QM083kGsM+S9/KagCVG6dpfh6A2hO4EWVe7yV5f0HiX57Q7Zt5qyAjS+M0PnCTe8+8jNA7ixkYP8CO5wYqZTKoc/8oQjPu2Y57fSxWdWenyrmD0wgLPvI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=m83IAv2U; arc=none smtp.client-ip=209.85.214.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="m83IAv2U" Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-2c0c20f0c0aso58808595ad.0 for ; Wed, 10 Jun 2026 23:28:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781159324; x=1781764124; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=RcjSCvdX7V7R5w3yb2h9bVTz3y2HJ7/ux+fWYyG6vVk=; b=m83IAv2Uy1PwbWpelTHT8+XCon/4hW2aB4XZJdCuoz2oYouMJME8fXgiaZqF5oWR0E IMe13KD9+PJU2juy49NiQx+YuedNAht5KQZineLefRA9Lageaa87d7WDXlZsJSxfVG3v V7xckKdkAWnyU0bh2gm4sBP6p4IXNX9X8xUkONp3NPwsZ7d58pqEljZ2hQOvFhgk7wif 9gPznjd3N/Ccuwk+BCSCnRj4Tv7bqUn+9ZfAEftBBh1Z/9fzZGeUo1VR/4IXuuOW5uW3 vEFaP3Dm6NtqQb66tGrO8yAdCaZohnsSwuMrw5ujlkWP4+YFkwfd959e3JehG7zlv3B1 cb7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781159324; x=1781764124; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=RcjSCvdX7V7R5w3yb2h9bVTz3y2HJ7/ux+fWYyG6vVk=; b=kAb8dA6t0BQm1vUVRdULk/7rS7vYr6tNCodLAs8vd095ZJRMi+wJFbxezaOfQGdDSU PcbCoyZor9ERxw+X3aYK6nhiyd/1Q11cE8Xw4T7UKZ2QeeFsb1RC7Eopf8t+nvN6nBqT HNFmIZTHT72vI/UmWc5vQEILXz6K91aoJP2soLx8mEy5r+bcoa4rovDgu5hkhi3n9RIX mFT0UZiTvHTapU+NxkTJXRWQZ2dKsqrIKaYW+UuuQbJvfp6GD2ffDLOtkvxzzYqrsjtJ /QXV+SHrMRQRCpi9GWwIYmPA0wAk3ka4PjxGWtE7BScexeP7YZnPnpIgobYxgTiCkGse VP0g== X-Forwarded-Encrypted: i=1; AFNElJ8sxMmTD0Ye1mrOWrTg9CTNkqDo1/iO1L+VIVbOPpDcKNmvVM/wckorU73hg7xAadfIiCWsPGzXRUB4XRE=@vger.kernel.org X-Gm-Message-State: AOJu0YwpRa1Eabl3W0oZqKAtbQVbkM9XgwBsyh27o5QkPyh8aLa0fEh7 MvQMmv3IES4pD0qk+31a22NPlrzDZm5Rj8CbVO1SrgeaLtsppkCPgkrx X-Gm-Gg: Acq92OFoaUZvLGZXo1++DXu8QLvEpZ4kS7sdjqe9IWYlXDB0bzUIT8V7UofrjaVUPm4 b/kD02Qjr6P/lYowG1gduyFeZKExlCHEDzA9myhWWnyPdVZVgf0jIRiiRuY6gvzJnRf+LOO0yun rQMfO3Xi7POKwlHtruHDqLHpGkOWDkKfaT+a80XRVUaoAzR8+S3YmAz9SdJ8daRbju+aMKcDspl XQItWPospZpXxSoMSEpQfUMyd7BPhUuyD2u9YpkBwnV0chD+jKim4rqUFJnHZJuFT7jDGZZxeq6 WiZL4VjHNDVPgJNLbYwb4NbawbwX/CybKGDj1B+fLncMToMq02Npn0ISac+NB6qkzoJrOqVqdYZ nv7f6Y3px4mR/1tCt2oHV0p1ztlEiGsrPYttA0PpMiTPVFF6q5X9qdbSh44a9lPYGnrcIwH9FYY YXjIF37xOmiK89k20s0j8Ve5NMh2zBEtZblBiVEcda84+yNTbtKq27zsadxtA= X-Received: by 2002:a17:903:3586:b0:2c0:c3ac:4af3 with SMTP id d9443c01a7336-2c2f229d856mr17512785ad.15.1781159323849; Wed, 10 Jun 2026 23:28:43 -0700 (PDT) Received: from csl-conti-dell7858.ntu.edu.sg ([155.69.195.57]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2c164f6d2bbsm282891565ad.1.2026.06.10.23.28.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Jun 2026 23:28:43 -0700 (PDT) From: Maoyi Xie To: "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: David Ahern , Kuniyuki Iwashima , Xiao Liang , Steffen Klassert , Herbert Xu , Simon Horman , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: [PATCH net v5 7/7] xfrm: xfrm_interface: require CAP_NET_ADMIN in the device netns for changelink Date: Thu, 11 Jun 2026 14:28:14 +0800 Message-Id: <20260611062814.2528793-8-maoyixie.tju@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260611062814.2528793-1-maoyixie.tju@gmail.com> References: <20260611062814.2528793-1-maoyixie.tju@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit xfrmi_changelink() operates on at most two netns, dev_net(dev) and the interface link netns xi->net. They differ once the device is created in or moved to a netns other than the one the request runs in. The rtnl changelink path checks CAP_NET_ADMIN only against dev_net(dev), so a caller privileged there but not in xi->net can rewrite an interface that lives in xi->net. Gate xfrmi_changelink() on rtnl_dev_link_net_capable() at its top, before any attribute is parsed. Reported-by: Xiao Liang Closes: https://lore.kernel.org/netdev/CABAhCOSzP1vaThGV35_VnsRCb=87_CPjPVsTHbq905k8A+BuUg@mail.gmail.com/ Fixes: f203b76d7809 ("xfrm: Add virtual xfrm interfaces") Cc: stable@vger.kernel.org Signed-off-by: Maoyi Xie --- net/xfrm/xfrm_interface_core.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/net/xfrm/xfrm_interface_core.c b/net/xfrm/xfrm_interface_core.c index 330a05286a56..688306bf62c5 100644 --- a/net/xfrm/xfrm_interface_core.c +++ b/net/xfrm/xfrm_interface_core.c @@ -869,6 +869,9 @@ static int xfrmi_changelink(struct net_device *dev, struct nlattr *tb[], struct net *net = xi->net; struct xfrm_if_parms p = {}; + if (!rtnl_dev_link_net_capable(dev, net)) + return -EPERM; + xfrmi_netlink_parms(data, &p); if (!p.if_id) { NL_SET_ERR_MSG(extack, "if_id must be non zero"); -- 2.34.1