From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C472F3C5526 for ; Thu, 11 Jun 2026 09:48:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781171322; cv=none; b=Xk+BiIug1nOYggEBnDienjXbmA/WY6F21pXXu1I5k0hAqlWGWmOMuzh15JV9xTa5kX2R6gQxyYmbnwf0RUoXnGWPkIJx+t4jl800UgferD2fR6bFacB8GzcgLwrVI4h4Die2vClGshytQ6lwjSRSCrXKGxLPFHW6q86DFFjvPHA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781171322; c=relaxed/simple; bh=m/eXo++qysxw7lybczOtxAQVK9dhV3toSMRwZYW/4jM=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=WQ/HxRcOJt69WAKI8qZIsXf7yz2fv5dPYmWAHgxki2JZ4NgxathyIU5BRMTjARPezzBgfRAhPsKCZZpaZJ2ZuecuY41lQ150TPUGyZTpa+ar6DzSO0L72sT8S7cO2zXv1BiHBKx9EVP5whewVtD9WD1QMCpKdUAuud68NJ6JLc8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=I+uZzwNQ; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="I+uZzwNQ" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-490b64c8311so84813225e9.3 for ; Thu, 11 Jun 2026 02:48:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781171319; x=1781776119; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=0PnrMx3F3Mo06rwgwVZw+wlkBVdU2ASIomiMmAPzODI=; b=I+uZzwNQ+AZRKaacuqz6/gsH8qoFMqjbkbzC2XffDzyayJd/uO4Gr0yMWh9m8iE4R3 ltvNI+r+DhKVuwCtjqT7O0BcdelTYOkxPHjnNC5aKSE0T5ecTzxcez78kf6Pta9MR7b4 NoRdgkJElCB29PqEg7CXIGuOeB9qCztrUUL2lW5URaATkS5/MF0QGYTXrD2CrlOViibC mKWDFdUBERznrZcPo/PAhGlVtHHDUsICe7Azy+c7RZJ5yQaH4Rt7c0qOkjaLRFDCcdhx XifpwF5QRMTLRAeh0nnl+rYuTSiUVlS+FiDpLvSIs4IsCe2bMvAqPLeaOoUujYIhvVIH fnuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781171319; x=1781776119; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=0PnrMx3F3Mo06rwgwVZw+wlkBVdU2ASIomiMmAPzODI=; b=oZTsAf42TxB15FZjgUIzHx7p3gX3ugZfLBNUCgaxwbUilAg61xs0mOA1mi8ExCW2+4 wf0AAMSWBr5iz1PtFjQnV+Leww9O6GFlWnwe2XNeydrx6D76OhLVUwr+qssKLn1y4SBp izz5jBhd8WP2vgknFJOisfvZjWtJZe857rs5tYqPG2dNqNi5geHLN+jKJz0y4j+8KKdj xuGeyT289mRBGG8LoBpYPfSOyTONNA/WjmmfyVGFNxYeGhXNpj1LOZ3W9wGDGT+pccLy +byo3o5yDYzmjMXDj2ibGucZVMqoYlt/1Ilt2Xl2jvNyhxcmx0plnWEwlaI30SeTDiP/ hECQ== X-Forwarded-Encrypted: i=1; AFNElJ+fVe1F7geV1uU7wbyD/9TEmKvA3/T8PXzYncQDFmhWNBtpWjDzKi77gUvQbGDx5KxUufFaS3rbDxuInk0=@vger.kernel.org X-Gm-Message-State: AOJu0YydMa/7CfJDUsUc0fhQ7u+41Ccf0IQJ9DwYTF63+Zw0Xt6GL9lc S/oKwsJ5DQL5DlhAZIrKCxOT7A/IUEcwtWgf79LGhY0d7ysdMmghl0MN X-Gm-Gg: Acq92OFiemUllZgC9A9xU5wk6lJLQBpP0wnAaEQdME1aQqL9SeIMYKKjZwYXX7uhrNi nP86g+FYwxaWtu0cAeFAUwCJx3SbSU47KGGuyR98R73nC8etxcLPnQH57qcMvlb6EYH4GjiR6G+ 6Z4jxsvsFcc34h3or8CJfdMVY6wdQmcSRg8r2J50FhLzeGDRT3eY/+lGTF4bGlwLfeTAl6q/5ec 7fHs4dB96I+OLRwoGwPZ0hkI+C7BcnHUesZxLt+ILq93vie8HQc/uxw3/vPLMvSQkNn0Neber5D uxFBCCIdR+WFZwMJK1920TfAf5DuDnBwBJVwRwYFnwaOE4nRTpVLpfWu6ic1UlK8JbKqcZq1Kzd SkTvL7Vvr9iP5dvKfB6c60wUW4lJsACxmX3RNZbecTRs8CvzGrap2lhXeLCht+6TbplptzPP0I6 mvO0YJyVrPxE4pPZh7Yds3rF4vtGowtDLgJwpkLbSyPW+KY5Tjb2b7+r/B5HePru2S+QV4M9k= X-Received: by 2002:a05:600c:3b19:b0:490:e5c1:b8c6 with SMTP id 5b1f17b1804b1-490e5d0fffbmr23778935e9.8.1781171318970; Thu, 11 Jun 2026 02:48:38 -0700 (PDT) Received: from pumpkin (82-69-66-36.dsl.in-addr.zen.co.uk. [82.69.66.36]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-490e4228768sm38905995e9.0.2026.06.11.02.48.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Jun 2026 02:48:38 -0700 (PDT) Date: Thu, 11 Jun 2026 10:48:36 +0100 From: David Laight To: Xiang Mei Cc: mst@redhat.com, jasowang@redhat.com, xuanzhuo@linux.alibaba.com, eperezma@redhat.com, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org, virtualization@lists.linux.dev, linux-kernel@vger.kernel.org, minhquangbui99@gmail.com, bestswngs@gmail.com Subject: Re: [PATCH net] virtio-net: fix len check in receive_big() Message-ID: <20260611104836.469610b0@pumpkin> In-Reply-To: <20260610221606.1091465-1-xmei5@asu.edu> References: <20260610221606.1091465-1-xmei5@asu.edu> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; arm-unknown-linux-gnueabihf) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 10 Jun 2026 15:16:06 -0700 Xiang Mei wrote: > receive_big() bounds the device-announced length by > (big_packets_num_skbfrags + 1) * PAGE_SIZE. That is still too loose: > add_recvbuf_big() sets sg[1] to start at offset > sizeof(struct padded_vnet_hdr) into the first page, so the chain > actually carries hdr_len + (PAGE_SIZE - sizeof(padded_vnet_hdr)) + > big_packets_num_skbfrags * PAGE_SIZE bytes -- 20 bytes less than the > check allows for the common hdr_len == 12 case. > > A malicious virtio backend can announce a len in that gap. page_to_skb() > then walks one frag past the page chain, storing a NULL page->private > into skb_shinfo()->frags[MAX_SKB_FRAGS], which is both an out-of-bounds > write past the static frag array and a NULL frag handed up the rx path. > > Bound len by the size add_recvbuf_big() actually advertised. > > Fixes: 0c716703965f ("virtio-net: fix received length check in big packets") > Reported-by: Weiming Shi > Signed-off-by: Xiang Mei > --- > drivers/net/virtio_net.c | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c > index f4adcfee7a80..afe73eda1491 100644 > --- a/drivers/net/virtio_net.c > +++ b/drivers/net/virtio_net.c > @@ -1999,15 +1999,17 @@ static struct sk_buff *receive_big(struct net_device *dev, > struct virtnet_rq_stats *stats) > { > struct page *page = buf; > + unsigned long max_len; > struct sk_buff *skb; > > /* Make sure that len does not exceed the size allocated in > * add_recvbuf_big. > */ > - if (unlikely(len > (vi->big_packets_num_skbfrags + 1) * PAGE_SIZE)) { > + max_len = vi->hdr_len + (PAGE_SIZE - sizeof(struct padded_vnet_hdr)) + > + vi->big_packets_num_skbfrags * PAGE_SIZE; That looks like a constant (for the vi). Probably worth saving rather than recalculating all the time. -- David > + if (unlikely(len > max_len)) { > pr_debug("%s: rx error: len %u exceeds allocated size %lu\n", > - dev->name, len, > - (vi->big_packets_num_skbfrags + 1) * PAGE_SIZE); > + dev->name, len, max_len); > goto err; > } >