From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DC797376BE8 for ; Thu, 11 Jun 2026 10:03:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781172231; cv=none; b=RtaRoyleI6GgUcoWMQNk7YOn2xe+duTvBhW1JfAWzM9Pzh+IVsm2OXxF0YivB5y3db93+aO5/8x4JZ0mbalCuVhrlNMQHF0ysaqwXhZGZ/AEvVnB9csf407ZHBhNLaMTmkn3wHojwjaYSyvx+ZVLkNWEv90cIwiF6ol013cbvEo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781172231; c=relaxed/simple; bh=VAs/GCibCyDaqi3nHsOx9BPF6bvlc6LG8MqXmBo4L8c=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=OfhuIe598rFvr5VquvUx7pZwDEXd+z6me2KHH6fjOPqdKekRAHyaMl+a8X7tgaMNE+SGV0f3ZjAKZfr11AW3Q845wk+3ioKzQ3l2UlfKwLl+l1fPLJ5x5+exfNnR+7JnU2Mmk4Uim+LBWjUkYWTjxAe5PadYnJanoOA0pR950m0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=jmIUlsNw; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jmIUlsNw" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-490b3e03939so6048405e9.1 for ; Thu, 11 Jun 2026 03:03:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781172228; x=1781777028; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=D9STgvUk3oRIx7XFabbesfUNmdUEn9qMIeHh38tKNZA=; b=jmIUlsNwEBgeP0Vi/6rGxj0bcXZz/jWs71fhVwXQSn0metqm+67YrLCvvJz+UuXEE9 AXpZsW/NuehlNqV5Zm4/7ZwaGauaB7eEQfXUEkg34Zp4xrW2T9RBILR6Tr1eF0UENVYk mYrECY2nDOd6L6G+JUbE9DZZJahw/QOuZFrXKCZRyupVTX8rJoeatNa6N9HmjPGJRcas JvJ9DdBCiCvGc5P1MQUlKq6J5hGFBh7Zum1tsDQqwqXY5cB0ALI4nWGB0NDBeZryKpem i0TBE0+Ens1J1ZOFkrmMKt33Z7QfOpXaG6mmNQc+GiREkEZm3tIIE+inEHcuZYgZlrse R7Bw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781172228; x=1781777028; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=D9STgvUk3oRIx7XFabbesfUNmdUEn9qMIeHh38tKNZA=; b=FQcWBzmzHIesxDK0i3yDa7yz5NGvIU2C+eZVd7JVmJm9du8YEi0FzgOHwWjI8nLGnu teeu5EgXbWZfvfqRr1ZNKO4mek0SgsGqA+MvbvsJEvwvR59BKL0F73qOzeZjtt2iEgsT 46b9ui765PnphAPdhUZdUo7AcgxYETFNOV/nNROmP6wfcf4pUvk2tm7EqB1bP9Z4xN03 5Bhg9Ach6ilsLNVhebLs156na8HQtcN5bQjmL4zOLtn9BE28FIKHu+RzJUJ2+LJRFLhl wv6wrUHSrgb2Ds5NDdSUr5fPwRJW4hX+nom1zkMBOxikMjYI+iEYOsP9LrcS54xx4Sk9 AZ0A== X-Forwarded-Encrypted: i=1; AFNElJ8c7njzQ9H4FJB30L+uOnTXy2FYGHwbNwQ8RTZ7vF7roUNEGdOhPZKmAOOEhTaFH39c/8OY//bd63Jr8E8=@vger.kernel.org X-Gm-Message-State: AOJu0YyrAH0buNvjXutUNRhlrs5abev71GBAZup2t+dyZNFe/vTLksME v5m99gsim9eZWM22/darjF3OH3iQRhiWiY0zFJCoBv6xGSaQSouf6fw/ X-Gm-Gg: Acq92OE7wp3IkyOBN/n4QyDmz1DobYdvhlzXFvNvWWeGkuMNn1ls9GlHU7eLjM12pRv iN4tOSOzCH1CX8AzfcMhVvlwHT7/q5uBX6N27OW7bf3+9gUFDV19Y1Cc3D75gx3h8cyfLJJE6H+ nzn85pi7fvsWw26mgZB8uDNUwK7ZFoRlrE9uVKNYmBMBAir4OQvVKtj+6ozAiZH+RSGoyc2v3Gm NbebIleX7G1PEuY10z6Bdl7nep/QIbAhVyu/Ary4VoJ1opGt29y0pcWgtVaJHLamO9YGVEYtHMF Xrvk6ETCh/8gutp27nj3JGMmsskIJAZtXjZYzpm4wFVCBMGN1eHN19OVe7mYAHeY3pZ9S83bVBJ SNhz2a6QfxAe/GyTlbVWPt5wofEe7vCjDdtASa4IZBj4R8uXv/Zx/bUqr9l9dCrkzQgwT1y7hIN RYWRtTcJQH6hPHTVXltVbyE9JjUtZU74rkn4Ye75p8+UlBCOR90Kk56XeFzJn0fpgEhhS1vCQ= X-Received: by 2002:a05:600c:4f47:b0:490:b26c:64ad with SMTP id 5b1f17b1804b1-490e52d5bfdmr22105515e9.5.1781172228070; Thu, 11 Jun 2026 03:03:48 -0700 (PDT) Received: from pumpkin (82-69-66-36.dsl.in-addr.zen.co.uk. [82.69.66.36]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-490e47a9284sm32769395e9.1.2026.06.11.03.03.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Jun 2026 03:03:47 -0700 (PDT) Date: Thu, 11 Jun 2026 11:03:46 +0100 From: David Laight To: Nathan Chancellor Cc: "Michael S. Tsirkin" , Jason Wang , Xuan Zhuo , Eugenio =?UTF-8?B?UMOpcmV6?= , virtualization@lists.linux.dev, linux-kernel@vger.kernel.org, llvm@lists.linux.dev Subject: Re: [PATCH] vduse: Fix error around jumping over a __cleanup() variable Message-ID: <20260611110346.2b9388a1@pumpkin> In-Reply-To: <20260610-vduse_vq_kick-fix-guard-usage-v1-1-0ce02c08006e@kernel.org> References: <20260610-vduse_vq_kick-fix-guard-usage-v1-1-0ce02c08006e@kernel.org> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; arm-unknown-linux-gnueabihf) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 10 Jun 2026 12:16:49 -0700 Nathan Chancellor wrote: > When building with clang, there is an error in vduse_vq_kick() from > attempting to jump over a variable declared with the cleanup attribute > using goto: . > Jumping over a variable declared with the cleanup attribute does not > prevent the cleanup function from running, it would just result in the > variable being passed uninitialized to the cleanup function .clang > errors instead of generating the invalid code, unlike GCC. Does the same apply to variables allocated inside switch statements? I'm sure I've seen one that wasn't inside an extra block. David