From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f173.google.com (mail-qk1-f173.google.com [209.85.222.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 75AAA3F822F for ; Thu, 11 Jun 2026 12:32:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781181140; cv=none; b=kwmABctVdRXxijUft1T3h+DyckSQEk6ZCuRgKfuJ2zH9ahlz+mFdbyph4fig0yprK89R1tD0p24uf3yPGR5zbTdqeg8fWQYDTUcAIKZgIRG7yd81fe9O5ZPnEHBQ6X/YcFcItocfhIrBBmi739tKnPr/PbckUwsFtNkCFhTRsYM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781181140; c=relaxed/simple; bh=+g3UoGJSQBMIJWfE4I1WQriSnOqWfRW0HPDuB75fY0k=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=XWGLInIqd2WshJoL7JRCT6keIwhjYo0/XIOSOjOWS6ImRntyBbEovIZ+dQT0LQD3KuVGCSiqctnMrlZW+VOfiCk7eCj/kO8EwsdWC7T6sioNsdpyUucdgNlb5S7r1Yh+urpzDC2niKXcFgZS4nWReF5cxuLzG2uKnCRDgP0/UXg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=AVQN5Lzz; arc=none smtp.client-ip=209.85.222.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="AVQN5Lzz" Received: by mail-qk1-f173.google.com with SMTP id af79cd13be357-9158629a220so880551285a.1 for ; Thu, 11 Jun 2026 05:32:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781181138; x=1781785938; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=VGR23VQQ0KIak7ZD7YLq3Alex+Q6WU/vJpcU1WhhyY0=; b=AVQN5LzzLDR6l4zmuedj4Kj76oucvGfD7HqTkq4tGb18BXNO3Sj+YvVqF1GKv030m+ JlImv9Eyfv0eKC0hfNukxTwO241dNX0vERIXnj2SlDOSqNTafdJbDKN6YH3Zzusk6Rdw Fz4VAOjJjHISNW+ol7QjZ46yq/MDbOptcdaL8uxBeh0QMuB8gj/lc6Fz5k5b0W4wSc5L dsnRLO7XJN7gYHgNapC/oM8Nm/7aZtvaIbczFeKUMZzIX58xyJ/Wu+MMPGFBnsXaSrSf 8jJ+DYORCHRqYHnBPpblAIihk8wzUpFfWJpYLdHzLBPrPqOtZL/4SoMF9oHCJq/L/nCg lSBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781181138; x=1781785938; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=VGR23VQQ0KIak7ZD7YLq3Alex+Q6WU/vJpcU1WhhyY0=; b=jH6inAl7ocP5N4dsuYOMZR4mRYOx/Rzw44W+NPlBVfU5q1Q07T4OK4dW6kD4SsaOPL /lv5sNhN3y+jP0dU9Yobd5py2yTrDHuuGAjI9LrJrqkEgFk0FC4b7coz2Ct5dMRx3GC3 TduK2Yt487nk1DMcg211iNNndcvzGinedKHQtXS8fcabd8825ZeBAxF2IJMHuyKOu2Z8 W6KCOdsEVNJdTSvegQAp/tfpF+GXci6NNaoANLi0VCYMAd4lnvaOLLprXHfRF7yqMNe9 aSxM8UdViEvhBEVAt/k1be88TmUJOtOEfb/BPUYD5KUFCHGDy8ZuKaR1O4gU2y0MAfs9 DnLA== X-Forwarded-Encrypted: i=1; AFNElJ8Jxxf/xbXLDpuU3LHdWMot5BhmCAibWbMtD1F91amqtASNSqEqnGp7aV6UKgl7W0eeeTSnCjN4Q41zC5A=@vger.kernel.org X-Gm-Message-State: AOJu0YzvN4RvgdBV41jJsXVkc8a6kyV1ekQouWHIoAqdH3bLVlwhAVnO lmk3PdL6PyqlEQXA2FZ2H2WKUj3Y6QTcAGy/ZaepUmljoymjbK00vcD4 X-Gm-Gg: Acq92OF1zRxbuB7y8xf1LrdcN4jE35N98YKUL2+xFELrrLP4IZTz1DpiTysROJk+vhl mxSkbz92JpjSj6T3l7gCENlwKkG/EEwT/6r531qwiM+knz1l6Tsfjz1d4VpY2INWmTpjtGA4VEa 5JIA618mJJrm9Un30ut+WWqSz3dUgn4ErWp854IUFooGNBGidMW3kVYle1+SoyW4S727whXmWMG QyZnfof7xbt8nE9Ebz9Mr+GG8V1YjU2q56eaCiykxRC9HRprYrFLEMqGgmeJ7J6hyhbIHoO/00U 1UWG/1fe8y67YhQQywsYRYR4mrxz55iR4jnkzpRPyF6SX+VB052gMTFCSb7LsksqDGfSXfRS61i VPJxZgsiKqWFgP/1rDqGC4Ip0KMiIZFeuXKJxl665CM41Eg0n3WwX0btWWgpsqbgPRg2pFkOClI rdzPkSNQeh/b/OOm1EFlMDoS2T383V/ZFWeXy4z8zrHByLvo36yMfouyT0ll771Kwrw7wfaYcG3 OhJECu/azImYyWs/MqtnELQapAoi8A= X-Received: by 2002:a05:620a:17a2:b0:915:3542:ff72 with SMTP id af79cd13be357-9160acc37e6mr365473885a.22.1781181138395; Thu, 11 Jun 2026 05:32:18 -0700 (PDT) Received: from server0 (c-68-48-65-54.hsd1.mi.comcast.net. [68.48.65.54]) by smtp.gmail.com with ESMTPSA id af79cd13be357-9160b02f758sm171220685a.36.2026.06.11.05.32.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Jun 2026 05:32:17 -0700 (PDT) From: Michael Bommarito To: Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko Cc: xen-devel@lists.xenproject.org, linux-scsi@vger.kernel.org, stable@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/2] xen/scsiback: free the command tag on the TMR submit-failure path Date: Thu, 11 Jun 2026 08:30:46 -0400 Message-ID: <20260611123046.2323342-3-michael.bommarito@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260611123046.2323342-1-michael.bommarito@gmail.com> References: <20260611123046.2323342-1-michael.bommarito@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 7bit scsiback_device_action() obtains a command tag in scsiback_get_pend_req() and submits a task-management request with target_submit_tmr(). When target_submit_tmr() fails it returns < 0 and scsiback jumps to the err: label, which sends a response but frees nothing, leaking the tag. Impact: a pvSCSI guest can leak the command tags of a LUN's session, stopping the LUN, by issuing VSCSIIF_ACT_SCSI_ABORT or RESET requests whenever target_submit_tmr() fails. transport_generic_free_cmd() cannot be used here. By the time target_submit_tmr() returns an error it has already run __target_init_cmd() (so se_cmd->cmd_kref is one, not zero), and on its target_get_sess_cmd() error path it has freed se_cmd->se_tmr_req via core_tmr_release_req() while leaving SCF_SCSI_TMR_CDB set and the pointer dangling. Letting the command release run target_free_cmd_mem() would then double-free se_tmr_req. Use the same helper, which returns just the tag, on this path too. Fixes: 2dbcdf33dbf6 ("xen-scsiback: Convert to percpu_ida tag allocation") Cc: stable@vger.kernel.org Assisted-by: Claude:claude-opus-4-8 Signed-off-by: Michael Bommarito --- drivers/xen/xen-scsiback.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/xen/xen-scsiback.c b/drivers/xen/xen-scsiback.c index f324732eba7f8..c7036e0e41bda 100644 --- a/drivers/xen/xen-scsiback.c +++ b/drivers/xen/xen-scsiback.c @@ -658,7 +658,7 @@ static void scsiback_device_action(struct vscsibk_pend *pending_req, return; err: - scsiback_do_resp_with_sense(NULL, err, 0, pending_req); + scsiback_resp_and_free(pending_req, err); } /* -- 2.53.0