From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0EE5B408020 for ; Thu, 11 Jun 2026 13:28:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781184530; cv=none; b=juhjUYEZzE7LKOnp4iJFhCiJm6gAawRQVGdv6HPYL0X8FR9VEcA6W5+jDQyn4dfI+02/Ml340h1OZGcl7Ix/WdnEPoyu8p+v5DsCH3Ac+g7XHO3b3v+XM2xcHlKqPIuKTd3JtOLQbNThOZeajXTsu7yH1uZuoiBR7m1Hcfh9q4s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781184530; c=relaxed/simple; bh=crKmGM2BPtU1gWofMArc5RSNIxo8syCXCMCQHJjzvSk=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=NoHbhtFRToTenHsWhnl0eevkbaQxKuOsnTuIcCgGcsDy/DwuGYk71wlX6qEQpkyrifZcTTIUovhhb7CTSlU3MmtKuxJFcNywdT+fAP0rMoYxF0XCWzESykk1jelmADAi3e87NAioJcmNdf08JEyRsSgnmOKIrEj0+QjZg8Gfggg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=e7juqfne; arc=none smtp.client-ip=209.85.214.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="e7juqfne" Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-2c0bb4a94b8so67622225ad.2 for ; Thu, 11 Jun 2026 06:28:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781184528; x=1781789328; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=kr6lr/Zk4qDdZQL9yjJdI0zh4QdrOtRvdN1aN8UPXKU=; b=e7juqfne4BEQWFb7uAsbNpZ6bBRPG3XKGRIkDFcLIKc8iHJxeg9PA4FwMuKx7izMrC zvcAYxmIVlTvSVBp+TMJHP0r1EQvwEbLGK1fGIJ+6nyoZvSRfLUe1zf5TI8PldPbCOr+ ExKcFbrPiAyvvEReMVudx9VRa36T2oNDa4o4DPEoXd+cy+n4LSq6ciplza6ioTStRog5 CwEA07jb4eRKzZ2RQU/QQ1bYgjYeve4XXm+ZtkLjWDdzygl5E8vZhMSF7XVlOeJPpmcQ 13yn1ybBiP5X0e0jfSA0u4mDoweAI90lqnk/Xl4BwjhN5Oif7gfuybYKUrNhIT7cAMPW yw/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781184528; x=1781789328; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=kr6lr/Zk4qDdZQL9yjJdI0zh4QdrOtRvdN1aN8UPXKU=; b=JqkOw1ZaHuzJxPq/iND2LLiyj2WgBYDBJidgpO592PqxxU0ERzWfbRc9PEYb77A4zi /jjFwp4qOkNbmYaRuY2ILi4Ska+6rEMdWiODSfG08vacXOzlNiOzQYJfJYxJnGplq6WP 49GC92Z+/xylt4rJS9L2+shwG77CwYb5lo16b7LI3ie4Cx59T8fq4zNgdZoyF7nZzWwL Gk1ur/WY1YVsdBx6lVILJXQ88r+/C+qC/iGrg6PB0Jy5c4WKuHnlmx42vxpX6EbeeNds nsNl6mu0r06u/QR1eGnNJaTa/1wNWN4Vpk/syGKqL01RiDFGx09+3X2skXb8+otjCaG6 HX2Q== X-Forwarded-Encrypted: i=1; AFNElJ+t+GR6B91ilJDgZ2gW9tPSfP2Edo9/ITZABcH7Eqp/xix4cJXNWNnPBU1Y7J1p9pLkVuMAnt0/Z7WeZvM=@vger.kernel.org X-Gm-Message-State: AOJu0YwfScm5l8N/idTD0kuCVkVJx1ohryKjJxOsd8B/rK7Q2mbD4yWv 85EmjPbD7IVDHOpIZeUyesfIAzwBeXLf3zJ3KdLh0R7YHi1oWoc+dDJzOdRPt8VP X-Gm-Gg: Acq92OFqeeKwL72sYytl7fznOLQf9qYezxv5lRKln2vep5MLkaOu0p3fNR9WrEXeMZr PIkPdOVJQT/tQ6Iy21BVi707GESFD1GTVTofviD2a+MxlSKkD/64bXbt4iwBDXE6LCVq4vJ8+mo Pzi9WEo2A16a5ORMv6Omd+Yzx2BoNWWduP99RQKr1VeQKr0BfoRxBmR8FwYo8Xic8LJ1iluXwMx zkdD+ZGaDBZl/0Ld9ThmUc7ooaIUa531uBRHSC1Hw7sGyzEUHn22MkQ+4tmYX9Wfcn4iIuCz06U iH2XnN4UIfrrphscnreyM9dXO8/ByforMEgWE2WNkbSnva8sdaFYjmdkH2/iaMk1aKyKusx5Hwf eLyrpLFIAUqs3HDKEiX00N17060hl/FRg0KiklnGZRaJOuY1JU0LpG2I6CHFDZtsXWKbJ9rwLeb FC+KeZ/Tw0xIVxepAH0JovJH5ZZHT3cjd64yd5FUTE5jShN8MCoeXDmhZP0UXeAKp/4L/Sp29sh fvxA1RRn0WGB0a4WaeQUYVPUBG+QlAImCVx8vbjZ4XYLs8hi69S1caLr3jGF/PG4ROkcCZorMxi ZUWs1f39Ohz3L6ge9RbGc+8nq+dvudnuycKuNQhZo1LlVw5a X-Received: by 2002:a17:903:90c:b0:2bf:dd8b:7cd with SMTP id d9443c01a7336-2c2f10165e3mr31858515ad.10.1781184528412; Thu, 11 Jun 2026 06:28:48 -0700 (PDT) Received: from jfk-HP-EliteBook-640-14-inch-G10-Notebook-PC.cse.unsw.EDU.AU (dyn-dhcp-226.cse.unsw.EDU.AU. [129.94.175.226]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2c16629cfb4sm292927115ad.59.2026.06.11.06.28.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Jun 2026 06:28:47 -0700 (PDT) From: Weigang He To: Hans Verkuil , Mauro Carvalho Chehab , Maxime Coquelin , Alexandre Torgue Cc: linux-media@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Weigang He Subject: [PATCH] media: cec: stm32: prevent out-of-bounds write on RX overflow Date: Thu, 11 Jun 2026 23:22:48 +1000 Message-ID: <20260611132248.114519-1-geoffreyhe2@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit stm32_rx_done() appends each received CEC byte to rx_msg.msg[] using rx_msg.len as the write index, incrementing it on every RXBR (receive-byte-ready) interrupt without checking it against the buffer size: cec->rx_msg.msg[cec->rx_msg.len++] = val & 0xFF; rx_msg.msg[] is a fixed CEC_MAX_MSG_SIZE (16) byte array in struct cec_msg, and rx_msg.len is only reset on RXACKE/RXOVR or after a completed message (RXEND). The number of bytes received before RXEND is decided by the remote CEC device (it sets EOM), not by the driver. A peer that keeps sending bytes without ending the message drives RXBR repeatedly, pushing rx_msg.len past 16 and writing peer-controlled bytes out of bounds into the surrounding memory. This is reachable in normal operation once the driver has probed and receiving is enabled, from the IRQ thread, without any local privilege. The length check in the CEC core runs on the consumer side, after the byte has been stored, so it does not prevent the overflow. Bound the index in the driver before the store, as the other platform CEC drivers already do (e.g. tegra_cec), dropping the excess bytes of an overlong frame. Found by static analysis tool CodeQL. Fixes: d69ae57453c8 ("[media] cec: add STM32 cec driver") Cc: stable@vger.kernel.org Signed-off-by: Weigang He --- drivers/media/cec/platform/stm32/stm32-cec.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/media/cec/platform/stm32/stm32-cec.c b/drivers/media/cec/platform/stm32/stm32-cec.c index 1ec0cece0a5b7..8c2fc232202de 100644 --- a/drivers/media/cec/platform/stm32/stm32-cec.c +++ b/drivers/media/cec/platform/stm32/stm32-cec.c @@ -132,7 +132,8 @@ static void stm32_rx_done(struct stm32_cec *cec, u32 status) u32 val; regmap_read(cec->regmap, CEC_RXDR, &val); - cec->rx_msg.msg[cec->rx_msg.len++] = val & 0xFF; + if (cec->rx_msg.len < CEC_MAX_MSG_SIZE) + cec->rx_msg.msg[cec->rx_msg.len++] = val & 0xFF; } if (cec->irq_status & RXEND) { base-commit: 9716c086c8e8b141d35aa61f2e96a2e83de212a7 -- 2.43.0