From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 94A263164BA for ; Thu, 11 Jun 2026 21:07:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781212075; cv=none; b=WyjFhC10V+KAoQwQjapCKWe5z8MToevSXOPptVUaV1Uya6IRODUCtmCnXlLIANVMihm6mYcGJMGjmZFhGnNn9bpIybEDDBnIpYI7rvMQFfntogR/2JbpLZ/d9An9ED6Mln67eikoalu/W18qL43ca7jFFAUlPh5ff4znK1wR6KU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781212075; c=relaxed/simple; bh=SnXi41m/PJ/XgXZREgW9Hgvxn/Sg1ZuvA6UCUp8vS8s=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=C9ha/f8wqnTvMFEq+Hprqojdxxnbil9QySHvtFarrc6u5ehXAG0gD+wV71AK84KW9if1EVpk6LR47ycakGmZXYCFwrPB5oslUQp2Xe7KIJxAyO5Wm/Du0wigZPTk7jlawkv1sA0t0S7Tuf3bn4dtSTe70XmvFC/6/59gdj9T8LU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=LFLR/tOg; arc=none smtp.client-ip=209.85.214.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LFLR/tOg" Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-2c0c2d792c8so2150665ad.1 for ; Thu, 11 Jun 2026 14:07:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781212073; x=1781816873; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=pmerwbqBQn/j0PTKrCM8zAfuII8rL165LbPN0XVzvqw=; b=LFLR/tOg+/Fd9sqfJ/Er2RQnDOEiciazkc4aWi1Ph80OYxM4uNBCunxZ3QXvwleZIP PFI7RmTr0/xmJk8FyBp/uO5VJtNmTpBmszRR+aR/WkXXh7hRGE5ARAgS1s55ZeRIq3C7 jxu9BOCWeTUmZpIxtkxYHTsvdEO7s0s3AipQWoniNDgul/CDXsjHP1mZ31NoUj05gVCt mH3HEqaTKfBS7EjOvnwUgDaAS1T1PVxhVr/3zN5lc4tQuEqyw6CVNEIhXa01Lbfh7r0f 5TXCOi7e6e7wQkp09JpANBveBtHRfSZWVUL66cVRDlk6BrJPihqwice5V3YOIjuB66nB CHpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781212073; x=1781816873; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=pmerwbqBQn/j0PTKrCM8zAfuII8rL165LbPN0XVzvqw=; b=fLpQPTE9aLSpVCnkOXXcn9I4U3QesQL4zkmbwOVFO6zfihe6UB6bFlRUUwjNmj1HX8 E6SzQ5NUcLiV0c65Ii1VPU7y2zwUPls/6yF38x+XgvXa3mCLOA5RkbePohBVvKYnkj+h wlIHOtBSuwYpN/JtrAk70y/2HD8LO2y7WHenYkwB5p5oiyS3mFCSAncyQczVvYSG1rrG A79OIqXxaaZFQyDoxlHnhgHZfG3SHEAexM8c6GR1dDc5aahrPuyDu54+oNlQLeDZMowk STOACzadAulCm4C3OeokzK+BDkrmpXdL+c50k6eZUIARDV2Hbc0aEsQikA2zuZSLnkGh 6pYQ== X-Forwarded-Encrypted: i=1; AFNElJ8ve88rc8hV0FjBo9k0otqwmIM3wyTZNfExBdNC5Rqah/h+2rpSc8JDW4rQhBECBHnJQ5dhg++imCMh5tg=@vger.kernel.org X-Gm-Message-State: AOJu0YyNtZJipzaCdImGAyDKsodPp5iwOdLBCVG0LM48JDr6YQlWecsX e0K7H3pMYVx8NYeJjCySAvJt5+DMaPbhHsUnhVFI5ZYA0mTsYhdD/9yb X-Gm-Gg: Acq92OEJEiI7VbI04KhdI9DwzXZRVCtWmcuN5vLHF03CYk5a0oe/ek/g0W8oUmqNj/9 7uWc9JwPMiCErElgNMSPMC0PgKQTq/31imRCmdEVdcRzfHi57wGNOZ2U5kyQbnQbkyuSnaYBFZg EjsZMQCmBS0Nn1PaBrjT+qV01oSnivLVKv7/xWLhwanWvlXN3ffftktjg4JX8nLd2QnGF7odHMl W+O5B4AZXWwpbTgtkTQxCFzfAcBytVu0oYQQ4FMUVjeQt6n2EYxn56vEnxtC1GzGe67V9tLOWMt +G8d+CHThHMMvD/H2Jt7XzoNBpzCoXlKaoSCeq712ECYIc8i085UqylLJeWqUJGSNXXbAPDKwYV OyPMu+8AiOMA8Ed16m8diG8aeDzcz7cUMWWwtG7jwMd64+GgVDUy7OwhBP/jYO4iKrj4X+4Q55r jRrFAhba/jLm9USQ2DUSOly2/32zze/WGrgOdkgf+XZ/F8UZRSkXB9OG988fXSjyWyvnfPBGik7 Brz4cfBSzHeifMOwSLlKVar2RNlKqUB5yp/uXCL1gGM8g== X-Received: by 2002:a17:903:8c4:b0:2c2:5446:30eb with SMTP id d9443c01a7336-2c411b7e5a4mr975565ad.11.1781212073087; Thu, 11 Jun 2026 14:07:53 -0700 (PDT) Received: from ryzen ([2601:644:8000:5b5d:6d3a:64fc:4ee8:9cc3]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2c411d79289sm389995ad.14.2026.06.11.14.07.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Jun 2026 14:07:52 -0700 (PDT) From: Rosen Penev To: dmaengine@vger.kernel.org Cc: Vinod Koul , Frank Li , Thomas Petazzoni , Gregory CLEMENT , Marcin Wojtas , Rob Herring , linux-kernel@vger.kernel.org (open list) Subject: [PATCHv2 9/9] dmaengine: mv_xor: add missing platform remove function Date: Thu, 11 Jun 2026 14:07:21 -0700 Message-ID: <20260611210721.81979-10-rosenp@gmail.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260611210721.81979-1-rosenp@gmail.com> References: <20260611210721.81979-1-rosenp@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The driver was missing a remove callback, so channels, DMA devices, and IRQs were never cleaned up on driver unbind. Implement mv_xor_remove to undo probe, patterned after the existing error path. Assisted-by: opencode:big-pickle Signed-off-by: Rosen Penev --- drivers/dma/mv_xor.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/drivers/dma/mv_xor.c b/drivers/dma/mv_xor.c index 255df2dd9c71..85cb77022144 100644 --- a/drivers/dma/mv_xor.c +++ b/drivers/dma/mv_xor.c @@ -1446,8 +1446,19 @@ static int mv_xor_probe(struct platform_device *pdev) return ret; } +static void mv_xor_remove(struct platform_device *pdev) +{ + struct mv_xor_device *xordev = platform_get_drvdata(pdev); + int i; + + for (i = 0; i < MV_XOR_MAX_CHANNELS; i++) + if (xordev->channels[i]) + mv_xor_channel_remove(xordev->channels[i]); +} + static struct platform_driver mv_xor_driver = { .probe = mv_xor_probe, + .remove = mv_xor_remove, .suspend = mv_xor_suspend, .resume = mv_xor_resume, .driver = { -- 2.54.0