From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B1A043806D2 for ; Thu, 11 Jun 2026 21:07:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781212071; cv=none; b=VKbiWT0A3URXu4aA+AoAVxiNMIGIYcJrJZwl1G5BKlGotuLacn2uw2v9dlnsq3+qS6g2QHpIVL/WFoTBeczMYKA+4wnY9yQqA3igyI02LtLDteCr0tk9WGlwOaH7w51wqmyjGpMMa97xQvbr8JxZN7E7lPtRG2o9rbXLVWbUhMY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781212071; c=relaxed/simple; bh=jLPEef41Me4DDI5vEkM1r4e22JBWWaSGeJ69z2ZwqOY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=i+LMuEmzeKhouS13umyT9UrvNo+PbEMnJMW520ytJ9F50wZBvSGqN+Ciuu9vB9dTkiNjXxotA9VY5LXvXNlGTIfpLiYF+cWiiQ/sRSJf9RkQdddJjc3jOHLJW29wUH3u73igHW1I0zGZggCzOZHgCfe3kPcr3upnXeWgmJ7pp40= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ftwFWFMD; arc=none smtp.client-ip=209.85.214.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ftwFWFMD" Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-2c40397e3caso623725ad.2 for ; Thu, 11 Jun 2026 14:07:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781212068; x=1781816868; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=BrgKTzyAU7bi0fcz93xKN+kfwyhbg/GkzGbf0bvAjl4=; b=ftwFWFMDPSLjWcEX1VCntPoeOIR27Ytkad66+/uFGRKj601iSXKu79/CtzNouyIoqO n12fYteeI92p+U8F8e+fgEGuF4//qHNIu/E5lnsp7YjtB/cmVhczzIgbAK2ZCwbpa/mv vlQhemysluJbhJoGJSCYmpkIl/mQpaRcOJR+Xca7jwz8BV4Unh/36/r7SVV45IG7UC0n lIEsXxnDgr9G4BqNHI6L5Imtmi6ACCSNb9miD+2i702eW8vVD0uJM4+rjgC3m1CQeZ8V YyvQIuz2e4j8Mm5zCWEzxqM/rCbDfHVvwkr4KZlMnRCrWmsHVerAINR/LJblcpKDFgYF Bn2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781212068; x=1781816868; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=BrgKTzyAU7bi0fcz93xKN+kfwyhbg/GkzGbf0bvAjl4=; b=qqFZyyD29WO43kbF/dk9A0C0rHhHkMXsIXMRAvJZSqXwinFS40mzTyP7hoDKhqGQ9Q 8rGCnW4erhq57ulTH/Xf/OziExa0r+hqHWtEZljgey2R2jlMBmyPwQuGQrrI2MjQ6nc7 pjGVhGXDGM9l8S0QJXEXGUAbmuocOHKYnU5YVRWogpTu8bIwRmpgiBSA0PhPiLfU/YDE EWEPLe3uCrkHldUqOIqX+uBAUZwNFw2A590fHWISAvLd/1UM/XhHPdH2zZp5OkHFbAi7 OxBqBrfife5q88PcBRbepHHImyHtphPYKujbfesVqclITn5bpuo0RnphqyXciVfiJDIT EGtQ== X-Forwarded-Encrypted: i=1; AFNElJ/fF+hl1DyMoMxBZMDgD2ch+A9d32Me+2BHD7ZyUjuIeOe8MjLTGNWa22IUlQeX8qJZZhawEe4e2+TVSBU=@vger.kernel.org X-Gm-Message-State: AOJu0YzGFxHP7F+i0SE3sG2nfFwlibAMX71VZnI+XKNY9j/4MM1nNZVU SOQ6cKU8qOX+ZNINldmWUGRY9q9W4fEtdAFW84Y8YN+xujIC/i4DE8hjAbg6Yg== X-Gm-Gg: Acq92OEh9SZXAIL5NdVgJT5oNxKcU9+xAotjsipYl36yZaLFkRj9FPUk9wWIYxO8g5H pdu6X3RZxhHUBKCgVPim2CYj/9Y0cZqjbDn7jrMSoYxXQXW9k2mGii8pcYaO/YIx/pE+vt1DTCL Gn/ARvlypBat3fb8AFxckurx618j9xcZATHRg86D4RtLK75R0hjOEaLof5dqi2yLo/ZaGJ/ztny 3pm9PniBgGLALK2obQkIQJaTonJYwtKhXHr1Gk8MYR7BzyBjDh2yjKr6A+sxe3Edg9kq6VfiWl9 EBEn/F4GJsXw0fNb4vJsCLYjMOV+GxhlL/ihFxdivVoWWa/iXsYgiEt6kPJWzm5aBVikMmqbHlB JHp2UxUi5fOvf54z9LO4ltYBqAvHYNRTK0dtc7bYEhUvzLHJXfCJjPF1rUhK2Wg52T4+oXLGqIE /q6o1Kv2O6VoxnQzMTSsU51tDyQOSpiwlwLV59cgc8PrKkDwHEqkpo+G85eJyve9UwAcZXPIDY0 I1L01ujex32g16Zu25hXBmZuJ8NayoprLxc2+2+F4ae2A== X-Received: by 2002:a17:902:e812:b0:2c1:b8af:18ab with SMTP id d9443c01a7336-2c411d7a10bmr1108035ad.19.1781212067873; Thu, 11 Jun 2026 14:07:47 -0700 (PDT) Received: from ryzen ([2601:644:8000:5b5d:6d3a:64fc:4ee8:9cc3]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2c411d79289sm389995ad.14.2026.06.11.14.07.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Jun 2026 14:07:47 -0700 (PDT) From: Rosen Penev To: dmaengine@vger.kernel.org Cc: Vinod Koul , Frank Li , Thomas Petazzoni , Gregory CLEMENT , Marcin Wojtas , Rob Herring , linux-kernel@vger.kernel.org (open list) Subject: [PATCHv2 6/9] dmaengine: mv_xor: switch to of_irq_get() Date: Thu, 11 Jun 2026 14:07:18 -0700 Message-ID: <20260611210721.81979-7-rosenp@gmail.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260611210721.81979-1-rosenp@gmail.com> References: <20260611210721.81979-1-rosenp@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Replace irq_of_parse_and_map() + irq_dispose_mapping() with of_irq_get(), which maps the IRQ and registers a devres action to automatically dispose the mapping on driver removal or probe failure. This allows dropping the explicit irq_dispose_mapping() calls in the probe error path and remove function. Assisted-by: opencode:big-pickle Signed-off-by: Rosen Penev --- drivers/dma/mv_xor.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/dma/mv_xor.c b/drivers/dma/mv_xor.c index d9403172ef59..eefc8f22bec6 100644 --- a/drivers/dma/mv_xor.c +++ b/drivers/dma/mv_xor.c @@ -1423,9 +1423,9 @@ static int mv_xor_probe(struct platform_device *pdev) dma_cap_set(DMA_XOR, cap_mask); dma_cap_set(DMA_INTERRUPT, cap_mask); - irq = irq_of_parse_and_map(np, 0); - if (!irq) { - ret = -ENODEV; + irq = of_irq_get(np, 0); + if (irq < 0) { + ret = irq; goto err_channel_add; } @@ -1433,7 +1433,6 @@ static int mv_xor_probe(struct platform_device *pdev) cap_mask, irq); if (IS_ERR(chan)) { ret = PTR_ERR(chan); - irq_dispose_mapping(irq); goto err_channel_add; } @@ -1468,11 +1467,8 @@ static int mv_xor_probe(struct platform_device *pdev) err_channel_add: for (i = 0; i < MV_XOR_MAX_CHANNELS; i++) - if (xordev->channels[i]) { + if (xordev->channels[i]) mv_xor_channel_remove(xordev->channels[i]); - if (pdev->dev.of_node) - irq_dispose_mapping(xordev->channels[i]->irq); - } return ret; } -- 2.54.0