mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alberto Ruiz via B4 Relay <devnull+aruiz.redhat.com@kernel.org>
To: Javier Martinez Canillas <javierm@redhat.com>,
	 Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	 Maxime Ripard <mripard@kernel.org>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	 David Airlie <airlied@gmail.com>,
	Simona Vetter <simona@ffwll.ch>
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	 Alberto Ruiz <aruiz@redhat.com>
Subject: [PATCH 0/4] drm/solomon: batch command sequences for SSD130x/132x/133x init
Date: Fri, 12 Jun 2026 18:17:15 +0100	[thread overview]
Message-ID: <20260612-ssd-batchcmd-v1-0-c61e5f7c24bc@redhat.com> (raw)

The ssd130x_init(), ssd132x_init(), and ssd133x_init() functions each
issue long chains of individual ssd130x_write_cmd() calls, each
followed by its own error check.  This is verbose and makes the init
sequences harder to read and maintain.

This series introduces ssd130x_run_cmd_seq(), which interprets a flat
byte array of length-prefixed command entries terminated by a zero
byte, and converts the three init functions to use it.  The result is
a net reduction of ~110 lines, with the hardware programming sequences
now expressed as compact, declarative tables rather than imperative
call-and-check chains.

Signed-off-by: Alberto Ruiz <aruiz@redhat.com>
---
Alberto Ruiz (4):
      drm/solomon: add ssd130x_run_cmd_seq() for batch command execution
      drm/solomon: use ssd130x_run_cmd_seq() in ssd130x_init()
      drm/solomon: use ssd130x_run_cmd_seq() in ssd132x_init()
      drm/solomon: use ssd130x_run_cmd_seq() in ssd133x_init()

 drivers/gpu/drm/solomon/ssd130x.c | 367 +++++++++++++-------------------------
 1 file changed, 128 insertions(+), 239 deletions(-)
---
base-commit: 2b414a95b8f7307d42173ba9e580d6d3e2bcbfce
change-id: 20260612-ssd-batchcmd-35f7ba8c1e8b

Best regards,
--  
Alberto Ruiz <aruiz@redhat.com>



             reply	other threads:[~2026-06-12 17:17 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-12 17:17 Alberto Ruiz via B4 Relay [this message]
2026-06-12 17:17 ` [PATCH 1/4] drm/solomon: add ssd130x_run_cmd_seq() for batch command execution Alberto Ruiz via B4 Relay
2026-06-12 17:17 ` [PATCH 2/4] drm/solomon: use ssd130x_run_cmd_seq() in ssd130x_init() Alberto Ruiz via B4 Relay
2026-06-12 17:17 ` [PATCH 3/4] drm/solomon: use ssd130x_run_cmd_seq() in ssd132x_init() Alberto Ruiz via B4 Relay
2026-06-12 17:17 ` [PATCH 4/4] drm/solomon: use ssd130x_run_cmd_seq() in ssd133x_init() Alberto Ruiz via B4 Relay
2026-06-12 19:54 ` [PATCH 0/4] drm/solomon: batch command sequences for SSD130x/132x/133x init Javier Martinez Canillas
2026-06-16  8:48   ` Javier Martinez Canillas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260612-ssd-batchcmd-v1-0-c61e5f7c24bc@redhat.com \
    --to=devnull+aruiz.redhat.com@kernel.org \
    --cc=airlied@gmail.com \
    --cc=aruiz@redhat.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=javierm@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mripard@kernel.org \
    --cc=simona@ffwll.ch \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®