From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 84B373A641F for ; Fri, 12 Jun 2026 18:30:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781289026; cv=none; b=cR9Nhstzr7R11WI3h5n5mGhOXa90XFLw4zhBzFZb0m6zXKw0aDujc/wQ7VeFs2a98h6SEBZRuiyf3raTdURmePVm7dMgDPxWY981wvwkWYNEwMOkw02MNX55jXf2uhn9sUnhd5VQNTYmNsEgXRJ5dr2tLqVE3GXWc8wCvulYuIE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781289026; c=relaxed/simple; bh=hLu1cwKI2bwQjArWh6mX4nFC7KW8Gok04gwgDGIykRs=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ZdEQps9O+D4fF0lUFU8NqXs4+J+6fDu0FgeWLlxMMWVRX1oXbzKvGG6xGbuhuD1VcE3XRBTT9FEJKKUSNYI8hi1x6BrvicWdBTdatdbbCmXnAUYfjJybA5SUacIuqaphhi6nn3PEQIcbrpH+3nTcTVc5rxWL5+f7mtL3c8B/wIg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=fFyj2AKo; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=L/kHukEJ; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="fFyj2AKo"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="L/kHukEJ" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65CGUkFm4153136 for ; Fri, 12 Jun 2026 18:30:24 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 49OPqlKhqHIeEAhBZzcXi+3lZ4PA+n7d2F3AhuDo47c=; b=fFyj2AKooKHoOJKA NJgTtdivW3JLm+klRZc4PpTlm1VQTdUOBgkHjpNv+opgjkfzFCbs/xXVHNoIb8IP tIY4D0YKYKra6h+5juTT/O0WTaHR67EJ8J9eZpI12fu03EjveSnXBiJXWkJnotN8 BdHxG7ipbukle14/tTq9WSiXQCQUTi+u0CK0zUnFql52yCXNdoNswkDV6/5bc4w3 3cUFwu5KE94MOEUlr6lGn10HTuHcGo+wfQfcqerphjxnbSWG7LPtvgR/XM5w+7vZ D+ZXrEgYUErJiDyl2MUJrkd4VornswnCb0xo0hjn6So7K1550uobZwDtjyCuJpC6 oR3wgQ== Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4er1xcm9ge-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 12 Jun 2026 18:30:24 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-9157f1be083so216137185a.3 for ; Fri, 12 Jun 2026 11:30:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1781289024; x=1781893824; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=49OPqlKhqHIeEAhBZzcXi+3lZ4PA+n7d2F3AhuDo47c=; b=L/kHukEJez9pNilhYX3dXDygQ4lJntOREHj6i+9Sr5lfXbJoRBIIJxtUGPxa1Sv7Cq YFY3y5SV7PYidTkzRVG6LLA+fhaMs6rDC5v2yU0K3p40y1QO0zs5S4B1tpmxDNH5BMKC CK6iv+oGd1bdjRmhP1AAegxBRHAdlCeLc2/oYXhUke8++HF0XcfyWw5X38yvLiJSPcQF UBPflURDeQnA3DvTUTNO4BQSgnmIGtcL5u/mSXlD23sjyi87zDdFBjv7A1NbziC9llwK otCchmfZdwfZnJW+1O+4RL39E3EyWy3YalSxKJ+p0kLl+nLViLlxdxJ4Ca+hlxsIViRJ 9Phg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781289024; x=1781893824; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=49OPqlKhqHIeEAhBZzcXi+3lZ4PA+n7d2F3AhuDo47c=; b=PqTS5PfbOzqRZHFD+HqPlfhf7hed8HfzW2MNEbOVmn/65dD9mYf52hSKpmaeBZWwbh Eh9stZJDw4QF8hSV0VSpuLKljR3WBrIxX/pooD3hJN3XNn4gJ5k6RQvnKWtGBg4ezVJw Vyx/yd8tKj5wAmUB7MRE9b8BGLIBA5OJ/aTQhzkZXnfGPJa6eFn4phlJB80l32V0IIeO 3xoEwQ0L1C1alRb21lxYOgznKr1wGPsv5aG+o7wkCBBmmElRh8MahFaHyD6tUZOnqMVC S4iMPNBuCDncEgUh+UT47eUsBLdIcOwP2vhp0dUdSzqByeu9hgExNr7C3AKzE3fAb8d/ JdiQ== X-Forwarded-Encrypted: i=1; AFNElJ/u/7GgN2pNkcIiy4pE7bP6leLdmr8u9YBd9RHvuBXq7+k4hIf4isDosOukQpT+j/Z3ruc/zFACVah1Pyk=@vger.kernel.org X-Gm-Message-State: AOJu0YwETqKqivqiMjakIPtdjZOP8gltfgE8WppZnb7my5iGhaTMyfLE p8AtQ8KtjS5Obk+9qSTxrrl4S4MUOQE4f6CwSBxKwzPeTfAs4lQMnWSRZyw2Ap0zfslKT7hNc+I ZJwKlojrG8IZtahlVsqr+SdSNouYPHojtr+t9F8eN1rI1JeApPSiWGqD8d+1+EjHEJVM= X-Gm-Gg: Acq92OHANsShoOISZ+N5hn+8QJEGPQdTFYIk28pa/URC21mY3lcw01ia81tJsmgprIO UMQemciRM2KyobDm0r/YqAxpA79Lo0BOy9kyPhfeMz3uhB92Jj42owuloAkcvWMsb/xPE/Pp39L x7Eo4ARNjW4x/Fyflf7SobhKXVy7n2+xZLPWiyHacg/7+cmzdd7idT+noZrB0FFRbbEd0krAt5v C1o4G6b0UTd7qx8uQ23NuTnHI2VoAxdlvkVjN6VDICNkokKHGZi5ppvRkggcxzQhOeGHlAt9iw9 6loSqUO8gBLkPvedh97EuuVbSdaYqgZF6MfnZgwkjWzlTyILu6m8AwwzdP4LvanGxV31POdoRVI kAuv0XAaklZFlUnPejZA/oSkYcHCtqBl2AQ8DV3uK5pHbteUOEkwXEbnn/P8XT1hGe+r+j/8d8K 0DF7Y/DDKPeMpBSyym/jRcNnEugF6v3nP7oEA= X-Received: by 2002:a05:620a:a0d2:10b0:917:fcec:cfe0 with SMTP id af79cd13be357-917fcfc208bmr80221385a.33.1781289023470; Fri, 12 Jun 2026 11:30:23 -0700 (PDT) X-Received: by 2002:a05:620a:a0d2:10b0:917:fcec:cfe0 with SMTP id af79cd13be357-917fcfc208bmr80214285a.33.1781289022999; Fri, 12 Jun 2026 11:30:22 -0700 (PDT) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5ad2e161fefsm742173e87.8.2026.06.12.11.30.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Jun 2026 11:30:21 -0700 (PDT) From: Dmitry Baryshkov Date: Fri, 12 Jun 2026 21:30:12 +0300 Subject: [PATCH v6 2/9] drm/amd/display: use drmm allocation for writeback connector Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260612-wb-drop-encoder-v6-2-9f3a54f81310@oss.qualcomm.com> References: <20260612-wb-drop-encoder-v6-0-9f3a54f81310@oss.qualcomm.com> In-Reply-To: <20260612-wb-drop-encoder-v6-0-9f3a54f81310@oss.qualcomm.com> To: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Harry Wentland , Leo Li , Rodrigo Siqueira , Alex Deucher , =?utf-8?q?Christian_K=C3=B6nig?= , Liviu Dudau , Laurent Pinchart , Tomi Valkeinen , Kieran Bingham , Geert Uytterhoeven , Magnus Damm , Dave Stevenson , =?utf-8?q?Ma=C3=ADra_Canal?= , Raspberry Pi Kernel Maintenance Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, Christophe JAILLET , Alex Hung X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1809; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=hLu1cwKI2bwQjArWh6mX4nFC7KW8Gok04gwgDGIykRs=; b=owGbwMvMwMXYbdNlx6SpcZXxtFoSQ5ZOgNlx2RvH1rmncgWo3DgW+vltmevq93dm7mxf+Ev8u rbv61fHOhmNWRgYuRhkxRRZfApapsZsSg77sGNqPcwgViaQKQxcnAIwEbuv7P/965vCjkxfXj1Z UqjpR6ueWrD5vk8ixa0SSz5WMc8XTdxVdIpFd45lkOOtyH1s6ZwvigtCTzD8fhQZfGuZeX2NUCq jmUp84FsuuWjFjMrJO77/tTW6rmfIOl34nbv22bvT7/Dc//0o77D/+iLWy91JDV08gkb6s9lfTW VNm6U5rWI3x6HVK/ReKMvapE1RNnNg+CSurmvqGlGnONeQZa6/z4+jq6umiH9n4PvAu5/3Q8KN1 W9MOYN1eZLy/2icMarpbZNht9+lvoApLGfRMod9v/TO1drvk6y2Cj3qeNzSJHICi9vs7BbRTRoF aZuU0ta+m+y9gUWj4lbMr8edy14G3DWIM5qz+Ob2RttTAA== X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjEyMDE3MyBTYWx0ZWRfX/NUBy7NbsylZ /QVEZOLuUiu/XCX1cIbh1s/TkF1zxOBXX5t9HxjV2GshSlEI1mQoSPIhas8BwHVkh3+USOodpEu pTsD9BCObOghn0W+pxtiVcVCP8EJDutBsRQnPM0BmLOpLqV4HFPWkM1Tzzk9NxeWQwoT12HVy78 VdnQk/cVrUxyNwdHrQEpF6T4QsOBuHF2qCmLEEH4ewCaU6xatDJGxZ38F6zy9BCxSTFOOiWuU4r mGtE1nEmE2bONOHfSVluDyLkWfUolgbG3mSkJho7gFufLs9H1iPEfAjOqEx6RuTGlbNAuIj8ys2 XwA60m0rEMnVo9CGCe7B3BbzSvYJR/JOxs0XDDWZ86kqFAGfFF5+FREgHFyNTsFx9lZ+nFH/kMj Fv1nO6JOzJir7zyIRWcq1TvM+rKILGwdHrDJ3ACanu1vGzlYxLCj6FGKQyaDwhbJz7XtL92k+Vp wOA/gUzS5tNiyjmbNxQ== X-Proofpoint-GUID: _AMrT76Gdjy_-JOECwslunudtSKAPhI- X-Proofpoint-ORIG-GUID: _AMrT76Gdjy_-JOECwslunudtSKAPhI- X-Authority-Analysis: v=2.4 cv=NZPWEWD4 c=1 sm=1 tr=0 ts=6a2c5040 cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=zd2uoN0lAAAA:8 a=EUspDBNiAAAA:8 a=6a0IvY6ZUD0qJKO7u2MA:9 a=QEXdDO2ut3YA:10 a=IoWCM6iH3mJn3m4BftBB:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwNjEyMDE3MyBTYWx0ZWRfX91c/PiVAonGy kV8Ppsy6+qpaFhKx/18xaxuuZCw3XKNnpMFfG0v95HXqnjA4vOpchV4dVeQ3JELnUm19XSreMaL P39Dk8McB0EkQld3p30DkTdGq2Uy2g4= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-12_02,2026-06-12_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 suspectscore=0 adultscore=0 lowpriorityscore=0 clxscore=1015 priorityscore=1501 malwarescore=0 bulkscore=0 spamscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606040000 definitions=main-2606120173 Currently memory used for writeback connectors isn't freed on driver unbinding, leaking the memory. Use drm_device-memory allocation function for the writeback connector, making sure that the memory is freed on the driver unbinding. Reported-by: Christophe JAILLET Suggested-by: Alex Hung Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c index ece581609cf7..436562e32e63 100644 --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c @@ -91,6 +91,7 @@ #include #include #include +#include #include #include #include @@ -5807,7 +5808,7 @@ static int amdgpu_dm_initialize_drm_device(struct amdgpu_device *adev) link = dc_get_link_at_index(dm->dc, i); if (link->connector_signal == SIGNAL_TYPE_VIRTUAL) { - struct amdgpu_dm_wb_connector *wbcon = kzalloc_obj(*wbcon); + struct amdgpu_dm_wb_connector *wbcon = drmm_kzalloc_obj(adev_to_drm(adev), *wbcon); if (!wbcon) { drm_err(adev_to_drm(adev), "KMS: Failed to allocate writeback connector\n"); @@ -5816,7 +5817,7 @@ static int amdgpu_dm_initialize_drm_device(struct amdgpu_device *adev) if (amdgpu_dm_wb_connector_init(dm, wbcon, i)) { drm_err(adev_to_drm(adev), "KMS: Failed to initialize writeback connector\n"); - kfree(wbcon); + drmm_kfree(wbcon); continue; } -- 2.47.3