From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 49E96397347 for ; Fri, 12 Jun 2026 18:30:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781289032; cv=none; b=FuHt5VDdf2mp4pm4Sclm8Yy6x8xnHpoqvAbsIYuorDaMReLBcRHmY2j4RqtpHnH1b4mx+pVbPCVyREFgbbz7H71Rw0z44Bfu3F5EPFxlyUZZKUEZyYXZWwxIm88V38rbOtXYy4ChqzTIUxA0pHSbE3nWRHGsjqp9xbOpnulVXm4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781289032; c=relaxed/simple; bh=EekG2aEhKLuUzGk/MefJaYhFv2SLpgTabnBvDlYdrFk=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ulaH0hNYWVZcfm2S9EnBjokVI0zY+fSqf3a6Oes8a3Om5JSQO/IJnfhPK7i5QoPvQwx0D4qJvuOFRHC+KJeT9/5OAycdsZeNpaLSJfY2ovDjmhwxjjOn8fvtwxIpmvEel4RuMsass2f7N2iEWF5zpWSOA97GYkwNtopbhuBbWfk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=JDjJywkl; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=dBOxgsRF; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="JDjJywkl"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="dBOxgsRF" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65CGUQDJ054885 for ; Fri, 12 Jun 2026 18:30:30 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= QBJeYuGqe22P6k7nEfBN02fWJOuRECh3h974+RTUQts=; b=JDjJywkl573Oppgc a/m3TBe+6a2JfecT9b3uIzacmtAK1q8qhgZtpoimZPEHqTfkTmpmVogPPmbYys90 cAwU+ANkYhc6AwLv7Pj3Ahz56Thyb+tH+qBa6uT/nEm32ARE/RlGwuSJ5Pdoa2ts P63Xf2JKBP6W12t4s6guCx1pTC0JZMeRAXjiw3M6Q6l5l8XPzmrA7p++0Qnjs/LO bvfOVyOu21xR7Avbo3pHgk+B/WgXUj8fx6YQy7EoFRZ3BkkfxkZhNgJgXqtfcb0E qrn8c7Aot/kKThewvIPHA97mqjq2zdeuZdMglDGJ8eSUA/tqJwHHG418RYVPp8QU tp/B8Q== Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4er29uv65f-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 12 Jun 2026 18:30:30 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-9157db42dd8so202885685a.2 for ; Fri, 12 Jun 2026 11:30:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1781289030; x=1781893830; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=QBJeYuGqe22P6k7nEfBN02fWJOuRECh3h974+RTUQts=; b=dBOxgsRFEtMqzytmCYEEgrmKyIdzSWs24D4+cQAGgjHTcUQzfJu1+h7GqjH6aoZFLK 7IjdmOI8cX++8e3WY5yQviDcpn4ysdXyJkiFE7tO0fEIH1cAWD+KBtIbHpZa9sHFno0b u5DTGhHXC/Zr1cHt7ptFmvXJ0f+rTm+wdWFhWrT/HtHHy0t3nNLZqn3SYAqgtJmQeSLo 1N3PnPtF2DCs/1HupghcrBy8ZTdre+Ie7BEgr/VChRm2xHdOPSIm5B8jqe4qkMggGFFV TCd8fMYXthpItPIRvdFRhoiRSW9/lIjuhs97Xon0POf22v/AP4R+3khT68C/KLGxo2iw k46Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781289030; x=1781893830; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=QBJeYuGqe22P6k7nEfBN02fWJOuRECh3h974+RTUQts=; b=Wooox8isDc8E94SYWfoBOyc4AjXYWIh1OyTCTZ9NFfgTm/4bRpwf0LZDrzkUw9X4nV uVdSB4AvUvz8QrC0RV3WXZnyYb6l42gx0hpA080r+Mf5nP0KffoStPuf/fqHZ9MjBq4Z 89CCWuIjapwu+DcbTD7BArIb5OIefSfdlN5hmZa1/TX43YJNKcKlXrX3kevgZTQ/cY38 oT6B3ZMydC2q53YJsXq2uW45Dq/9MJU1JM/qhk1TXfp6iAYmtOPU3oRWcVDgySkPQwAw 0yhlDTeQADLQlBcIuK6+ms3D3qpqSBNGDHRUgW6FUdbMrjAOahjyQM1VSyIc/3UYXGLk xIiA== X-Forwarded-Encrypted: i=1; AFNElJ92DH2g6f5Cj36bwld3mQaSb91RnORU9o0kA4vyyGlMrf+4FzWyDrVR57slTvCaO9J3wfbJrA1bCvKYOl8=@vger.kernel.org X-Gm-Message-State: AOJu0YzznXRuYGwrUVd53+gE1o1qshr3j2xhKMP2mtDPSX44ln2i3O3v XGmF7TBaqFBm7vu4GO5B/I5MWKtVoj/C0+JITzUlysdB+P5cxfIjTfQAscG+0OgmoMfvGzdnMfM 45vglrjyOsMVBCJ+69nX+GAGOBntmcc7Q9RQ0P9OXUiXvWrmtBrRGhSFtcBfizdcRGj0= X-Gm-Gg: Acq92OF/3YiGbcv2nxdyNviDkcV9K7nLyTE0tNKxYWmQQDZ1tINtRa3O+3XV5nT3oGT 6a46c+ES0cit6gA63T6QbPNUcJ6XOHLX/SWxuDmJCTuYXdeknx+SrbzgqYs+ZlcfO66hac7sawX zcrWXol+s5uVbQonYEj0t9YvmdQq6kFzo9gIkydzKRaEMju7wzU+JigLAaa1D+HnNzFU400RIEO b9zj906Um4E8nnFwe/qxJytPV6X2cPduFa5VeOjJT4ELfJKqLRPvXiwe/HYqt/zXldk4YJapBnv wPI4FozyKPr5sjzcRFseX66TYsNatu6imSwpyXUTssIT4RoYXy7xdx0vcADwBJ8/3g/ZFBGjF5S vCQZx+5WEoRpsfOOu/93yFzM0sAlyQrkEZcial31Zrbq/c4pezDsjdVKVpEtCzSRcJlmK5YbbPQ gF1nYHzgXqCDxWrzDNg0HAP9aVOUI6yen/spI= X-Received: by 2002:a05:620a:438e:b0:915:2b46:eec0 with SMTP id af79cd13be357-917efac52d5mr130402485a.11.1781289029662; Fri, 12 Jun 2026 11:30:29 -0700 (PDT) X-Received: by 2002:a05:620a:438e:b0:915:2b46:eec0 with SMTP id af79cd13be357-917efac52d5mr130391585a.11.1781289029193; Fri, 12 Jun 2026 11:30:29 -0700 (PDT) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5ad2e161fefsm742173e87.8.2026.06.12.11.30.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Jun 2026 11:30:27 -0700 (PDT) From: Dmitry Baryshkov Date: Fri, 12 Jun 2026 21:30:15 +0300 Subject: [PATCH v6 5/9] drm/mali: use drmm_writeback_connector_init() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260612-wb-drop-encoder-v6-5-9f3a54f81310@oss.qualcomm.com> References: <20260612-wb-drop-encoder-v6-0-9f3a54f81310@oss.qualcomm.com> In-Reply-To: <20260612-wb-drop-encoder-v6-0-9f3a54f81310@oss.qualcomm.com> To: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Harry Wentland , Leo Li , Rodrigo Siqueira , Alex Deucher , =?utf-8?q?Christian_K=C3=B6nig?= , Liviu Dudau , Laurent Pinchart , Tomi Valkeinen , Kieran Bingham , Geert Uytterhoeven , Magnus Damm , Dave Stevenson , =?utf-8?q?Ma=C3=ADra_Canal?= , Raspberry Pi Kernel Maintenance Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, Suraj Kandpal , Louis Chauvet X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2921; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=EekG2aEhKLuUzGk/MefJaYhFv2SLpgTabnBvDlYdrFk=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBqLFA2/CqgW8HuyhGiu6mrDQOaZfrC3PXXYFzVN Bdfw2R9NwqJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCaixQNgAKCRCLPIo+Aiko 1VKpCACMjzF++leJC1KZCPjZzLnYEoWLvNMfjha1yB3vZJDN+Gqn1YkZEgAJdK8jmV1tS9Rbjn4 hGjhf1aRkpmRYnFRnV6o8k4JDpOyKwyVh4y/cx6eGcsJRA+wJ0s+JETrf9hdKaZ3b7NUiWYiYKC /4Elx9R41ZvK7BLWGrPzY7fn9MR2UmVTSulSrdceb0yoEapLzh1zKSNdtci5eKN3ejmx53WQIY1 BWz66qjliBJVWDoYBfaYoKgEeAMDmoFgicMjFse8+5/M5vVq1bPshcIOVK0obX01xrE5zNmyZfZ UuQEkfMTQdZewSOEO6B0Dv6Knmy+ogKMWnz5CnhkeoTI0/rA X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-Spam-Info: AW1haW4tMjYwNjEyMDE3MyBTYWx0ZWRfX+Sz8a+jp45oq YormE6DDwP97F0rJdX6Kyx830WZc4pGsEFdw87C4eLdWoeYnIjrg4rGRWWpKa6ILs20ephpLNAQ IC1ZYN8mAZuLmKCH6wUQrBUhLSj8XSM= X-Proofpoint-GUID: u62MQNDmBg6jEGnParRh4jMFw5W0PXj9 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjEyMDE3MyBTYWx0ZWRfXyyEuyovRUp94 lOG+SZOSnfV/eFaswCMeehKQszui00BM6w/WoDO/841AH4d4HceRDHc9vVwS8K7rnkOXjzk55iV BgV440P6oCDJj+GFQwmuW6Q5UEIy9T5b7DtNDCBaY5bXGQwX0e+Hg1fzwCF5DC6W+vzLu4tzC4l tTO0mu4GriFyG7GU/fbzf4g1RmwsNjRVeZ/IqGysRjuqte4vtQzEnx5WTFk4EbneABdyuGN/ORd jHEH6BM0ZpNmBKMYtY9at7Z1T3LFH5UWo96C9v+GjdicPc1F5Zl8qUMN+k1cm1RSyKKXg1vD/eK o3FqQ8Xe8g0NLxchPMg/dU/0b/+8f2zGhUwsGAFzDPjY5yoYYtcYKqXP8XaMC0gelMPGBoInxi3 JP6gpvWo21DIwPgRTSobfUnfbWVYknRqcEd5JDu5YOzbb3LpUBCAZUfA4BdoTv/RVibBouRNcsy wlg8kK0poRQTx9xEx1g== X-Authority-Analysis: v=2.4 cv=DppmPm/+ c=1 sm=1 tr=0 ts=6a2c5046 cx=c_pps a=qKBjSQ1v91RyAK45QCPf5w==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=QyXUC8HyAAAA:8 a=P-IC7800AAAA:8 a=7CQSdrXTAAAA:8 a=EUspDBNiAAAA:8 a=rEXDA0v2x0ZtafRnR6sA:9 a=QEXdDO2ut3YA:10 a=NFOGd7dJGGMPyQGDc5-O:22 a=d3PnA9EDa4IxuAV0gXij:22 a=a-qgeE7W1pNrGK8U0ZQC:22 X-Proofpoint-ORIG-GUID: u62MQNDmBg6jEGnParRh4jMFw5W0PXj9 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-12_02,2026-06-12_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 adultscore=0 phishscore=0 priorityscore=1501 lowpriorityscore=0 malwarescore=0 spamscore=0 clxscore=1015 impostorscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606040000 definitions=main-2606120173 The driver uses drm_writeback_connector_init() instead of its drmm counterpart, but it doesn't perform the job queue cleanup (neither manually nor by calling drm_writeback_connector_cleanup()). On the contrary, the drmm_writeback_connector_init() function ensures the proper cleanup of the job queue. Use drmm_plain_encoder_alloc() to allocate simple encoder and drmm_writeback_connector_init() in order to initialize writeback connector instance. Reviewed-by: Suraj Kandpal Reviewed-by: Louis Chauvet Reviewed-by: Liviu Dudau Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/arm/malidp_mw.c | 25 ++++++++++++++----------- 1 file changed, 14 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm/arm/malidp_mw.c b/drivers/gpu/drm/arm/malidp_mw.c index f8be65119e3b..cfb7300e3e95 100644 --- a/drivers/gpu/drm/arm/malidp_mw.c +++ b/drivers/gpu/drm/arm/malidp_mw.c @@ -84,11 +84,6 @@ malidp_mw_connector_detect(struct drm_connector *connector, bool force) return connector_status_connected; } -static void malidp_mw_connector_destroy(struct drm_connector *connector) -{ - drm_connector_cleanup(connector); -} - static struct drm_connector_state * malidp_mw_connector_duplicate_state(struct drm_connector *connector) { @@ -114,7 +109,6 @@ static const struct drm_connector_funcs malidp_mw_connector_funcs = { .reset = malidp_mw_connector_reset, .detect = malidp_mw_connector_detect, .fill_modes = drm_helper_probe_single_connector_modes, - .destroy = malidp_mw_connector_destroy, .atomic_duplicate_state = malidp_mw_connector_duplicate_state, .atomic_destroy_state = drm_atomic_helper_connector_destroy_state, }; @@ -211,6 +205,7 @@ static u32 *get_writeback_formats(struct malidp_drm *malidp, int *n_formats) int malidp_mw_connector_init(struct drm_device *drm) { struct malidp_drm *malidp = drm_to_malidp(drm); + struct drm_encoder *encoder; u32 *formats; int ret, n_formats; @@ -224,11 +219,19 @@ int malidp_mw_connector_init(struct drm_device *drm) if (!formats) return -ENOMEM; - ret = drm_writeback_connector_init(drm, &malidp->mw_connector, - &malidp_mw_connector_funcs, - &malidp_mw_encoder_helper_funcs, - formats, n_formats, - 1 << drm_crtc_index(&malidp->crtc)); + encoder = drmm_plain_encoder_alloc(drm, NULL, DRM_MODE_ENCODER_VIRTUAL, + NULL); + if (IS_ERR(encoder)) + return PTR_ERR(encoder); + + drm_encoder_helper_add(encoder, &malidp_mw_encoder_helper_funcs); + + encoder->possible_crtcs = drm_crtc_mask(&malidp->crtc); + + ret = drmm_writeback_connector_init(drm, &malidp->mw_connector, + &malidp_mw_connector_funcs, + encoder, + formats, n_formats); kfree(formats); if (ret) return ret; -- 2.47.3