From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7D04A39B49E for ; Fri, 12 Jun 2026 18:30:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781289034; cv=none; b=FKEpXYsCzcwcUl+s+U3VFF/PWeZDViEXXbJlBkG0UoB5GC6RNx5b17dhfu31nDTgWr6WXdkQkLx6JR5xkiIthH5qBb9vHOwB4Y0GcqlvYz02l/U+YbwL1RYIySDvQcfiiFad57/aWcj+SHC4RU+XSeAS5dg/XImfBK7CZpRb5kc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781289034; c=relaxed/simple; bh=4Vucpdbps+yQVez32oDVtzt/iw6YyMI2r6E/Wi913Hw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=J6D7IhO+sICEiy2xYR+BKfpFubydYGC28ElNIKAtk3AQrie8cbDVCwIAgs/f5QuZeBNEe0koh8+oOozD5XQYOrlEorHsh1GafwnFMWNTc9XDRivQatXu3+IwywNTQ8KMHchu3t8o+tSqmY/jjRYrgT+McJU++ZaXprtGi9YyQsk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=dVL5BU2p; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=b6U/eEhX; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="dVL5BU2p"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="b6U/eEhX" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65CGWMjP020179 for ; Fri, 12 Jun 2026 18:30:32 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= sTMi+rpeIeeTxwgAvd6Vb3BN+nfcxX4j3a3avZMj7+E=; b=dVL5BU2p5TxAPTdi S28MTvYXq86i+lhwR0HsWJot0vqed5Q82o8xOa1w+PaY4AYkw+ZdIC9xho1H4G/R Eg+Y0ltF4oVtQaKmvMa3k1+d+qqvQH4lH2iU/R8iRFX4qKKkWy2Xo5RbRidP3OXH AMhXLIrYWFn5kc0TMkqkYmh/GNb1hFoFrJ60ZCiw1Wwx9EQ2svsj03axFNKFIwew QN/lhY36dlaRIUs3D2RD7VZBCRaSBE1HeA5XAqLUwwET9iNqA7Mzj/iGugIOBz3P ffxADznUhAPiWxkM3tnnwOxLqDUIkU9RESdvor7Ns7uK3ja5rX3xsS14XLJGvBIe t8SRgw== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4er1cbmh17-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 12 Jun 2026 18:30:32 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-9159bc52211so181394985a.2 for ; Fri, 12 Jun 2026 11:30:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1781289032; x=1781893832; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=sTMi+rpeIeeTxwgAvd6Vb3BN+nfcxX4j3a3avZMj7+E=; b=b6U/eEhXlcr7+Tp04+luHc6WjHWMpx2KsVfc0IWxbJ9YFnz3roTdata50YAJj2VJT/ 0lkavYjbThXT/YHr5ZZcPmdXc9qw7npR5wrfFmq9E7wwNtFyHf3zFO7X3vvYHYZgI87g 7/044scHuBpcXhZY+jZM6AS/epbAPmQpKY6rYOVRsNk/iDp7DD0dD8rdD58YDND4r4wn Tmh2/NwA8D5tscVuqaUwinRsJHEBNNHCsgQU6W5OjmPyt7SEM3ZG4aSjzhKsFxSga2pz pRPWjNb67QXyzIzQogTevwwxrdWLH5nh8a3jW8um+6yHOIBuQUznF16KJ5wfA5R4otC/ 6WkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781289032; x=1781893832; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=sTMi+rpeIeeTxwgAvd6Vb3BN+nfcxX4j3a3avZMj7+E=; b=Is4lbvBMDcRrBaTXwHxV0lKQyauv8Rb7tIhl67dcG66OEtNeF6JbVrVtWgPKnajTTt iac2YgtyILAhCfjEP+7xdiY7tmBRlZMn87EZyJpC1zSi0FVYYNyI5s1bp8qoeZ9E+ycF 0dfkFVya4Ih6leYV2Z+2sKBchQe8ulgXumL2HfPiUx6g+Eo9pFCge5fisoC0rpQpCzcq 9Ijw9wJjpvYqqYIg+kEOBlT3btb3TbQ3Z9Wgln47DMvPf1i5iOwHIwZpABD0rfN29/AY cPo/Viq71122+L4cR3ixWiy/DbCet9gXdtnDmBklrE+Yn0sILttXeXvXB52ul/60/lfW KGwA== X-Forwarded-Encrypted: i=1; AFNElJ8UD8G2pPp4FZXuQJG36Iw8+NHlgPzZrIwVtUROEKAhPVjfJpQX/pNvFBi0Wu71SEtJ/q0WPxayKMR/r0s=@vger.kernel.org X-Gm-Message-State: AOJu0YzMBq+Wl9oLHXQSShgZa6eLmnG9o1rNIQfiOPbUCKNBAOSbnaBg OZsu1c5rfuQDrhMbNfISCzW11CyPCl1ajTKO0VDOln7Uhlj/oIsnzPxQMqqL6eYlZeYQQafDXT2 WsPPHVy5cxd4pwfa9XczaxYhrR+NgTemySpXij9223nvgjZy/qnvPS29/X8Q4t+QbvxM= X-Gm-Gg: Acq92OHfwDnA5MPm6iT5LUF31x1Fn31lL+LRWYTt9s00snZmeNcF8XbV0iOfrsbLBm2 q09GzUFDZkQZ4nkm9mU5Ze/n3PtbxrtSgiJ8MdtrZuRGSu3NEgv2NUltX1CSiUVewzR5pftqrun H48N1Ea+VO+z7AmLgxlHQx1VsxXB9Cjm7Zjz41MDO82WVmd7O09lzBP68DCNnwW8G2xoj8jfOrf PZb32a/c0PzmuDjVd4sHb/7z1i19aTNnGhF7HVoSLPM7qPG2AcbjkIFUl0nvgiZi3nudGddC3sp AMhaxTXbAegHRSYf4zBrj7kgytBh3cB+8LoO5viF2g2KCq6Lqf1YJ+LJmAOv/WIc3ZngLZWx0tm 8nDdynTQOErvzbNiLDV7a5sdWFMWX/GV4H24e+vsZgCeNgQuqy6HcGrTXP9GP7vCQMph0/5/kYR ARqmeDfpeBjG4JJDICONyr/oO6jH4/UHXVops= X-Received: by 2002:a05:620a:6497:b0:915:cda5:2807 with SMTP id af79cd13be357-917f1c595d9mr132338285a.57.1781289031557; Fri, 12 Jun 2026 11:30:31 -0700 (PDT) X-Received: by 2002:a05:620a:6497:b0:915:cda5:2807 with SMTP id af79cd13be357-917f1c595d9mr132325485a.57.1781289031019; Fri, 12 Jun 2026 11:30:31 -0700 (PDT) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5ad2e161fefsm742173e87.8.2026.06.12.11.30.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Jun 2026 11:30:29 -0700 (PDT) From: Dmitry Baryshkov Date: Fri, 12 Jun 2026 21:30:16 +0300 Subject: [PATCH v6 6/9] drm: renesas: rcar-du: use drmm_writeback_connector_init() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260612-wb-drop-encoder-v6-6-9f3a54f81310@oss.qualcomm.com> References: <20260612-wb-drop-encoder-v6-0-9f3a54f81310@oss.qualcomm.com> In-Reply-To: <20260612-wb-drop-encoder-v6-0-9f3a54f81310@oss.qualcomm.com> To: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Harry Wentland , Leo Li , Rodrigo Siqueira , Alex Deucher , =?utf-8?q?Christian_K=C3=B6nig?= , Liviu Dudau , Laurent Pinchart , Tomi Valkeinen , Kieran Bingham , Geert Uytterhoeven , Magnus Damm , Dave Stevenson , =?utf-8?q?Ma=C3=ADra_Canal?= , Raspberry Pi Kernel Maintenance Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, Suraj Kandpal , Louis Chauvet X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2589; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=4Vucpdbps+yQVez32oDVtzt/iw6YyMI2r6E/Wi913Hw=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBqLFA2qL8S5YQqKBPsRn9MTFivondiBpU/eAjZX v1710/GiaSJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCaixQNgAKCRCLPIo+Aiko 1bx1B/4qwPQtIu7I3Bwv5Sn6D3nPGP9G7fSvF58H/+/1e+BmXtWR0I52tzdypAxD6UGIshghp6r R9fC/vVHKY+cJlSIAkJvzdeviVpFG8H828Z976B2ZSeqgJ90a7o+vkfJEY03HCbBS9KVHQVmlWk wa43sUxKRxXS3xARc/fyWzjCVBtId3lFolo/JGuYlcdRpBqeoZB599OZQEeLetXVly3F13qILYK 2pztXlzGcfm5HDqC6ZOH+E2UHqSGHreRU202s3H9mR2LSXaYbnAc+lwUfurempYYfrNrKzpnXyA kqUq1HqnbLF9EiHxM4hNn5Dyyf5KvcLTbq6A43ZbRgqn8F9/ X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-GUID: pevAKdC3tpWPWloZfd3gpa_uJW7kYCnE X-Proofpoint-ORIG-GUID: pevAKdC3tpWPWloZfd3gpa_uJW7kYCnE X-Proofpoint-Spam-Info: AW1haW4tMjYwNjEyMDE3MyBTYWx0ZWRfX4+dct2OdjrD1 nYN7TXdgrJgF7rGI+UIrIwytijr3xB3mGBeiR1M72mUHWe1K3JdfK+dApVIw6KdWioIxEMqPvUo 2By/tXGnGQ8AfTx6qj9udyT4IA7pjUY= X-Authority-Analysis: v=2.4 cv=S57pBosP c=1 sm=1 tr=0 ts=6a2c5048 cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=QyXUC8HyAAAA:8 a=P-IC7800AAAA:8 a=EUspDBNiAAAA:8 a=rEXDA0v2x0ZtafRnR6sA:9 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 a=d3PnA9EDa4IxuAV0gXij:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjEyMDE3MyBTYWx0ZWRfX0VW4TReAXirR 3JZKWPfwNShrmJ+VW8tHtiKiMoSpFq61o37P5iy8m1N8JKWz4dp5EOPMUr9klTjwMFqpwYGq9yK vToI4bhanE4r3sysKqhrwWYIAxX2pQJWxjiWKTecyheLzQYPG7t6cjfXNZw+0yEtrLF1z1nCzvb JKSZnna1pRvpi8sImCrF7haGC+ZxupJ6b7jFkeyE/hJgFzkDusNLYCG6SsAmQZa0jJ92Tz59Z5v Nxouw/lcccOuqfG2JvPO6ZsaNZD4eWxecD5s6cPo26N8Rsyds5DPXkgJQzgSVdxbcK/vHqDW+i/ KQXlvXgkqplrTL6qcX8XD9MB+ewx5tVyxtjm0tkRvoia+NI/5U5jdzpQCf5CYFti5CoBSeTcy/v YQRXU3m5jMey29Jq5DFfbDspP97C3Rh+VvGKEnPa1rz++JsaPfdQnNR0Zyz06M010kC/ZUw467k Of6HSQfIGX6ghP5yFlw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-12_02,2026-06-12_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 impostorscore=0 adultscore=0 phishscore=0 bulkscore=0 lowpriorityscore=0 priorityscore=1501 malwarescore=0 clxscore=1015 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606040000 definitions=main-2606120173 The driver uses drm_writeback_connector_init() instead of its drmm counterpart, but it doesn't perform the job queue cleanup (neither manually nor by calling drm_writeback_connector_cleanup()). On the contrary, the drmm_writeback_connector_init() function ensures the proper cleanup of the job queue. Use drmm_plain_encoder_alloc() to allocate simple encoder and drmm_writeback_connector_init() in order to initialize writeback connector instance. Reviewed-by: Suraj Kandpal Reviewed-by: Louis Chauvet Signed-off-by: Dmitry Baryshkov --- .../gpu/drm/renesas/rcar-du/rcar_du_writeback.c | 22 +++++++++++++++------- 1 file changed, 15 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/renesas/rcar-du/rcar_du_writeback.c b/drivers/gpu/drm/renesas/rcar-du/rcar_du_writeback.c index e5e6e6a156aa..ecfd4fc1f210 100644 --- a/drivers/gpu/drm/renesas/rcar-du/rcar_du_writeback.c +++ b/drivers/gpu/drm/renesas/rcar-du/rcar_du_writeback.c @@ -134,7 +134,6 @@ static void rcar_du_wb_conn_reset(struct drm_connector *connector) static const struct drm_connector_funcs rcar_du_wb_conn_funcs = { .reset = rcar_du_wb_conn_reset, .fill_modes = drm_helper_probe_single_connector_modes, - .destroy = drm_connector_cleanup, .atomic_duplicate_state = rcar_du_wb_conn_duplicate_state, .atomic_destroy_state = rcar_du_wb_conn_destroy_state, }; @@ -201,16 +200,25 @@ int rcar_du_writeback_init(struct rcar_du_device *rcdu, struct rcar_du_crtc *rcrtc) { struct drm_writeback_connector *wb_conn = &rcrtc->writeback; + struct drm_encoder *encoder; + + encoder = drmm_plain_encoder_alloc(&rcdu->ddev, NULL, + DRM_MODE_ENCODER_VIRTUAL, NULL); + if (IS_ERR(encoder)) + return PTR_ERR(encoder); + + drm_encoder_helper_add(encoder, &rcar_du_wb_enc_helper_funcs); + + encoder->possible_crtcs = drm_crtc_mask(&rcrtc->crtc); drm_connector_helper_add(&wb_conn->base, &rcar_du_wb_conn_helper_funcs); - return drm_writeback_connector_init(&rcdu->ddev, wb_conn, - &rcar_du_wb_conn_funcs, - &rcar_du_wb_enc_helper_funcs, - writeback_formats, - ARRAY_SIZE(writeback_formats), - 1 << drm_crtc_index(&rcrtc->crtc)); + return drmm_writeback_connector_init(&rcdu->ddev, wb_conn, + &rcar_du_wb_conn_funcs, + encoder, + writeback_formats, + ARRAY_SIZE(writeback_formats)); } void rcar_du_writeback_setup(struct rcar_du_crtc *rcrtc, -- 2.47.3