From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E934F39FCCA for ; Fri, 12 Jun 2026 18:30:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781289043; cv=none; b=VDYtqfvaNSSVbN29+1oqJvFPaAGE6v/Re6hUYyN7XmPKEVE/LCuiSHbynB9ZmFMyEEcI56S9yLfGiXZ4NnDgSjhsnepUehXQW/QQc2BM4PBAr0sHLHFTZrTpfiURp6I9g9OPjnyVATxigi9zGXRgIILnRCux2y+Oz9bWRQlSxX0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781289043; c=relaxed/simple; bh=WHDRI+JhBcNuBgC+0OtPNMX06wOpYXQsdurLSHRrbWw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Iq+YDZHpBHtIv4TMynugBKpLXpazRLlLQpHE8HmAFuV7KO5PJoSc+N9R6Kh+GQzG2wpUvMb17+t+d+Xo/NnHUwlffZFAMxiF5Ix24oMiQ/PQ6SbNFsyudj50fijzNB7wptD7ga0mp1iYxMvCJ33gHGH2TSTzmkzdRxHG46DnG6w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=WR8zAQI1; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=HIdrVYP4; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="WR8zAQI1"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="HIdrVYP4" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65CGUM0Q4150487 for ; Fri, 12 Jun 2026 18:30:38 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= TPWo467A1KtBfknXLUhzGM05jfJhVUBGDG8kt4+2Duw=; b=WR8zAQI1Ce48sbsQ iko4kevADzRuNsFys/yUaT2wA08EO8kntUazpR3SYgJ8qEQ1mCbCrkD4hWZ7nnet QfCrCERbHHPoErM3ZXgBgnCCnNGEM7pBbrXhpn/cghbYrkA5K8CRcHrbbRV6fLry HJ82D6zeU4RQJc8MeriCpWHeG0iZm4CscGQjMvXbE4fLGj1WNnffM6lrsBWfaWvi KTylmWw4szOJRozfVJ51Wfi+XQ87hv7dCUCOJ13ulkBrhsoOjurLWd/VhjbAV4dh CKIFwJkRM1ZOXusNS1w5n0T24KqXqhEoGpp8pv8qsaU3VCum5Ik7ZtCop5gh8sKk DoE0iA== Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4er1xcm9j1-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 12 Jun 2026 18:30:37 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-9158f2c4b55so201537285a.0 for ; Fri, 12 Jun 2026 11:30:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1781289037; x=1781893837; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=TPWo467A1KtBfknXLUhzGM05jfJhVUBGDG8kt4+2Duw=; b=HIdrVYP4s3OalOnYzAMpinsXHlKkk8d2la4IfgpqoRcyepIsDg5sbsRKooWQH9c41Q MnrAr37f0Li/6xDkRMjH4t8Rw+Ase6m7dtVdip+Q+p0nse4YdLY7B2KbgXTfo9jAY69Q GKO6dFQmFFtetbaPsrJXYNKyxBCPpZjWkNNDte8NTM9SbRxF7R5Xl5mRiGcAPjhQDtHP Lb9ArFjb6957OA/83AQqSoRYDNb1+yHt+UQUdqqo/4YptlleQikpkPA5QP9q5LX65TLG 5KThgoSw/GYiD0tPqJTFc/mlkD0ILKqpIZHExfXy1VClBGeJ5+NqMJjzQmGYLcJ3WzcC nvtQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781289037; x=1781893837; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=TPWo467A1KtBfknXLUhzGM05jfJhVUBGDG8kt4+2Duw=; b=Q69gsIXt+HZ2W58ldNentxPdg3ydHI9x11ugF7SXmjZez+YffOC4Pn4jH5kSp4P/1G IlFalDhda4Ip6Nx5vrdWjBU3k73CV/+1JNmCfr1NcprfoTKcHvdR3acYhH2BMPM/39OX NkSt3tsnkDR23fal+9YFIKCvy8ClyAFcOyRNV12ni9U11zGFNDEuIqM79IF+oe6/J+1u rPQ+VSFCxnj9UOPkzICQf7KtPouxHlzqaSP2p8c45wYo3synyLto0wW6lhe+wyVtzy2c 6PhSKHzDoGx+ie1m6w9hSrDdCCupJUjMVxpTyVod1GNkHqUATyxHGeepwiZGx+WFLh7O lLdg== X-Forwarded-Encrypted: i=1; AFNElJ9dS2+e405k1i6dM7xp//uKf3hXtRSFT3iQYckURqRY4OSSuvLIvp68w/dvcNLXlh9uyh0H26IbSdHw5jw=@vger.kernel.org X-Gm-Message-State: AOJu0YxRcpDumBsT5Drfpy26TPgOTYNgc0m0qCY45oFFY3+7SiIELTuE OSSKzqXML1gDRZoTZ7IchWeFtAmCIxa53e9GvlXVmGF8rA2Hn9e74pGWkrBaHdKWE3gpM1QE18I BOnh1Z4aY+n24ko1v8v8zy0DVR0BzVd/vCFTbiRex7ZTDFkSxVKa12v3FKLe4F+C3jlQ= X-Gm-Gg: Acq92OF6DlQjGMu25nkP5u0pS86E+m4SzGw04aDxXCMwyfoRYp904xNvzPZnTVS4C3l F+UJWCfOwUyvlJ/Uo8E762t8ZlKMBELD3k5M40cXiCMO12OyDxNcQLoIXtPnP0d8r7aDTf5xo+q L1Q3urnQB0Bf+6b7eBxIGPMRBdpN9s8I9pgCa4YfdjtH3vV7cVftTD3ZmOwrezfVt6Uplmtzn3s lttw5IhMNwg0LT78+wDt1auVD29rI2TlQY144jKV+40pxUuJPmBXXjRyWQbu3vWWSEBnMK8bR8B Toi09JzVzIdT3TMAHN4rRj5PmKPOjSdd3FsHgeBv64QOadfovKjK2uSFNfF8HoMcOFCz/0AFFa4 7/yuoEypjZqWmJBqACVK9fzzdqoQi/3lDRasI5k+9wvnqv6gyVPf3/i5epC2TiZ3P16XKXghxW+ Q1Eiqxa24yqXKZMOtm6WEtBasnfbsJCL465jM= X-Received: by 2002:a05:620a:6cc3:b0:915:a5bd:d82b with SMTP id af79cd13be357-9161bab53d7mr621083085a.9.1781289035518; Fri, 12 Jun 2026 11:30:35 -0700 (PDT) X-Received: by 2002:a05:620a:6cc3:b0:915:a5bd:d82b with SMTP id af79cd13be357-9161bab53d7mr621044285a.9.1781289033033; Fri, 12 Jun 2026 11:30:33 -0700 (PDT) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5ad2e161fefsm742173e87.8.2026.06.12.11.30.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Jun 2026 11:30:31 -0700 (PDT) From: Dmitry Baryshkov Date: Fri, 12 Jun 2026 21:30:17 +0300 Subject: [PATCH v6 7/9] drm/vc4: use drmm_writeback_connector_init() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260612-wb-drop-encoder-v6-7-9f3a54f81310@oss.qualcomm.com> References: <20260612-wb-drop-encoder-v6-0-9f3a54f81310@oss.qualcomm.com> In-Reply-To: <20260612-wb-drop-encoder-v6-0-9f3a54f81310@oss.qualcomm.com> To: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Harry Wentland , Leo Li , Rodrigo Siqueira , Alex Deucher , =?utf-8?q?Christian_K=C3=B6nig?= , Liviu Dudau , Laurent Pinchart , Tomi Valkeinen , Kieran Bingham , Geert Uytterhoeven , Magnus Damm , Dave Stevenson , =?utf-8?q?Ma=C3=ADra_Canal?= , Raspberry Pi Kernel Maintenance Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, Louis Chauvet , Suraj Kandpal X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1991; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=WHDRI+JhBcNuBgC+0OtPNMX06wOpYXQsdurLSHRrbWw=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBqLFA3w2eA8bVTfCfHWtbd+wRuk4WZ7UwSCELFb NxOkKpvyhmJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCaixQNwAKCRCLPIo+Aiko 1Zs7B/9AUhF9TKQrWA7mEHSfv7WVuiuih1udWVrnH9RNj8QpmTWalWgAaq88xcqtqfZQ1rKIgyi 0g9nwOMEU8kaWGhLFEbRXwS+0IEmVPcYdrtHtyILGIyAuThnCUQPQ85n5Pyko1tQY4J4AzY5gLx BO2pvW2aGpYAwpdiU5sipK7Wk6hcQnmS5tI7hYVq4utxYb761SSAMwC8E562cRt9Eodyi9aba5D xjvI7FKExDv/WlhOoJbXDAELkCQwM59yfhR2U+yn9b8sVAoGz9vceb5G8NgGI30BppAUwjAcJrU 82zcn3Il4qxGFNUlheHmOwHsDcH96KoaQpAjKpqqd+4WzXud X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjEyMDE3MyBTYWx0ZWRfXwAwnxPnLvoY8 jdWHwTVYuYtTdOuYO4FwGhwwU99zYqjjckWm4IzIaQiz2moVT/IHva4HD6YKJL482H0HUVrR9Bp WqPOVU9+gj9g1w7ZuG6OMOEer2TW2vFLV1liHLw3iOYuRUL3vRdFra4WBRBv14hXsw8WVwa8V0r JwEmRiA8AUJ75BsZm9EQJtNZhyAIUg5nr6vkChneLuCqeDMKfWcgOWOhGrMcUWrVtew5738hLxA 5WV2pzZ0v2Ztca08+9n+e5lz4QiyczLpFCss0QiPdDMBBfQ1atYeK7gLQR9gO/9xP4hPkuC7uQH 34FYnPg1guewxBAOY1w50nY8DAHD71xalv5prJuf0UcV0xjFYqitMj5X4q8IUU4IA4BU2sEZsGR zWQggYhhFfqGeyWFTI2QbChUTLshuxLpd8eFHX5CMiGOeVknfjSmupDfrXohubX4hHgh4c31mdP Gu/Vm7HPptuShb7mXbg== X-Proofpoint-GUID: YcdoicPkGdYjsbkW0246PsHt8LcKhFbb X-Proofpoint-ORIG-GUID: YcdoicPkGdYjsbkW0246PsHt8LcKhFbb X-Authority-Analysis: v=2.4 cv=NZPWEWD4 c=1 sm=1 tr=0 ts=6a2c504d cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=P-IC7800AAAA:8 a=QyXUC8HyAAAA:8 a=EUspDBNiAAAA:8 a=YDDQE0DzCl7hcZedIR8A:9 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 a=d3PnA9EDa4IxuAV0gXij:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwNjEyMDE3MyBTYWx0ZWRfX+4nW4zWLUbBd p+C0Y9d8+GDkAX3hLqIJRkOZCrwijfloN+sJyDyGDni3B+GDq1mPYJMyq5xO14AtzPXCxrZjA2Q yhVUHjwMildrd5OnowE5//4PLq0zQ14= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-12_02,2026-06-12_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 suspectscore=0 adultscore=0 lowpriorityscore=0 clxscore=1015 priorityscore=1501 malwarescore=0 bulkscore=0 spamscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606040000 definitions=main-2606120173 The driver uses drm_writeback_connector_init() instead of its drmm counterpart, but it doesn't perform the job queue cleanup (neither manually nor by calling drm_writeback_connector_cleanup()). On the contrary, the drmm_writeback_connector_init() function ensures the proper cleanup of the job queue. Use drmm_plain_encoder_alloc() to allocate simple encoder and drmm_writeback_connector_init() in order to initialize writeback connector instance. Reviewed-by: Louis Chauvet Reviewed-by: Suraj Kandpal Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/vc4/vc4_txp.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/vc4/vc4_txp.c b/drivers/gpu/drm/vc4/vc4_txp.c index 66b6f2acf862..3fd89fccfa10 100644 --- a/drivers/gpu/drm/vc4/vc4_txp.c +++ b/drivers/gpu/drm/vc4/vc4_txp.c @@ -378,7 +378,6 @@ vc4_txp_connector_detect(struct drm_connector *connector, bool force) static const struct drm_connector_funcs vc4_txp_connector_funcs = { .detect = vc4_txp_connector_detect, .fill_modes = drm_helper_probe_single_connector_modes, - .destroy = drm_connector_cleanup, .reset = drm_atomic_helper_connector_reset, .atomic_duplicate_state = drm_atomic_helper_connector_duplicate_state, .atomic_destroy_state = drm_atomic_helper_connector_destroy_state, @@ -602,10 +601,10 @@ static int vc4_txp_bind(struct device *dev, struct device *master, void *data) drm_connector_helper_add(&txp->connector.base, &vc4_txp_connector_helper_funcs); - ret = drm_writeback_connector_init_with_encoder(drm, &txp->connector, - encoder, - &vc4_txp_connector_funcs, - drm_fmts, ARRAY_SIZE(drm_fmts)); + ret = drmm_writeback_connector_init(drm, &txp->connector, + &vc4_txp_connector_funcs, + encoder, + drm_fmts, ARRAY_SIZE(drm_fmts)); if (ret) return ret; -- 2.47.3