From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1BB1837CD2C for ; Fri, 12 Jun 2026 18:30:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781289039; cv=none; b=jbS1BQS8xLYTaUusRWAUi2AoScBPCaomdr0YRGjtDctoJkLqrnUyr3pVQ3gtxbjXuditX73ekN+Fjiz2x6lZKA9sZpPdlYD8CYdaLPqz5776VYhzbqAdoMnPslIBz7PpsBq3+ClYzyzeKvbMJs4GpWxJ23792Efk3rtbzs88ZZM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781289039; c=relaxed/simple; bh=6KkNpyC526rgMVIeY0D11Z3gyU75WDlgdpp2dL9pdq0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=qJ/P4Qx83unuMKcBKeo7UYD+vpba+HEmaNv2FL0mNo+1kj+LwIzf2wcjghWXbTenb0KDmsgu/cqxLOMx/w5hYtkP9vpVCC2lt44iYtN7hT4f6rzXwX8LBpC6BCF5r8/dVU6a/bc15oG/R+e+1EYlqn9lUtg8EBDJzQP15D2acyE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=oRWWBt6A; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=aMajdtHq; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="oRWWBt6A"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="aMajdtHq" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65CGVe824112800 for ; Fri, 12 Jun 2026 18:30:37 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= EaIMgG/IEi5Ad5NwXbrOlQk4Ovs4qDGmtqlsgR815SE=; b=oRWWBt6ABEqt5eXm crjECfTbmZn3hmv5zjdzfkecPBLuWdzAsMuK1dvbN9+4HEx4qoON0XSGX/thQhl4 FyW/EmTg8fdQ8PqTuKFQtilSnf54Rt/j5teGI7/rTy4p4hO8YHrhZi9m+kWqlexa 3jbOfFvYxLa1hz7XrbcFcUKIAlS0psOKYvSQAdB/+GVB+UDJUJ6KbYaffXC2Q9R4 /CZsJTzCnVEKd2nty0p7DZ7kVUOzNV2EUSPltDGnuvT80hmE/LPKnVIKJueVq3wB ILlcMdzhPT9MPmSLNvWDCv2BoJLG6kopu7HZ6vGka+HIux2UfrYpmo71qUaeehEX nlvHXA== Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4er30gc2qd-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 12 Jun 2026 18:30:36 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-915c1997732so295177285a.3 for ; Fri, 12 Jun 2026 11:30:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1781289036; x=1781893836; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=EaIMgG/IEi5Ad5NwXbrOlQk4Ovs4qDGmtqlsgR815SE=; b=aMajdtHqbhDe0BO6nEpaDot9PBN8bC1te/oGrI45uY0GS4146jlkTEF7ArgH45+W+x i0n/kpzZ+P6DoCwzlAzK8IUGQPhT1RAbj6UMjCkZ8BtAEaNELAnW2FDQAPczeRmhQfvr qLzjhVcE/+lSYwAANHyFf26qBmkfcofpeecofw08wsvDKVmK+oaUwiE/apNdxo2O25Kf /kViI6nyqk7FyJXcpHjILNQyFKDfiVKuGCCD7Y529SHuBCDDXKN0cVpyDgz9YwHFhO4p XUfl1dFuhu6zGLjkGxPaZBygx504kgbaWGK2FPng5yXLcWGmkAxnflgMpdDD6+WPxTyc 7CFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781289036; x=1781893836; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=EaIMgG/IEi5Ad5NwXbrOlQk4Ovs4qDGmtqlsgR815SE=; b=Mhqle3sLXw41llvBrBwEnr2wW7IUmh1ZPl/d4xP2nwlc8vpW+1slOlc7BgENOMUdZE 3fdcl/gvDRMyZblmD2p5bxAojZ775pLVipuwARyw9eYDovhZ6jDruehyQ4ev1wHmw1T6 FuuK1DCwxOQ4qPn1iiwumHBsOBnOruYDpIj/NRsV4YiPVzWxf1u7fzBAPNnQu4hCNOhV Hc/aVvWjVyE2GnIEhr701prbDuqGTuFe/srHDE7AScl5g0MFVjmJwLP4Ahe6EYouqocM BMXf3Lh3TrXAS5ZcCimPoLPgrH0xwmeEPkpo0CH4W17Dinn8a4SDyPUaf24HcBjcH2ag V/XA== X-Forwarded-Encrypted: i=1; AFNElJ8Db/P5vxPwIWvyOftQ5a+vhhdsPIMHS+jqADjA6i76Y3D2Ky9PoAGkJyTborI2xKbHy+eQprJYOjqLaxI=@vger.kernel.org X-Gm-Message-State: AOJu0YyYX21hN3+BaR0z9smo+CrpZl7Q/fH5daeFMa1L+HDbeZxtL3FP aVZEFaAC1q+FQKkChn49aHGuLDjYBurBSG9EovhRPbkSnc3PQ5TnS5jbgJJftDtP3iBQJ5lGRRP hF986QXyBoC6Ew1LPE5jo6Bks95BABS8vasuDGh4VIVRS00JumBVSaEnSZSJlPE+aOAs= X-Gm-Gg: Acq92OG/e3f4wmhViSElw3RR9wPdFYAFkgccBIekhEVVFRUOGw2SAkwe9yOe8CzWYzd 5uPxJ+LZ0mfdzeufY3/cqFmA35bfgu8OdQQRMPGfzETVCZS3krdCFuSvGKXpr1/Gfqk/+XoXad2 DE1flFQ8kPmTOeO3FiwzbslNg5LSyHt+MwMa2WoQaPZQIZSEIG/MeXniMEHVDRRJ6GuT+wp2jFX mVW+DXMnWqRoSmZzUVPKQmkGaBUmZP49vHgSYir4ZoLS6YGf7PKoiJAuO6WbDpch/Z0y/oq4tzo i7w6mB1ZTo1JhoHgQN8Pd71YDthHWdgyPaG5/Z79+5kWMMut5uQuhG/Tv3Qh+cSW42Bh/J+dggg W+J5KDZisJDn/UztvcB1uVTpj5J6HYFxU8i3vQKdtWcVd90u9U94MOZalbDim6zoE2jSgns10jC U8CPJBy/q5G5cgJVUaWl9ogkB9Q/zwQ8+zBbA= X-Received: by 2002:a05:620a:6288:b0:915:9125:e63d with SMTP id af79cd13be357-9161bcec31amr573647685a.43.1781289035952; Fri, 12 Jun 2026 11:30:35 -0700 (PDT) X-Received: by 2002:a05:620a:6288:b0:915:9125:e63d with SMTP id af79cd13be357-9161bcec31amr573639485a.43.1781289035445; Fri, 12 Jun 2026 11:30:35 -0700 (PDT) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5ad2e161fefsm742173e87.8.2026.06.12.11.30.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Jun 2026 11:30:33 -0700 (PDT) From: Dmitry Baryshkov Date: Fri, 12 Jun 2026 21:30:18 +0300 Subject: [PATCH v6 8/9] drm: writeback: drop excess connector initialization functions Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260612-wb-drop-encoder-v6-8-9f3a54f81310@oss.qualcomm.com> References: <20260612-wb-drop-encoder-v6-0-9f3a54f81310@oss.qualcomm.com> In-Reply-To: <20260612-wb-drop-encoder-v6-0-9f3a54f81310@oss.qualcomm.com> To: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Harry Wentland , Leo Li , Rodrigo Siqueira , Alex Deucher , =?utf-8?q?Christian_K=C3=B6nig?= , Liviu Dudau , Laurent Pinchart , Tomi Valkeinen , Kieran Bingham , Geert Uytterhoeven , Magnus Damm , Dave Stevenson , =?utf-8?q?Ma=C3=ADra_Canal?= , Raspberry Pi Kernel Maintenance Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, Suraj Kandpal , Louis Chauvet X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=4480; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=6KkNpyC526rgMVIeY0D11Z3gyU75WDlgdpp2dL9pdq0=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBqLFA3jhMYBxZuTwA5P8pC0iOzIEdJ7fr70b3ui c51TlxkhXCJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCaixQNwAKCRCLPIo+Aiko 1daWB/4u2v+4zU23e3Xdhf+ZULhAcCbc7KPvw3poBWoSLMiMVcozrKDBfgSWbwSIQaYyWKcl/0G rGIMRuyDsDJ34XQRo4oLUBfA9Y2piTv49SnLjBpEXNh3YK6BuIm0hpukouPxJWhBYpFmRsmkxUr 9pjBpnGdQDBbvDbPCX5DNzKxUYzMjoaULMuQ+yqa6fDQcsAhq9BcCp6ahC6z0whUx9BrKDtpc2G 1P9N+IGrF4eJivzCB/LhONe9SJLkY9NRiNsgbfi5nJ9+n6e8uAsjeXmPXHIdw3n+aBUTb2e5vj7 kTbZwrgAuTMpFWIQ36Q0w99dnWIe2bX9Fqir8Cebzr6dyOpm X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-Spam-Info: AW1haW4tMjYwNjEyMDE3MyBTYWx0ZWRfX8lpFeicRXL8a SvJW1qZfSBiNjXFxMlikSIgG8wvxUpdhED8E+gDalQtqznBLAeS0nqWrOHQTvsfU4lJihXlKf6s Ce+kseFFLiYlrHLiYDqJMobdGyS0+GY= X-Proofpoint-GUID: 7kM4SQ9PzJr1uXxZb19ussVPnPQUjmoE X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjEyMDE3MyBTYWx0ZWRfX0kVQKSgr1fle uXnTKyaCCTRjE/oz8SQUvDhvSuzfs68iQ2RBjWa9pRwtM28an0jt44R4NYbdxIMEtpS10BE2Z5R J7xRJX9yBXI/d71Tqjd72ryglRinaokPjEAs5WVS9L0xTkeMQfdRbHyTfUIiERP5cB1JEuJyaVr mrwC7Xy0N0zZ422o13qWFhvuPkEd8NpsI9FFdJP0b0T/8VOA/1ag7KpbqVJmoNqpMD9AtGDw83k /7OMQ9mtDVzS9P3e72iFvNbjAnGXnG+HbO+411D3uTPw3HO2aJ9gXTMLV4EMuBCLL6StcmwhVfB EZTcmOmeEpKi/fWKL0HfwAKGZsx/+C96WbPt5B2land3GaifD4JE4ctqIZnC1HNix3r8GRuj36Q Pxzhw5pg47gNHMNmlsLUUJTNfrqcMMe9pEA7EqWGkC6qaYl4O0CmaT8CUoHho7+y9/JiIacDyYR +py1JugiCiyrGOek5kQ== X-Authority-Analysis: v=2.4 cv=evnvCIpX c=1 sm=1 tr=0 ts=6a2c504c cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=QyXUC8HyAAAA:8 a=P-IC7800AAAA:8 a=EUspDBNiAAAA:8 a=3owybDqXPaZAjLikVYcA:9 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 a=d3PnA9EDa4IxuAV0gXij:22 X-Proofpoint-ORIG-GUID: 7kM4SQ9PzJr1uXxZb19ussVPnPQUjmoE X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-12_02,2026-06-12_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 suspectscore=0 bulkscore=0 priorityscore=1501 phishscore=0 spamscore=0 impostorscore=0 malwarescore=0 adultscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606040000 definitions=main-2606120173 Now as all drivers have been converted to drmm_writeback_connector_init(), drop drm_writeback_connector_init() and drm_writeback_connector::encoder field, they are unused now. Reviewed-by: Suraj Kandpal Reviewed-by: Louis Chauvet Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/drm_writeback.c | 55 ----------------------------------------- include/drm/drm_writeback.h | 18 -------------- 2 files changed, 73 deletions(-) diff --git a/drivers/gpu/drm/drm_writeback.c b/drivers/gpu/drm/drm_writeback.c index 4da5d6094721..9fc15168c34f 100644 --- a/drivers/gpu/drm/drm_writeback.c +++ b/drivers/gpu/drm/drm_writeback.c @@ -142,61 +142,6 @@ static int create_writeback_properties(struct drm_device *dev) return 0; } -static const struct drm_encoder_funcs drm_writeback_encoder_funcs = { - .destroy = drm_encoder_cleanup, -}; - -/** - * drm_writeback_connector_init - Initialize a writeback connector and its properties - * @dev: DRM device - * @wb_connector: Writeback connector to initialize - * @con_funcs: Connector funcs vtable - * @enc_helper_funcs: Encoder helper funcs vtable to be used by the internal encoder - * @formats: Array of supported pixel formats for the writeback engine - * @n_formats: Length of the formats array - * @possible_crtcs: possible crtcs for the internal writeback encoder - * - * This function creates the writeback-connector-specific properties if they - * have not been already created, initializes the connector as - * type DRM_MODE_CONNECTOR_WRITEBACK, and correctly initializes the property - * values. It will also create an internal encoder associated with the - * drm_writeback_connector and set it to use the @enc_helper_funcs vtable for - * the encoder helper. - * - * Drivers should always use this function instead of drm_connector_init() to - * set up writeback connectors. - * - * Returns: 0 on success, or a negative error code - */ -int drm_writeback_connector_init(struct drm_device *dev, - struct drm_writeback_connector *wb_connector, - const struct drm_connector_funcs *con_funcs, - const struct drm_encoder_helper_funcs *enc_helper_funcs, - const u32 *formats, int n_formats, - u32 possible_crtcs) -{ - int ret = 0; - - drm_encoder_helper_add(&wb_connector->encoder, enc_helper_funcs); - - wb_connector->encoder.possible_crtcs = possible_crtcs; - - ret = drm_encoder_init(dev, &wb_connector->encoder, - &drm_writeback_encoder_funcs, - DRM_MODE_ENCODER_VIRTUAL, NULL); - if (ret) - return ret; - - ret = drm_writeback_connector_init_with_encoder(dev, wb_connector, &wb_connector->encoder, - con_funcs, formats, n_formats); - - if (ret) - drm_encoder_cleanup(&wb_connector->encoder); - - return ret; -} -EXPORT_SYMBOL(drm_writeback_connector_init); - static void delete_writeback_properties(struct drm_device *dev) { if (dev->mode_config.writeback_pixel_formats_property) { diff --git a/include/drm/drm_writeback.h b/include/drm/drm_writeback.h index c380a7b8f55a..879ca103320c 100644 --- a/include/drm/drm_writeback.h +++ b/include/drm/drm_writeback.h @@ -24,17 +24,6 @@ struct drm_writeback_connector { */ struct drm_connector base; - /** - * @encoder: Internal encoder used by the connector to fulfill - * the DRM framework requirements. The users of the - * @drm_writeback_connector control the behaviour of the @encoder - * by passing the @enc_funcs parameter to drm_writeback_connector_init() - * function. - * For users of drm_writeback_connector_init_with_encoder(), this field - * is not valid as the encoder is managed within their drivers. - */ - struct drm_encoder encoder; - /** * @pixel_formats_blob_ptr: * @@ -148,13 +137,6 @@ drm_connector_to_writeback(struct drm_connector *connector) return container_of(connector, struct drm_writeback_connector, base); } -int drm_writeback_connector_init(struct drm_device *dev, - struct drm_writeback_connector *wb_connector, - const struct drm_connector_funcs *con_funcs, - const struct drm_encoder_helper_funcs *enc_helper_funcs, - const u32 *formats, int n_formats, - u32 possible_crtcs); - int drm_writeback_connector_init_with_encoder(struct drm_device *dev, struct drm_writeback_connector *wb_connector, struct drm_encoder *enc, -- 2.47.3