From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-m32105.qiye.163.com (mail-m32105.qiye.163.com [220.197.32.105]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F1C43339B41 for ; Fri, 12 Jun 2026 03:26:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=220.197.32.105 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781234808; cv=none; b=b+3WPPgp1aC2WoqBR3944IXnVRMM4x4wx2LqOFELB1sVer3+s2o9AqMTlGrsGALnvUKKsE3OIVgzvZRfKN3xq0dWUlDGZUkwneQcUgJMGQjpbdMPclHUq1zyUM0FWjPVqGIw02UHBxrWlIVyGUg1I+y070YYwbp73lfQX2mv1qM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781234808; c=relaxed/simple; bh=u56A2RSYRfT+GeE3ZJlQaMXqLmUe4wBMdH+pYFf4YMg=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=pDSqSaxLc6ICEwVO99oCyrVWWvtQ6/SnbjkPNBLcDE13e5rGgJyJUseM82j79hqNKT0Vszt7otCK9BM7N87d3Uy1vgCI2QuDpytDZDBKD7BFYiNomLWeEEN4Kogsxuq4vvqnnjopo7on/IBnD6PeBOLuNhBIBSHnpVaCHw/pfXk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=easystack.cn; spf=pass smtp.mailfrom=easystack.cn; arc=none smtp.client-ip=220.197.32.105 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=easystack.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=easystack.cn Received: from localhost.localdomain (unknown [218.94.118.90]) by smtp.qiye.163.com (Hmail) with ESMTP id 1b583596e; Fri, 12 Jun 2026 11:11:13 +0800 (GMT+08:00) From: Zhen Ni To: Mike Rapoport , Andrew Morton Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Zhen Ni Subject: [PATCH] mm/memblock: Remove redundant pageblock_align() in free_unused_memmap() Date: Fri, 12 Jun 2026 11:11:05 +0800 Message-Id: <20260612031105.3350181-1-zhen.ni@easystack.cn> X-Mailer: git-send-email 2.20.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-HM-Tid: 0a9eb9cff0fb0229kunmc57f76532447b4 X-HM-MType: 1 X-HM-Spam-Status: e1kfGhgUHx5ZQUpXWQgPGg8OCBgUHx5ZQUlOS1dZFg8aDwILHllBWSg2Ly tZV1koWUFJQjdXWRgWCB1ZQUpXWS1ZQUlXWQ8JGhUIEh9ZQVlCSUMYVhhNTUtCThkZQx9DTVYVFA kWGhdVGRETFhoSFyQUDg9ZV1kYEgtZQVlJSkNVQk9VSkpDVUJLWVdZFhoPEhUdFFlBWU9LSFVKS0 lPT09IVUpLS1VKQktLWQY+ The assignment `prev_end = pageblock_align(end)` is redundant because `prev_end` was already aligned to pageblock oundaries inside the loop. Since pageblock_align() is a pure function, calling it again with the same input produces the same result. This line was added in commit f921f53e089a ("memblock: align freed memory map on pageblock boundaries with SPARSEMEM"). Remove it to simplify the code. Signed-off-by: Zhen Ni --- mm/memblock.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/mm/memblock.c b/mm/memblock.c index ccd43f3abb82..f50792375604 100644 --- a/mm/memblock.c +++ b/mm/memblock.c @@ -2258,10 +2258,8 @@ static void __init free_unused_memmap(void) } #ifdef CONFIG_SPARSEMEM - if (!IS_ALIGNED(prev_end, PAGES_PER_SECTION)) { - prev_end = pageblock_align(end); + if (!IS_ALIGNED(prev_end, PAGES_PER_SECTION)) free_memmap(prev_end, ALIGN(prev_end, PAGES_PER_SECTION)); - } #endif } -- 2.20.1