From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0E2353DDDAA for ; Fri, 12 Jun 2026 07:23:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781249003; cv=none; b=gs4vIFPGvMJUeK7rGCB0uFtBucEj9yfgpr+/iayr3Sx9n6nvOcFvotW9clhLFLR5weD6tdZNDr3FCnwJK2hKG18Ke51rkADW7pjmbP42UJiEr8vLSBQYylHIAGTJzIU2w3bWDESvs+pms1z9x9BaeTQzHEzPMTKzAu0i7BCu3WQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781249003; c=relaxed/simple; bh=L4IGNbM7y1d+TqDRCJgF9JoD/da1bj3QcNTtav1CsvA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=UYfNWqqoBh/g0C1nRTnrr6FlLmmpgDgWYF3eMuZ+MJw0vGxxDbTD2puVr+/LlllJHYn0GUvkm85hrjfROWu6vdoBRzINK6iwZIsIrGdMZVvoqIbXQb/hJDrJsWrApcO+5kLFS/9+XpuK2nseLc5Yts/O9XYq5wDVyUUxHEQM8SI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=bBz4Tp75; arc=none smtp.client-ip=209.85.221.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bBz4Tp75" Received: by mail-wr1-f47.google.com with SMTP id ffacd0b85a97d-45ee5cdbd28so1068619f8f.1 for ; Fri, 12 Jun 2026 00:23:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781249000; x=1781853800; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=xutruK5RfR43rmAYdiUjHl9bnTWIPbtUF5GMeFFCbOs=; b=bBz4Tp75X9vsRD/zUcOkpEb+HJHYOdgJutMZwCksCDWrXbc/6yj9Lr71IaYgwz74lc NmMFpvnuEE5SyVYmqGEJwcxl3Ol5lACPi7I6J8Uk20XyL0SmMj7VQh30T0IZzVDuxG3k p/nE/7r0WXUapFDJYm0fXQfn+bTASi4Fo4ece8aCig+neeC2js2lcTld5PPkGI63f6AJ VYrx7fBlsqGO0sOUDCV2gTp3rOaLqv8RFDPULcH1TzZmVWMFHV2Vx0hQPDB3USgDd/hR /j513fr3STQrF/kJcynm6V3VBs6mCGqHxSikoy/rpp1QtVxrou8rJsIW755AZku+XFmG g5dw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781249000; x=1781853800; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=xutruK5RfR43rmAYdiUjHl9bnTWIPbtUF5GMeFFCbOs=; b=H7J8qjuC7UVLRU2D0/1+MxFoVkAIe+le7bLb5inklUPlio6VJjpzxthWCwJkaxKYOj K9FkNmKcK3AVsm1csqvu96RsHj8+iw1BdX2Rew6/v3GJzBOjPYk0bxmGbmlHwwRIHVOB /52jj7v2PiEU61yIjOOe9I7WtYS4vtn2fou6dztGbST66eDX/7eIbUEk0+6+RxOZGRJA mEdZ+CiVOQ8VcxTnBCMNeasuWK0bif2ZQqX7uoOkp28x47GfM0kNmibj2shjbW+UXlpb AB9b/KhxELCi5zKnxdUekwvaYb0HrrwqWh+FpCi78EY4Msf7wMk99c42Rzl9YnF7wtJ0 rxlg== X-Forwarded-Encrypted: i=1; AFNElJ/PC3U/SbvAQB/S7U3UtOHqpt5IWJaNdKz4TF0OYHAwHeKFUyebE7LPxyPhi73FvBudHTovhufjqPuoK+Y=@vger.kernel.org X-Gm-Message-State: AOJu0Yx15V5ajNORMY5zVgUi21/cMR+euhloT6kxeelfD8g5LRA3R/N7 tJVk45AVNr+zdZUDNpvJDSlLArtUGMKX4X4WaxlJ7N9HeuJfR7TG/Z4X X-Gm-Gg: Acq92OGxtKEhFwRoxuwWCHNryM4EqtCbsJeBZkHSa9I15TmROMvq/FdNPePJsjoSN9m qnbD4bmUbUs5e15986qsWej6VjCbrFZamyxYu2LcvX7uWXYv5dZTm+JkE+PbpKdqWZfXxMm1Pqk 29FQL1uvTrQSG/0UAhU2L8cNHrBbgAEhVowuIKtVEFp5AdVsQKHxLgBYc+EUcjTUPlZqgt/u9o+ GgQTxk5b1MEQm/99lNtFPBB36fnaEJ5J6kdnye9gxQlGbTxH3ODopvNQyBP7gjkOU9Z3mozhaLa e4oiv9+sDLUDKuUz5ddlboYHesxHyPWZfQixp//kTf8hbU8aa17AgHLQhp+HzIcI2LD0zKPtC4y 1wVqU0f0vSPtc1xxO/24c3vIbCl+pm88iK9b7T5WlIxp2yxno2Qg/j6OejDPtJas1vJlVp/v8Xs tOdsWERqolbznUdSSV7CdWxbxN50TgGl0oE1nCB5k= X-Received: by 2002:a05:600c:3542:b0:490:b4a8:e031 with SMTP id 5b1f17b1804b1-490ec480e65mr14320715e9.4.1781249000081; Fri, 12 Jun 2026 00:23:20 -0700 (PDT) Received: from arch.localdomain ([2409:8a28:a54:e741:3a5a:3245:d3dc:4b5d]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-490ea963cf8sm28715245e9.2.2026.06.12.00.23.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Jun 2026 00:23:19 -0700 (PDT) From: Jun Yan To: Dmitry Torokhov , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: Jun Yan , linux-input@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 1/9] Input: cap11xx - clean up duplicate log and add probe error logs Date: Fri, 12 Jun 2026 15:22:07 +0800 Message-ID: <20260612072237.1177304-2-jerrysteve1101@gmail.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260612072237.1177304-1-jerrysteve1101@gmail.com> References: <20260612072237.1177304-1-jerrysteve1101@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Duplicated device detection log exists at line 537 and line 542, which brings redundant kernel print messages. Drop one redundant log entry to clean up dmesg output. Meanwhile add missing error logs when I2C communication fails during driver probe(), helping debug. Signed-off-by: Jun Yan --- drivers/input/keyboard/cap11xx.c | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/drivers/input/keyboard/cap11xx.c b/drivers/input/keyboard/cap11xx.c index 2447c1ae2166..485d8ba97723 100644 --- a/drivers/input/keyboard/cap11xx.c +++ b/drivers/input/keyboard/cap11xx.c @@ -512,7 +512,7 @@ static int cap11xx_i2c_probe(struct i2c_client *i2c_client) error = regmap_read(priv->regmap, CAP11XX_REG_PRODUCT_ID, &val); if (error) - return error; + return dev_err_probe(dev, error, "Failed to read product ID\n"); if (val != cap->product_id) { dev_err(dev, "Product ID: Got 0x%02x, expected 0x%02x\n", @@ -522,7 +522,7 @@ static int cap11xx_i2c_probe(struct i2c_client *i2c_client) error = regmap_read(priv->regmap, CAP11XX_REG_MANUFACTURER_ID, &val); if (error) - return error; + return dev_err_probe(dev, error, "Failed to read manufacturer ID\n"); if (val != CAP11XX_MANUFACTURER_ID) { dev_err(dev, "Manufacturer ID: Got 0x%02x, expected 0x%02x\n", @@ -531,11 +531,8 @@ static int cap11xx_i2c_probe(struct i2c_client *i2c_client) } error = regmap_read(priv->regmap, CAP11XX_REG_REVISION, &rev); - if (error < 0) - return error; - - dev_info(dev, "CAP11XX detected, model %s, revision 0x%02x\n", - id->name, rev); + if (error) + return dev_err_probe(dev, error, "Failed to read revision\n"); priv->model = cap; -- 2.54.0