From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f172.google.com (mail-pf1-f172.google.com [209.85.210.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D420B36654C for ; Fri, 12 Jun 2026 08:59:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781254795; cv=none; b=OAofSEk9JPYNCks+SfuUZ+MfW/LFtdIhEs6LmJRk9SlJpMpVsCUafbw8INFCwfy1uVN8abHeDKF11m3Q34AuMWPDL0U9O50chrUi9Zi38qdVGG+b9ZyoNNPcNTWMFZpXgRS41cb5NbTwErrZhnPIbP6ib3JAgmzqXB7ZUGnXWSE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781254795; c=relaxed/simple; bh=9KELg0fF52vLssDqyULifU6gVEgt2TGPTvM2ovfjH+I=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=lDGAZYVteeLzpSnaZDtPkeDoRJqQMog4Z6jUAYC6GY1BhrncG0/HIadmWLr8CAAZxNLaKg4CXlJMDifsLD4ArUVw7EajvdbXoogNlmKwyBGn3+9vV8wAc8zUwnBXNGNGrqzzJjIeDPTMHWUCraosW9PxtfKm+R4Dga25vFRnaGI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=cwrQt5Cy; arc=none smtp.client-ip=209.85.210.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="cwrQt5Cy" Received: by mail-pf1-f172.google.com with SMTP id d2e1a72fcca58-84275887a3fso1291756b3a.1 for ; Fri, 12 Jun 2026 01:59:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781254794; x=1781859594; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=9kTdniclDK6QIUDXwqEIxG+i53yHxIwhyl42LN144xs=; b=cwrQt5Cy48rJw6j8NEME6vSlVcJkPUcy7s+siaCuqjQkkEWZjhqboaOgN6W/r9t2Pl 5xGQPwVxN9zwx8whdTJHHnzxqM5qe7MW/lFAZ0UJK0hXkxovaheirgUf5hWGSV4PI/0G Ojx1/jqByRt0sJPAwrlUtEZOUYcH8I815lQnTJUhvmmddOTSS6o5/KlyDHZ0TOKwqeJS yTD//4Gdp4TqvsTtQlku8hMU/RH8cnam35uXQDPQjIz065vB0j9NgHuT20O+TzbPu4ge i9uk39ycsnJX3t5lqQbs1RIkG2npVhMEXtdRHuEMHjSH9Jf3Gk3H9xyxBjWXXIfrxgvq fibw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781254794; x=1781859594; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=9kTdniclDK6QIUDXwqEIxG+i53yHxIwhyl42LN144xs=; b=lrzh3ged/6ZZ7p/Xu3IUHRYtRFgBUBS3mxBtrmXa1htJI4AOAZkd89DW0mJsN5chAu aJyAvyLgWGqU8blK04fZ1zj/0SOYnRgGMYuTTpVAJkjP6mmwitV3IqNJFDHnXpOK5aoP HaI5Jr84hyTWSlH3EjIkRT7YmRvgwjCayD9arDSLzyhx7GPj79jqGA8g7g2KXNXH1h4y TjJ4rwOgS+GqwU+pUKvMCHeLfgQNE579RoA35JDDzX1FBKNSqWeoVEgHSjF9LiLj6hnh PsgQ/CdcISF9702nMQd2syXyylMbINSUAUiSi6gTmPPvNtaMGrrR6EgkPNBaCJDqZACv givg== X-Forwarded-Encrypted: i=1; AFNElJ+EOMXUlYL4dqo3NVi9FbL8l3YIxK0s1d7PInx8PUV3vS4ErUhalwIxYxclraVFKvZjb0jRglK3O+eBM+A=@vger.kernel.org X-Gm-Message-State: AOJu0YwtIqv7ABHLQOW9VNOLFKA6nUVJrvzAX6+Pq6kymqSNYJWlf5fQ Eub2/QlLyZetpGKTm8mKumwR3qRZZ4c2u4bunPg1tXx9GLzAMWqqMO55 X-Gm-Gg: Acq92OFv06h1gkzVfGHTGS7w/CgDCHIwjQSekv2DHoGucxnqPWUnZ5v1+82GyUZZGWZ 7zoOwco4+pyyoumzI4eUvc9sLWRH55A4m/Wb+d7DVx0HzMN+gC3taR3xIAO3xLFkVRRWDYWW5uE vPxMRBwWuXdvYRc4qfW8yjg+RBOU4EA0oOzQBopctoyjRSmVoEFLDmaZCTJf+/GNgLPvwFd+rmF RrI+53zOas6z9k1Ms9NGiRBno1oqSCASxlaFoo3df5IkGq/7nyCWHwvzK9HSAY7/gbprUCZyG4l sGnobh4RlxSUZxiuV47yLHdNv3CniMwVa3p8Vy0T5aGh2/xtAfKOW54dTVgQ34eGUmJQUfTz408 W7P3JMNCx5bkt8MSF+NESbzDEsApp8qLNjZiOfLcoxrTh+E1TlqPkygHOR+urzZL/65vYKjflsh /+sINRlqm1T4rrZ3ojyXvFwrzfsURAzbLr1dW+6o76Nzy1B1OU X-Received: by 2002:a05:6a00:14cf:b0:838:5145:c1c5 with SMTP id d2e1a72fcca58-8434974f482mr2183604b3a.21.1781254794144; Fri, 12 Jun 2026 01:59:54 -0700 (PDT) Received: from csl-conti-dell7858.ntu.edu.sg ([155.69.195.57]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-8434a934a97sm1646892b3a.0.2026.06.12.01.59.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Jun 2026 01:59:53 -0700 (PDT) From: Maoyi Xie To: "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: David Ahern , Steffen Klassert , Herbert Xu , Simon Horman , Kuniyuki Iwashima , Xiao Liang , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Maoyi Xie Subject: [PATCH net v6 2/7] net: ipip: require CAP_NET_ADMIN in the device netns for changelink Date: Fri, 12 Jun 2026 16:59:36 +0800 Message-Id: <20260612085941.3158249-3-maoyixie.tju@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260612085941.3158249-1-maoyixie.tju@gmail.com> References: <20260612085941.3158249-1-maoyixie.tju@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ipip_changelink() operates on at most two netns, dev_net(dev) and the tunnel link netns t->net. They differ once the device is created in or moved to a netns other than the one the request runs in. The rtnl changelink path checks CAP_NET_ADMIN only against dev_net(dev), so a caller privileged there but not in t->net can rewrite a tunnel that lives in t->net. Gate ipip_changelink() on rtnl_dev_link_net_capable() at its top, before any attribute is parsed. Reported-by: Xiao Liang Closes: https://lore.kernel.org/netdev/CABAhCOSzP1vaThGV35_VnsRCb=87_CPjPVsTHbq905k8A+BuUg@mail.gmail.com/ Fixes: 6c742e714d8c ("ipip: add x-netns support") Cc: stable@vger.kernel.org Signed-off-by: Maoyi Xie Reviewed-by: Kuniyuki Iwashima --- net/ipv4/ipip.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/net/ipv4/ipip.c b/net/ipv4/ipip.c index ff95b1b9908e..e7378569bd5b 100644 --- a/net/ipv4/ipip.c +++ b/net/ipv4/ipip.c @@ -494,6 +494,9 @@ static int ipip_changelink(struct net_device *dev, struct nlattr *tb[], bool collect_md; __u32 fwmark = t->fwmark; + if (!rtnl_dev_link_net_capable(dev, t->net)) + return -EPERM; + if (ip_tunnel_netlink_encap_parms(data, &ipencap)) { int err = ip_tunnel_encap_setup(t, &ipencap); -- 2.34.1