From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f181.google.com (mail-pf1-f181.google.com [209.85.210.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A994A37C0FF for ; Fri, 12 Jun 2026 09:00:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781254808; cv=none; b=kzy5HMSV/ShMNiPc1roHoAG9fqqbsnEEs0vU+cKD4nzFLr6Hn9CAfCgatYLqQvqjloXKyUu9IcgJhmM5ZauvqAqr0PFqCvfPCWgArmwQRWr26lYATDrG3h6eVUPjgE/zEjNS9P5osWxSE1iUqh1wBR6jnm9X6PHZO45kwgnxk0A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781254808; c=relaxed/simple; bh=c5Ovqn0fbu1jXKNfhzl7xwQ/WtrZQNup6EQ6zkDC9cw=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=adHQr1cuQ7KqZyv8z3oTt6wsQK/HnraHScIo4g+h8UUEquVg81RkFhhRt/m9r7WzHvqKQ/6wTW0Muttq9NzZ/I3SwZI2w5mJQKQhIhYofn/e0W1xxUsa7x/ry+fo8hFYz9KRwCuD1Idwl6YKWXe9t+GrgEYVBJf/+AXvC9JV5EI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=eLOmaGh0; arc=none smtp.client-ip=209.85.210.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="eLOmaGh0" Received: by mail-pf1-f181.google.com with SMTP id d2e1a72fcca58-842d37438d8so344897b3a.0 for ; Fri, 12 Jun 2026 02:00:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781254805; x=1781859605; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=islszk4qO02xP4bfqkbmrVfs4AwnzsoexkuUe8m8IY8=; b=eLOmaGh0jKlwz10vMJ117BuOQrJIev4xUUvsVjqv0nnSLa5folZr0isSqlyu8fGalv BhgR8zDr/jh8EIyCB1/4GZqEdWGmuqxC0TxWKyx2KkvYpnQQ4uYd51sK53fV4Z22jbRG PYMmDgLqbTkkdYLyPiiUbnpBD984AVQFs9U11W9z9PcKqK7Ig+OXXz7RPOQiJJdj6p/+ 3akW82T+DrV2ZOk2xYkwTovBSQNP6r+7nF53ihya+QMdCxlZg01ZSZt+kvYMrTgzqtut frvAweGzELedoOco9Z7rU1LPPTeb8xFM9+URZOIMXaBHU0zMZSbPQQJ1KAW0Owv+f0A0 0aoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781254805; x=1781859605; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=islszk4qO02xP4bfqkbmrVfs4AwnzsoexkuUe8m8IY8=; b=iEAytSGMPjUObGdfoIVqy/ccdX1ujr5kGisQ+80j5vdCPevTpCrhJeyMaRq3zaCUH2 Qpv3Mth6hjXAu0AAkjYMUCo0VY72KPl38b4dP76qmiqCg+iVI5AmW6pEz1Fl/CxnCnos vkld8Ouct3MCrE0BkePQuzOgpokqZnAdqfMzUomLK7LoVz+fUg9Pkv7hbf07q8Q78Zm6 lF68cGB2P3Q11/UFOVv8TiWdd+b8uR7MuTEiUffUGmM/N2VaUFqgcytJpMJhAO2RttNq L6jBTk7rIJ0oCPIxpcknDBwWhJUyKO0rL1UCmjnk3kLeTZB545Qdm96ue9QAKmrwGdT6 1hxQ== X-Forwarded-Encrypted: i=1; AFNElJ+2mDS9HQb3eTOwALMiyoKSHn/c+d11IkP9ZhiiKv5v7BEbby59Byy7hF8n0Uk+ObnNkCQ8Ht8yHEmY4cc=@vger.kernel.org X-Gm-Message-State: AOJu0YwFsMk721zcktvS2BO0AqJ6cjO123fB4eszT0/GlGIKoOiVfNrV 9kDCjMugP9DUUpcZAmOIvCUW24HnqltU1jq1TIgyHJWyyEde+2JsCMPT X-Gm-Gg: Acq92OH894+eE3HE4AczRgNH+IcY/c9tdH2C+EiZ9Eb9MIafLRjw91rucN0qiUBihUd UBnjVU+Zq7jRWbEqH/WblcLRnQAtf2Cd/Ohr1T2dcs+X33ZQZRjXyoHxKSp6ljwjvXf7vZyQF9w +8O+tqyQSKLmQExVs/44awBcqtngJJnIB5kf6vJmf/Bt4wSy3WkXwNY3Voe+VJFyQqBL49biaxd qlTOixdY1Pv9lx8OfjTcb6n/dxwx2/RYdGFTfayZ+P7omRbSPu/o1yekLmlQLrLlFuEFoUynByV /QgMPZwEy1Tc8vEakVKOILhxLZ60TO+40DEMXL1miNXW4Z/JCDCdUQiHXdYSiG9+FnupaAILDVJ m8eRiBZdYdcglH9rK4vTWEMW8e+/J3bKwLignCuIhuRuBa5ilhW+5e4Xf1AIjgzQXF71Sf6mH62 t/2f2a7osUXWcLvPKbqfH2lweDPU66xxF/GHLj9kx742SIZApt X-Received: by 2002:a05:6a00:2ea5:b0:82c:d7c4:4c5c with SMTP id d2e1a72fcca58-8434cd5cf1dmr2207276b3a.20.1781254804923; Fri, 12 Jun 2026 02:00:04 -0700 (PDT) Received: from csl-conti-dell7858.ntu.edu.sg ([155.69.195.57]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-8434a934a97sm1646892b3a.0.2026.06.12.02.00.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Jun 2026 02:00:04 -0700 (PDT) From: Maoyi Xie To: "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: David Ahern , Steffen Klassert , Herbert Xu , Simon Horman , Kuniyuki Iwashima , Xiao Liang , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Maoyi Xie Subject: [PATCH net v6 5/7] net: ip6_gre: require CAP_NET_ADMIN in the device netns for changelink Date: Fri, 12 Jun 2026 16:59:39 +0800 Message-Id: <20260612085941.3158249-6-maoyixie.tju@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260612085941.3158249-1-maoyixie.tju@gmail.com> References: <20260612085941.3158249-1-maoyixie.tju@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ip6gre_changelink() and ip6erspan_changelink() operate on at most two netns, dev_net(dev) and the tunnel link netns t->net. They differ once the device is created in or moved to a netns other than the one the request runs in. The rtnl changelink path checks CAP_NET_ADMIN only against dev_net(dev), so a caller privileged there but not in t->net can rewrite a tunnel that lives in t->net. Gate both ops on rtnl_dev_link_net_capable() at their top, before any attribute is parsed. Reported-by: Xiao Liang Closes: https://lore.kernel.org/netdev/CABAhCOSzP1vaThGV35_VnsRCb=87_CPjPVsTHbq905k8A+BuUg@mail.gmail.com/ Fixes: 690afc165bb3 ("net: ip6_gre: fix moving ip6gre between namespaces") Cc: stable@vger.kernel.org Signed-off-by: Maoyi Xie Reviewed-by: Kuniyuki Iwashima --- net/ipv6/ip6_gre.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/net/ipv6/ip6_gre.c b/net/ipv6/ip6_gre.c index 365b4059eb20..8ebc99a299c9 100644 --- a/net/ipv6/ip6_gre.c +++ b/net/ipv6/ip6_gre.c @@ -2047,6 +2047,9 @@ static int ip6gre_changelink(struct net_device *dev, struct nlattr *tb[], struct ip6gre_net *ign = net_generic(t->net, ip6gre_net_id); struct __ip6_tnl_parm p; + if (!rtnl_dev_link_net_capable(dev, t->net)) + return -EPERM; + t = ip6gre_changelink_common(dev, tb, data, &p, extack); if (IS_ERR(t)) return PTR_ERR(t); @@ -2266,6 +2269,9 @@ static int ip6erspan_changelink(struct net_device *dev, struct nlattr *tb[], struct __ip6_tnl_parm p; struct ip6gre_net *ign; + if (!rtnl_dev_link_net_capable(dev, t->net)) + return -EPERM; + ign = net_generic(t->net, ip6gre_net_id); t = ip6gre_changelink_common(dev, tb, data, &p, extack); if (IS_ERR(t)) -- 2.34.1