From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f169.google.com (mail-pf1-f169.google.com [209.85.210.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 52ED4392823 for ; Fri, 12 Jun 2026 09:00:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781254815; cv=none; b=Ko+DUcGANJItAXiLrSKuYOL6R1FUNSPdHw3YthAdrp11FgLI4LQGxV8ehMI3KNsVVR3skZFEC7wyBxhBaKJTetwnfqQ0o43MG9QpdG+vSQlg4TRNmoKseIYtGoUFadHyCjs9de7+I5e1ttr9mxwCjg6praCH/4wV6HEnlfpvClM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781254815; c=relaxed/simple; bh=b1Ef7m01SlvbqYksVxxjRq3JiNuZbQ9XJSkONcITG2c=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=hBdLdaIddXz8fvacau05JJrDNCzRpzD93Et1tQScBNhgmTlyGyUCvoDO8mqatTVR/eSij6oi8mTAYk5gbWI9smFNuPllBQifGH2eI2iNFiB1BX+dweAq2eJ/MJjMyCuNPLLBTrG5vHlQRT+wZea4WiG8K8AKUkAnkzOUo+IBHME= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=QZkss8lL; arc=none smtp.client-ip=209.85.210.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="QZkss8lL" Received: by mail-pf1-f169.google.com with SMTP id d2e1a72fcca58-8423f236418so497372b3a.1 for ; Fri, 12 Jun 2026 02:00:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781254814; x=1781859614; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=am9un3Mpyi4zgWESM9WSZJ/9n4NAc/vveWguadq2LnY=; b=QZkss8lLpfDvDlzEZwGXNm55PhIjmO7++WWkgLYn5XUZk0KIp8dMjDSCHINWGbdqSB sp0MLeujw7Lrgy58GNJsh4UJ0nwhKlL4dRnKtzvN8iEGk/57GH/IYYxOrKex9P2Qs+2f pHNWvrmQVEqAW1Jf4zGaXRf0xQRfjBHle5dC8lKGd6HZ5OEcCjzeILcEW4FQZrkqk+LX rFsb+1TAEYR9l6cp0j5p4bx5SypkJhTLjJUUX63s/t5H+1+tJWA/v9VjOov0PcTYa9bl Cok98r1R5Zm00b0RWBxMhP1KSTdEpGhvS/tWSaulRvuQA8izUHY+2sgMwhSPU/F4ZyuM y1/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781254814; x=1781859614; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=am9un3Mpyi4zgWESM9WSZJ/9n4NAc/vveWguadq2LnY=; b=iZpkdZkG2SRv00NZhxL4I2l++ppHS8z7AukYWUtF+bmgQA0ZTjARigvYc7oJFcV+Ei 9S4BuSiv1xoza7DsdRThcYXtjGrOSDc291v4LIjLmXnc9/165C5X/8mSYFMRsg/Q+0Fk Cndf/os1VW7KZx4xz/KkEW2UGZsR2jmw3ayofMyJvlVP69DxWSx13zU0U9LYRFTCJ1ix 8cVDHoznSVOXP7HjsSL9sp8HWtl1tBr0feKf6f+XglCocA84kGYG9Zoq3Q9uaAx9Qir6 6mrWcSDEr/xh1OiJtL9uyz+bcTe2mivFpQtjgxNfgjXaA2xCfDCcoTHxJ7ZSfIIK18Q9 dEQw== X-Forwarded-Encrypted: i=1; AFNElJ/+R27LUzzR+22mvAwxe3LxxrJXsS1nM3mXqQBMyoaCby9NuawCgVtG+qygtP0wKfzNyvNcDsU5smbZv8g=@vger.kernel.org X-Gm-Message-State: AOJu0YzFygWp2zCcslLTttpKOgC7z+ULP/FK+rpTsDgq4wdjr0i5IDEc QucnqGXyqijnd7z1Md9pI0l3HsAnjCYS4Z7MiNdqR9lmMqGRfxq2f/F4 X-Gm-Gg: Acq92OEGfJBgrpcDCjJllHLMyWbx0q+qCKfp7WATet3y8W16TCDhCa3p88LT3REMCHs 3Gycbz6NbnfixGwiOQ1qRJkjKf6J93Bw8nsywhRB1iLpsJA4mv0vfm6bQSgUWf0gnz74J2eO6eO Kbqvpke5QKPantyj2bymVjFMVpUestaB7DUDizzl7CLsGgjPRXvXrJvXk50DsDK/+qjBZBMNofx 6+qvrL9Hm/RVJr3ikSLfmAz8qlDvDNvEdAtYipyvN0ex2GiKiCWeFFmfqUzhe2fukdx840yQdNw xoMmhJG2sR14Bd5SPN8GZa0+RYfggxV7XQecei+obIzVW8Y+hLFprBpc81Tas8jpSXKyAqOnNNV wjJ1cBP3cjEDVUbAQXDysFIJYojjTa23Fo7/x5Cb+32dukOiL8g6wsj9HakBaRM8iiwLIPJu7aU pEoOA+3TKTvLxIzwWkXbLDF1LFEkH1mImr8roAdErphYbq2aaEQ/WHxJFxXL4= X-Received: by 2002:a05:6a00:2354:b0:835:3f51:730e with SMTP id d2e1a72fcca58-8434cd24381mr2048514b3a.13.1781254812154; Fri, 12 Jun 2026 02:00:12 -0700 (PDT) Received: from csl-conti-dell7858.ntu.edu.sg ([155.69.195.57]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-8434a934a97sm1646892b3a.0.2026.06.12.02.00.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Jun 2026 02:00:11 -0700 (PDT) From: Maoyi Xie To: "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: David Ahern , Steffen Klassert , Herbert Xu , Simon Horman , Kuniyuki Iwashima , Xiao Liang , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Maoyi Xie Subject: [PATCH net v6 7/7] xfrm: xfrm_interface: require CAP_NET_ADMIN in the device netns for changelink Date: Fri, 12 Jun 2026 16:59:41 +0800 Message-Id: <20260612085941.3158249-8-maoyixie.tju@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260612085941.3158249-1-maoyixie.tju@gmail.com> References: <20260612085941.3158249-1-maoyixie.tju@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit xfrmi_changelink() operates on at most two netns, dev_net(dev) and the interface link netns xi->net. They differ once the device is created in or moved to a netns other than the one the request runs in. The rtnl changelink path checks CAP_NET_ADMIN only against dev_net(dev), so a caller privileged there but not in xi->net can rewrite an interface that lives in xi->net. Gate xfrmi_changelink() on rtnl_dev_link_net_capable() at its top, before any attribute is parsed. Reported-by: Xiao Liang Closes: https://lore.kernel.org/netdev/CABAhCOSzP1vaThGV35_VnsRCb=87_CPjPVsTHbq905k8A+BuUg@mail.gmail.com/ Fixes: f203b76d7809 ("xfrm: Add virtual xfrm interfaces") Cc: stable@vger.kernel.org Signed-off-by: Maoyi Xie Reviewed-by: Kuniyuki Iwashima --- net/xfrm/xfrm_interface_core.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/net/xfrm/xfrm_interface_core.c b/net/xfrm/xfrm_interface_core.c index 330a05286a56..688306bf62c5 100644 --- a/net/xfrm/xfrm_interface_core.c +++ b/net/xfrm/xfrm_interface_core.c @@ -869,6 +869,9 @@ static int xfrmi_changelink(struct net_device *dev, struct nlattr *tb[], struct net *net = xi->net; struct xfrm_if_parms p = {}; + if (!rtnl_dev_link_net_capable(dev, net)) + return -EPERM; + xfrmi_netlink_parms(data, &p); if (!p.if_id) { NL_SET_ERR_MSG(extack, "if_id must be non zero"); -- 2.34.1