From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f173.google.com (mail-pf1-f173.google.com [209.85.210.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DDAE33A7F4C for ; Fri, 12 Jun 2026 09:36:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781256979; cv=none; b=LcfhFkzqo+iiDY22NPa0AANBcqmJgAMHoUZCjfWpUJzOj8PPvWbVr4qkBWroTihgs/FSF3hLRs6wXAiN88LxRVxK50396marMTfOKzn9yYSpXCQhqRH739nQqEiuKLZBxFg6XbNZuoMz3ibE5KqK37vOGpp47mll0+JX5pHy9cg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781256979; c=relaxed/simple; bh=k45LPxbi8Z+hz+KQCRHVhQ72vUfstcU7nrp/BFSgY4Y=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=YpF3j6H57Xu9SyB4rd47PddpgA826C8EOg+yBtwq9ODoMQuZN9ovDfzeTsJN/KykGOSeu2NYQu5cs/z/BoAwNNXpbOFt2HGktbD1vJaIRtK5Bh/DjfsrbneNdvsiZi5zxtE7NbSGKyoPSHYJ2qc76Wl266cIgevloHfMVoxcJ7w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Qh7wQdAT; arc=none smtp.client-ip=209.85.210.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Qh7wQdAT" Received: by mail-pf1-f173.google.com with SMTP id d2e1a72fcca58-8419ab3a297so376899b3a.2 for ; Fri, 12 Jun 2026 02:36:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781256976; x=1781861776; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=NTu7u8FS5bZuOkg5kwPhz2mwDAHKZtJNZoWMEvIIywE=; b=Qh7wQdATLyBDPJfGA69te1SsXd0G5oNfRR+fl4ND6BJziDceGGwnQyYzd68/L9W7D/ m2ClKoqgbUbXahmbpK7JFlJE2Vu2Pz16fMJw6wko2Pbw4DCDs5v/gmxaVm/jgFKTm3ih qjZYIg8gwYAk1SCc+tuJYzxDrjWxUkfzxmb9197kNM9SIXxWXHkj8w13PafqZMaHQT/+ LQPOAJBBKz9DVUmQd3nBdZprH42n2qDyu8+YuU+bINWZIS8qsQCrDWhytDnbO9Ds6W29 RRk/JrCvKGWF6DayQ2zjHitmOq3bjQm82d7RUjGpp3MTSdlgHiEan31lCn5BpZH+vIPY zaJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781256976; x=1781861776; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=NTu7u8FS5bZuOkg5kwPhz2mwDAHKZtJNZoWMEvIIywE=; b=el7FdsXkX9DZx9Xq9S6Zpz77L6QZy3rN6VHd+UDfgr3jDYeM0oHAJaswYmmmTxZ4Cm saL1ZAVUXCyFermnUv8ivDLZR0YB5bZTQ59+6ehJFd3DMQP2C28AiEbqWfGTfkdYT0mX oMjJ/If0PpTn0U0D0LON+R5xX51LenSKikPkUvYtker2INW4Lww5/GFnQbyK6nXQg9Pe c4ij7dFJmsNf/re5u9EhTPNItmRvFveTiV90TWZQKrM2/cTBtjXfYUjZlvWIrNe3OrTa gSmUgvtoBBVyGKLb6dl6aNKf4WgT0y3i2OU6Jew4npwKS9V6jtq2qt+L/je+yDaIQjjJ Tc1A== X-Forwarded-Encrypted: i=1; AFNElJ+AtmJCQw4GDewTdNdL0V4ffWxc6ihSofLoiukIqfzneZ/Y8IkWNj4kFhx8Jz8L+lIFyau5xXAoJsBioVA=@vger.kernel.org X-Gm-Message-State: AOJu0YzmSuT9pkQmGy1Cye9SQsv95V350XQa8PewgLpSwO2/vcC8Fb6o 3rFOH03XP6amGYPTdMdOL2a++livw1wrm31bRaPjy4MkfrXrondUZ9Ka X-Gm-Gg: Acq92OG4e/cCTvAotSWPHpuAlzrDjtLxy8Qg8t1P9w0wVc7pI1ZkX+va/fTRFmdtpf+ 7WZXJOx4WSbK5TOZ+iy2cCN9EGu9+lPqXRoGG6E30icynA1Y93mRq6M7tefSfEJ4Mq5tO3Asqvx TSgoLtTkYteHvs8uHGj4AkuOaw1RsXxxXpNKJp4LEcm5f3UqqrjRE4xZdjeJimVFDjnLRqdnrl4 yM9cbTsh/z77ZXDG7ycJYF6mL8GZY12aUitXQGD0nNjAdqvDn2iZXT4dnE9l2RQS93h+ALQc/KP O9rVJCH0wR7tGaYz1okcSvFriDaSy6Iod2mKg0NXqkC5Vrn7uwLdVzJjbRCUCYlTGPdfSZlanWX Gn+9VuLMMS8e71hEYp4FA7N6vDZ1S7hzEsEdppRdnHn4r/1q7lDtLk+01bLqGNn9I9YUEuqR8H0 4JIKfJOelLr5KgraHCFvQt4Es7fUo= X-Received: by 2002:a05:6a00:390b:b0:842:6004:3fb9 with SMTP id d2e1a72fcca58-8434cf0dc0cmr2208873b3a.25.1781256976020; Fri, 12 Jun 2026 02:36:16 -0700 (PDT) Received: from amd.com ([165.204.156.251]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-8434acffd04sm1701370b3a.26.2026.06.12.02.36.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Jun 2026 02:36:15 -0700 (PDT) From: Paritosh Potukuchi X-Google-Original-From: Paritosh Potukuchi To: shyam-sundar.s-k@amd.com, andi.shyti@kernel.org Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, Paritosh Potukuchi Subject: [PATCH] i2c: amd-asf: Validate firmware-reported length Date: Fri, 12 Jun 2026 09:35:02 +0000 Message-ID: <20260612093502.3805287-1-paritosh.potukuchi@amd.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The firmware may sometimes return a length greater than the allocated buffer size, which can lead to out-of-bounds access and a kernel panic. Currently, the driver does not validate the length read from firmware. Add a check to ensure the firmware-reported length stays within the bounds of the data buffer. Signed-off-by: Paritosh Potukuchi --- drivers/i2c/busses/i2c-amd-asf-plat.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/i2c/busses/i2c-amd-asf-plat.c b/drivers/i2c/busses/i2c-amd-asf-plat.c index ca45f0f23321..3d355e880d54 100644 --- a/drivers/i2c/busses/i2c-amd-asf-plat.c +++ b/drivers/i2c/busses/i2c-amd-asf-plat.c @@ -90,6 +90,9 @@ static void amd_asf_process_target(struct work_struct *work) outb_p(reg, ASFDATABNKSEL); cmd = inb_p(ASFINDEX); len = inb_p(ASFDATARWPTR); + if (len > ASF_BLOCK_MAX_BYTES) + return; + for (idx = 0; idx < len; idx++) data[idx] = inb_p(ASFINDEX); -- 2.43.0