From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A7A753806C1 for ; Fri, 12 Jun 2026 10:18:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781259523; cv=none; b=OGE37G0V957wv6YzxEsFY7fI0LId1HO/ufvtiwMj0qiBUYkHH7RvJO8iQQ6Ts6wJBlAdbflK/b7e4ZEJL2LU3gsYX24pJ5Mx5dbq1moYFbCO2XvGCzzWv6OzbWtVhgAWKnND+xqWPEPhloJDSb82mtVjanCE9PNt7H24M4ztumw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781259523; c=relaxed/simple; bh=sXKBaX6Hr2LAg4dl5TUj48KgKUHVi2a3LJ3BJOGQzPo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=RQemm1wh9iqA7a+5O5U4iWOWSzYGEnYIogQM9tcDXUzY5U/d1SXH1leaZ7iyKTOzhVQmYNEpV+nKDuAy0GjFhw2BL/S+kuTcpZTS+V1rwHgku85GQ+45f9Qofo/0msKITvI+IHYVAUql4hIYZ38WX2vB4UvV51O8vvUWc6kPV5o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=RYLDiwcL; arc=none smtp.client-ip=209.85.214.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="RYLDiwcL" Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-2c0c35980fdso7708375ad.2 for ; Fri, 12 Jun 2026 03:18:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781259522; x=1781864322; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Aiqy4XFAiFCzZrOgOwXI36fmGBpHZGsULNLcfvFZih4=; b=RYLDiwcLGiCDB+lllDpz874eluxFF6pVvnic88wd9q0lOif7sDB5dcubHX7UJFG1/z rcnO0ERssqtk3bI1u9kNLfa3cU+DmHd9mWHtmonkLh27KRwfNA1xy5AmJLm1pJGZdPUD G/I8jyqvhnS3paZYfADQ6/AboMrtg15RggB/dn0FsRt7ewwbZlyBmdKkS7NAfR/erC92 qhJ5VDlWWQvAOS1d6L5lzFL5fpSKbIztlU7AccN1gpmsV7KQl+O1Admj5LHqMPcngABg CZCps+tddCjhQ4+rJX+f+0cNVpaXc01JGARnPqYGyb/RD7Sdi5VG9z+YKyX4VIMlITu2 Ug/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781259522; x=1781864322; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Aiqy4XFAiFCzZrOgOwXI36fmGBpHZGsULNLcfvFZih4=; b=JQ4f+f95JVJbkBGiB3SEVWVhdC6pzuUiQ+UEpidZPQnhKMrjWbbLkl1/gqSqdFnlsA krwYj3BRBnp4SQm3Ic6RxqUUxv0p0CYucmUgnRcc9M0Eye0ezJQbQbcFrZA2nlpd7FYf JOHPybTlDuNlXDi/U/YeNNRmxP9/zH9VcNd5as2vSLCS5O/nh1SOetoEIbRy3BRC0/hQ J2fKw0Ycrbe6hp8Fng7ydmVYQwJDnygSyF9NO2t7p98JaX7hxx6yvSOtB38xN7lnmMHf EBq7dIzOi3NiMUjEjIU08rnEG4IpqgIchmVEfUYPf6wg+nFpIO4pkKkqKdqIXsoaf+hW sj1w== X-Forwarded-Encrypted: i=1; AFNElJ9nH0N5+66E0rt5Onb7SDcbw0BAriHSWcImX2jfB9+8kj0JmwO68A3IqJaO1Q636cGkkU9fPjZf/2+zoeU=@vger.kernel.org X-Gm-Message-State: AOJu0Yz71sbt0ihT8Rs08ATWTrqmNWkFnpQuDjMNSSz5O/72Gxk21QQr h3ceIRYJT7sjF0255uivgYDNsJwAhVWr+paOQfDRRLYOBlRLgOpR3Uxu X-Gm-Gg: Acq92OGBG5QA53UStG7diYXh/J0dPM/pfu6bMdcN9qgWe7RsrKeqvYK0bBmytEyBIUa 1Z7wW58g2EnNlWCPPld9rYdvTs2SGqmIbmI6Q9eMECADONupnBCWqbGNnw3JDjOnTNOyGg4heRL 8EIgJe9DsE3Of/a0Bsb0hOmH7vAXjhJWBTzV4K8YTDn+EDaepw4Tq0e/WTQDrOyYPcXKP9mtcv3 BEebw9USou76y0fjwGTZh33JjU7JZn+m1zelzGype8S2wTf5Bt2gG7qQiJM8U3kIYmBE7OVstL1 gT3mwruTUKc9A/EFGciA7kYib14rdV122AdeVt/WNoU5s7rH037p2gEXQSPhhdTz2wUJg5K+kNq WkOa0TqYX67STqwWTcdCrWl+sp1oyQkEzUBdI/AHaSwTydBFVpwTT5hTzdEvfTv3p+ppw+H/tuF 0AtF3IQgvY0972ze/M7ZSjKh7Df1w= X-Received: by 2002:a17:902:e84a:b0:2ba:4ad9:70f6 with SMTP id d9443c01a7336-2c412d2854fmr30667915ad.31.1781259521984; Fri, 12 Jun 2026 03:18:41 -0700 (PDT) Received: from amd.com ([165.204.156.251]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2c42f2e5374sm15113235ad.5.2026.06.12.03.18.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Jun 2026 03:18:40 -0700 (PDT) From: Paritosh Potukuchi X-Google-Original-From: Paritosh Potukuchi To: shyam-sundar.s-k@amd.com, andi.shyti@kernel.org Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, Paritosh Potukuchi Subject: [PATCH] i2c: amd-asf: Validate firmware-reported length Date: Fri, 12 Jun 2026 10:18:15 +0000 Message-ID: <20260612101815.4124804-1-paritosh.potukuchi@amd.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260612093502.3805287-1-paritosh.potukuchi@amd.com> References: <20260612093502.3805287-1-paritosh.potukuchi@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The firmware may sometimes return a length greater than the allocated buffer size, which can lead to out-of-bounds access and a kernel panic. Currently, the driver does not validate the length read from firmware. Add a check to ensure the firmware-reported length stays within the bounds of the data buffer. Fix indentation issues reported by checkpatch. Signed-off-by: Paritosh Potukuchi --- drivers/i2c/busses/i2c-amd-asf-plat.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/i2c/busses/i2c-amd-asf-plat.c b/drivers/i2c/busses/i2c-amd-asf-plat.c index ca45f0f23321..e1699da838c2 100644 --- a/drivers/i2c/busses/i2c-amd-asf-plat.c +++ b/drivers/i2c/busses/i2c-amd-asf-plat.c @@ -90,6 +90,9 @@ static void amd_asf_process_target(struct work_struct *work) outb_p(reg, ASFDATABNKSEL); cmd = inb_p(ASFINDEX); len = inb_p(ASFDATARWPTR); + if (len > ASF_BLOCK_MAX_BYTES) + return; + for (idx = 0; idx < len; idx++) data[idx] = inb_p(ASFINDEX); -- 2.43.0