From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 72491346AD5 for ; Fri, 12 Jun 2026 17:34:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781285680; cv=none; b=YdJQWjRo5K3nuMPx9VFVyBT6I4iR07QrHBvuwp2U1zWzTyDIb74y7NnouV+cgMj61n6UrLZfr2P1/J8ZGamLscUDL0xh/2g9ckCr8fcBzGeEi1MSrTklPBGaZo8G+237Bx2Mseos092hHup4lmfSGBEdSe36dP4jo9Peg265y1M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781285680; c=relaxed/simple; bh=2vXTYwKAqE8zGS6G1ooSD5BTmzZfSEZFKULV8+Xply8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=PerbaXAc8pN83ZBErB1nuQpUqwgpksNRp2CljRzfUmHNxEr5PfBtpQikAxG0BYavSnUq2qedhsc7SHExd9jbzM1SSrM45eVVSDptIkTKRlNFdLjA60rPVqsSk/+MYFu6YleOLK5C5LsamuyBqpeszzcdjPh5opR/Dq9j+/c7TAE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=Qkr48IH0; arc=none smtp.client-ip=209.85.214.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="Qkr48IH0" Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-2c0b1a48855so6145ad.0 for ; Fri, 12 Jun 2026 10:34:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1781285678; x=1781890478; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=0ifKMUC6sFpR43pSlkSu8t/hrhXmnCH8Plz+P3dkdA8=; b=Qkr48IH045JrHBYA2janwFJVYNUw0o+Jp0lglXWwwPODV3mQrfVgnvpa9xOFrJmpP0 6PpoY5HkwwNNYag2jBzmDiJJqQ18jTPiEIeJJBdjPEesAp90EhWdLJspEq8lir/PcpVy 3LJO5XtvqbHFsCt10VXQbEFVQ3DiufvpiGIezW77koOgC5VYACyi3vJExzVggVayjhjv iEkRnIqsIOjoOhhZyEpDpmSOTQDZyiUOPbP6+xK0f4CAkMAH0LP/3dQOm7NuOg1bM1+o BE57CslrMSVjFvDHgccLT2dYPYSVFu7vtFEXgl16tV4CxPNajv1rTmfhgFYU/vjnPzyP KBVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781285678; x=1781890478; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0ifKMUC6sFpR43pSlkSu8t/hrhXmnCH8Plz+P3dkdA8=; b=pF/FKoHv4/hy4Czb9wnQEqr+lj2SIYXu8cGQA+JYRSkPGMdlhK5N2Vjc7Mjhp80kAS WBsu4Nu6d+gSa/S+4GRvbMEY5Z9JrR1KkWS7eZXoAoXSNgzwqnrdP/A4MubUwtYQoYs5 qh0tbY8j2FLYAkX3whKPgkwPXwQDMCWm3Ylao5iGg0jGy7DFQz7AS7/kLjsWx7SPSAHT 0KesBbtVsYRdHzjI/0XrtTU2LCyjCAAnjImvlcmov/njhRVsk3uSjUTKhaPaChT3ctFP P1CxaCMp4AHpA13y1oyK9e43HesbVOaQkxcPe9JSina9VpYY7Us28VALKk6aOdE3NSg0 UJTw== X-Forwarded-Encrypted: i=1; AFNElJ9eJ/7Z5x03Bsj0anwskCBfb4WpqxmYpxYg7CUemX35sDvih02viqTlKwOcSA9YSyI2p0dOo+5vX/xbHK0=@vger.kernel.org X-Gm-Message-State: AOJu0YySL/NvHIzxK1bVdCRIBIJs1cyyzWVtgKqCzcFfkKkH5PFobk1N 2/Q2MUUQG/Cpbft4mBljo8tYWp+5+J6x9601Gwxz0ChVrCNTFCTWciL287C7FAvH2g== X-Gm-Gg: Acq92OFlNIIe9ApRHDTPbks45AItDora4Gbe0lRRBDOJnLG/WguYarN2qUpi523IQPL L5C5H4MRrQmV1Day9qkVe2IexLu/DsCfWYVDpWJN3vvNO1c/BmWZSoxraovMyUJuxesROcXgK3+ U99UOMIH2OZVYFDf/jhQfZ6OjO4YrFlKN6IrNx9S47C+nqb/QRZEtsR+rZO8VV8kjUgsOA4OJtu L+xYY6CKgZLZ8skEm6o+qMd/xtAJDwrZr/Jovy5CUmiViN4H1PtL4Mz15KmYAl92usRC6DxzdGk 2dFyviZg2WEUTsiNBuGRef3ngtQ4EZMtdE6u5VjvW2iMtHhN5K46YMotwbbT+M2NbxrbVLYejY/ wgs+rv3pLVNVAwPwBqOf98FlgpqR/ctYNAb5TDhslNiWNnK8MXGPhAyeY4nQ9C4bkVNFrdMUa81 xfmqE2DjEwp14pxVjMpqIPVls2nDm92tpFRsUBESOXEpyBF7XX+H71d2jrYEty X-Received: by 2002:a17:902:ea0d:b0:2bd:63cb:c5be with SMTP id d9443c01a7336-2c665175772mr102415ad.5.1781285677239; Fri, 12 Jun 2026 10:34:37 -0700 (PDT) Received: from google.com (176.13.105.34.bc.googleusercontent.com. [34.105.13.176]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2c42fbb5411sm27322505ad.32.2026.06.12.10.34.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Jun 2026 10:34:36 -0700 (PDT) Date: Fri, 12 Jun 2026 10:34:32 -0700 From: Vipin Sharma To: Pasha Tatashin Cc: rppt@kernel.org, pratyush@kernel.org, tarunsahu@google.com, skhawaja@google.com, shuah@kernel.org, dmatlack@google.com, linux-kernel@vger.kernel.org, kexec@lists.infradead.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH v2 2/2] selftests/liveupdate: Add helpers to preserve/retrieve FDs Message-ID: <20260612173145.GB40404.vipinsh@google.com> References: <20260610230909.876546-1-vipinsh@google.com> <20260610230909.876546-3-vipinsh@google.com> <178123377287.908199.15268768789704684712.b4-review@b4> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <178123377287.908199.15268768789704684712.b4-review@b4> On Fri, Jun 12, 2026 at 03:09:32AM +0000, Pasha Tatashin wrote: > On Wed, 10 Jun 2026 16:09:08 -0700, Vipin Sharma wrote: > > diff --git a/tools/testing/selftests/liveupdate/lib/liveupdate.c b/tools/testing/selftests/liveupdate/lib/liveupdate.c > > index 897c200f3845..961a732b541d 100644 > > --- a/tools/testing/selftests/liveupdate/lib/liveupdate.c > > +++ b/tools/testing/selftests/liveupdate/lib/liveupdate.c > > @@ -78,9 +78,35 @@ int luo_retrieve_session(int luo_fd, const char *name) > > return arg.fd; > > } > > > > +int luo_session_preserve_fd(int session_fd, int fd, __u64 token) > > +{ > > + struct liveupdate_session_preserve_fd arg = { > > + .size = sizeof(arg), > > + .fd = fd, > > + .token = token, > > + }; > > + > > + if (ioctl(session_fd, LIVEUPDATE_SESSION_PRESERVE_FD, &arg) < 0) > > + return -errno; > > We do not return positive values on success either, so !ioctl() would > be a tighter check, but < 0 is also acceptable. > > Reviewed-by: Pasha Tatashin I have to send v3 for other feedbacks, I will address this also in that version. Thanks!