From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f175.google.com (mail-pg1-f175.google.com [209.85.215.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D911C369D71 for ; Fri, 12 Jun 2026 18:32:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781289167; cv=none; b=XdwI/GYJ+n5TS8AhE2ZP7/XhYkGTuNlCsAgqOdIjS1UIw92tqy11S0FqtKVJbRbmVRJfICbtg/76vCo8TeS77AvYlHx8N0V5Ryt1yVujbdbZmXMAAOAAjPu1tXkvBGJE999cgLcXIyG08noHmLkVyAsV/ViELWOB1GH6QL3p4HU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781289167; c=relaxed/simple; bh=epx1EclZDUKXoGEp/BrPYosT32cPjMDCoAyA9MV0Bck=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=X+Ll/D+SspSpgkokUg9gnhclHNpOd1c0TueLpJx/+V+kqz9wt/M8dKaXFG8hbzRJHFRBFhUIH6YX7sXrusduW1CLHvqIHEMmblhQVMGubc+ETLm5i2JWCUmnk+AYVm/o59V/GasG/idrsoP9h1ZI+jP3hQUQoIMFVOGZ+cl6/WI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=dkh4sdQI; arc=none smtp.client-ip=209.85.215.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="dkh4sdQI" Received: by mail-pg1-f175.google.com with SMTP id 41be03b00d2f7-c85a2ca7bf7so578213a12.3 for ; Fri, 12 Jun 2026 11:32:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781289165; x=1781893965; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=fNWmZw1xXe1jGxvW+POZwW4xRJpp6BPX6JcDe5ZLzlk=; b=dkh4sdQI3qG5LFqK0HPpTxuRhqG+KDqv/zlOf8gymxV8zRo2ZjvemZHBD0b53+3TqO ZdG9mvnVzuKZlPRxeRgnc30VvtTfUPuBIhxgHOfQd67jobvHsmO51JARF9bfDMtWm/CZ MUOLrcG7sVgscew77kaBm4ILdav/sFNFB/BLzeR5ZCUYTCF/FOyG0LhKnaGx7sdFW3Cf DbiMm5v4PrYcbCMkFOAgyJFM61qO6+rMIYN5uYB4hdSPjjwbLLh6c/ebBR38TO9g0Cej ac19WdvLGpH/PTTMX29pYlnaeV1JNfKBk2Jj74AwDiZjkiuulX3DTEWantrgpzQRUkrm xF/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781289165; x=1781893965; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=fNWmZw1xXe1jGxvW+POZwW4xRJpp6BPX6JcDe5ZLzlk=; b=cBXFR8QW2rewUBh3Mjtg9FTaf5keLGgeVeANePhfM+6SZfbGlyx0rnuHrJSH6Wa9Jt kUSnJUM33/3MJEXAzjj5F6Td8SaZXkXBsRskrlHqQkqfYFJ2dYPlDgpYXXiB+N8nIksz pUnDn3WtiXnyXGXO/+6HD29WyAY3xqCuyuV6TPaYhBd35vHxeEvDnMFyyqVZQpbNR30i siY+lIEQKh+qpOHkBu0EejhR4IBziE+vWb5SUSuTKleSLp3b+1h2JtZFSlRq71ce00HO agIcyyPjK2Xrl6F+Lbx9opj7usjNaD9hha4LNWPxTLh2BLDRULlz1py7bpuq4IJft3Yb kEwA== X-Forwarded-Encrypted: i=1; AFNElJ+ZPmpn71yc09DFrNpW7YbGU0xKF6DKLZ0CH1s4OY3fKfB/0B1UDDb31FqYQegSU6hia4aCMAiUqQ7TcZQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yxi4RrxJ6dgiguayjGbzV9+cUB3fERiyGcMjfiH6h/hivldgPnC +CHflD6KeRedrHVk+8BA012Jdc9sHpoPqsrTP0YFA7OMP6+zVtoOs9mQJQmNVQ== X-Gm-Gg: Acq92OFjAJTaZnAoeUE4mwDW7a22/P9wzpLOqEzdbP7eGIjbUrppab7SoaQz4UcY+4j X3/QDhJeWorMeMDz/BbhYVRiCtDFgZAIcBPta1nx7ZNrvksbV8qBnoS4/PfA7vixrvCqArTK+S5 t07bjgZq0i/zN9foXnleyLqjZLQ9HqOSA+vhjCx2iE/5ELqytmBXUrO0Vjqj/seVkTwG98pLKvy 5WZSH22UrpMWa37F+l11plUsB0Y6h2Fbu6w6xkXCfWw9lfToZ/D3GZoqFa83iktA8/TNLEoSPkz 5pcQD6iC86xOxdBiLWYrhEa4jiKv69A5hjpamWZaJUt62sKmSzLALiulR1h7fRfhD1fGliqSchU WLNo/u6auGYZpPGpWpLWABWxN6GiVMxnrGvuZXR02EjGY9BGwmPtuYLkZzQOyS5Psft8jU+WWOa fQn2Nf4EQfHhK/dtI6hu+4EQiP/wWbeP9lho31R121AjbL0FGZwGQ2gGRq0HAZ6QR1/f8VXfC0Z unIf31UUhbAfOgZtu2QL29G4LVldFly0g== X-Received: by 2002:a05:6a20:939a:b0:3a2:d68d:9e78 with SMTP id adf61e73a8af0-3b783b30f96mr4974294637.4.1781289165140; Fri, 12 Jun 2026 11:32:45 -0700 (PDT) Received: from ryzen ([2601:644:8000:5b5d:a073:5e58:ab5:a167]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c8661b5b207sm2795034a12.5.2026.06.12.11.32.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Jun 2026 11:32:44 -0700 (PDT) From: Rosen Penev To: linux-ide@vger.kernel.org Cc: Damien Le Moal , Niklas Cassel , Grant Likely , Tim Yamin , Julia Lawall , Jeff Garzik , linux-kernel@vger.kernel.org (open list) Subject: [PATCHv3 0/6] ata: pata_mpc52xx: fix cleanup ordering and modernize Date: Fri, 12 Jun 2026 11:32:21 -0700 Message-ID: <20260612183227.20446-1-rosenp@gmail.com> X-Mailer: git-send-email 2.54.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Fix several lifecycle bugs in the MPC52xx ATA driver: - The BestComm task IRQ was managed by devm, creating a use-after-free and teardown inversion. Switch to non-devm request_irq/free_irq so the interrupt is unregistered before the task is freed. - The error and remove paths called irq_dispose_mapping() explicitly, duplicating the one in bcom_task_free(). Remove the redundant calls. - Replace irq_of_parse_and_map() with platform_get_irq() for proper error handling and integration with the platform device model. - Replace the open-coded of_address_to_resource()/devm_request_mem_region() /devm_ioremap() sequence with the standard helper. v3: extra sashiko fix and platform_get_irq moved. v2: add extra patch from sashiko review. Rosen Penev (6): ata: pata_mpc52xx: fix NULL pointer dereference in IRQ handler ata: pata_mpc52xx: synchronize with task IRQ before resetting DMA state ata: pata_mpc52xx: reset cached DMA direction on resume ata: pata_mpc52xx: remove redundant irq_dispose_mapping calls ata: pata_mpc52xx: convert to platform_get_irq() ata: pata_mpc52xx: convert to full devm resource management drivers/ata/pata_mpc52xx.c | 101 ++++++++++++------------------------- 1 file changed, 33 insertions(+), 68 deletions(-) -- 2.54.0