From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f177.google.com (mail-pg1-f177.google.com [209.85.215.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ED7B3379996 for ; Fri, 12 Jun 2026 18:32:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781289171; cv=none; b=MeZEPMw7+1Jt6MXpnzwi8YAcPooAv03QH7/HMnET3bujoVGDLT5nMMkYPFD5fi3vC3OWvGyQ/PuOKyf3Db+g/fktYD9KsJlI+Y1euZ/oI9gH2fXTnKO5birSTbcG5k7zP+nga34F6H6aI1Bv9FbvS9Mn9oSdHgSw7zlwbYC1pmY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781289171; c=relaxed/simple; bh=lgccTGsaibWbGYrgiSBRBT3uAGaakFBX/Csibv5T0pk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=CMsPLzkB1xrYICEW0qD2GikdStyotQbdPDl36fBXNuUp+6mnUdcJ9Se7NDpIHIk93f+03M0z4AWZEYT6Emh5mjUKgfObmr7M2Jw6Ax2ivPXO+5vSRmbT3l6tHFB8Y8sgMIjZbPP5ZBAYgqIGTZgi528xrq3Ki8qXVGA9VnXBZsY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=CTKYnTKO; arc=none smtp.client-ip=209.85.215.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CTKYnTKO" Received: by mail-pg1-f177.google.com with SMTP id 41be03b00d2f7-c8587427468so555192a12.1 for ; Fri, 12 Jun 2026 11:32:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781289168; x=1781893968; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=paVBip7d4bA/4l1GnzUS+7HmxQ3RS/Ae+nq1ju4rOJE=; b=CTKYnTKOmAZLLH8heRtBiWLLBqL8SxJ8TWaoefvJOQe+lpmfwwRBFZa7FhftZNH4H2 BxH8NWZGVQOjwGDViyWj0tTHzMO/YVV5o3alW+ChSazS2YNjVbWnxJ0dEPjS6FDd2mTS vQ7ZbxtbCgtbJahPW+r/9UaczjrysFnt//SYXnKuxvnE2bSjWe65AYNXEXHHXeoa6ovT NtjLkc++6Ce+wLF9tzjdoUd/akH6xinJAekzbimvBXOAAgYMvftUoTIn+iyUf9X/4HVS s61v1YucWbaMnRuR+Iko2LTxfBR6NmQckJkij0AUU8Vxr0W7alUbjpq8TCxFCI2nMb8o mV8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781289168; x=1781893968; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=paVBip7d4bA/4l1GnzUS+7HmxQ3RS/Ae+nq1ju4rOJE=; b=qOIYc6Zv6qv3oKiLTmFkx7V0ZDfEf9PvfnX6J8PdCrkUcLsZFo/eYrIDrUO1Ae0y9t j7N1sDu5AkyWO1GRRj3Ghb556Mm/+L64OHNa9JB4+67V/4q+JkcqWKKKMcG0/6CSkOyq wGiuJh4NBpEQB7XCs2y73wDVS20ZtOUL3Bztn9t07cKVCczBtcRQ1TMPLUvNMWTwEprp AAWz9HxK0p4Rulc6dm4ROqhiAZupNzWSy16UAbvitBzEjfP7aWHoHpAw8zrLLCzRzpKC dlGpkGgFp9DqUggXqvDv/e6NVTMovPBsB6YDqZ4qyklj7bYYxLe0hr8ZYnCVzCUxDLxS 3Mkw== X-Forwarded-Encrypted: i=1; AFNElJ8PHJUruZAAZUBz3YK417sxOFTuVgGRI5NoSG7IXe7yfDkaSziEr9nwh7jqLTAAGgj36w6g/nmcLjxef5o=@vger.kernel.org X-Gm-Message-State: AOJu0YzSKXcvDmX/8/xiFDqUVUnnCCTtDh5gmxsrxqLl1g7iXoiRVFPL Fi0Newe0/5F0honAG2Dg52cwv7wNNm4KgQlLq9E3q3xUjUOIngqCzaQg X-Gm-Gg: Acq92OFBkXfxzwW1yWuoK1INIRgZFcMpHGhsF+4Mq3wCCtvu1LNQO59Id3/qFl2uYW+ 5s6+1g8qNoKLGYsW/iI2j+vCEBwZkmAYuJlCI69VNAfeG1KFRf4jhC+kWqTLNZNF1WjbwRKj/+Q t63yp52rXbAKN+bRvFNTiyc2RTFHYmWid5qGql87NNVadycLkNxqRXhgRp61CuUN+s85v0kwzJG UtaoNmy5PgI/zZ0JgNdUuBAKzkZN9aQlVeWaBMJ7a3qNR4vVrM3GxUiUWhNIgU003/KQnDstRbY qWQcrkrLHCPRczLYogDacrwnhE8Dg/JMA8iDtzkbmXmREVAvlk2gc2Y7JiYoDQdRCm3Q4CGSvS4 J9YJ3Xxxqbjpf2ajkUAKXKSg9XhOLJD76NvdAYlCg8VOOVrf/rVKavSL2pyWOArc4AQkZbmHgMx bbOwWMZnyTksqC+6ncv/3Spl81B1T7qaf9Ou3S8UiqxISxFymsl2YfaYqwpd96IOEtPLU+hUB4k 7ToUSDAhmm81Tpnm8AlMDXrnDBl0rsLQQ== X-Received: by 2002:a05:6a21:6b0f:b0:39c:235:c5ec with SMTP id adf61e73a8af0-3b783fb3210mr4906265637.34.1781289168172; Fri, 12 Jun 2026 11:32:48 -0700 (PDT) Received: from ryzen ([2601:644:8000:5b5d:a073:5e58:ab5:a167]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c8661b5b207sm2795034a12.5.2026.06.12.11.32.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Jun 2026 11:32:47 -0700 (PDT) From: Rosen Penev To: linux-ide@vger.kernel.org Cc: Damien Le Moal , Niklas Cassel , Grant Likely , Tim Yamin , Julia Lawall , Jeff Garzik , linux-kernel@vger.kernel.org (open list) Subject: [PATCHv3 2/6] ata: pata_mpc52xx: synchronize with task IRQ before resetting DMA state Date: Fri, 12 Jun 2026 11:32:23 -0700 Message-ID: <20260612183227.20446-3-rosenp@gmail.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260612183227.20446-1-rosenp@gmail.com> References: <20260612183227.20446-1-rosenp@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit mpc52xx_bmdma_stop() calls bcom_disable() to stop the BestComm task, but an already-pending task completion IRQ can still fire and execute mpc52xx_ata_task_irq() concurrently. The handler iterates the BD ring via bcom_buffer_done()/bcom_retrieve_buffer() and writes to priv->waiting_for_dma, while bmdma_stop resets the BD ring with bcom_ata_reset_bd() and clears waiting_for_dma -- all without synchronization. Add a task_irq field to priv, store it during probe, and call synchronize_irq() after bcom_disable() and before bcom_ata_reset_bd() to ensure the handler has completed and cannot race with the BD ring reset or the waiting_for_dma clear. Assisted-by: opencode:big-pickle Signed-off-by: Rosen Penev --- drivers/ata/pata_mpc52xx.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/ata/pata_mpc52xx.c b/drivers/ata/pata_mpc52xx.c index fe445d6aaff6..72a2b677bc90 100644 --- a/drivers/ata/pata_mpc52xx.c +++ b/drivers/ata/pata_mpc52xx.c @@ -58,6 +58,7 @@ struct mpc52xx_ata_priv { /* DMA */ struct bcom_task *dmatsk; + int task_irq; const struct udmaspec *udmaspec; const struct mdmaspec *mdmaspec; int mpc52xx_ata_dma_last_write; @@ -571,6 +572,7 @@ mpc52xx_bmdma_stop(struct ata_queued_cmd *qc) struct mpc52xx_ata_priv *priv = ap->host->private_data; bcom_disable(priv->dmatsk); + synchronize_irq(priv->task_irq); bcom_ata_reset_bd(priv->dmatsk); priv->waiting_for_dma = 0; @@ -769,6 +771,7 @@ static int mpc52xx_ata_probe(struct platform_device *op) priv->dmatsk = dmatsk; task_irq = bcom_get_task_irq(dmatsk); + priv->task_irq = task_irq; rv = devm_request_irq(&op->dev, task_irq, &mpc52xx_ata_task_irq, 0, "ATA task", priv); if (rv) { -- 2.54.0