From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8AE6B2EAD15 for ; Fri, 12 Jun 2026 19:32:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781292775; cv=none; b=ih1DO+BlIMAR7EFaF7RkWsgksP4mBvH+2MOEeVsjo0/ugLx0/zfFNQeLYx9HCHcPjOZ6vF6lzl9Sy5s5JTFv8NdJHIKO88aFcyuYv92OZb51+jUj8fTVzMmxXnxYXqlE1NqIMMfYjp937d4Hz81oqq8cV7Bda/zPvSzfzrXBspk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781292775; c=relaxed/simple; bh=LeHYuo9szS41qFozUvOvQQMg2Zib78CELJoZiTfPrCE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=n9FDpPD1ZcShaKBehpscIZgTEKPRd1spLKt3ZqeLiJJuMAv3n2tTvSjjew2enWbgaraG2w7baXK65aCRoa0OGhUtUVFQdCuN0JCwRv2DKRcuqZnOM6UEJpmsJMq7kOUNF47edgmVkSiUUEuO0pm6BkJfTzX5xVNRc4bP9qW84l8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=arclwpuB; arc=none smtp.client-ip=209.85.214.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="arclwpuB" Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-2bf22c18ad3so18595ad.0 for ; Fri, 12 Jun 2026 12:32:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1781292773; x=1781897573; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=IdP+1KaTR40VhK3ScPAjSIhJkFP1yviJa4xgMjReCWw=; b=arclwpuBfPkoR+wJbtne/P7tLtc7BFQqHDSB8erAn8mjupIv5JZg7WXmBizjL2V+GW B5FqAWHcvAK1uZNjw/ub7GMOXx+GBg2kFeaXZ2C2xWrD1Jc6mghMCXHYiMV0JA/Ml44Q g+N8SndaEaJhg7jDSgyyOVBn1tMD7rlOs8mGANmcdZgThHQukzcWpoUaIgA5yQfOYKxj q35CMJUAIBK84Ipu2MclxqCfHXAtu69YQNUOHNocu4QwXMCo2Fwmp0IiXJibLQwdkel9 TFGdo6VCvJ+Vr/8lrjO/0YVA6a6zO5WyJcMUFrgJhfyo0q4f+SEX1Fn2d1wDpO1YLqAS XbbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781292773; x=1781897573; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=IdP+1KaTR40VhK3ScPAjSIhJkFP1yviJa4xgMjReCWw=; b=NhdkAwXTCYSNcy1z/pIU8xWyPuF9JZl+pbSiENrNIzSXsWVJP3fYefWMiZSCUJ8Bi8 30zZI0+fj8MD4j+3dOHijNZnjBuenlk6hwTJKd1zJweaNfG04hVT6yqnCX2v6SKwXsQ8 sf7i10BR/9nrQwedSTNQHqGuk4/8lyun4LXEOlDTcfrpsXJfrCyd1jqkWbmxpvFvjWU3 s4TQt5HViVYvPvYZ5ZbMIWjXVohUd+i1Uh5qtRGJlWz66nY39cdAADq02ax1SWdIu8Mm KHo+EBYVE4bRx+CB8dflD4cI2ZFJAUuAmsyeqm6dClPzpgtqM0RWEkHPymxD1R2EFXiz kGRw== X-Forwarded-Encrypted: i=1; AFNElJ8XDwgDe69g1x2DBgz/0nW40NTiCAh6VBqFcuqZnqpxe4OI6Iz1YhGLVS6oSyMpGJ4MJYFhQDZoLrUdJyg=@vger.kernel.org X-Gm-Message-State: AOJu0Yz58YJhUGHNQ6H+2559XTspD4m1+gJJ2aXYj/2o9OWnHiYJx06+ Gb2dsJOV7lOy6BAAdwekoA7+f8Fk9MEVEegC/1oH/VLeR8RWWwCLOCdApVvkLhUVYw== X-Gm-Gg: Acq92OFO1N1cpgT8mafdEOx3+tM/fTypxBXR6ocERPWTobMm4hk6GKWRC1UK84yWz2G r8bwHQ6ooM76HHFAAzX/abQay2NnOhF0lDzJST+hjLi85uXzdO1/vwckYtecmbDkCbm/c9hORqV 9WWxtVVUx7MieV3Vhk/cObIVsZJVgMl7J4Zt+MPS0LvLg5+JeBDt1EqPqqMHaYKAxCoSw63yDzV +Hd6uqxx5Mmk4yp+YdL1jQt46wJ3dXp4EpCrvrQxRuV6k4VWdsKiFF5flCKAlygyjKDx639LdlQ T6boHxqsx8JE/dh9cvd0+RPHZOFtqAuohP5AfBU8KB+pNyQ7tep4KV3Ke0h6nd6f/4T2QGTO/93 nMHdoXTkOUMxyJgFY0XoncGrispW/cOmK9nE+aWfR8oNcW+ugpSLXW7NKHvVPKmd2eZhzRp0dt4 /dRHSSL6SYrw1OZRopNoSJoNkW+k8vkAc2Ra7XHx2tEXkHHWaQ2QE0/WNuAxdzwuJZBhb0b2w= X-Received: by 2002:a17:902:f541:b0:2bf:2e8c:db96 with SMTP id d9443c01a7336-2c665e349c0mr9395ad.5.1781292772339; Fri, 12 Jun 2026 12:32:52 -0700 (PDT) Received: from google.com (176.13.105.34.bc.googleusercontent.com. [34.105.13.176]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2c42fbb4134sm25141365ad.30.2026.06.12.12.32.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Jun 2026 12:32:51 -0700 (PDT) Date: Fri, 12 Jun 2026 12:32:47 -0700 From: Vipin Sharma To: Pasha Tatashin Cc: rppt@kernel.org, pratyush@kernel.org, tarunsahu@google.com, skhawaja@google.com, shuah@kernel.org, dmatlack@google.com, linux-kernel@vger.kernel.org, kexec@lists.infradead.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH v2 2/2] selftests/liveupdate: Add helpers to preserve/retrieve FDs Message-ID: <20260612193000.GB232424.vipinsh@google.com> References: <20260610230909.876546-1-vipinsh@google.com> <20260610230909.876546-3-vipinsh@google.com> <178123377287.908199.15268768789704684712.b4-review@b4> <20260612173145.GB40404.vipinsh@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260612173145.GB40404.vipinsh@google.com> On Fri, Jun 12, 2026 at 10:34:32AM -0700, Vipin Sharma wrote: > On Fri, Jun 12, 2026 at 03:09:32AM +0000, Pasha Tatashin wrote: > > On Wed, 10 Jun 2026 16:09:08 -0700, Vipin Sharma wrote: > > > diff --git a/tools/testing/selftests/liveupdate/lib/liveupdate.c b/tools/testing/selftests/liveupdate/lib/liveupdate.c > > > index 897c200f3845..961a732b541d 100644 > > > --- a/tools/testing/selftests/liveupdate/lib/liveupdate.c > > > +++ b/tools/testing/selftests/liveupdate/lib/liveupdate.c > > > @@ -78,9 +78,35 @@ int luo_retrieve_session(int luo_fd, const char *name) > > > return arg.fd; > > > } > > > > > > +int luo_session_preserve_fd(int session_fd, int fd, __u64 token) > > > +{ > > > + struct liveupdate_session_preserve_fd arg = { > > > + .size = sizeof(arg), > > > + .fd = fd, > > > + .token = token, > > > + }; > > > + > > > + if (ioctl(session_fd, LIVEUPDATE_SESSION_PRESERVE_FD, &arg) < 0) > > > + return -errno; > > > > We do not return positive values on success either, so !ioctl() would > > be a tighter check, but < 0 is also acceptable. > > > > Reviewed-by: Pasha Tatashin > > I have to send v3 for other feedbacks, I will address this also in that > version. I forgot this before, other two ioctls LIVEUPDATE_IOCTL_CREATE_SESSION and LIVEUPDATE_IOCTL_RETRIEVE_SESSION are using the same pattern of checking with '< 0'. Lets keep it same, I can send a separate patch if there is a desire to use tighter check.