From: Sean Christopherson <seanjc@google.com>
To: Sean Christopherson <seanjc@google.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Vitaly Kuznetsov <vkuznets@redhat.com>
Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
Yosry Ahmed <yosry@kernel.org>, Kai Huang <kai.huang@intel.com>
Subject: [PATCH v4 00/30] KVM: x86: x86.{c,h} spring cleaning
Date: Fri, 12 Jun 2026 17:02:59 -0700 [thread overview]
Message-ID: <20260613000329.732085-1-seanjc@google.com> (raw)
It's still technically spring!
Perform spring cleaning on x86.{c,h} and asm/kvm_host.h, by adding regs.c
(the kvm_cache_regs.h => regs.h is already applied) and msrs.{c,h}, and moving
relevant code out of x86.c.
v4:
- Drop the GPR API cleanups (already applied).
- Collect more tags. [Yosry, Kai
- Chunked the x86.c => regs.c code movement into several patches, so that the
bulk move is as close to a pure move as is reasonably possible. [Yosry]
- Drop a redundant BUILD_BUG_ON() from store_regs().
- Fix various changelog goofs. [Kai]
- Fix alignment goofs in kvm_get_{,feature_}msr_index_list(). [Kai]
- Drop the defunct x86.h include from mtrr.c. [Kai]
- Fix whitespace goofs. [Kai]
- Rewrite the changelog for the bulk regs.c move to better explain why only a
tiny amount of EFER code is moved. [Yosry]
- Move "struct kvm_x86_msr_filter" and "struct kvm_x86_pmu_event_filter" to
msrs.c and pmu.c respectively. [Kai]
- Rename LDT helpers to vmx_{load,store}_ldt(), and call out that they will
hopefully be replaced by kernel helpers in the near future. [Kai]
- Drop the kvm_cpu_get_apicid() code movement (sent a separate patch to kill
it off entirely). [Kai]
- Add more detail to explain why using VALID_MASK defines outside of x86.c is
dangerous. [Yosry, Kai]
- Bury kvm_arch_interrupt_allowed() in x86.c as kvm_is_interrupt_allowed(). [Kai]
- Move kvm_find_async_pf_gfn() prototype to x86.h. [Sashiko]
v3:
- Collect more tags. [David, Binbin, Yosry]
- Use kvm_run_sync_regs_{from,to}_user() instead of kvm_run_{g,s}et_regs().
[Kai]
- Fix a variety of typos. [Binbin]
- Everything beyond patch 15...
v2:
- https://lore.kernel.org/all/20260514215355.1648463-2-seanjc@google.com
- Collect tags. [Yosry, Kai]
- Fix some truly egregious goofs. [Binbin]
- Rename kvm_cache_regs.h => regs.h, add regs.c. [Yosry, because he
complained, not because he actually suggested this :-D ]
- Drop superfluous casting/masking of e*x() usage. [Kai]
v1: https://lore.kernel.org/all/20260409235622.2052730-1-seanjc@google.com
Sean Christopherson (30):
KVM: x86: Extract REGS and SREGS runtime sync code to helpers
KVM: x86: Move get_segment_base() to regs.h, as kvm_get_segment_base()
KVM: x86: Rename __{g,s}et_sregs2() =>
kvm_x86_vcpu_ioctl_{g,s}et_sregs2()
KVM: x86: Move the bulk of register specific code from x86.c to regs.c
KVM: x86: Move local APIC specific helpers out of asm/kvm_host.h
KVM: x86: Move kvm_caps and kvm_host_values to asm/kvm_host.h
KVM: x86: Swap the include order between x86.h and mmu.h
KVM: x86: Move tdp_enabled from kvm_host.h to mmu.h
KVM: x86: Move eager_page_split to mmu.{c,h}
KVM: x86/hyperv: Eliminate an unnecessary include of x86.h in hyperv.h
KVM: x86: Move kvm_{load,put}_guest_fpu() to fpu.h
KVM: x86: Extract get/set MSR (list) ioctl logic to helpers
KVM: x86: Expose several TSC helpers via x86.h for use by MSR code
KVM: x86: Move the bulk of MSR specific code from x86.c to msrs.{c,h}
KVM: x86: Move register helper declarations from kvm_host.h => regs.h
KVM: x86: Move kvm_{g,s}et_segment() to inline helpers in regs.h
KVM: x86: Move MSR helper declarations from kvm_host.h => msrs.h
KVM: x86: Move "struct kvm_x86_msr_filter" definition to msrs.c
KVM: x86/pmu: Move "struct kvm_x86_pmu_event_filter" definition to
pmu.c
KVM: x86: Move MMU helper declarations from kvm_host.h => mmu.h
KVM: x86: Move LLDT assembly wrappers into VMX
KVM: x86: Move misc "VALID MASK" defines from kvm_host.h => x86.c
KVM: x86: Move __kvm_irq_line_state() from kvm_host.h => ioapic.h
KVM: x86: Move IRQ-related helper declarations from kvm_host.h =>
irq.h
KVM: x86: Move kvm_pv_send_ipi() declaration from kvm_host.h =>
lapic.h
KVM: x86: Don't treat interrupts as allowed just because a nested run
is pending
KVM: x86: Rework kvm_arch_interrupt_allowed() into
kvm_is_interrupt_allowed()
KVM: x86/mmu: Move kvm_arch_async_page_ready() below
kvm_tdp_page_fault()
KVM: x86/mmu: Move kvm_mmu_do_page_fault() from mmu_internal.h =>
mmu.c
KVM: x86: Move a pile of stuff from kvm_host.h => x86.h
arch/x86/include/asm/kvm_host.h | 470 +---
arch/x86/kvm/Makefile | 4 +-
arch/x86/kvm/cpuid.c | 1 +
arch/x86/kvm/fpu.h | 26 +
arch/x86/kvm/hyperv.h | 3 +-
arch/x86/kvm/ioapic.c | 1 +
arch/x86/kvm/ioapic.h | 12 +
arch/x86/kvm/irq.c | 7 +
arch/x86/kvm/irq.h | 6 +
arch/x86/kvm/lapic.h | 8 +
arch/x86/kvm/mmu.h | 90 +-
arch/x86/kvm/mmu/mmu.c | 132 +-
arch/x86/kvm/mmu/mmu_internal.h | 66 -
arch/x86/kvm/msrs.c | 2745 +++++++++++++++++++++++
arch/x86/kvm/msrs.h | 156 ++
arch/x86/kvm/mtrr.c | 2 +-
arch/x86/kvm/pmu.c | 12 +
arch/x86/kvm/regs.c | 875 ++++++++
arch/x86/kvm/regs.h | 60 +
arch/x86/kvm/svm/nested.c | 1 +
arch/x86/kvm/svm/svm.c | 6 +-
arch/x86/kvm/vmx/nested.c | 1 +
arch/x86/kvm/vmx/vmx.c | 23 +-
arch/x86/kvm/x86.c | 3709 +------------------------------
arch/x86/kvm/x86.h | 354 +--
25 files changed, 4457 insertions(+), 4313 deletions(-)
create mode 100644 arch/x86/kvm/msrs.c
create mode 100644 arch/x86/kvm/msrs.h
create mode 100644 arch/x86/kvm/regs.c
base-commit: c1f7303302927f9cbf4efedf70f0512cde168c65
--
2.54.0.1136.gdb2ca164c4-goog
next reply other threads:[~2026-06-13 0:03 UTC|newest]
Thread overview: 92+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-13 0:02 Sean Christopherson [this message]
2026-06-13 0:03 ` [PATCH v4 01/30] KVM: x86: Extract REGS and SREGS runtime sync code to helpers Sean Christopherson
2026-06-15 2:16 ` Huang, Kai
2026-06-15 5:02 ` Binbin Wu
2026-06-13 0:03 ` [PATCH v4 02/30] KVM: x86: Move get_segment_base() to regs.h, as kvm_get_segment_base() Sean Christopherson
2026-06-15 2:43 ` Huang, Kai
2026-06-15 5:03 ` Binbin Wu
2026-06-13 0:03 ` [PATCH v4 03/30] KVM: x86: Rename __{g,s}et_sregs2() => kvm_x86_vcpu_ioctl_{g,s}et_sregs2() Sean Christopherson
2026-06-15 2:46 ` Huang, Kai
2026-06-15 5:13 ` Binbin Wu
2026-06-15 15:58 ` Sean Christopherson
2026-06-13 0:03 ` [PATCH v4 04/30] KVM: x86: Move the bulk of register specific code from x86.c to regs.c Sean Christopherson
2026-06-15 5:25 ` Binbin Wu
2026-06-13 0:03 ` [PATCH v4 05/30] KVM: x86: Move local APIC specific helpers out of asm/kvm_host.h Sean Christopherson
2026-06-15 5:47 ` Binbin Wu
2026-06-15 16:06 ` Sean Christopherson
2026-06-13 0:03 ` [PATCH v4 06/30] KVM: x86: Move kvm_caps and kvm_host_values to asm/kvm_host.h Sean Christopherson
2026-06-13 9:01 ` Xiaoyao Li
2026-06-15 6:49 ` Binbin Wu
2026-06-15 16:24 ` Sean Christopherson
2026-06-16 8:18 ` Xiaoyao Li
2026-06-13 0:03 ` [PATCH v4 07/30] KVM: x86: Swap the include order between x86.h and mmu.h Sean Christopherson
2026-06-15 7:26 ` Binbin Wu
2026-06-13 0:03 ` [PATCH v4 08/30] KVM: x86: Move tdp_enabled from kvm_host.h to mmu.h Sean Christopherson
2026-06-15 7:33 ` Binbin Wu
2026-06-13 0:03 ` [PATCH v4 09/30] KVM: x86: Move eager_page_split to mmu.{c,h} Sean Christopherson
2026-06-15 7:49 ` Binbin Wu
2026-06-16 17:19 ` Sean Christopherson
2026-06-13 0:03 ` [PATCH v4 10/30] KVM: x86/hyperv: Eliminate an unnecessary include of x86.h in hyperv.h Sean Christopherson
2026-06-15 7:52 ` Binbin Wu
2026-06-13 0:03 ` [PATCH v4 11/30] KVM: x86: Move kvm_{load,put}_guest_fpu() to fpu.h Sean Christopherson
2026-06-15 8:13 ` Binbin Wu
2026-06-15 16:31 ` Sean Christopherson
2026-06-13 0:03 ` [PATCH v4 12/30] KVM: x86: Extract get/set MSR (list) ioctl logic to helpers Sean Christopherson
2026-06-15 8:30 ` Binbin Wu
2026-06-13 0:03 ` [PATCH v4 13/30] KVM: x86: Expose several TSC helpers via x86.h for use by MSR code Sean Christopherson
2026-06-13 0:03 ` [PATCH v4 14/30] KVM: x86: Move the bulk of MSR specific code from x86.c to msrs.{c,h} Sean Christopherson
2026-06-15 9:30 ` Binbin Wu
2026-06-13 0:03 ` [PATCH v4 15/30] KVM: x86: Move register helper declarations from kvm_host.h => regs.h Sean Christopherson
2026-06-16 2:15 ` Binbin Wu
2026-06-13 0:03 ` [PATCH v4 16/30] KVM: x86: Move kvm_{g,s}et_segment() to inline helpers in regs.h Sean Christopherson
2026-06-16 2:19 ` Binbin Wu
2026-06-13 0:03 ` [PATCH v4 17/30] KVM: x86: Move MSR helper declarations from kvm_host.h => msrs.h Sean Christopherson
2026-06-16 2:25 ` Binbin Wu
2026-06-13 0:03 ` [PATCH v4 18/30] KVM: x86: Move "struct kvm_x86_msr_filter" definition to msrs.c Sean Christopherson
2026-06-15 2:47 ` Huang, Kai
2026-06-16 3:12 ` Binbin Wu
2026-06-16 6:29 ` Binbin Wu
2026-06-16 7:29 ` Huang, Kai
2026-06-16 7:43 ` Binbin Wu
2026-06-16 7:46 ` Huang, Kai
2026-06-16 16:19 ` Sean Christopherson
2026-06-16 23:30 ` Huang, Kai
2026-06-16 23:45 ` Sean Christopherson
2026-06-13 0:03 ` [PATCH v4 19/30] KVM: x86/pmu: Move "struct kvm_x86_pmu_event_filter" definition to pmu.c Sean Christopherson
2026-06-15 2:48 ` Huang, Kai
2026-06-16 3:18 ` Binbin Wu
2026-06-13 0:03 ` [PATCH v4 20/30] KVM: x86: Move MMU helper declarations from kvm_host.h => mmu.h Sean Christopherson
2026-06-16 5:04 ` Binbin Wu
2026-06-13 0:03 ` [PATCH v4 21/30] KVM: x86: Move LLDT assembly wrappers into VMX Sean Christopherson
2026-06-16 6:40 ` Binbin Wu
2026-06-13 0:03 ` [PATCH v4 22/30] KVM: x86: Move misc "VALID MASK" defines from kvm_host.h => x86.c Sean Christopherson
2026-06-16 6:46 ` Binbin Wu
2026-06-13 0:03 ` [PATCH v4 23/30] KVM: x86: Move __kvm_irq_line_state() from kvm_host.h => ioapic.h Sean Christopherson
2026-06-16 6:50 ` Binbin Wu
2026-06-13 0:03 ` [PATCH v4 24/30] KVM: x86: Move IRQ-related helper declarations from kvm_host.h => irq.h Sean Christopherson
2026-06-15 11:55 ` Huang, Kai
2026-06-16 6:55 ` Binbin Wu
2026-06-13 0:03 ` [PATCH v4 25/30] KVM: x86: Move kvm_pv_send_ipi() declaration from kvm_host.h => lapic.h Sean Christopherson
2026-06-16 6:58 ` Binbin Wu
2026-06-13 0:03 ` [PATCH v4 26/30] KVM: x86: Don't treat interrupts as allowed just because a nested run is pending Sean Christopherson
2026-06-15 16:40 ` Yosry Ahmed
2026-06-15 16:43 ` Yosry Ahmed
2026-06-15 17:03 ` Sean Christopherson
2026-06-15 19:37 ` Yosry Ahmed
2026-06-15 17:26 ` Sean Christopherson
2026-06-15 19:48 ` Yosry Ahmed
2026-06-16 17:46 ` Sean Christopherson
2026-06-16 18:08 ` Yosry Ahmed
2026-06-13 0:03 ` [PATCH v4 27/30] KVM: x86: Rework kvm_arch_interrupt_allowed() into kvm_is_interrupt_allowed() Sean Christopherson
2026-06-13 0:03 ` [PATCH v4 28/30] KVM: x86/mmu: Move kvm_arch_async_page_ready() below kvm_tdp_page_fault() Sean Christopherson
2026-06-16 8:40 ` Binbin Wu
2026-06-13 0:03 ` [PATCH v4 29/30] KVM: x86/mmu: Move kvm_mmu_do_page_fault() from mmu_internal.h => mmu.c Sean Christopherson
2026-06-16 8:48 ` Binbin Wu
2026-06-13 0:03 ` [PATCH v4 30/30] KVM: x86: Move a pile of stuff from kvm_host.h => x86.h Sean Christopherson
2026-06-15 13:01 ` Huang, Kai
2026-06-15 14:23 ` Sean Christopherson
2026-06-24 12:30 ` [PATCH v4 00/30] KVM: x86: x86.{c,h} spring cleaning Paolo Bonzini
2026-06-24 12:55 ` Sean Christopherson
2026-06-24 13:00 ` Paolo Bonzini
2026-06-24 13:02 ` Sean Christopherson
2026-06-24 14:37 ` Sean Christopherson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260613000329.732085-1-seanjc@google.com \
--to=seanjc@google.com \
--cc=kai.huang@intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=vkuznets@redhat.com \
--cc=yosry@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome