From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C1A3539B481 for ; Sat, 13 Jun 2026 08:59:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781341153; cv=none; b=ShIXDjxspVyf2dJ/ouH8Jn4adHeNnu2U15ByJVYAP3YgfWkKl/Gv+si6pzI/5v8U5d5IF2RDzanmT0CMSAalxD0mctsm6w8vTA2+S5TW8ZISDeZAMvFT2VFsghZaWkEsSgwQDhRFSN3yBLfGEcX380UlodFy7UOUBOuRwSluXe0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781341153; c=relaxed/simple; bh=00clscMus6r7SEHDxIAWGdr/EK2RPZmGO8KjEBtp9RE=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=dAlPdGJwTBfWi5Lw0h3w9gE6AKKhyh4QewuwTXJ0npf8UtoAGqZkaH7Fw2iiuF6cLoBY53h75nRD/c0Mq15Mgg4tM24ZzOPBUaKN8pcwX9iHbzCR3Pv6fmkeMdCVYy0oo8+LldqHoXZhj6FRYaHgbRB/rYENsZGQ/6nNdGNHV6E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=epo6qyN8; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="epo6qyN8" Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-490afc47455so7683085e9.2 for ; Sat, 13 Jun 2026 01:59:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781341149; x=1781945949; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=qIbL4P1VbZmrGr/aVmx2oP8ImiTJmIIkN72TtfvPmNk=; b=epo6qyN8oU+51ORAgiiTONSRkvYxV5GklSAsL17j6Kr01/GBlmVl1dGA1ElLs6jy6c 1uVuw8/ca8SxP4UFPl63sfL5yKf5Vjs9v0+SYbPaqZUlW9k1sYZ+dDl9Y+p1b+yEfj+U sxa1d5U6Sgq6fqjHqMpwGs+2ggRsjC9fLcHn+n6pXQZZLPdPKd36htPR7R092nJa/ldy VS871HKVn2/BshP9pMKEZ4XHdQ9dkQ4i5aEJUMS3R0Tw+dvzxRza2Czcdu12wn6d9aF/ Gol/XTSeUG25YFgPyhbi5mv7oqIVQAJwGcf5LdynU+qRscz9XQhqTEbhMO99qSAhQRvC +JYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781341149; x=1781945949; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=qIbL4P1VbZmrGr/aVmx2oP8ImiTJmIIkN72TtfvPmNk=; b=TSWtjdRFyM1k6oYvQh3x8BytiS6Tm/ivPHpZBxmMMeXXvC1YUZ4ucwXKPND5kmDl5p vRxi0opdgzOTtmd4nad/Njltt1UQ+eR8ir31x5fmfNv+INlsc2epwsWo1eAJPqU727q4 DwuGYQxMBDQVcv3vOc375bZwYyiWugwu61vJHM0MDrH9FYzwFpRwLixZwSxJCudUlXWi T/OksU3QoPLOoASScU+RDkrsIJGeiFtzoCLPi3/VrNPRuCgrJJ0sN/FJ4H58OXHb6wYS 19ZwaBd5E97dvSZw3NmDUd/o/fbOlDHzBmt2G5H41uyJBkdmnr0/aN8k3h1Z+jTyKBrw 9W9g== X-Forwarded-Encrypted: i=1; AFNElJ/0c8Jn5obHrrYGGHnBBgFZVIbp15OWjCef4z6cdgcxLkFwC4ad4kU7Jy2EDcYXK6kqDKWsHG46JosPOxA=@vger.kernel.org X-Gm-Message-State: AOJu0Yyf7T3eiH7G3qdedXvh5TUhAioRs4oiBavm7vprAN6lyT+ZcssV mF6KLz+WdW8GWWOR7ZzNAVHbH7uYSvC0DVkEEoNYrIJtQagWsTBtaMP6 X-Gm-Gg: Acq92OHyTnkXx8YzdBFMV2wJIdgxaSROZBUw8veWXR2ALJj9NDRMD9yyiYd/WPmz9fj NLnfknSVjST1Y6U/Nc7K9BMMl0Ei4f4pL4xxkMGtsJCsyfjCKxtEHtCPlpDCiVTYUSzjgjyAArc Pl3DzmS8stGrGLZka1PB6/OHBmQ4KYSnZ64tDOnzJldXzOqNtTnl9HHt8hu/uDasczez0JT5Y1Q wHnTA75nlU3enEdAuzNLQA1A+K5N5BRTgzkXcXq0d939XAE80gh7vTYDoEXTgYw/tXuap16MS0n G5rkaYRiZEdIikwl+1iP0aDMQcPyHF+n5xg6yN1nAOVuryibeAfX9+Bw3XpUfrjI7MoO55L33Zh 1lRKcQbDIx79bR8IImPf3jEZLYn9q+XNlH3r3n+gynKunuezMqvrIpF3h9+6VW42YCSE7021CgE Hoq5/xr9j/uX5GSXYhYhbZ7HdpR3ot20HRmk4H2zCbhcTrEzcJlM3yfDE8dDD0AlUoq/N/+T5fy COPp4ftPT4PMrSYfUHIfqki3U2S0A== X-Received: by 2002:a05:600c:8b56:b0:490:b8c0:d471 with SMTP id 5b1f17b1804b1-490ec507e3cmr75280425e9.23.1781341148835; Sat, 13 Jun 2026 01:59:08 -0700 (PDT) Received: from workstation.speedport.ip (p200300d507395e7b52cb516e4912de49.dip0.t-ipconnect.de. [2003:d5:739:5e7b:52cb:516e:4912:de49]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4606f263945sm13849081f8f.8.2026.06.13.01.59.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 13 Jun 2026 01:59:08 -0700 (PDT) From: Mert Seftali To: T Pratham , Herbert Xu Cc: "David S . Miller" , Dan Carpenter , linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, Mert Seftali , kernel test robot Subject: [PATCH] crypto: ti - Use list_first_entry_or_null() in dthe_get_dev() Date: Sat, 13 Jun 2026 10:58:58 +0200 Message-ID: <20260613085858.32580-1-mertsftl@gmail.com> X-Mailer: git-send-email 2.54.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit dthe_get_dev() fetches a device from the global device list with list_first_entry() and then checks the result for NULL. However, list_first_entry() never returns NULL: on an empty list it returns a bogus pointer computed from the list head. The NULL check is therefore dead code, and an empty list would be treated as a valid entry and moved around as if it were a real device. Use list_first_entry_or_null() so the existing NULL check works as intended and an empty list is handled gracefully. Fixes: 52f641bc63a4 ("crypto: ti - Add driver for DTHE V2 AES Engine (ECB, CBC)") Reported-by: kernel test robot Reported-by: Dan Carpenter Closes: https://lore.kernel.org/r/202606111933.69GGTKxr-lkp@intel.com/ Signed-off-by: Mert Seftali --- drivers/crypto/ti/dthev2-common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/ti/dthev2-common.c b/drivers/crypto/ti/dthev2-common.c index a2ad79bec105..cc0244938267 100644 --- a/drivers/crypto/ti/dthev2-common.c +++ b/drivers/crypto/ti/dthev2-common.c @@ -40,7 +40,7 @@ struct dthe_data *dthe_get_dev(struct dthe_tfm_ctx *ctx) return ctx->dev_data; spin_lock_bh(&dthe_dev_list.lock); - dev_data = list_first_entry(&dthe_dev_list.dev_list, struct dthe_data, list); + dev_data = list_first_entry_or_null(&dthe_dev_list.dev_list, struct dthe_data, list); if (dev_data) list_move_tail(&dev_data->list, &dthe_dev_list.dev_list); spin_unlock_bh(&dthe_dev_list.lock); -- 2.54.0