From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 834DC384CE2 for ; Sat, 13 Jun 2026 09:53:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781344433; cv=none; b=goFL4r9o6M6JXZGhXf7On4KW5fabkYS6syYJi1UQZdLmNJdpF8H0GA2op2tz60icCle0jdNxWvO9SLOW7INMiU0uy2nWAH5gOmnuK4cXORfNtxRUkLMywDppkwSI0cX8KnmNuSXq9ZjZLvTHZq5deC2H7Gi2xxymBG+c42tVvAk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781344433; c=relaxed/simple; bh=qqmQu9QhFJihloVV9kpv6ZGS1lV3EON/Kf/ZG2EwbAY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=n2g/xMHdqEmAW+dJFOON716i4O3JG3+YTMqld+UiJM9If7G1ZKdS0XS7+kBmqxXMXcIdjCZSY5DTNcceQ5ki8QoQ7/vYjYZEJYgVp9M9WhSlLrKQVo+qebrtV9jONI2KM++xPye5DVYKdsNwyfMWnRQm7auHCJ0MpsXGGxNZ6ac= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=IE7wsLLK; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="IE7wsLLK" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-490be03d47bso17687395e9.0 for ; Sat, 13 Jun 2026 02:53:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781344431; x=1781949231; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=fkuHdTMnoVgs/0eBa7wSJv5oJQ1ELoL7/5JUPgvuaJA=; b=IE7wsLLKvI5taKf2UOC8wk4A1Z9+tkF8HfdZQ0W39gXrF5+CnFcIzUtvrvYKZ55f0A BXimRYqg9Wsnb/bJnMYMYyfiWBUyWWDj/cfmczcg/yyyAj6mcYJzrtumXVbs1Tqfj3l7 mjKFJtDnXn9ncH1hbkTNg6OiZ5eZFOrcDlwQ42nTYDVnTup5TxEiDhqge3NY1qFole1T 9cJXtXwC5/to5XjI4JmkBrPCGb+v3PImsidRJEPEwkF+N9nE9KB0XkYihXR82PzUbaYc ojH68u895x56iR8DXBk5X0F2n+vqtGhdZQCoVPqX/REzgFCCKF8ON5mZw2q8ztvfQK6+ aasw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781344431; x=1781949231; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=fkuHdTMnoVgs/0eBa7wSJv5oJQ1ELoL7/5JUPgvuaJA=; b=of4rEeCXv49Ru4XTTUdVX79BJv83npHF3fu+QGxBZNGtomx32upZmEZYVETNN56Fge 2v/+kuesfVO5sAeOZwJgPB5t7EVlfPNYvoysELUTQEAxZzmdjLQHDlbq+fbPoe+2UjWM 5eYp2D3VtDuG+fz5wL/swEK5IzF26dck0U7ReZzVFE3IUYPl9fD0U1lfWhxhchWHorBg nScJbD6FR/JV4r9JJHDwiCBucIPJ0+9mEludgIyqPunO8z4/psm+w2o9AwK31IqnyYNy VmG8irILJokr/MX3subz+oKBce/NIavEdGt6XHfKza6BkAtxVcAnLAYKJdNPX2GXZFyT 0idA== X-Forwarded-Encrypted: i=1; AFNElJ8dQNd6yrBMFG4yISqcHllVZvGSj6QT+5jiauin+2J3mOuyu5JkKGnQr3fbK2BB2P3ta2PGN6Yp4TROc4k=@vger.kernel.org X-Gm-Message-State: AOJu0Yxn0grVxO0TeSDRtjTHoz/brvTuyJc2ZbAfeamLMIbDnr2F/zNJ PxhYPSkOZtL1NOXCllBAQ/Ezb6mpeqwV/zUke1IaovF5nLS+4QrwjjnW X-Gm-Gg: Acq92OGCuqnZRRZulwEqSes7LQ/Ru56I0I1o4VNHq7rXBniDQVu5O+82IJNojmLcQJJ vfHK5KHm76GB+f+ClYgyrHuAmur+tBPG9s0uiL5hiCy4ggOTpaLROMJscWjZSM9nlb0rs3Vufot GELG5ERKhph4A9Sl0/R1kkw1ytfBgF8j5PnJDTVucUKP5+T9muJkwSrAUJmMofmKdR9+7L0chQD P/ng99QF5Y4oRc12QxOGleUyxb3w5d9QcSXD7FxrWS5bFthwyKFkAzE/BjAn0aa9+3nkM2lcFDj Q9x3XS5LxuUJst1MFf9M7/c2QjPMiRBkaI9zuP/YzyQNgQXd0cDMsy6OKDXeuwbYB3pphJsoAw/ kD8AI608x/nc/pinISLy157vtk0TH2PlRV6vKrONA7LQsMuDBSri35ueu4NT7Aj8YzWkco/1sf9 58WmALrKCB3IADigRIBHTF X-Received: by 2002:a05:600c:e556:20b0:490:bde3:d112 with SMTP id 5b1f17b1804b1-490ec5088b6mr57347065e9.30.1781344430713; Sat, 13 Jun 2026 02:53:50 -0700 (PDT) Received: from arch.localdomain ([2409:8a28:a54:e741::1003]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49220304180sm61050235e9.4.2026.06.13.02.53.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 13 Jun 2026 02:53:50 -0700 (PDT) From: Jun Yan To: conor@kernel.org Cc: conor+dt@kernel.org, devicetree@vger.kernel.org, dmitry.torokhov@gmail.com, jerrysteve1101@gmail.com, krzk+dt@kernel.org, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, robh@kernel.org Subject: Re: [PATCH v2 8/9] dt-bindings: input: microchip,cap11xx: Add CAP1114 support Date: Sat, 13 Jun 2026 17:53:43 +0800 Message-ID: <20260613095343.6489-1-jerrysteve1101@gmail.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260612-plethora-debatable-d00cb679277b@spud> References: <20260612-plethora-debatable-d00cb679277b@spud> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit > On Fri, Jun 12, 2026 at 03:22:14PM +0800, Jun Yan wrote: > > CAP1114 is a 14-channel capacitive touch sensor with 11 LED outputs > > and hardware reset support. > >=20 > > Add the compatible string for CAP1114, add its datasheet URL, > > update the maximum of LED channel reg, and add constraint for > > linux,keycodes. > >=20 > > Previously, the LED reg property had a default maximum of 7 for CAP1188. > > With the addition of CAP1114, the default maximum is now 11. > > An if-then constraint is added to limit the LED count for CAP1188. > >=20 > > Update description for microchip,input-threshold: CAP1114 only provides > > eight threshold entries, which does not match its total channel count. > >=20 > > CAP1114 does not support microchip,signal-guard and > > microchip,calib-sensitivity. > >=20 > > Add CAP1114 to the unsupported enum list. > >=20 > > Signed-off-by: Jun Yan > > --- > > .../bindings/input/microchip,cap11xx.yaml | 32 ++++++++++++++++++- > > 1 file changed, 31 insertions(+), 1 deletion(-) > >=20 > > diff --git a/Documentation/devicetree/bindings/input/microchip,cap11xx.ya= > ml b/Documentation/devicetree/bindings/input/microchip,cap11xx.yaml > > index 778ec6d659a8..0e9a1a8a3f3e 100644 > > --- a/Documentation/devicetree/bindings/input/microchip,cap11xx.yaml > > +++ b/Documentation/devicetree/bindings/input/microchip,cap11xx.yaml > > @@ -12,6 +12,7 @@ description: | > > =20 > > For more product information please see the links below: > > CAP1106: https://ww1.microchip.com/downloads/en/DeviceDoc/00001624B.= > pdf > > + CAP1114: https://ww1.microchip.com/downloads/en/DeviceDoc/00002444A.= > pdf > > CAP1126: https://ww1.microchip.com/downloads/en/DeviceDoc/00001623B.= > pdf > > CAP1188: https://ww1.microchip.com/downloads/en/DeviceDoc/00001620C.= > pdf > > CAP1203: https://ww1.microchip.com/downloads/en/DeviceDoc/00001572B.= > pdf > > @@ -26,6 +27,7 @@ properties: > > compatible: > > enum: > > - microchip,cap1106 > > + - microchip,cap1114 > > - microchip,cap1126 > > - microchip,cap1188 > > - microchip,cap1203 > > @@ -122,6 +124,8 @@ properties: > > is required for a touch to be registered, making the touch sensor = > less > > sensitive. > > The number of entries must correspond to the number of channels. > > + CAP1114 is an exception where channels 8~14 reuse the eighth entry= > 's > > + threshold, so counts differ. > > =20 > > microchip,calib-sensitivity: > > $ref: /schemas/types.yaml#/definitions/uint32-array > > @@ -149,7 +153,7 @@ patternProperties: > > reg: > > description: LED channel number > > minimum: 0 > > - maximum: 7 > > + maximum: 10 > > =20 > > label: true > > =20 > > @@ -178,6 +182,18 @@ allOf: > > properties: > > reset-gpios: false > > =20 > > + - if: > > + properties: > > + compatible: > > + contains: > > + enum: > > + - microchip,cap1114 > > + then: > > + properties: > > + linux,keycodes: > > + minItems: 14 > > + maxItems: 14 > > Sashiko complaint here is valid. > You need to increase the outer constraint to max 14, and only set the > min here. > Then you need to add an else that sets maxitems to 8. Thanks for the review. I'll fix this in v3. > pw-bot: changes-requested > > Cheers, > Conor.