From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A4B053E6391 for ; Sat, 13 Jun 2026 13:04:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781355870; cv=none; b=PzFLFopdpp7QTLWMgzZh7u88BEWax6NcfWjAsZYM9PLF28uZKH61nCQBmSF2wD8TBeYi4HJ9p1NUJQ1QQhMFzo/wLAwINg9thtUklHydsVynlH6/ZkgxteIETMU4ei0ulcq9CTMPX2/xp8IJ8fAT4/CY/IkP182EmO6Dqicl4PI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781355870; c=relaxed/simple; bh=8rdVy967/KIekFumWZJodjNYinOgWN/JZjf+3u7FmjE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=LbZk62DmUIJKbClZDBfDZZ9FAjiXnSJc4oXf7Xu69ldjfHLLdhJfjf5dLBpBj8/vemDbWAggd3vzaA7+i0tHKui2ZR8kACeSyICulbMBg1wl7lTKHKk3ZibefXcQOuhHyAJ3kEEz8TaZNut02tTJRmS03U0CK3sO5TJFPJRQ0eM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=n8ID2Prw; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="n8ID2Prw" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-490c0c92cffso12318325e9.2 for ; Sat, 13 Jun 2026 06:04:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781355868; x=1781960668; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=MNHff3ZA1wnEWNCHL45Ie5KO3LOfvKjTR8zIU+k8sA0=; b=n8ID2PrwDMHD33lC0HfluqTgB3sNLcduK66hgkPgk4lz3G1OV3utNhHABA4/xzHoNg /Eju2lWceIX5YLnpV2IcDjvw0zlEFSUu8LLick6NRa2htEDsdTTREC/j1PsNGr87Cfu9 JjBoskdoWPdv6jcu2TSMHmDHd0eLCzCqgX5drNOWuD3CgZRjDF0FsJQT7cAmv8nIsIDU 6KHCDGrPry4mXvXlUKtp9bsXE7JTDSQjSeg5Y3jSasWoKwuRvt+JiXIihqFrNkmG9M/K mzBgeE0sBFZI5FXrA/v/s5urL3BOjqXlZ8Uqh2maEBPIpZbC7qt4rGEr/0d2DtaijB0Q mvIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781355868; x=1781960668; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=MNHff3ZA1wnEWNCHL45Ie5KO3LOfvKjTR8zIU+k8sA0=; b=NJzVB+XALHBPgQUi0eD+GS10TuVVJsabDqnfT1UX8nyXFB2AjZ+RRzxVeYg7gwWY8U kjNGj0oGLksO81M/S3B+2NE87KHKJfU0OaCHvVLK+PEJevNYk6J1KUqgz1w/wldED+kp Lb4DAuOLKCNLXlqCg5CumTC2SELnP2iFAo1c604GjljlF3gDiUjdRZWwstbNAQKDre1p Or9Npixohh8xgTD2jPs2A7LL7HbBkQFaEPj+fwFIuxx8nxvbxAOUbM9e1OZxa94WZBql vDBfPl8EctvY9HSn3QVV2QDD3w+QjQ/8AHmk8auPCkM+B596Jo796bjAdAAi9jzEoaSB mwdw== X-Forwarded-Encrypted: i=1; AFNElJ877xZ6y1XDp4JEt/eyAeiTUZCfEie0v54bR3wcnFnqo26cTWbL5yNBt7cZ8BFo0oa9URSi7Gb0mxf+9bE=@vger.kernel.org X-Gm-Message-State: AOJu0YxwHmGS+a206YaJ4qfmvklu0wU548DPKCnEHZ4zY+Fn6nnOvH74 I/oBuUCNK2TdVE/tDs6DJngYpeNRiNjmYxLDBYYBW1IuxM4hj555Y8E= X-Gm-Gg: Acq92OHEEUlDdmdgw4dw2CjcwHmPqV/uZu2kZ2sujeWHzC/gQlYpaOvmbO17own3VOu exu4h+X/Q0Ew45MtrpTprWb9dHakQkOAVIJLG2aHhURo2CIW3N1wJ1r2q3iLZt19B+FqbfSRgyf 8nHkHHZyE7K5NgFV+/uf65vler8UUKswjSSzukVWTlp7nwql4FTi0JfDL35hYl/VR9RrkVGXWFU Go4CA3+H+SvsQ5yto1tUIwbziFQbGiah8OW6HWcPxPjsTugPET6Lvi2b5GVf2fzrSVGLfXLvhV3 t/+0X3YK0yhVUGlGRfA5zh7hyd5iTsV7ySNWrkKeMK1gO4GVUtV6FVXRgX2h4MVTOE1GZ69pjUt pcgAY/f3Ntmhfhev/kauBNm9Esc39zw7FhZ9IH0YXP2JknDDK7IugcPzTX2kj6uVIsciIJty9hr Iv2U5nk++uUz3q5TXUrXwGwJUL+6xhyuvWtIkTJFu5xyOk4j+4F5ptIBhsAQDKEDxgm/komZdV8 n9/WLasWakAePJ8/6raYZj3f5oLKw== X-Received: by 2002:a05:600d:8489:20b0:490:b724:507d with SMTP id 5b1f17b1804b1-490ec4cec11mr64189855e9.11.1781355867847; Sat, 13 Jun 2026 06:04:27 -0700 (PDT) Received: from hp-ubuntu.. ([41.140.217.91]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-492203c0801sm66259515e9.10.2026.06.13.06.04.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 13 Jun 2026 06:04:27 -0700 (PDT) From: Mohammed EL Kadiri To: jarkko@kernel.org, dhowells@redhat.com Cc: paul@paul-moore.com, jmorris@namei.org, serge@hallyn.com, kees@kernel.org, keyrings@vger.kernel.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org, Mohammed EL Kadiri Subject: [PATCH 1/2] keys: request_key: replace BUG with return -EINVAL Date: Sat, 13 Jun 2026 14:04:07 +0100 Message-ID: <20260613130408.13709-2-med08elkadiri@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260613130408.13709-1-med08elkadiri@gmail.com> References: <20260613130408.13709-1-med08elkadiri@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Replace BUG() in construct_get_dest_keyring() default case with return -EINVAL to handle the unimplemented group keyring destination gracefully. Signed-off-by: Mohammed EL Kadiri --- security/keys/request_key.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/security/keys/request_key.c b/security/keys/request_key.c index a7673ad86d18..fa2bb9f2f538 100644 --- a/security/keys/request_key.c +++ b/security/keys/request_key.c @@ -332,7 +332,7 @@ static int construct_get_dest_keyring(struct key **_dest_keyring) case KEY_REQKEY_DEFL_GROUP_KEYRING: default: - BUG(); + return -EINVAL; } /* -- 2.43.0