From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f169.google.com (mail-pf1-f169.google.com [209.85.210.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AFBA137AA9A for ; Sat, 13 Jun 2026 13:07:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781356065; cv=none; b=D+NTqjJhfyUmnpcEKO+vn5uMbIQ1jLI7YoeiaZAH8HKI+GwEUStDXBzzTDOH2wilMuswDCl4kreQYTZetcO7rDBIAiuAYejK56XTWxZUDarx9NlT5iwxgwodWgADdEvDtlSM5Xkv42kMBnH7H2IIwddYLQVAtmjETYZpw0DYCnU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781356065; c=relaxed/simple; bh=GmZ7hlNwqfSz0MCKgoapjDySSeXK8lsX46ODhl/JuJ0=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=V0hhwNdcTI11XHDdceYWHTurUSItaCHkxmNFLOUozNmTE4nKjhicAQQX7ktOoJj+wsBEIDWFg0ewz+1auw3ofwFLLVwvsabaY4a5gKXd9ZLqx7I973e6+vRsiWTluVGMVcds/u2ESIv1hp+Uy4JZqzl8ZLkUSyWcjEtFx1MCVRA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=PwjOymvQ; arc=none smtp.client-ip=209.85.210.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="PwjOymvQ" Received: by mail-pf1-f169.google.com with SMTP id d2e1a72fcca58-8423f52af13so1506658b3a.2 for ; Sat, 13 Jun 2026 06:07:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781356061; x=1781960861; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=bnqfJc9uIWxjcaXjEbkB/bV1HAo7jhd4Hq3fcqX/0Z4=; b=PwjOymvQ2D6iRq3zwYxwpArtAag2Bo9C8BPj0Zw2B3v8UWr5egbbIzK/kpFHK9YqPd cBm3w4bi6BH7km1Vazk7Cmn4TrS+b566gSO4zXZecA3x9WFhE/hdeXzgJ/JaBdEygWfc 0GLNalt5sbtdaaytYOCXig7/9RkOs2xhIpEB+DZ92ndl2qzx161gmgj35FkuuB4/VK3Z R/TYVhCJX9q6IVCFrABGykFdtdCnKYj2JFT0F/F8OaZEWd2Wn4x2q9etIMBy0YWyk9QR CzoPhHQgSfXYXAO/8Jj1I2Xx+589vt0mJn3yRFJvc7EcdFJ9S9AWeJUEMzhy7nn1SFAW DhQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781356061; x=1781960861; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=bnqfJc9uIWxjcaXjEbkB/bV1HAo7jhd4Hq3fcqX/0Z4=; b=XHFTeCmIPuZyZXvChDJUZtLDAmfmQUDYUmBL/Aqtq3fuAOZ4pjt1Z7vifHXRPe6kq1 f7DznVumFOBkNn4rtBoMHILkxGnJdjjlC5QIbgPgSxfnOzEDo6TfHuGL7ObY4WkmVsOi Acx/TJJa9wVKyXcKHSwMMAORMlwhNeZAfvzT/hovCLBHd6mttJwmVn1NbtYTQgDKmKHc fQDgqG6FqZtRJW8+YScUZzAz/RQ/4/NTTNmySceso59xvSvarGOOH5IK8aHSr3PaiIS4 9IswzQf8gcMgNg0sSxZnTtTrJGgN7ztHmjIdLn+xg7vCNljMO80FMJoRckVBCJiFVbEX 16CQ== X-Forwarded-Encrypted: i=1; AFNElJ83hZKHZx53Z7QIVDJeH1RA+fm6dqpZpOpwobvszBH9e53kggAIvh7c7+moVCq26VqhGlPZoOoycmbpQ5I=@vger.kernel.org X-Gm-Message-State: AOJu0YxrQwjk8LfkBLXZMWiGnNo0XIhVe4LEoa2IApL7oG3tyZf9bXPq Ks4N073k4qLPszmoG0SRh4W/CgZZFyJ4bB666xZC3chxm61CVqLmj0Ww X-Gm-Gg: Acq92OGMgjYsrA7Ki2NewELAkR/rb60LsuIGNQl5+5cc5T25QH4aFuQiKGkK+QkYaqq 8/B5O4DxuLMe+LP8w6nJXQtNUYOUFRpgGZCBLPZdfghYNo3jYKehPKCJUQHKhQuutkAlpBEvom4 XG4a12mKCjMC+6vojwfa1uM9sxuV0+/+CeiHysUvwr8NmA8YqGAnZ2DYkhhfTsKb/3AF4SbbMch kH0TfDkwO11NJwlUkhq60ODl1rOynFPk/YzL+RmFhcqosaMmXefOJeuCE1c33TSvi7IrOHXuBWA MwSIvbXiDUXIZOSw/k8cudd55W+1f041mfDiGCQLt/m58Lnp8lWXOYh7Jr3sTb73qZJ/uwoQEct xsXeGtSw5xH2mQWWkuQzHRbq5FFegyPVozuzg82+8Z0/GNTt5f9n+GmfHyDNQZE5eMiJTMsYwrX j5ottWr36Nd5/idvRIOSu8fPQK9RhW/Jl7D6NqxpQLBPPRzpz/H+pyKDRk925ASlE= X-Received: by 2002:a05:6a00:1f04:b0:83d:b0a0:90e3 with SMTP id d2e1a72fcca58-844e1a625ebmr3798522b3a.31.1781356060870; Sat, 13 Jun 2026 06:07:40 -0700 (PDT) Received: from localhost.localdomain ([49.207.217.37]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-8434b009e67sm6021995b3a.42.2026.06.13.06.07.38 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sat, 13 Jun 2026 06:07:40 -0700 (PDT) From: Biren Pandya To: Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Biren Pandya Subject: [PATCH] media: i2c: ov772x: fix memory leak in probe error path Date: Sat, 13 Jun 2026 18:37:34 +0530 Message-ID: <20260613130734.68983-1-birenpandya@gmail.com> X-Mailer: git-send-email 2.50.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit If ov772x_parse_dt() fails, the probe function branches to error_clk_put, which does not put the powerdown GPIO, leading to a memory leak. Branch to error_gpio_put instead. Signed-off-by: Biren Pandya --- drivers/media/i2c/ov772x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/i2c/ov772x.c b/drivers/media/i2c/ov772x.c index 062e102..2643a84 100644 --- a/drivers/media/i2c/ov772x.c +++ b/drivers/media/i2c/ov772x.c @@ -1496,7 +1496,7 @@ static int ov772x_probe(struct i2c_client *client) ret = ov772x_parse_dt(client, priv); if (ret) - goto error_clk_put; + goto error_gpio_put; ret = ov772x_video_probe(priv); if (ret < 0) -- 2.50.1 (Apple Git-155)