From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D47292F3C3D for ; Sat, 13 Jun 2026 13:23:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781356995; cv=none; b=aA1kd1DfqhuavoWyX16ssN+69ysdy8IUFyeqyDmkI2ABFdnSaa2nxvqP9nhhdD6a6JRPKqUpMpd048tlwEX8w4d0D5DpYbndISE2Qm7QrnyfeiBJxXkd18JwokypzENOoSeniKK+gIsM8RlsefbQI0yuP2+gJ5e1XraCozJuH3E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781356995; c=relaxed/simple; bh=latppLkXW+Z9Eii9nMQdTqCwSMkjVFnaKbnuHoAVXNg=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=OI6Wr3x4S4ywsOHur3hqrAHIktgOnRQuq3DtNWjpxh9dQiXzaJBpkwczT2eOLUL07hjSTEtuhE2JSGTbuI6T8OyhPsMPt/7q/KS/CL29+BIcZ7Mm6Y287Ao/s8MVR2J/Nmg80d+6xo3zGOPY3E5jbjgQkiftXekDKxEC52b+bL4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=G95o7wOt; arc=none smtp.client-ip=209.85.214.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="G95o7wOt" Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-2c0c2c7d45eso17288115ad.1 for ; Sat, 13 Jun 2026 06:23:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781356994; x=1781961794; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=nh5EVU6hXhADCRgNUvrfU8TEsVskYZBUVfjSVvb7e7c=; b=G95o7wOtVHkNyyZe7WvBjM1kWFMjpkNInWDFQF8sEqNLjA42rO/MpqGcPxZXK5hARz FMCwUmr2bIN7a0DY/Dp7dMWGdD3dqWTILiHzN15U7t+BFt1bmpRZq7PZLaJgU862c7hf 3rjoZRZp++sQbTMCKchnt5fJIkKT9+/jNKhK+u1GkCOUgsHa2BHGUgs7ulbzGDEj7Tq1 NKAG04O8mpJZJbIxDPTM4PZM1YajoXJltEGiuU5szXvgc8GTgFss70E0FNvEMgCsEqBM qN8FqgHTGvj4A9ghaqvMcn0lDzvefjdCVS4+Eb7ZvcGzA5AX+qRacvVX8ixhMwO3c331 vpQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781356994; x=1781961794; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=nh5EVU6hXhADCRgNUvrfU8TEsVskYZBUVfjSVvb7e7c=; b=Ea4hngI1yP105E3RRhitVPcLJODHMvEaPktrzKu+6rfkAkFejzJLSZdezqWyHtNpuo /A5f2nAYZgDWWPgbI9sfocmamkAffkYeijFTmqlVbucoc06bRylEp3JB+m+utWYTg43s U2BssEHCSjfF6jEMsxj17zR9OkpJPI6/DL7dXEK50XQUKdYXhH5nrjpd1kieTwNC0ZfM VxSprQ8/sgGerluiLWZKDY+2NWHoFLCwaTKWBoyEli1M2m7VDS0cWh13ZX1HAYBrYT6Y kaxNqV4H0ticwfNW0SGji5t4tw3mCmP+sttwAUKnFu4uxsjSEbsDiHRA0BwSzz7hzDJx f3ng== X-Forwarded-Encrypted: i=1; AFNElJ8fZ0HhnVQxDAPsObLxc4e1mSMXgh1M8k/hFRLrqTvCP4fYDZrp79LQf49s9f3EvN8spQWsqMmQGml7FuU=@vger.kernel.org X-Gm-Message-State: AOJu0YyRUJ2p7TvXkK5ewdmDa9sAGlqy+hX+yMkW9IGM3ydlVJTOYFVN FHvBvKFYTOKCuJMi9r3TTzauWTQY57LIb+99BN3JBaObeFRClrpDyBr4 X-Gm-Gg: Acq92OEjYqHGeFmVPnQhZ+PPXnP68gF4djZUH0GsAqxPlZARDznmlzdzGAYRD8Nf8E3 iy9d+kz9TtaBaIi5bPDaAO0af4YLIz2FhRrkhxz9D6ldv/Xv3X5nDk/VRcMZeL63O11HLt6fy9Q x0r4KUi0e+/Wc7hP+mz2HTNh0gTJqmXRH2xDT/FlXMYIQiy18yHfnQPizso/ZyE5g1o9WxBqRK2 i7CnOenEOEOknYEVtc9j0fHYaqXHgDIL/QslJ06VbzCCu40IC+JJAvKISiu0k4U+bje2UCxwTRH 5ef2oGyx2txdwhzEA5ucwXwb3kZoreV9xKgODwSfMTdDLt2h4z8c3bFzbv2nvpgu8oH0mGa+rce oO9VE8dHxEnZX6fOLtL2FUjQkRGvREEv+R19lZlSe6RPMzfuveCw5CLfLkfNkxzgL6Z9F77MplZ ngSdw9RvQdoJq7ZGskqGH9m9xhPMYarMg5Bhv5zq9h0So6hw3huRDd X-Received: by 2002:a17:902:e84a:b0:2ba:4ad9:70f6 with SMTP id d9443c01a7336-2c412d2854fmr89259485ad.31.1781356994078; Sat, 13 Jun 2026 06:23:14 -0700 (PDT) Received: from localhost.localdomain ([49.207.217.37]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2c42fbb50fbsm48323475ad.34.2026.06.13.06.23.09 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sat, 13 Jun 2026 06:23:12 -0700 (PDT) From: Biren Pandya To: Jacopo Mondi , Sakari Ailus Cc: Mauro Carvalho Chehab , Laurent Pinchart , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Biren Pandya Subject: [PATCH] media: i2c: rdacm21: Fix missing media_entity_cleanup() Date: Sat, 13 Jun 2026 18:53:06 +0530 Message-ID: <20260613132306.69394-1-birenpandya@gmail.com> X-Mailer: git-send-email 2.50.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit If v4l2_async_register_subdev() fails, or if rdacm21_probe() hits any other error after media_entity_pads_init() is called, the media entity is left uncleaned, potentially leaking resources or leaving it in an invalid state. Similarly, the remove path misses the cleanup. Add media_entity_cleanup() to both the error path in rdacm21_probe() and the rdacm21_remove() function to ensure proper resource release. Fixes: a59f853b3b4b ("media: i2c: Add driver for RDACM21 camera module") --- drivers/media/i2c/rdacm21.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/media/i2c/rdacm21.c b/drivers/media/i2c/rdacm21.c index bcab462..26088eb 100644 --- a/drivers/media/i2c/rdacm21.c +++ b/drivers/media/i2c/rdacm21.c @@ -595,6 +595,7 @@ static int rdacm21_probe(struct i2c_client *client) error_free_ctrls: v4l2_ctrl_handler_free(&dev->ctrls); error: + media_entity_cleanup(&dev->sd.entity); i2c_unregister_device(dev->isp); return ret; @@ -606,6 +607,7 @@ static void rdacm21_remove(struct i2c_client *client) v4l2_async_unregister_subdev(&dev->sd); v4l2_ctrl_handler_free(&dev->ctrls); + media_entity_cleanup(&dev->sd.entity); i2c_unregister_device(dev->isp); } -- 2.50.1 (Apple Git-155)