From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CDF2A18872A for ; Sun, 14 Jun 2026 01:29:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781400577; cv=none; b=MHIxyt+Z9TcmaIOTtx6bSGdQ6A/ThMm5lFovJjMhE+VBgARevtY2nEKx2bEo6uS19ybLQlWfUNDZ+ZnwZJCd/SSMB1AtuhWcBGsagsdrK7Do30ralamJqeuNtpbY1DrOkvjG/u+8e5OKa5DzFzbA/t1BX8zqSMr/cwleeWZuh/4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781400577; c=relaxed/simple; bh=8Xqny1EEKfsZnZAw6Hrvhi+5T9ULq1DfaQo6bF9at+k=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=WWBULqvkNtnFpAI+e5dJmUQw/dymTdtoz1Wn0yYY9b9DVx4z70GfzEqSUNYN8KvE3qsvPPVqPkvWYMHYRKnkAbMna43PCHEvjw2WtZlLHAslGevv3zjH/bdhhY8bbo0LLWFfMGzCmtwWXGU+gdIV5hXcVFGpeulHQH6u0ySYxlY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Qqxs5KHA; arc=none smtp.client-ip=209.85.214.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Qqxs5KHA" Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-2c0c3543590so14881565ad.2 for ; Sat, 13 Jun 2026 18:29:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781400575; x=1782005375; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=6T/LwGPf7tdWkgxqKaa4uBL4QJA9LIGsy6E8GC0qjkg=; b=Qqxs5KHAZ317jRE4ev/Q6saa5VFnBIFujRC/twXeivPQqESNQscRE2uyUGgPZhujsw 2lEK8PPLEDtWnDqjQsXgFCwXqpXxpM2vrr0Qli5kt/ORgnBDDNXriRYCGtVYIt7yvvUK YK9ROlnsh6F1wa9FiyAP9zO8kQxhKwp7ZuNDW95LcZgkwL14Kc7ou4yEjBxQcKAKWhw5 +WbsQXQQZL2XSWx4RztGPulvDoanxupzf89y1vpnLf26yQ4HrOkuf+ZmytRK4IHgd1lx A5edk2HSbiLI44YLeQHVpY5z7LUev2k/P8/Y9Sy7F+rh+zoD3tk6cG79Fb0c0QUSVT8z 681A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781400575; x=1782005375; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=6T/LwGPf7tdWkgxqKaa4uBL4QJA9LIGsy6E8GC0qjkg=; b=LllLLehFczb+edqcomK3fw6Tk+sXBrG/P3mLxv7XjOMkARZkMUhKDbR+DVhjLYkyGW G7Rd++itK34EEgmMYpetJokzLzHWqG0Xu0an1eB9VZ1lDPf0w7vtEiTRtHYGLr6SS1r0 Eomejsg6nSWgVVzFTzEqzBIe4BcANlkOLMbA5Y1izHQXITyoRzXVGHgWbwJwyLDb+Bj1 ZmI3Gc1RGhxqMeJ8YB5xhXb4rXfFl45+OoAsb6pMCgeHLtK993I2PdfOIgtuFAyskirb scKPp1GoXKgODC56mxwQ9+Dw9ZCPI0iWJIh0/8m4kzIQoBFu4XarJDHFWcXPRru6njlA xYJA== X-Forwarded-Encrypted: i=1; AFNElJ+NN/Z8ZrGVE1MGkYmsrfxqF8z9B8tub0vH2pQw90nwcV8UC+Vm6Z8q/iBMn4smYfQMe1GSZFar3u91TJI=@vger.kernel.org X-Gm-Message-State: AOJu0YyBW2DU8mmyWLhxTmMch7fBGnFSobwgYvdk5eq6vlw14AgCqB36 T7SMSjv+7PSbsFFzpkyT1g5+8zXC7j/rYcjgMzeA1HGQ8IU7nh1KYtv5wJijng== X-Gm-Gg: Acq92OE153oq9dZdw8jHxwPaXl6TSLFJLJRLBzBsSAZp94DygKLzK4Z5vqcJ6rsH1WR YmYLhCT4ZmgEmUZ+yX9wlcqm5ZF0huG+2PtGx28+rwWW9UjjPIwNYNZRI5L0XHGZt7Q92Zad/P9 8E+0r2LZtLkJFxs/EAGXiB1PE9iKMQSDF59am27VvogoWBRET0YJQZFMBbWRZ8jMEu8Bqikrw+z YDf+SEca7J7B5M1JRdJ3EyNc9sK4W+FBxpwgZ0LNtOMSnJqygBNQekeyNmwo+zMi/jfxZk9eIGF aW/1RFlJc2b+weHNEqqLVvknIx/HmbjaQYDRI1YiTx2mY8imp8iMJLpD6t6ISc6OVi+3KklgG/P FRe5ck97LBGh+kvX+3Ytsy37un6AIQiVSSoRjotGyZEjWqo8NdtQmC2AIWFwAkDZTFZnnM9FHhK yUx/KI3t13d2Gz2U+kGGulJKrfTtbrVXnUWFcKkyurnrF95OmudufXSpTgw2T0XLzNs2lo5Cd/P k+X1myQRd3fuWuv5Dscv1ltZB7UKD7r1vQ= X-Received: by 2002:a05:6a20:549f:b0:3a2:7ef4:81d9 with SMTP id adf61e73a8af0-3b78405985bmr9960245637.44.1781400575025; Sat, 13 Jun 2026 18:29:35 -0700 (PDT) Received: from ryzen ([2601:644:8000:5b5d:6e63:e53e:e773:8f84]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c8665187371sm4771731a12.18.2026.06.13.18.29.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 13 Jun 2026 18:29:34 -0700 (PDT) From: Rosen Penev To: linux-crypto@vger.kernel.org Cc: Herbert Xu , "David S. Miller" , linux-kernel@vger.kernel.org (open list) Subject: [PATCH] crypto: amcc: move ioremapping up Date: Sat, 13 Jun 2026 18:29:17 -0700 Message-ID: <20260614012917.70772-1-rosenp@gmail.com> X-Mailer: git-send-email 2.54.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit There's no need for devm_platform_ioremap_resource() to be so far down. In fact, putting it up allows direct return instead of having to goto some branch. Also, remove the error message as the function complains loudly itself. No need to duplicate. Signed-off-by: Rosen Penev --- drivers/crypto/amcc/crypto4xx_core.c | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/drivers/crypto/amcc/crypto4xx_core.c b/drivers/crypto/amcc/crypto4xx_core.c index 001da785af07..0271b5e4d923 100644 --- a/drivers/crypto/amcc/crypto4xx_core.c +++ b/drivers/crypto/amcc/crypto4xx_core.c @@ -1251,6 +1251,10 @@ static int crypto4xx_probe(struct platform_device *ofdev) if (!core_dev->dev) return -ENOMEM; + core_dev->dev->ce_base = devm_platform_ioremap_resource(ofdev, 0); + if (IS_ERR(core_dev->dev->ce_base)) + return PTR_ERR(core_dev->dev->ce_base); + /* * Older version of 460EX/GT have a hardware bug. * Hence they do not support H/W based security intr coalescing @@ -1286,13 +1290,6 @@ static int crypto4xx_probe(struct platform_device *ofdev) tasklet_init(&core_dev->tasklet, crypto4xx_bh_tasklet_cb, (unsigned long) dev); - core_dev->dev->ce_base = devm_platform_ioremap_resource(ofdev, 0); - if (IS_ERR(core_dev->dev->ce_base)) { - dev_err(&ofdev->dev, "failed to ioremap resource"); - rc = PTR_ERR(core_dev->dev->ce_base); - goto err_build_sdr; - } - /* Register for Crypto isr, Crypto Engine IRQ */ core_dev->irq = platform_get_irq(ofdev, 0); if (core_dev->irq < 0) { -- 2.54.0