From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 22B1F2F8BEE for ; Sun, 14 Jun 2026 06:09:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781417388; cv=none; b=Yrprz6tc1eGOdzFbUW8tBpHfKijJKLzgT82UWUt9OxxsPR27+co9+6DMFUpEX15TSdmcG4PoS3sCWIfRhE4QQ3gBd7W8qnUZhUifwVdKNY3B1Zt8bzj1DP9cfiix5IkScb/2GXF8kNLMkzJVUgeAeLeIdkQqG9qT2em2Hb0wRuY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781417388; c=relaxed/simple; bh=w+BEYwapyEnGeH7XclT4QkIwWad4QiYpdSQPssAvQDI=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=krcIyYTxEKscFckbZn7x39Nw1Z+IpsGrXOaOjDfkUx/KOFtc8yiLsBF1kWaC9HwGfxnYkj8dVF06+phb0SPDFnT0keYbapwZPr/1r1GQ7Y2ZDEbEDZe3W2dpzG7jgsrUbJEJ1IQODUJO8VxNqKcM6fo2HN6MTVGo/Gwjy0C/en0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=OoNj+q6i; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="OoNj+q6i" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-490b9318997so15959265e9.2 for ; Sat, 13 Jun 2026 23:09:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781417385; x=1782022185; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=DrZxkAgBrgWZE1APhH3jZINrbNeZRGIQoGoFoO1ZxfA=; b=OoNj+q6iiEX0OliWOZhFKXBKIDW9CGJVfvoSJbXmck9Oa5Gnl0lVSVJHMVJ82gO61Q XFGCV7yAZsKUlrovZU4olIMkZc32yw4sg0IKSPRTrrD8g3AXXbXGHzLI3mmk+kSyf2rt y6vV+W2k8SfvKzhJtV0V9ZLsTSRUoWuthxf1zxchyCUM1ZbGx3XgX9kYJT0dirTdxlQw GPHu6KgED8oL5OlxsrYton7vtnD4ci5qTOeWCF4WyZ6zDR+ncHQfdMAZffWLkaNZUKTL IKBManp0MhOJ2nAIlgTdUQTFF7QAZ0N3v73xA2VpSf9c5uWZ9w/05rpxwEH5RQ0l517Y LHsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781417385; x=1782022185; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=DrZxkAgBrgWZE1APhH3jZINrbNeZRGIQoGoFoO1ZxfA=; b=ndQommNRp36ih1Bln27Z+X2aXpUvK7c6vaon06E8b56lNJhIbMsMzb/8Szx+LnebkW J0FaWNCv7NaZI9FtlFnHDQj+XsxvUf7ziS/fCEJmHQTIvyLIbjchhS5jBmzgRBreg0jk hWNqon7dpMxFKu6CNn4Np6bB21t29eaE3TTrZrJ722VO5swUtPs8DjufXyogSKxeD9or H5XdmRvkAOfZMHLFclE7WJHOYlFQgihecKPDAuEPknm7zIwn85f16lvb7Ey5DxeFvQL+ q5oE7/k+xKIz6Yc2UUZbS2KQfigl9+H4pDVMNxCOGhJs82o91FZJUGHPHTJ7jf9BA3vr a25g== X-Forwarded-Encrypted: i=1; AFNElJ+0CXmSbkAcKYhA5h4i9Q0QLHXTzKjndBUImLo3wDjr3FhT3ELcvnhlQ83nweACMk3Nf6EyQPqVIaRHWSg=@vger.kernel.org X-Gm-Message-State: AOJu0Yygt8uqopg4tIfvY52omc34Bdcg4fxcQhBSmrocvvEssXS9wQqr EL6oIx3K/Jj8GzyHT2h55L2As1VTErQuWTU0ogKYI8FG2aTCvwisr/Ks X-Gm-Gg: Acq92OH6Kqh1XolgFdh0G5b9y2IG7sRN9WcmVo+yKfd7y2DhSA6vzvgl434FK9/sarC XQTkyg2KGuQE5G2ChcbtFZu3qVg3o2THhmrCRJHGtW4Lzm9wHMebFTNr74ScbK5rahehhvFjt8Z oRFW/DgJJJhOTKBy8uywe6vAesHVKU+5IjmzejAZ4UCazq0P9rRbhQMcMLwxWcjUmEJYQOnXWKo aKrz5p55A2WKjbfadMqZxfbaRT8cVcdSiIOccVAnEwH/r/GrGQMtzAp7rW9fOw7H8bIlM9WklMA iEvYq8NTnKoGPKtMjeDAh0i9xF0goX5AzeKLtjVSs8dKT44GfU8UwxiQDvELEDmutzY3QLbofpf 6mO4A8RIKWj8DtlfZSTA3j/lX0bRxWFioKZri+ecPucoKF2K9BRLakwvpxlC/uBAAJ3WgHObi5P 1HkGVilTgQNlNDdBKT2qMM/BfFidDGX83KfkesHw+KkOSUXQ== X-Received: by 2002:a7b:c8ca:0:b0:490:6237:521d with SMTP id 5b1f17b1804b1-49220092e7dmr49935755e9.13.1781417385421; Sat, 13 Jun 2026 23:09:45 -0700 (PDT) Received: from fedora ([154.182.122.228]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-490ea95c512sm125598265e9.2.2026.06.13.23.09.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 13 Jun 2026 23:09:44 -0700 (PDT) From: abdelnasser hussein To: Vaibhav Agarwal , Mark Greer , Johan Hovold , Alex Elder , Greg Kroah-Hartman Cc: greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, abdelnasser hussein , kernel test robot Subject: [PATCH v2] staging: greybus: audio: check sscanf() result directly Date: Sun, 14 Jun 2026 09:08:57 +0300 Message-ID: <20260614060857.15366-1-abdelnasserhussein11@gmail.com> X-Mailer: git-send-email 2.54.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Smatch warns: drivers/staging/greybus/audio_codec.c:335 gbaudio_module_update() warn: sscanf doesn't return error codes sscanf() returns the number of successfully matched input items, not a negative error code. Compare the return value directly with the expected number of conversions instead of storing it in ret as an error code. Also remove the redundant else-if check for snd_soc_dapm_aif_out. The widget id is validated earlier in the function, so the remaining branch can only handle snd_soc_dapm_aif_out. This avoids a compiler warning about a potentially uninitialized variable. Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202606140347.gGVWDnbi-lkp@intel.com/ Signed-off-by: abdelnasser hussein --- drivers/staging/greybus/audio_codec.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/staging/greybus/audio_codec.c b/drivers/staging/greybus/audio_codec.c index 720aa752e17e..6daa4e706792 100644 --- a/drivers/staging/greybus/audio_codec.c +++ b/drivers/staging/greybus/audio_codec.c @@ -311,8 +311,7 @@ int gbaudio_module_update(struct gbaudio_codec_info *codec, } /* parse dai_id from AIF widget's stream_name */ - ret = sscanf(w->sname, "%s %d %s", intf_name, &dai_id, dir); - if (ret < 3) { + if (sscanf(w->sname, "%s %d %s", intf_name, &dai_id, dir) != 3) { dev_err(codec->dev, "Error while parsing dai_id for %s\n", w->name); return -EINVAL; } @@ -323,7 +322,7 @@ int gbaudio_module_update(struct gbaudio_codec_info *codec, ret = gbaudio_module_enable_tx(codec, module, dai_id); else ret = gbaudio_module_disable_tx(module, dai_id); - } else if (w->id == snd_soc_dapm_aif_out) { + } else { if (enable) ret = gbaudio_module_enable_rx(codec, module, dai_id); else -- 2.54.0