From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A4D082030A for ; Sun, 14 Jun 2026 07:16:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781421362; cv=none; b=Omch8OlI+lgbOamqGOTs1qc7ugRwaS82mdP4vajLzSbKlG17atH/+xzR0nzLos0RkwbSendyQpawIpFeuJsY8nJaPwHzo3TS4DYs7PY/YD/9R/RFkMm68QjVwkvNkMmxJE3ryqGWL0/wpLOx6qfi/osjWh1CGCqmui+TY6L/jls= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781421362; c=relaxed/simple; bh=HSFVueNEH5xg1DfWVSw6O7NeC929r2+Y5blCLJlbKKs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=pLnlf6c7vEBqsEZeIMjilPl9zZUNUl0Zp7YGbOIzKtpFTbxfJ4CIPAY8KVzeYj70bNdMyW6P1yzsap9mk2C+9kB9XN/l8jwTCxIrGs2PljqyBw0XE1etAZffAde3kkfMQ0Aiv8kAGbJeh5VwiFkWzqS3nXH8jJT1j7djASmNLGM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=FNFL62KN; arc=none smtp.client-ip=209.85.214.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="FNFL62KN" Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-2bf2e8ccca1so15035835ad.0 for ; Sun, 14 Jun 2026 00:16:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781421361; x=1782026161; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=HWgMQVrY+dz9rsihfRCMQ6mLj8tg7gjE/NKN6bh8RUs=; b=FNFL62KNnTM9YGGFC9J74n9mAJl+Z/ztpgtQaA5h42NFLaUWvtOK8rS724d+TQBmD5 d/1mFA/WJj/NKh6fs+alXDtkdCnvxccXd5FAJ9+zYk3HL6V+Sub1/SGUwUWg7pE137zR YIr1yZh1M4caeAD5ij0Uv6vvObDcrRVKvBQkuLIbG8TXAhZwvo+t50VWxOcwgE8WQ5g9 OdCTueg25JVK+FEibxgI+ZKf6NL/8FwYhNhlsY5Bh9YGn1zK9nJktPIc0oYcUSAiZ55r g2TiV86jL19PUnr9fAOeTljtKF3i7Mcn51vyP5elHA3vyhuh5OOiKYBqk8SihBi5wxTT vU+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781421361; x=1782026161; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=HWgMQVrY+dz9rsihfRCMQ6mLj8tg7gjE/NKN6bh8RUs=; b=T4Tf4ujFtcErYH5uezvAiDc81RILw6vQYe5hEZWwB3ju7oqrtn91A5R22ePkS6C5Vw N3vqJ96I2nNny6nFBm3W8Al+Ez21A5aLavfx/DxqyiAmS4YnlWzDL/YdrYi6xP9Qm09Y MkX0G8UdKWLXmEor08CRMFK3P1t6QWVpCByV+So1pvZM9ca4SCfptxysjldzHiyxDCnh ovsPDZWBbRZfZNQZt3sx5FKw12pAUp+KBgKKJgGHCB23ybbKvewkMRQG2yjbgjH4mnPq QxMMrOCzKY85IzFLGbNcAbnSLgh0JSfry7wk6ejpIT0xbUz2pW97atFDnHNOMRGJJJ6r EkLw== X-Forwarded-Encrypted: i=1; AFNElJ/P9JFCW1o9mxJcPfjKFbdE2rC8Ti/MfET2RB5DILwxM5EM7TulQpg1DyEiyHVFdTyqn0bQtoEg8A3HgcM=@vger.kernel.org X-Gm-Message-State: AOJu0YyGv8EhSDlUDSWdlDhI19HMOhcXjbaspuHxLrAWt2JyTEGG73Tm 14KuB+0u+FsL0Y6/wMhWZsBSnZlaBWQHnesr2KTFay4P/XLZSuJztoJE X-Gm-Gg: Acq92OE7gmJcSXo7FfavbcJA0/Qd5usj/sPEeTp6oXQggMO37CAhrJjK3LFjOzrerAX KevNI3PdftoRqVi8LA1sFgvmVE5NvQVkk7p5ANu5nkxEsb6bA6OLnCp8Bllpy+f29lN8vuOcYUT 2FHOZE5K03qmzjd+DM9pShsonxMiCaZyyV9X5x9GbWE6A3gjIBS5BDNL085XhqrmZOxYGYTW+/b L4qGRjWHAFJUXdbZynGnVGrN/v2nJXd9K5K4AmnuwOOZWUGDYL7BuIl6/w7kPkgtc+Flh3WwehB QVP6QnHeUF1fqy2O6InJq3TQPL5NwIqxqBev7LItJGkjTzBTo30DlRq2vlbaPzHbANQh56UR08g epm/Ze8XV+S6z1YhzKUxRggKU5DfzUDObmqkL6X4f8TT+vu+BJd1oBF2jkLHVKkG3J9JU+qR3xT Yqn55cDhyZ4q1l3K9gqy4LJc82xfYIAq8/2YJEgJzftpkRAYa7h80c X-Received: by 2002:a17:903:fa5:b0:2c0:ab82:6b99 with SMTP id d9443c01a7336-2c41216faa0mr110114895ad.33.1781421360944; Sun, 14 Jun 2026 00:16:00 -0700 (PDT) Received: from localhost.localdomain ([49.207.217.37]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2c4327ac794sm65595295ad.46.2026.06.14.00.15.56 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 14 Jun 2026 00:15:59 -0700 (PDT) From: Biren Pandya To: Jonathan Cameron Cc: Linus Walleij , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Biren Pandya Subject: [PATCH v1 1/4] iio: accel: kxsd9: fix runtime PM imbalance on write_raw() error Date: Sun, 14 Jun 2026 12:45:46 +0530 Message-ID: <20260614071549.81920-2-birenpandya@gmail.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260614071549.81920-1-birenpandya@gmail.com> References: <20260614071549.81920-1-birenpandya@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit kxsd9_write_raw() takes a runtime PM reference with pm_runtime_get_sync() but returns -EINVAL directly when a scale with a non-zero integer part is requested, skipping the matching pm_runtime_put_autosuspend(). This leaks a runtime PM usage-counter reference on every such write, after which the device can no longer autosuspend. Set the error code and fall through to the existing put instead of returning early. Signed-off-by: Biren Pandya Assisted-by: Claude:claude-opus-4-8 coccinelle --- drivers/iio/accel/kxsd9.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/iio/accel/kxsd9.c b/drivers/iio/accel/kxsd9.c index 4717d80fc24a..7ac885d94d7f 100644 --- a/drivers/iio/accel/kxsd9.c +++ b/drivers/iio/accel/kxsd9.c @@ -147,8 +147,9 @@ static int kxsd9_write_raw(struct iio_dev *indio_dev, if (mask == IIO_CHAN_INFO_SCALE) { /* Check no integer component */ if (val) - return -EINVAL; - ret = kxsd9_write_scale(indio_dev, val2); + ret = -EINVAL; + else + ret = kxsd9_write_scale(indio_dev, val2); } pm_runtime_put_autosuspend(st->dev); -- 2.50.1 (Apple Git-155)