From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0D7413911DC for ; Sun, 14 Jun 2026 07:16:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781421376; cv=none; b=tsTzbiggZASMtUsQNeXZjzDiKajbl6GVmfthP4dS/KvnKQ9/LDwCppAE4IB/DP54x1DzlQhFFFowMG+aNINhMSk5NiRT22N5ZDCaI+aei4dnDEeH90VQ6ug60hB2J4QwiRS43WXZgKn5l3r692eo+HpSmFUEYsWFSHRL+l3l3PQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781421376; c=relaxed/simple; bh=ImOyXwGqY9R+Xsddf0l/0dtCBwFyC6spjxLxs+Vzb0k=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=brg5io8mG5pdqRZTtuoWWSJuvHBz8QkNMCeqShN5TU4cYwWPEqYkHgJqZ28C37124L/uILh36cIMcmjP7kCOogRIjarhW2hLlxK9pF8BHbwHpcd3Rn8BDLRbrY7UtIej/0VeFkMKnxYiaV1DPE3kmeM1JyzW/D9BqUuepKdKhF4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=rD0MimvX; arc=none smtp.client-ip=209.85.214.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="rD0MimvX" Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-2c0c2d8b95bso17894685ad.1 for ; Sun, 14 Jun 2026 00:16:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781421374; x=1782026174; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=rraZsIATQSyWjxZIPsZ4xXDf9f10gJ+mVeYVyqxPx4w=; b=rD0MimvXBZQCueqw/1gHSamZ7kjkZiRoWD58B6cmZ+zHa1MkTrfitejzbpovMUDdUT ksgktQb0aQctr9MWPT3FUHQJne7j171vJA0+kSu531WlRXuPqTgOYp7/T8pc6GFMzHt6 KACL63BP+7A3UfHZSxrd8mE5wUbUdDFanGkX/MbLUsIi9tllY73EJr0MKBDMdPAtswIm 11PQ4MFMfRutnqqR9KsfmyfDL20bXZVUQVv9/9cQkHJLXPL0SNzTDldFbE1Kk+KoTSxc puCfe88veKot0O1GOaRuJRbDO56CIC5bYisEIYLUHRkD8Fxikht96FzypmbkFE8rTtAN b96A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781421374; x=1782026174; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=rraZsIATQSyWjxZIPsZ4xXDf9f10gJ+mVeYVyqxPx4w=; b=TnKO6Oq62KZ9I+ESZgz4fn1DUfUjB0+/g2TzNkCQaI782px5+tIetwVQsTBsWrYuA2 lt2DlNfrzXo1Igc6oH+Eyp73fwuISmztZhX9vRPblv9GVQKRBwJTaUnwI9B//46U+WI7 MitUCfuLAO2hb9/GblU3FOmx9bvF6icBfNwxOMO0Tz3Q5fEe7/r4aI9HKa+TgmHK53Xe hIUne6kRksqHWEWIx7kadGan0OpIG1P8O/ba1c2wcb1ZRXMmwdET4OlSHza8dDY9kmX+ QKwQVp1LUcBWVXgMZSCNV/1kVNxVlq1kW3zqEVquc/DjdbhKJ87T1l9qpOzBDHF47BRf YFkA== X-Forwarded-Encrypted: i=1; AFNElJ8iffdDJGjwVPyqKUnIzVcORb43J2o1B/PCRf1N/FTLP56hl3wsZzWAW8tONgWg2xHc3qr54FhWWPHcCFs=@vger.kernel.org X-Gm-Message-State: AOJu0YzwnLdl409w8mY+G9Q/M3lHUUS7jvuBpYZyk7/dB3WyLeEisU5A 5w06A+IdXPF5Q9XjwFo3dp2R9CH8KAHjWU7Ew7IU1F1gh6UYiwh0W534 X-Gm-Gg: Acq92OFYXiSSDZleYa7hIxUVid04N/qOkcV+FgRzv9GXOxaLT0BewC6SDnMgr0oXihh ZW8IQTPPvGrkIEwhtFFo4ANVwaHrpcb7KTaW0VtxTMGutdi4ViDZ5g2NotQqLc6+W/gQTbwo/hk DE1vq5iQSp+lxLQ3yox/mbNTNvi/Q+61xpiQAy1OFOI9h1URrUWXWgeAfGqIuOHm7Ia9LZPN+qO JFmIoAKbuxvLiCR5CT1s1vKXbK5iDNTrTDaxNr3C+DBG8+6mwJFxnn7/TcTT1002ZghYQLaIvka i3281ecDgrU+lTpNQ1LNHWnXyxRYZMgu/HYGFrYG532BKlBj+Kbl4ZlysiuOkiflNyb2n9Es62J UZRPYwJuDLO7IAu4bEAg0EmL/PwAbeK/zKXaof1ZGnUTGfXnTdKN5APlrDydOf5RYouK127U8AL 5Smvqa6W4Y4NVdQsUbjWkc11OoQibBns7YkEN7IO+ndoMzCEdRJtHi X-Received: by 2002:a17:903:b46:b0:2b2:5515:661c with SMTP id d9443c01a7336-2c6642b0dc3mr58122065ad.31.1781421374403; Sun, 14 Jun 2026 00:16:14 -0700 (PDT) Received: from localhost.localdomain ([49.207.217.37]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2c4327ac794sm65595295ad.46.2026.06.14.00.16.10 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 14 Jun 2026 00:16:13 -0700 (PDT) From: Biren Pandya To: Jonathan Cameron Cc: Linus Walleij , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Biren Pandya Subject: [PATCH v1 4/4] iio: light: gp2ap002: fix runtime PM leak on read error Date: Sun, 14 Jun 2026 12:45:49 +0530 Message-ID: <20260614071549.81920-5-birenpandya@gmail.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260614071549.81920-1-birenpandya@gmail.com> References: <20260614071549.81920-1-birenpandya@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit gp2ap002_read_raw() calls pm_runtime_get_sync() before reading the lux value, but if gp2ap002_get_lux() fails, it returns directly. This skips the pm_runtime_put_autosuspend() call at the "out" label, permanently leaking a runtime PM reference and preventing the device from autosuspending. Replace the direct return with a "goto out" to ensure the reference is properly dropped on the error path. Signed-off-by: Biren Pandya --- drivers/iio/light/gp2ap002.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iio/light/gp2ap002.c b/drivers/iio/light/gp2ap002.c index a0d8a58f2704..886accf5e859 100644 --- a/drivers/iio/light/gp2ap002.c +++ b/drivers/iio/light/gp2ap002.c @@ -258,7 +258,7 @@ static int gp2ap002_read_raw(struct iio_dev *indio_dev, case IIO_LIGHT: ret = gp2ap002_get_lux(gp2ap002); if (ret < 0) - return ret; + goto out; *val = ret; ret = IIO_VAL_INT; goto out; -- 2.50.1 (Apple Git-155)