From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f52.google.com (mail-pj1-f52.google.com [209.85.216.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 916C4247291 for ; Sun, 14 Jun 2026 11:48:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781437739; cv=none; b=GP/DYLbRoCGmgAe506Gtq1H0BKIwjffjFXZ/iby/0CaTp4oG2h5EodOxyHRnWaZAsnXFe8D631DUYecwsiKWbWZ9uw5lXjaL15iDoAlwNx5hNzWYzOQ0YX+IUIq3EMpfxb4wCXZ7xgTuWsTUFyccOuHowUBrVmk+9d1Dt+9SLXo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781437739; c=relaxed/simple; bh=ll40Wdsw5Beb5SEWvKZ7o8ZFRW5ZvL3rqlsZ87zKu/U=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=iDRbmA1PGnFD4TgVj/LQhS/JBRgISRCV04krKyDNQcoWDIYaZOLs/yasGEWnZn564TalxBV52jHkOBh1t2fO4JYpCHuyJOcye8xH8qxU0cIQJfUXI6iGRfsQFb8VC8tJY63sIQKkf+VRPnhtfmAh7LlId+pSzYPd5jUgnD/N8Fo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=B5LDujyQ; arc=none smtp.client-ip=209.85.216.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="B5LDujyQ" Received: by mail-pj1-f52.google.com with SMTP id 98e67ed59e1d1-36e0a13e801so334448a91.1 for ; Sun, 14 Jun 2026 04:48:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781437738; x=1782042538; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=mE+74dY5/0xayTn2/a4ziQg7s4J1BN3ftMLZ3hA9Rvw=; b=B5LDujyQjCH0EJ1NFJvTWt/rhz/pIWtMIEM83c/7tUOP2JTrPN0w/H89Uyxe45kRQN 5I6vc/F1YQjHx05sIhEH7Xgkld3gAUlnbp1XdEH3bX+bfqZbfpOC1rGefnNhNVQj6EWS JQJKPniOT1I20jPS8SWQhED69j5q3zzu3QErQB6rIxIo5ypA9jbGqu2S7SeJuij4yzOP Bs8T1roou2Yv5yWzQatLEl+NFu6TjuZJgWYdi4ybzo81GY4LgcqlJLQyTzuhT4vvkDTW kl0XnEQg1X3ryUzimo55sgEESQHcwrDMJXyhbjAeMxK6Rd4i7bcjY12mMXPDlWC9TuJa 6ffQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781437738; x=1782042538; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=mE+74dY5/0xayTn2/a4ziQg7s4J1BN3ftMLZ3hA9Rvw=; b=Ftt2bBmQr4oIgpaioyebsisZ7runolReE3ECH/PIQhl+R4SpT6xUm3rhBMMS3d03xM S/n+9d1bgPnZGr8Q1eWdqNjyGbXSEJEunTGrZMaYYVm44iby2uD5ChZlpOrb7Tdb+MMC gRq6YK7DrrBO0MHWpVBEIJOqAx2NAyFt4a2EQtM8n+RWdmejnKGpfDeFGa2bxr95nzNw n6P7kawphK6mkeFj6IEzWQCZsBlu+kMzh0Gi68ZNefKKj7mu1xyJeUmgf0z/Qaj0rrqF mBz2Bo6A+FVglKAmJJH70s6uVhP3sT46556/Y9g9zj0Tgka2PSNFml2ZyjyQEYBug5yp wJGA== X-Forwarded-Encrypted: i=1; AFNElJ/sLn4gksnqVLtgGkycryKWnZ8fmuJccjgIYDdhNMAH1HR165gPoY5pcGbM3ctDcGztlKB7P5+Inimu4B4=@vger.kernel.org X-Gm-Message-State: AOJu0YznEBF9Q4t4TgBP1H/1i9F2t1GO/hlGxpOEV8/N/BTShNG47Ktu xelV3YVthM/U3sL+u2HDSsBB+tL0ocQ92C5IwedFFRTPL5wztbs/Trcq X-Gm-Gg: Acq92OEv6f9LS/aJGrbzcwVWQBkFUwG9JqfMbTLoKzUhd0pS31fAv1xDuJ0o5f6ww7C JBq1623QneBRj+QvD1BPXAe+W1plB3iXm1pOJLtXv+fko/9Dj1q9YywV1dpYwCyKe2/emv+5U1a zMi4aKw0gLA8fL6jvkqio2mhfbidY5somKz7uAhSHnQhj45mYSJs4XcZPXRZk5r/C3XmJyXGG/i OHjY/mAeMnj9PRxYHZZpkklxseYskDDNnuJO3j7ERAFFSOruvrYMje0tyk73g15abZsLFZzY7JF WmjwmPCiLrXiOnALcftCUuGLxKTNtPuWh8EgSKxBbV5hQCnTpVTKA3pVikHeful7hfORvxYCcqm Jm3gUV1yQ3IA4bDLsFfcIMOQbk8lYbzhykGX5xW0oWPiYMasFVRNw4E2QwLi0E6bN6fKBlYgqgQ jtjM/yiD6+wdoRzU640VJbwNyHNAIoj4uZUPyFSfy7swdDsyFNkr8BSJadbc5QvV7rUsOwNevrU sh6QeN0usyGrI1j X-Received: by 2002:a17:90b:3901:b0:36d:de94:f31 with SMTP id 98e67ed59e1d1-37a03fb813fmr5350117a91.7.1781437737852; Sun, 14 Jun 2026 04:48:57 -0700 (PDT) Received: from fedora ([2401:4900:79eb:8cfe:b4fc:6fb1:4b23:8420]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-37a2179d743sm7388808a91.17.2026.06.14.04.48.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 14 Jun 2026 04:48:57 -0700 (PDT) From: Ayush Mukkanwar To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, linux-kernel-mentees@lists.linuxfoundation.org, skhan@linuxfoundation.org, Ayush Mukkanwar Subject: [PATCH 1/2] staging: octeon: add missing tasklet_kill in cvm_oct_tx_shutdown Date: Sun, 14 Jun 2026 17:17:38 +0530 Message-ID: <20260614114739.87061-1-ayushmukkanwar@gmail.com> X-Mailer: git-send-email 2.54.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The TX cleanup tasklet can be scheduled by the watchdog IRQ handler to execute cvm_oct_tx_do_cleanup. There can be a pending tasklet in the queue which might run after the cvm_oct_remove() frees net_device structures, causing a use-after-free in cvm_oct_tx_do_cleanup() as it iterates cvm_oct_device[] which is an array of netdevice pointers. Add tasklet_kill() after free_irq() to ensure the tasklet is no longer scheduled or running before teardown proceeds. Signed-off-by: Ayush Mukkanwar --- drivers/staging/octeon/ethernet-tx.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/staging/octeon/ethernet-tx.c b/drivers/staging/octeon/ethernet-tx.c index 14d10659bce7..785c6492f170 100644 --- a/drivers/staging/octeon/ethernet-tx.c +++ b/drivers/staging/octeon/ethernet-tx.c @@ -668,4 +668,6 @@ void cvm_oct_tx_shutdown(void) { /* Free the interrupt handler */ free_irq(OCTEON_IRQ_TIMER1, cvm_oct_device); + + tasklet_kill(&cvm_oct_tx_cleanup_tasklet); } -- 2.54.0