From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f178.google.com (mail-pf1-f178.google.com [209.85.210.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 940DF247291 for ; Sun, 14 Jun 2026 11:49:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781437743; cv=none; b=ID+aCP/0SyrpMrAmL730TRKogCuXbmGXsf3MvegP51oIxm0p1SVeeVbnqOexWCr1ckwIMgFp0ApK2n+myJ4e0OVCQMXL2K8LWI+iXWvPD+M7WVlYTRTNBwJkRyTOEsbYlhaVxr1a1T8iLpu6qf3DW8usTtSVs5GVrqVoqMebbto= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781437743; c=relaxed/simple; bh=3eQMYrqcZR+H7vo5G+ve3stl2q1Lclf1qKjKDAMgdvo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=n3r6kT1fgqs56KAR7Njje4GO41QQfuJefVyD+O8Z5sDWDUxOTWZydWpuJA5SkkZQn1YB3TDPduT81m+L5UFU1+q5CKrAFp54/FLCHi69wAXlsC+833TKoKM+wjbn8X+H4y6q6iJQba2RYibfCPAn3eRYJDm7kA4N2al/PNOw2fc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=j2BUFnNj; arc=none smtp.client-ip=209.85.210.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="j2BUFnNj" Received: by mail-pf1-f178.google.com with SMTP id d2e1a72fcca58-8426e2eff71so498251b3a.1 for ; Sun, 14 Jun 2026 04:49:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781437742; x=1782042542; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=nst4RlWH0dhLsxuUph3akJxwWh4r5iV9JHBzF1t7XFE=; b=j2BUFnNj3czir/zeIazz0vmkXcuWPs+j9P3KUeQR2j7JSPdXirUryHVN6cqCG05nKj BP/saENiyd/XvSx/ic6QcSQLoI0HeJXOtQqyowc5qBHmqsBAKwh3yiSXF0J8bb+Ecodc GpSr+z81jeuJCfQdsixLTfxVbl9cxdA1SIEiBAuM7q+9toxQrCTaXUIXlC4AHcCDLjTp X5PAH13wbWXL4WSI43yNtXvehrbjpKOlR0zGvozPh+um9arG7d7G7uwikOY4ZSW8kSfv a9OtGiY4AVhvYp8N0ytRppDmv82iXTW5xfu1tvOb9m9Jfi7UTrcPu+sQ/hJlSBUHIn+9 PECg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781437742; x=1782042542; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=nst4RlWH0dhLsxuUph3akJxwWh4r5iV9JHBzF1t7XFE=; b=jU5uSx/kikGgNl/sCSxNhyl+JvvQkeskYVRC3B6km+XjoRLaV12GaTEHErnSN9yUwm R2sZV7QDdEY5ZTKEb8/jj29hZDbBW4OjmBie+LZMPUNZjh0//b57Zo/pNZ/b5FiuTT4Z +HL95xTEzbUq3RhnaWlGVCPARSnpdgCci8DnmE1APZ4hVmfUYWMAnG/cvZ29Ouw19REW er9YPLt2Y1YCXDaarmIOhdkPewkTodJpR4yMKPkK/wXi8wMaqd3E1LM3xgUuQ02UoXpi hhlubpoKDdwNufc9p4nnU11X8sSu18ULGYbctAfoTuIzNsyzhDruTAGz4uD2XDYUQRdz Uxfg== X-Forwarded-Encrypted: i=1; AFNElJ8Jpr5fcUh0lSPxvRczo0t13uVPdhz+0U/MKOlS78sPuy6A3Lb7oREF3RkPQ146ZloM60Ej44Q7AInJCKw=@vger.kernel.org X-Gm-Message-State: AOJu0YwEL6xr/kUXv0iQgwst4eXzD0fyNYugkKR6O3LLJ2h/FEHFQqTm sysr26T5CpG6wLe2UCU0TkhTyVWO7sfeLuFWL4weItJSLpW9znPKJeWv X-Gm-Gg: Acq92OHOPOHUzlvzuFkTBJsYYCRvwxexQKnH1gz9AFoPPtBHUH5ur6DvqGQ+nEZNSOX Cw10/f8qTc5G9aRBvNAKjSvsCwkznuRqW0BE7pcS6AVE2NAj9XjeskNHEohKA+2hgdtQe4XvkNR +4VknK2E2szUFwn84FLYPpM9wYtSCoEAHKwUsfXCHklMVNJzusKMfYeAUe6flVLh28FOUp6da/H Ow+Z9a/+AZ+5U8P6+bKs4W3X1p0BQTNdCYqDt4YWWmsuHbvrDxUDonaXQ1HsG2fY1Q3SQ7A5GqR PlBSdN6+uBb+9H7WywjlOouJ49qSlffXLEt9n1k3fRR6TMqtgFQaIVJaAalVXk6DwTpdKQstzvc hntUaYLvyKGR/gaGKIFYp2NdkTy7GvGKm6Z1/8RMwWG6Xn2DtqzMTDpF2Dgt3RPkBFH2FFtAhVS PbdwUMz6V8x1KYx204F4ekqKzqcBXZM/8zgP0DTV3fWHMnn+RC/uYbQoUb3Fzc39zRekE3Tpps4 09oj0uE3j7sQAeB X-Received: by 2002:a17:90b:2dc4:b0:36d:b30b:14ed with SMTP id 98e67ed59e1d1-37a0156049bmr5522444a91.2.1781437741984; Sun, 14 Jun 2026 04:49:01 -0700 (PDT) Received: from fedora ([2401:4900:79eb:8cfe:b4fc:6fb1:4b23:8420]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-37a2179d743sm7388808a91.17.2026.06.14.04.48.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 14 Jun 2026 04:49:01 -0700 (PDT) From: Ayush Mukkanwar To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, linux-kernel-mentees@lists.linuxfoundation.org, skhan@linuxfoundation.org, Ayush Mukkanwar Subject: [PATCH 2/2] staging: octeon: add missing napi_disable in cvm_oct_rx_shutdown Date: Sun, 14 Jun 2026 17:17:39 +0530 Message-ID: <20260614114739.87061-2-ayushmukkanwar@gmail.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260614114739.87061-1-ayushmukkanwar@gmail.com> References: <20260614114739.87061-1-ayushmukkanwar@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit cvm_oct_rx_shutdown calls free_irq and netif_napi_del without disabling the napi instance first. As the free_irq only waits for completion of hard interrupt handlers, the napi poll function could still be active. If cvm_oct_remove proceeds to free the plat structure (which holds the NAPI instances), the active poll function will access freed memory, resulting in a use-after-free crash. Signed-off-by: Ayush Mukkanwar --- drivers/staging/octeon/ethernet-rx.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/staging/octeon/ethernet-rx.c b/drivers/staging/octeon/ethernet-rx.c index cd36b5ba6f6c..3e9d58d32156 100644 --- a/drivers/staging/octeon/ethernet-rx.c +++ b/drivers/staging/octeon/ethernet-rx.c @@ -535,6 +535,8 @@ void cvm_oct_rx_shutdown(struct platform_device *pdev) else cvmx_write_csr(CVMX_POW_WQ_INT_THRX(i), 0); + napi_disable(&plat->rx_group[i].napi); + /* Free the interrupt handler */ free_irq(plat->rx_group[i].irq, &plat->rx_group[i].napi); -- 2.54.0