From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv1-f48.google.com (mail-qv1-f48.google.com [209.85.219.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 310851FC7C5 for ; Sun, 14 Jun 2026 13:10:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781442620; cv=none; b=m3zUhoCJAxZ9t76UyBOu92OZm5VqOTZwll5cqt5zkawOxeG+xw9cEp6qZ1HltRuGE2OHFvqcv5LBSbT7VdeR5j5JAS3Mni4IUw+leS8ceqaExObsNUkp7hTGfJyIsM3aFK1a+0IGrKV3sve0dVNX2jzX+x6ggh9xTjMNOq+ZUHg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781442620; c=relaxed/simple; bh=l1YrhJKSwtxthDenZdIjKLY4VixfDd+J7xq/PKf9pdM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=qgxwJUaJfOWuBSUVqnewOxc8FdsqeXH+/rAl99v4nfMlSAr+mBPbfiFIeQ54XJ7gRjloolY8Y1upvYTnv5W4epKHQWAXsJg2uPQ0m4faTRRdHLZqdKhIaF3d65FIP2ckJrujE/vYqsB3VzLK2UzPHcwJUXr7GRFesNdC/CQDHgQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=qiSQBX/K; arc=none smtp.client-ip=209.85.219.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="qiSQBX/K" Received: by mail-qv1-f48.google.com with SMTP id 6a1803df08f44-8ccf01ba514so26601406d6.0 for ; Sun, 14 Jun 2026 06:10:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781442615; x=1782047415; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=CKd9oqWR4qF+iy/wwQJEAglTquC/gKwfzimhVuiNy9E=; b=qiSQBX/KEskzjMa4YHZI0AgltEF1gTJ5Ja7Tj15s7Us40853L/PXXS8Atvv/nn27kY gskKkzTuywUh105Tch+t5lzu1XZF0Bif5P5/sIkG807oDoqBI95w0ZEvIPIEq+V0S6Qo 0kmggVCnog6ujWjpB0zbi27888MVolh0/vSrGWaUrTOaBaqGJFt+k6Qd8YChcs5DHrs1 QBA+lqBGdzP8EGVCjCImmDvWIZKuST5ApSknNZ8gG6uxY3JTlU5ATgpA1Vbya+IFnv9T HwGsU7GtX8q22Iire1lYEVG5nW/Lm22p6SW3AlWyKnR2O/NhU9wA7gLoQs5Gwb/AyO6+ Helg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781442615; x=1782047415; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=CKd9oqWR4qF+iy/wwQJEAglTquC/gKwfzimhVuiNy9E=; b=r/5Ax9quytRNDOMHbBcJp/tCimAQ0eI08JK/nqs08Y4Z3jtRXszq1ICuAei/lAhzNM splpooBe2hKC3awH7vM3cfq5BbW/jx8G34/Zl6Ox8ZvmlfoXU/o27jUZ6J+3l9EeT39F bOnMq1dIpnOg9veQNzBO0Z5lahTI0PUS/HCPANJkZrRdufyoa40g3uMvWTwXtCu6TpnB M9arX6yU6fLCq0Rf8sDJ+gvuGd/mUnmFa4O2/MsBfFL2cyGkbGGDAM0J5ldaaPKHcaq8 mqjMm0+bswmxd/sXLLhgvrzFgo5ercFZrP+hs+bjCSHbYSxmo4cqYHj9E3N6aPT1233j sMHQ== X-Forwarded-Encrypted: i=1; AFNElJ+WNW/ZyQ3E4mpK/8omypryB4/3hr/puEEbVrwHfN2Gi8NDS+FZ+PDc73/3nyEwPSRAW6MmW046P7z8MM0=@vger.kernel.org X-Gm-Message-State: AOJu0Ywqs5h8sr42u5/lG9OniGZkpfl4HdqTcaLwsBtWiMQiC1+PcbOn +JVNqKDd3Sd23siyXXRwYytV1O5kk64Xa7HzhoeICX+dXf7RysNwkECm X-Gm-Gg: Acq92OEVzzTAQfv14oV8TilGe//ApWwgiwvuvS6KTSlKfog6PHTfUasGG6oMLRMeck0 FFOOZ7RYjrnZsmjJNBEDoA4HWF1i07lGVaXPdOdvvbXFOw0gncp1W3FVu8c/doKzyUSQB3h+tDy ZUfLJXonCBtS2MqKy0C5VBLGnrJzO8lm4JZvmqFHFJmGriJOhNiZYtskJx3BQb+diqWkEsNiD0H 4cKj0JeH6kjCVKalMKry6QHFRpKyvzzc+drYHr4gcnxdEXBN32W6sHV1CfxcQLIs4UYwmFF9EfN x1sHbdjAqkzSrANtHCx5d7u2FQVyRRx3XB5DUIH+XkwkYM5P5/iFVGg2DcVBJbdEZcpc6sp6o8B S2FQFu4XrpMRHRJMWaQqiqIp70KOT7NJc4RXXA3AJMN+MvHP0NlQ9pjo85Q70DfIzuw+X7WpiIZ lV05xDVN7CBnlOzOAgn3vankmdJXQP4swCJK0bbQxff9l1FWAIoBlsdg2/KUUuNyibyrovbxZTv 6o6o533aqdg4r/vQxVcMBz3Geg80Ed/PETIuuYfRBo= X-Received: by 2002:a05:620a:d8e:b0:915:9273:9242 with SMTP id af79cd13be357-9161bac4a68mr1535377285a.3.1781442615118; Sun, 14 Jun 2026 06:10:15 -0700 (PDT) Received: from server0.tail6e7dd.ts.net (c-68-48-65-54.hsd1.mi.comcast.net. [68.48.65.54]) by smtp.gmail.com with ESMTPSA id af79cd13be357-91619f1b400sm752878985a.15.2026.06.14.06.10.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 14 Jun 2026 06:10:14 -0700 (PDT) From: Michael Bommarito To: Hans Verkuil , Mauro Carvalho Chehab , Sakari Ailus , Nicolas Dufresne , Sebastian Fricke Cc: Laurent Pinchart , Benjamin Gaignard , Detlev Casanova , Ezequiel Garcia , Yunfei Dong , Jonas Karlman , Heiko Stuebner , Kees Cook , linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 5/6] media: mediatek: vcodec: bound AV1 tile-start copy to the array capacity Date: Sun, 14 Jun 2026 09:10:02 -0400 Message-ID: <20260614131003.2524025-6-michael.bommarito@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260614131003.2524025-1-michael.bommarito@gmail.com> References: <20260614131003.2524025-1-michael.bommarito@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 7bit vdec_av1_slice_setup_tile() copies tile_cols + 1 / tile_rows + 1 start positions into mi_col_starts[] / mi_row_starts[], which hold V4L2_AV1_MAX_TILE_COLS + 1 / V4L2_AV1_MAX_TILE_ROWS + 1 entries. tile_cols and tile_rows come straight from the bitstream; bound the copy to the array capacity so the accesses stay in range. Fixes: 0934d3759615 ("media: mediatek: vcodec: separate decoder and encoder") Signed-off-by: Michael Bommarito Assisted-by: Claude:claude-opus-4-8 --- This is an MT8195-class SoC block not reachable on the x86 KUnit host, so the driver-side out-of-bounds access is not reproduced here. .../mediatek/vcodec/decoder/vdec/vdec_av1_req_lat_if.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/mediatek/vcodec/decoder/vdec/vdec_av1_req_lat_if.c b/drivers/media/platform/mediatek/vcodec/decoder/vdec/vdec_av1_req_lat_if.c index 2d622e8..49d9b4a 100644 --- a/drivers/media/platform/mediatek/vcodec/decoder/vdec/vdec_av1_req_lat_if.c +++ b/drivers/media/platform/mediatek/vcodec/decoder/vdec/vdec_av1_req_lat_if.c @@ -1299,11 +1299,12 @@ static void vdec_av1_slice_setup_tile(struct vdec_av1_slice_frame *frame, tile->uniform_tile_spacing_flag = BIT_FLAG(ctrl_tile, V4L2_AV1_TILE_INFO_FLAG_UNIFORM_TILE_SPACING); - for (i = 0; i < tile->tile_cols + 1; i++) + /* Bound the copy to the mi_col_starts[]/mi_row_starts[] capacity. */ + for (i = 0; i < tile->tile_cols + 1 && i < V4L2_AV1_MAX_TILE_COLS + 1; i++) tile->mi_col_starts[i] = ALIGN(ctrl_tile->mi_col_starts[i], BIT(mib_size_log2)) >> mib_size_log2; - for (i = 0; i < tile->tile_rows + 1; i++) + for (i = 0; i < tile->tile_rows + 1 && i < V4L2_AV1_MAX_TILE_ROWS + 1; i++) tile->mi_row_starts[i] = ALIGN(ctrl_tile->mi_row_starts[i], BIT(mib_size_log2)) >> mib_size_log2; } -- 2.53.0