From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 281353C2B8D for ; Sun, 14 Jun 2026 13:34:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781444070; cv=none; b=e3S8wMbMozeoyFGOTTUlTb1t2+rMDXW2U+lS7f+BSwtKUixn0QD3uknFm5T996u57gO5OEMb/xFyzDwB7zQm2l64hvWMphyj4DyWC2KG1tB4/q5hnqOWPcjpzJIb2Fs9+9RHwsR/Y2oziiPC41J/JQr5XB7xL45x+apo4LzymHM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781444070; c=relaxed/simple; bh=vC7gffF3nph/f7RymsI38P5G/8V/ZI0hrB57Y33Oh98=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=L8gaGR7SMPLkpoNnbtiNqXzycoRMfgi4Fcs7WWgpNvIupu8rFUmRvV52oFCnCZB6nk6RVd7JicBbxjiysCuSPeLezbsWiERfmo0W+BTkuxTV22NYf6/m7PBvBmAdN2JMVd4VHjc833fJiuVmh8HPIfcjE3x6uRZrispOpBqmQAs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=PTv74Etg; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="PTv74Etg" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-490ace40f4bso23364555e9.3 for ; Sun, 14 Jun 2026 06:34:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781444067; x=1782048867; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=eyKTqLVZ2GkXstSMIq5XRH7NFzj7gG6vhpUIFQhTa+U=; b=PTv74EtgR7h/IDwrdicV+UdkDb5WD//UcSf0s4FsTNhMiL7CYYvS/an1DeN7frH+kh Dg+hyx//17TbzPYImns4FaEMoOPJ0Qcz5AS1LRMPv6KwvUgKF2puCeAnVpkdjvUL4EVS 4JQ/YUBRIqtIGJlkHO6NRFNFDW9DGXk+183NTsmkUZbhWLKGCaQYPgA3Sndt98CaWgJh m7HCMREMQveOIwu1JkctLf2AhMbhxEnPLHjVYqU6+IVCP6nr5EXJZvXqQdjMVFNWnHlt slkIi+7TPKqOPunOklcUgUpR3gSWOvrnVYIVNoes5CsqDb+1gRUyxzRLg14n066DjyHe bDAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781444067; x=1782048867; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=eyKTqLVZ2GkXstSMIq5XRH7NFzj7gG6vhpUIFQhTa+U=; b=lg1eHy2xUqq1MU9Hni+i/bID4NaFSRzuSavbMZwIWfLN0SGFWEGHx9XDxJ+hxf3ZtM gBghMJB3utIHQbdWzjS+3QA4TbaWEt7IWkr7PBxhITBGfBDGc2N/3NQxlvoUq1qtZaRA Pa8uVv+6LzXmERnIoq5dO5YCipAKO+hielz2SG0wIZSodgGS9ZdhE8pSErcsqQhBVoxR 0b8fnCQW/NkHQunmSktKdu6kQKfQsf5HRpUMOzCbfHwQRou2CelEKly0mh0/RvOz/UQB KObFT+m6QeT6KIw1weIgKyjzxHVH8drqMaW1Qx9UFjUWbOq3BDLe8xYE/ugurzV6yejf ZY6w== X-Forwarded-Encrypted: i=1; AFNElJ/arrdAaG6MgXXk2LbQp8qbk/D3BrIWk+PScIN3b/wrtopdNj6iYClkOUan2eD0wCtilDSKi3rbmCQg/rs=@vger.kernel.org X-Gm-Message-State: AOJu0YwpW7Nu92M5y//nb7iaHtt6wVGtnFlDB0vfNB0jCJTzMBsNOD50 nil6ol8hLQnR8SkGbqfg5T9AvRa/ifIcoPHNReH8NQWY7ACi28JDX8Ec X-Gm-Gg: Acq92OGrw7/Qi2igal5J61ifpz88Tqom8E5/qUE4lXadNlg22RzlYVvDcsvsdZTwa7f b/TGzJR3RnZeCNX1jQ0x11KMwExOWI+F+h5KglKxUQSfl66ZQDbNpRs6Bl+CXxJY8p5d9ov5cde Tq6EEH4maoLRY7d8/e6aMIS1Ywfc0zt9rBqAVezPkwfO4xvG9K+AEdtZLD3eBJE/9sqVTpHPCn3 3mB5XiPyWNGRwmQR617pUYLt+Hp9FRah2btVdYRSyPT6C1xmJti0p+Y/ANeaFsEGYwwSdOY/2VH hohSg1QgX3M9dvuXDPOfztzlrVIgMzgBCNhf46Al34kqC67ImiUW9C1oJl3rxW9RAlXbjw3382V OUKqZvomvc71U/G/5KRmCqtKf7nuCZpQaViCTKLL4I1aZNaLj0ILZB1Q2QPxoybQSMHn12WiyEj SFJG6KKOUMo4sZkfKnxm4GtgVhUQ== X-Received: by 2002:a05:600c:4709:b0:490:5057:f5f7 with SMTP id 5b1f17b1804b1-4922007472cmr83103395e9.11.1781444067551; Sun, 14 Jun 2026 06:34:27 -0700 (PDT) Received: from builder ([2001:9e8:f128:d516:be24:11ff:fe30:5d85]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4922037055csm169464295e9.13.2026.06.14.06.34.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 14 Jun 2026 06:34:26 -0700 (PDT) From: Jonas Jelonek To: Russell King , Andrew Lunn , Heiner Kallweit , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Chevallier Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, =?UTF-8?q?Bj=C3=B8rn=20Mork?= , Simon Horman , Jonas Jelonek Subject: [PATCH net-next v11 1/2] net: sfp: apply I2C adapter quirks to limit block size Date: Sun, 14 Jun 2026 13:34:17 +0000 Message-ID: <20260614133418.2068201-2-jelonek.jonas@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260614133418.2068201-1-jelonek.jonas@gmail.com> References: <20260614133418.2068201-1-jelonek.jonas@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The SFP driver assumes all I2C adapters support reading and writing the pre-defined block size SFP_EEPROM_BLOCK_SIZE of 16 bytes. This constant was probably chosen based on good guesses and known limitations of a range of I2C adapters and SFP modules. However, I2C adapters may even support less and usually need to specify this via I2C quirks. Theoretically, such an adapter may provide full functionality but only support a read and write length of e.g. 8 bytes. Currently, the SFP driver doesn't account for that. Add handling for I2C quirks in SFP I2C configuration taking the fields max_read_len and max_write_len in struct i2c_adapter_quirks into account to further limit the maximum block size if needed. Signed-off-by: Jonas Jelonek Reviewed-by: Maxime Chevallier --- drivers/net/phy/sfp.c | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/drivers/net/phy/sfp.c b/drivers/net/phy/sfp.c index 18f2584dbe7b..3c232991faa1 100644 --- a/drivers/net/phy/sfp.c +++ b/drivers/net/phy/sfp.c @@ -810,21 +810,29 @@ static int sfp_smbus_byte_write(struct sfp *sfp, bool a2, u8 dev_addr, static int sfp_i2c_configure(struct sfp *sfp, struct i2c_adapter *i2c) { + size_t max_block_size; + sfp->i2c = i2c; if (i2c_check_functionality(i2c, I2C_FUNC_I2C)) { sfp->read = sfp_i2c_read; sfp->write = sfp_i2c_write; - sfp->i2c_max_block_size = SFP_EEPROM_BLOCK_SIZE; + max_block_size = SFP_EEPROM_BLOCK_SIZE; } else if (i2c_check_functionality(i2c, I2C_FUNC_SMBUS_BYTE_DATA)) { sfp->read = sfp_smbus_byte_read; sfp->write = sfp_smbus_byte_write; - sfp->i2c_max_block_size = 1; + max_block_size = 1; } else { sfp->i2c = NULL; return -EINVAL; } + if (i2c->quirks && i2c->quirks->max_read_len) + max_block_size = min(max_block_size, i2c->quirks->max_read_len); + if (i2c->quirks && i2c->quirks->max_write_len) + max_block_size = min(max_block_size, i2c->quirks->max_write_len); + + sfp->i2c_max_block_size = max_block_size; sfp->i2c_block_size = sfp->i2c_max_block_size; return 0; } -- 2.51.0