From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E554921FF2A for ; Sun, 14 Jun 2026 15:45:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781451931; cv=none; b=UaF/0xldzNY9wud80qPwrsej4qlPBonCcY3zbyrxmV2/D8dLtQlkC1nT9UTrQhBCOhNuWcZDwfoBZIuMKqoNlD/m7EFRslaIXCDauGvpauQeps4uEaVkQaItwgs/7gwt9RlaEyW7XuwDwxJ6fhwz7GuMtbgIv4VddooUGyjSHIc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781451931; c=relaxed/simple; bh=a4fUsm0sri2CJp9Xa6+EfCy3v837PLIvJct/CxDUWxw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=EB+FAb/5NBuL9oc0e/QbybnDk38D2eLkJ7K1+TG9/15Hg8v9HIFPfkUlXZKCpcVf1FgYXu3FoeeER79GJlmgo9olrCRB1r4UQB5sFKd92MMxKtxRyNHhhZfzD2hxoqnd3x4ReDBo8Zq4ShUbklBHl/+/PLrbjtIg/A/nnrxDk5U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=MIBqjv1g; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="MIBqjv1g" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-4903d730b1fso32541585e9.2 for ; Sun, 14 Jun 2026 08:45:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781451928; x=1782056728; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=5Ovn4XB3GgCDHVcufiauy/1mVBNPpRS6FI6cibDiq4A=; b=MIBqjv1g4QnV/BhJORkzdVL0hXe32CXblN94sfEZvH/Xt0SgulVb1rNp3n3by4RN6v 8zl5D4gnvXQC2gqLKze8OTYjJC1aYWEKHk3OSVtDY8pTfk1PIH0e8LZmNpnoHRsFacwo MgYMBL1gUe8SowBa2CMwwInUW1vR/e4yO8cbXGWSn4RZmCtWb2GmXxhsxgksP7DdzjSG Nv37VCgdh4VHkzene5+uA0kCjU0DLfjAIyErnzgFxBidNsXFFVAr6ydSTA+fdFeh2FrZ tQrIFPU5dvWKehVacgMEVF+AgmSvtoldTfBKZhDjhUh6mzBigBOzZB0/BXEIHvWY1v/Q yP8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781451928; x=1782056728; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=5Ovn4XB3GgCDHVcufiauy/1mVBNPpRS6FI6cibDiq4A=; b=Wu1Y+MMi0FS6kDVsfaahfcJHccQXqwTzhA3BqEqcbTLTqOG5/MQhD8B4JHqYJtmVnh VUEPPeKpenU3f2IRKD26+funV9OcIPT/oSdUKK9BCpbNxLhxI6jXzik8YB6+2skcMdVr 7SvJ9AGOvZOkuVivDEHfV4VSU2v5QF7k/ravYbk6mPIwCXPT34J7HJKJepqSamvp8juF y972tyIot36qA1EnP80NbrLy1YefUw9e6ukMneG1JzovTvUSIGjE7kT7cvmYST59fOHF XPzW5FHw95wD1+L9INEdCWCsDYlRHqNv5KuxfU9g6z1otCPyhK3F7l0zlzXVytV/TTS4 gqsQ== X-Forwarded-Encrypted: i=1; AFNElJ9IzjAVlmKnsBg1u66EWGk8QOUt5+vqQmF9nqIz9ApqWi1GuvlhMKRdGesLDxi+8jNBkXSks7KXO/1Fif8=@vger.kernel.org X-Gm-Message-State: AOJu0YyMHzs9X8J6jmMzg2IzHb+uURSwV1uexGkUohsjnBaleIHXgf4c dJHIa8Oz271BFWmGJ6Bz20yAz+fdK4so44L4eVCDeO24j62yqoRFEXAw X-Gm-Gg: Acq92OE41Fbovy2XJWywqzZafF4zKXRJrpNH18wms+IzrhRQB+wch9wh4eyiThwGFfg +FUVAAwQzggZ6MfdgJPFj8c3ULXCr/Ju56UjapjbAoVIHw5emeldcnEPDv6cUVstJiMpdlUoVay PXw+u8a7ZS6GMbXKKrvZbjKZu8yHqiZ9oEdOEZ2+lqvBUWduVVr8KTSh+txXWg+BvlG1yueylDT ONw4pQ69er4uNcRO1LTZ0K4y+EWZQrSc8nsrHqgtwUGEsuN8cB0VZGWwi7mv0rXe+U6mX7dGGj9 3vSgzyMlyt5vGhSjI9g+3DIJo+furu3l/1l3R7gHLIK0fMAWbVxx0dfLS+rbqY2rpzxgMR5Y+w8 PVMLQ+X4LYf9xQnOjw0dHQwcKg3kf8tD5WXMucarDL6QE/OI9UYWAMRrsGbS20Auu56MkjI0dat 2Me5/XF2yJ+FlhcOEh7r/CzdsBcwA5gb69P/Q6GGZCJlQFjg== X-Received: by 2002:a05:600c:3512:b0:491:9969:739d with SMTP id 5b1f17b1804b1-4922011393fmr92175955e9.29.1781451928107; Sun, 14 Jun 2026 08:45:28 -0700 (PDT) Received: from fedora ([154.182.122.228]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4922031b7d2sm184237135e9.5.2026.06.14.08.45.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 14 Jun 2026 08:45:27 -0700 (PDT) From: Abdelnasser Hussein To: gregkh@linuxfoundation.org Cc: vaibhav.sr@gmail.com, mgreer@animalcreek.com, johan@kernel.org, elder@kernel.org, greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Abdelnasser Hussein , Dan Carpenter Subject: [PATCH v3 1/2] staging: greybus: audio_codec: fix sscanf return value check Date: Sun, 14 Jun 2026 18:43:28 +0300 Message-ID: <20260614154329.5176-2-abdelnasserhussein11@gmail.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260614154329.5176-1-abdelnasserhussein11@gmail.com> References: <20260614154329.5176-1-abdelnasserhussein11@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Smatch static checker warns: drivers/staging/greybus/audio_codec.c:335 gbaudio_module_update() warn: sscanf doesn't return error codes The sscanf() function returns the number of successfully matched input items, not a negative error code. Compare the return value directly with the expected number of conversions (3) instead of storing it in 'ret' and returning it as an error code, which leads to returning a positive value on failure. Reported-by: Dan Carpenter Closes: https://lore.kernel.org/all/YoOLnDkHgVltyXK7@kili/ Signed-off-by: Abdelnasser Hussein --- Changes in v3: - Split from the previous v2 patch into a separate patch. - Updated tags to properly credit Dan Carpenter for the smatch warning. drivers/staging/greybus/audio_codec.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/greybus/audio_codec.c b/drivers/staging/greybus/audio_codec.c index 720aa752e17e..295222ec0f1a 100644 --- a/drivers/staging/greybus/audio_codec.c +++ b/drivers/staging/greybus/audio_codec.c @@ -311,8 +311,7 @@ int gbaudio_module_update(struct gbaudio_codec_info *codec, } /* parse dai_id from AIF widget's stream_name */ - ret = sscanf(w->sname, "%s %d %s", intf_name, &dai_id, dir); - if (ret < 3) { + if (sscanf(w->sname, "%s %d %s", intf_name, &dai_id, dir) != 3) { dev_err(codec->dev, "Error while parsing dai_id for %s\n", w->name); return -EINVAL; } -- 2.54.0