From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv1-f49.google.com (mail-qv1-f49.google.com [209.85.219.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CABE93C870E for ; Sun, 14 Jun 2026 15:56:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781452585; cv=none; b=F6FFn3J0I2+XwX+tOMKJRBPYzVcay+346K4Ilt983OCAIgXJDk/B41rcY2+yurcyf+I7YPt4NALHMwuDPpFKJS5UtBHPidDl5y/rnGnbRhFiHdFTfr5xIifdMRzdHmfzhsTUYXndyORynX0uDUCvT7o3VC2z0fwzESgZgwCGt0Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781452585; c=relaxed/simple; bh=3KLh89mDhDdVayszBxxlbw+uuMcGM3EZXAmm1ZBvebU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=nYIA56E/xdqt2+tfqnmEdjbb9oOjVe1kbya6cJklemVBAE3Rhv5RHHkvrIlHDfOJAWNmTH0/UWU0vqXILFDYh5TkdyqGFP7A98T7TWOt9ExXB+eZjXXw2r8LtoD4X+aQ2aKmrOD/22ykZySF5/CA/LJUlsHIxGkWXKQ7b8bFGBo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=XN1CZtl8; arc=none smtp.client-ip=209.85.219.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="XN1CZtl8" Received: by mail-qv1-f49.google.com with SMTP id 6a1803df08f44-8ce9ddeddefso31026366d6.0 for ; Sun, 14 Jun 2026 08:56:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781452581; x=1782057381; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ppzEj7clxwYqaF2xsc1Xu8dwkm63CSTY5UlsiLbKHOs=; b=XN1CZtl8hDJS14UI02OZPqhJdTAFllsjVyGRHkjRMU23RXUyBFkk+7krP9wjqjd6TT 9UP1ELj9ZwP99FsiEakO6894MrRvTnFbM3nqZkLQDHNgpWAxKzVPAhSMjrSC2DjlcVkz AiKDCFhPVZ0Hoqe/PBd3AhFFtWSWFTlyX+Uit4GbOiNdHUz4DaPJ3Cp3zXJ4cgaIFZny IqN0mB/s/7XkFFuXWN0r3UfqR5MJUNgDTG9ornMlCLyBzFaaYJZVv0/+l8G67jLQfKqL Ne1xyIpIo+GIgLSaeIPUzBlmhilbkyOrY0P2JOi6hXMOZOeWf7XEvxSmpdn4unKhIiox YR3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781452581; x=1782057381; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=ppzEj7clxwYqaF2xsc1Xu8dwkm63CSTY5UlsiLbKHOs=; b=T4W2hHN6SpxEdSJONRl71IuZQYQr0cUzou26CWbPh15wJAJxt/MfhXEVz2trefk95T GQ3pYNKZK0ibX7Kx6QCDjswYnsExZuzgXp2gcfxj6Wdsizw2shxf1PCAc6kUWhX937sW AGJ4qAkvOMDvxtcH766DZJIDjn3bXPXo5WO8DHarFgGJXo8XLs4a+DIOmDsVvvw69Gca B+nSQJUYvxJ55fKOZQSlbqAP08u64ruLPQF9/Trfn04pVW5IzXht9t+fHBBTLuLGSbLT r7iryyl1DXVKao5JdgXYOIVP2hw45ZZnlDXKLn+jzwUDlMSokTkmlYg3nsv/Q1UNqRpt THDA== X-Forwarded-Encrypted: i=1; AFNElJ/WoMTr+EFrEaRJ0UCvxMki4NCeMhkbc1/f4Vl5I1/0u7sNBt6DFAVeuXHhETWmW9FuBkhar2pwofgHHzg=@vger.kernel.org X-Gm-Message-State: AOJu0YxeW5na4LWqyn9tHxW1JBCEyiODT6p3um2PEfkE5FoAaPCpm5Gh YG2qmnYuTNAHcd+oHEN2kARb6ZJteqZCwaJJZo02OiwJ7c+PC1DENq17 X-Gm-Gg: Acq92OFdLuhXBQiQv6Gcweg4I0/WW77aGcwpyuPlUD0mA3Yepw09KODuF+p6Dg8hr+5 Gfe4L0Z42rKWtZd/n1mTrzA8HSPGvX0NphABfdKIowVp3zjHJPkzBAL3wiM9amWu/yeHuRtUjIN rM3NB++xlOXTPL34rYcDsZ50C2wpWx79Ddd/KpKMmLQboG4qhMpC0XfviSDdrt1ZIRPxiuUVR7i Sr4SPEwaAjK7eIpBRTfaD2FB7cl8e+Jc7pxl/ZrskvCY31z1xd6Ep8PerJ9fDv1qDTYuxmfDE6o 2KQxMtIL7GE1Td2NsM+4i22RxkTENTZbued9BI1Y6J1UYn30GvfOTTWhiZnpABw7aRnVXEQOX/8 MdSbTGY3FVNbU2W7SKJ61FJFQYZqDSoWJRTM9h1k0/I0Jk8+LgrttSl7eLSeT1djhoarDrgxVcR aU8WgaJBAWeOemVuQXlS2yh6LwtH74niu4NEKq5DawDTpuibGNRu0NuHs4Z3Hogb6hY0cskLfkp +eaa1nu8hheKcsv4vHuA/tFvS6Pk/lyxREqd5ElpQE= X-Received: by 2002:a05:6214:40c:b0:8cc:ef56:d997 with SMTP id 6a1803df08f44-8d32bd2d8cfmr184388716d6.7.1781452580813; Sun, 14 Jun 2026 08:56:20 -0700 (PDT) Received: from server0.tail6e7dd.ts.net (c-68-48-65-54.hsd1.mi.comcast.net. [68.48.65.54]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-8d30522cbeasm82008446d6.44.2026.06.14.08.56.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 14 Jun 2026 08:56:20 -0700 (PDT) From: Michael Bommarito To: Hans Verkuil , Mauro Carvalho Chehab , Sakari Ailus , Nicolas Dufresne Cc: Laurent Pinchart , Benjamin Gaignard , Detlev Casanova , Ezequiel Garcia , Yunfei Dong , Jonas Karlman , Heiko Stuebner , Kees Cook , linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 5/6] media: mediatek: vcodec: bound AV1 tile-start copy to the array capacity Date: Sun, 14 Jun 2026 11:56:07 -0400 Message-ID: <20260614155609.3107600-6-michael.bommarito@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260614155609.3107600-1-michael.bommarito@gmail.com> References: <20260614155609.3107600-1-michael.bommarito@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 7bit vdec_av1_slice_setup_tile() copies tile_cols + 1 / tile_rows + 1 start positions into mi_col_starts[] / mi_row_starts[], which hold V4L2_AV1_MAX_TILE_COLS + 1 / V4L2_AV1_MAX_TILE_ROWS + 1 entries. tile_cols and tile_rows come straight from the bitstream; bound the copy to the array capacity so the accesses stay in range. Fixes: 0934d3759615 ("media: mediatek: vcodec: separate decoder and encoder") Signed-off-by: Michael Bommarito Assisted-by: Claude:claude-opus-4-8 --- .../mediatek/vcodec/decoder/vdec/vdec_av1_req_lat_if.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/mediatek/vcodec/decoder/vdec/vdec_av1_req_lat_if.c b/drivers/media/platform/mediatek/vcodec/decoder/vdec/vdec_av1_req_lat_if.c index 2d622e85f8271..49d9b4a72387e 100644 --- a/drivers/media/platform/mediatek/vcodec/decoder/vdec/vdec_av1_req_lat_if.c +++ b/drivers/media/platform/mediatek/vcodec/decoder/vdec/vdec_av1_req_lat_if.c @@ -1299,11 +1299,12 @@ static void vdec_av1_slice_setup_tile(struct vdec_av1_slice_frame *frame, tile->uniform_tile_spacing_flag = BIT_FLAG(ctrl_tile, V4L2_AV1_TILE_INFO_FLAG_UNIFORM_TILE_SPACING); - for (i = 0; i < tile->tile_cols + 1; i++) + /* Bound the copy to the mi_col_starts[]/mi_row_starts[] capacity. */ + for (i = 0; i < tile->tile_cols + 1 && i < V4L2_AV1_MAX_TILE_COLS + 1; i++) tile->mi_col_starts[i] = ALIGN(ctrl_tile->mi_col_starts[i], BIT(mib_size_log2)) >> mib_size_log2; - for (i = 0; i < tile->tile_rows + 1; i++) + for (i = 0; i < tile->tile_rows + 1 && i < V4L2_AV1_MAX_TILE_ROWS + 1; i++) tile->mi_row_starts[i] = ALIGN(ctrl_tile->mi_row_starts[i], BIT(mib_size_log2)) >> mib_size_log2; } -- 2.53.0