From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 189983A3E95 for ; Sun, 14 Jun 2026 16:57:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781456277; cv=none; b=nAIoUX0mAil61A0XVKbxytKU+u6RI3u42/qYUiZSbK0VHF6rydbqk2Unm/iL3Bfef/CWLnCnBcgKzS5jazaKD+RuHCEs7RyDb/6glSPziaeKIKJt4F1FVsMEXCQ+FV05sJO0S4romc1p4Ssrk7u4ZQOAPs2QsILOkqqIwJ2y+Fc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781456277; c=relaxed/simple; bh=gN87j6PTIvn/ARa0NZpeucZfdsvYUJ/gi5CQ4Gta24A=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=t+asFfRdCStxtYQ+c662zZvkLI/fZOza23r90uGp/oxfj++cFY/a7f/Ua7W5chXej9nvLjDHmg2Tb4pd9kxNksrfJT0XQ/l5YWEYsrTylvWl9zs3iKRSNuGMoSTipBpVTYSi0X6HqIbXF1G+nnbLhv3SAn1oYi+WVewhzHhMNdY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=na8Eb7PB; arc=none smtp.client-ip=209.85.214.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="na8Eb7PB" Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-2c0c3543590so17315715ad.2 for ; Sun, 14 Jun 2026 09:57:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781456275; x=1782061075; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=lrWzw8QqzhBXRcDuoAQQBRc2zIXQC2Yh/JGGLwvdA1I=; b=na8Eb7PBS1PY8q0ZmkUlMjM0lmXPULQNfTjMxLHqZga1XeS5EOaVGiQTTJSG1KKCzn RrxiNxJyfZocI5/1hMes+oBfKjgiN0V3d/iNqyb6tKIhF7fGlyO4xQxCm+2zWEbdt3HM bKvhw/KjpCgS3iBhbH94LcO9kFnodbkWgHbA970udkivvrdNCNJy6R0esIdVQNsUwFUE k2ypmo3SydKLiksEXymmLZGaFRcefzRMTV/r/RwUBhBSWuhS5bEryyARPeKvxsDHrsPH Za7RmJgvdl5fnpeUctueW+xgcakBuwjB3qQlALGrrjWnTIDhtAi+kmdeKK7qttrlu7Gp IhZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781456275; x=1782061075; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=lrWzw8QqzhBXRcDuoAQQBRc2zIXQC2Yh/JGGLwvdA1I=; b=CuFlS0Opuev8wpo8sRe/2MaB/kNNjz14BANklJgpjVdMYMTNXfLLUY6V54O/ENSY+/ 5KKkrNoJgNzILZ/mpKhKZZ41n9EBBDchHYPjxJpe8AtXElAC/boI6hopWUvTA69FPnko Q/KS8MdQUDcGG9jE75j5WXNZXX2seSq2BB/vgmK4mykq9nLcfTIIJqUPp+wjHTv1vJ6Z +vsIlxHPVE3kXjwOhmx9NYaPQCgwAO/M71e8PZh+95uXDKHZROx1yT22NHKdmwkmObL3 8PLbwvHrIeeHKPCwZPc8k7gkYM1FPV7Y0HK0Cby2+ZZi77w04S+ecYuKBZXF0iALdSN7 gnmg== X-Forwarded-Encrypted: i=1; AFNElJ/pTeP2XdLiOOWNf7aNP0y2fj2d8QGIW+zUo95GsdIojW8GQHDJevn9tzbK4H4AK8teJqMSjr7pr8vbSVc=@vger.kernel.org X-Gm-Message-State: AOJu0Yx1h+ZOqDjMl0IOd6GWlk4HnROupJbKUYHgCzLHHKaO1GvntXuv U3i6XETvTFNZtHp445nxMoLjV6abo85YWvfb7np1r4aUrrnRB6ZRgE02 X-Gm-Gg: Acq92OEJl0y+itOfo8sC1n6PlZS99ITWDybNYICHNNqiwSM2f0jayw7ZxNfik0B33YL yHjGF0y1kxvfyiq1gidDzICIEz3/zpxz+9iBYlH3mRhkU+jduU20oZxyfSjm5TmC5PpnW/6Lb6T yWVKbCB0U4zhqEwQRHMTrOrgLwVvbh9ggQlY1MtI1NElHnEU4TJVaVh48MczyO6SdbbI0WfRbJC gZDBFwO2mEMcrqSA+LgQRK/yCxnbqbO3HvNwZRSTzcwY8Kkgu+jnNVnFPBSCiQVnIPYEDD0fWO2 MCeYK6TYDmZSYzAtG5skceFcySUc3wdJ3x4CTP+aDfAY6ucUEaLHjteMi7El/5rC9RvdAf8HKXY 8XxQY+Hbka4Io8MKKVFWCDA9QUeKcHUBUC1MBPRFVtRQZ0+mpkGqkpGwCL2YxHQDHPjieENYQ8T xpblax1LwVTkoZ/2nJD4j7fCQDJ7vtx24C7dqtCYp3AJwwXpaPumLX X-Received: by 2002:a17:903:2301:b0:2bf:27b2:4b80 with SMTP id d9443c01a7336-2c411f6dca1mr118507075ad.14.1781456274563; Sun, 14 Jun 2026 09:57:54 -0700 (PDT) Received: from localhost.localdomain ([49.207.217.37]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2c42f2e5590sm85284025ad.14.2026.06.14.09.57.51 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 14 Jun 2026 09:57:54 -0700 (PDT) From: Biren Pandya To: linux-media@vger.kernel.org, mchehab@kernel.org Cc: Biren Pandya , Nicolas Dufresne , Benjamin Gaignard , Philipp Zabel , linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 16/22] media: platform: hantro_drv: Add missing media_entity_cleanup() Date: Sun, 14 Jun 2026 22:25:53 +0530 Message-ID: <20260614165630.3896-17-birenpandya@gmail.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260614165630.3896-1-birenpandya@gmail.com> References: <20260614165630.3896-1-birenpandya@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Signed-off-by: Biren Pandya --- drivers/media/platform/verisilicon/hantro_drv.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/drivers/media/platform/verisilicon/hantro_drv.c b/drivers/media/platform/verisilicon/hantro_drv.c index 2e81877f640f..ad71c0402ef3 100644 --- a/drivers/media/platform/verisilicon/hantro_drv.c +++ b/drivers/media/platform/verisilicon/hantro_drv.c @@ -771,8 +771,10 @@ static int hantro_register_entity(struct media_device *mdev, return ret; ret = media_device_register_entity(mdev, entity); - if (ret) + if (ret) { + media_entity_cleanup(entity); return ret; + } return 0; } @@ -860,12 +862,13 @@ static int hantro_attach_func(struct hantro_dev *vpu, err_rel_entity2: media_device_unregister_entity(&func->sink); - + media_entity_cleanup(&func->sink); err_rel_entity1: media_device_unregister_entity(&func->proc); - + media_entity_cleanup(&func->proc); err_rel_entity0: media_device_unregister_entity(&func->vdev.entity); + media_entity_cleanup(&func->vdev.entity); return ret; } @@ -878,6 +881,9 @@ static void hantro_detach_func(struct hantro_func *func) media_device_unregister_entity(&func->sink); media_device_unregister_entity(&func->proc); media_device_unregister_entity(&func->vdev.entity); + media_entity_cleanup(&func->sink); + media_entity_cleanup(&func->proc); + media_entity_cleanup(&func->vdev.entity); } static int hantro_add_func(struct hantro_dev *vpu, unsigned int funcid) -- 2.50.1 (Apple Git-155)